[NFC][LSAN] Limit the number of concurrent threads is the test

[vitalybuka]

Summary

Test still fails with D88184 reverted.

The test was flaky on https://bugs.chromium.org/p/chromium/issues/detail?id=1206745 and
https://lab.llvm.org/buildbot/#/builders/sanitizer-x86_64-linux

[morehouse]

LGTM

[azharudd]

This won't work on Darwin.

DIR *d = opendir("/proc/self/task");
assert(d);

Assertion failed: (d), function count_threads, file llvm-project/compiler-rt/test/lsan/TestCases/many_threads_detach.cpp, line 26.

compiler-rt/test/lsan/TestCases/many_threads_detach.cpp

 // Test that threads are reused.
 // On Android, pthread_* are in libc.so. So the `-lpthread` is not supported.
 // Use `-pthread` so that its driver will DTRT (ie., ignore it).
 // RUN: %clangxx_lsan %s -o %t -pthread && %run %t
 
+#include <assert.h>
+#include <dirent.h>
 #include <pthread.h>
 #include <stdlib.h>
 #include <unistd.h>
 
 // Number of threads to create. This value is greater than kMaxThreads in
 // lsan_thread.cpp so that we can test that thread contexts are not being
 // reused.
 static const size_t kTestThreads = 10000;
 
+// Limit the number of simultaneous threads to avoid reaching the limit.
+static const size_t kTestThreadsBatch = 100;
+
 void *null_func(void *args) {
   return NULL;
 }
 
 int main(void) {
-  for (size_t i = 0; i < kTestThreads; i++) {
-    pthread_t thread;
-    if (pthread_create(&thread, NULL, null_func, NULL) == 0)
-      pthread_detach(thread);
+  for (size_t i = 0; i < kTestThreads; i += kTestThreadsBatch) {
+    pthread_t thread[kTestThreadsBatch];
+    for (size_t j = 0; j < kTestThreadsBatch; ++j)
+      assert(pthread_create(&thread[j], NULL, null_func, NULL) == 0);
+
+    for (size_t j = 0; j < kTestThreadsBatch; ++j)
+      assert(pthread_join(thread[j], NULL) == 0);
   }
   return 0;
 }