Page MenuHomePhabricator

[mlir][Python] Finish adding RankedTensorType support for encoding.
ClosedPublic

Authored by stellaraccident on May 10 2021, 11:06 AM.

Diff Detail

Event Timeline

stellaraccident requested review of this revision.May 10 2021, 11:06 AM
aartbik added inline comments.May 10 2021, 11:25 AM
mlir/test/python/dialects/sparse_tensor/dialect.py
79

typo 2x: Tensor

87

do we want to check the contents too, or is that too detailed for these kinds of tests?

stellaraccident marked an inline comment as done.

Comments

PTAL

mlir/test/python/dialects/sparse_tensor/dialect.py
87

I feel like that is covered elsewhere and the equality check should be enough here. Mainly, as the primary example of an encoding, this test is doing double duty as a test of the RankedTensorType machinery for manipulating encodings.

Mainly making sure there is a test that uses encoding= and .encoding.

aartbik accepted this revision.May 10 2021, 11:43 AM
This revision is now accepted and ready to land.May 10 2021, 11:43 AM
This revision was landed with ongoing or failed builds.May 10 2021, 1:43 PM
This revision was automatically updated to reflect the committed changes.