[llvm-readelf] Unhide short options to match the command guide

[gbreynoo]

Summary

The readelf command guide shows the short options used as aliases but these are not found in the help text unless --show-hidden is used, other tools show aliases with --help. This change fixes the help output to be consistent with the command guide.

[MaskRay]

Help option output should be consistent with the command guide

Make it imperative, e.g. "Unhide some short options"

[gbreynoo]

Thanks Maskray, I've updated the title. I changed the description but reverted it back as I think that's still reads okay.

[MaskRay]

Thanks!

[MaskRay]

Unhide short options to match the command guide

Now a reader can quickly tell what you do in this patch. Previously it just stated an ideal state "things should be consistent" - but it was unclear what was inconsistent and what the patch did to make it consistent.

llvm/tools/llvm-readobj/llvm-readobj.cpp

cl::opt<bool>
                          cl::desc("Display the dependent libraries section"));
 
   // --headers, -e
   cl::opt<bool>
       Headers("headers",
           cl::desc("Equivalent to setting: --file-headers, --program-headers, "
                    "--section-headers"));
   cl::alias HeadersShort("e", cl::desc("Alias for --headers"),
-     cl::aliasopt(Headers));
+                         cl::aliasopt(Headers), cl::NotHidden);
 
   // --wide, -W
   cl::opt<bool>
       WideOutput("wide", cl::desc("Ignored for compatibility with GNU readelf"),
                  cl::Hidden);
   cl::alias WideOutputShort("W",
     cl::desc("Alias for --wide"),
     cl::aliasopt(WideOutput));
cl::opt<bool> Relocations("relocations",
     cl::desc("Display the relocation entries in the file"));
   cl::alias RelocationsShort("r", cl::desc("Alias for --relocations"),
                              cl::aliasopt(Relocations), cl::NotHidden);
   cl::alias RelocationsGNU("relocs", cl::desc("Alias for --relocations"),
                            cl::aliasopt(Relocations));
 
   // --notes, -n
   cl::opt<bool> Notes("notes", cl::desc("Display the ELF notes in the file"));
-  cl::alias NotesShort("n", cl::desc("Alias for --notes"), cl::aliasopt(Notes));
+  cl::alias NotesShort("n", cl::desc("Alias for --notes"), cl::aliasopt(Notes),
+                       cl::NotHidden);
 
   // --dyn-relocations
   cl::opt<bool> DynRelocs("dyn-relocations",
     cl::desc("Display the dynamic relocation entries in the file"));
 
   // --section-details
   // Also -t in llvm-readelf mode.
   cl::opt<bool> SectionDetails("section-details",
namespace opts {
   // --hash-symbols
   cl::opt<bool> HashSymbols(
       "hash-symbols",
       cl::desc("Display the dynamic symbols derived from the hash section"));
 
   // --unwind, -u
   cl::opt<bool> UnwindInfo("unwind",
     cl::desc("Display unwind information"));
-  cl::alias UnwindInfoShort("u",
-    cl::desc("Alias for --unwind"),
-    cl::aliasopt(UnwindInfo));
+  cl::alias UnwindInfoShort("u", cl::desc("Alias for --unwind"),
+                            cl::aliasopt(UnwindInfo), cl::NotHidden);
 
   // --dynamic-table, --dynamic, -d
   cl::opt<bool> DynamicTable("dynamic-table",
     cl::desc("Display the ELF .dynamic section table"));
   cl::alias DynamicTableShort("d", cl::desc("Alias for --dynamic-table"),
                               cl::aliasopt(DynamicTable), cl::NotHidden);
   cl::alias DynamicTableAlias("dynamic", cl::desc("Alias for --dynamic-table"),
                               cl::aliasopt(DynamicTable));
cl::alias SegmentsAlias("segments", cl::desc("Alias for --program-headers"),
                           cl::aliasopt(ProgramHeaders));
 
   // --string-dump, -p
   cl::list<std::string> StringDump(
       "string-dump", cl::value_desc("number|name"),
       cl::desc("Display the specified section(s) as a list of strings"),
       cl::ZeroOrMore);
   cl::alias StringDumpShort("p", cl::desc("Alias for --string-dump"),
-                            cl::aliasopt(StringDump), cl::Prefix);
+                            cl::aliasopt(StringDump), cl::Prefix,
+                            cl::NotHidden);
 
   // --hex-dump, -x
   cl::list<std::string>
       HexDump("hex-dump", cl::value_desc("number|name"),
               cl::desc("Display the specified section(s) as hexadecimal bytes"),
               cl::ZeroOrMore);
   cl::alias HexDumpShort("x", cl::desc("Alias for --hex-dump"),
-                         cl::aliasopt(HexDump), cl::Prefix);
+                         cl::aliasopt(HexDump), cl::Prefix, cl::NotHidden);
 
   // --demangle, -C
   cl::opt<bool> Demangle("demangle",
                          cl::desc("Demangle symbol names in output"));
   cl::alias DemangleShort("C", cl::desc("Alias for --demangle"),
                           cl::aliasopt(Demangle), cl::NotHidden);
 
   // --hash-table
cl::opt<bool>
       PrintStackSizes("stack-sizes",
                       cl::desc("Display contents of all stack sizes sections"));
 
   // --version-info, -V
   cl::opt<bool>
       VersionInfo("version-info",
                   cl::desc("Display ELF version sections (if present)"));
   cl::alias VersionInfoShort("V", cl::desc("Alias for -version-info"),
-                             cl::aliasopt(VersionInfo));
+                             cl::aliasopt(VersionInfo), cl::NotHidden);
 
   // --elf-section-groups, --section-groups, -g
   cl::opt<bool> SectionGroups("elf-section-groups",
                               cl::desc("Display ELF section group contents"));
   cl::alias SectionGroupsAlias("section-groups",
                                cl::desc("Alias for -elf-sections-groups"),
                                cl::aliasopt(SectionGroups));
   cl::alias SectionGroupsShort("g", cl::desc("Alias for -elf-sections-groups"),
-                               cl::aliasopt(SectionGroups));
+                               cl::aliasopt(SectionGroups), cl::NotHidden);
 
   // --elf-hash-histogram, --histogram, -I
   cl::opt<bool> HashHistogram(
       "elf-hash-histogram",
       cl::desc("Display bucket list histogram for hash sections"));
   cl::alias HashHistogramShort("I", cl::desc("Alias for -elf-hash-histogram"),
-                               cl::aliasopt(HashHistogram));
+                               cl::aliasopt(HashHistogram), cl::NotHidden);
   cl::alias HistogramAlias("histogram",
                            cl::desc("Alias for --elf-hash-histogram"),
                            cl::aliasopt(HashHistogram));
 
   // --cg-profile
   cl::opt<bool> CGProfile("cg-profile",
                           cl::desc("Display callgraph profile section"));
   cl::alias ELFCGProfile("elf-cg-profile", cl::desc("Alias for --cg-profile"),