This is an archive of the discontinued LLVM Phabricator instance.

Differential D102013

[Fuchsia][CMake] Update OSX deployment target
ClosedPublic

Authored by phosek on May 6 2021, 12:01 PM.

Details

Reviewers
leonardchan
haowei
mcgrathr
gulfem
Commits
rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target
Summary

Use correct spelling of CMAKE_OSX_DEPLOYMENT_TARGET and bump the
minimum version to 10.13 which matches what we use for host tools
in Fuchsia.

Diff Detail

Event Timeline

phosek created this revision.May 6 2021, 12:01 PM
Herald added a subscriber: mgorny. · View Herald TranscriptMay 6 2021, 12:01 PM
phosek requested review of this revision.May 6 2021, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2021, 12:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
leonardchan accepted this revision.May 6 2021, 12:04 PM
This revision is now accepted and ready to land.May 6 2021, 12:04 PM
This revision was landed with ongoing or failed builds.May 6 2021, 12:06 PM
Closed by commit rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target.
Harbormaster completed remote builds in B103038: Diff 343467.May 6 2021, 12:54 PM

Revision Contents

PathSize
clang/
cmake/
caches/
2 lines
2 lines

Diff 343472

clang/cmake/caches/Fuchsia-stage2.cmake

Show All 36 Lines
set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "") set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")
set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER ON CACHE BOOL "") set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER ON CACHE BOOL "")
set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "") set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "")
set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "") set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
set(CMAKE_BUILD_TYPE Release CACHE STRING "") set(CMAKE_BUILD_TYPE Release CACHE STRING "")
if (APPLE) if (APPLE)
set(MACOSX_DEPLOYMENT_TARGET 10.7 CACHE STRING "") set(CMAKE_OSX_DEPLOYMENT_TARGET "10.13" CACHE STRING "")
elseif(MSVC) elseif(MSVC)
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded" CACHE STRING "") set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded" CACHE STRING "")
endif() endif()
if(APPLE) if(APPLE)
list(APPEND BUILTIN_TARGETS "default") list(APPEND BUILTIN_TARGETS "default")
list(APPEND RUNTIME_TARGETS "default") list(APPEND RUNTIME_TARGETS "default")
▲ Show 20 Lines • Show All 246 Lines • Show Last 20 Lines

clang/cmake/caches/Fuchsia.cmake

Show All 30 Lines
set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER ON CACHE BOOL "") set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER ON CACHE BOOL "")
set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "") set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "")
set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "") set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
set(CMAKE_BUILD_TYPE Release CACHE STRING "") set(CMAKE_BUILD_TYPE Release CACHE STRING "")
if(APPLE) if(APPLE)
set(MACOSX_DEPLOYMENT_TARGET 10.7 CACHE STRING "") set(CMAKE_OSX_DEPLOYMENT_TARGET "10.13" CACHE STRING "")
elseif(MSVC) elseif(MSVC)
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded" CACHE STRING "") set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded" CACHE STRING "")
endif() endif()
if(APPLE) if(APPLE)
set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "")
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines