This is an archive of the discontinued LLVM Phabricator instance.

[AIX][Test][ORC] Skip unsupported ORC C API tests on AIX
ClosedPublic

Authored by hubert.reinterpretcast on May 5 2021, 8:38 PM.

Details

Summary

As mentioned before in D78813, currently the XCOFF backend does not support writing 64-bit object files, which the ORC JIT tests will try to exercise if we are on AIX. This patch disables the tests on AIX for now. This is consistent with what's been done, for example, regarding armv7.

Diff Detail

Event Timeline

hubert.reinterpretcast requested review of this revision.May 5 2021, 8:38 PM
hubert.reinterpretcast created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2021, 8:38 PM
lhames requested changes to this revision.May 5 2021, 9:07 PM

Hi Hubert,

It would be better to just disable these tests on AIX for now. You can do that by extending the static bool isSupported(StringRef Triple) method to return false for AIX.

XCOFF backend does not support writing 64-bit object files...

Is there some other object format that the JIT should be selecting? Or is AIX not expected to produce JIT-linkable objects at all?

  • Lang.
This revision now requires changes to proceed.May 5 2021, 9:07 PM

Hi Hubert,

It would be better to just disable these tests on AIX for now. You can do that by extending the static bool isSupported(StringRef Triple) method to return false for AIX.

Thanks. I'll update the patch to do this.

XCOFF backend does not support writing 64-bit object files...

Is there some other object format that the JIT should be selecting?

Not really. There's only XCOFF in its 32-bit and 64-bit variations. We're building LLVM as a 64-bit application, so I think XCOFF64 is the right object format to select.

Or is AIX not expected to produce JIT-linkable objects at all?

I'm not certain how capable it is at this time of producing JIT-linkable objects. We've been trying to enable functionality for building C/C++ applications using Clang on AIX (which we had set up to call out to the system assembler). The direct object code generation started out with XCOFF32 and we ended up building that out further and further without getting to the XCOFF64 side.

  • Lang.

Address comments: Use isSupported

hubert.reinterpretcast edited the summary of this revision. (Show Details)May 5 2021, 9:44 PM
lhames accepted this revision.May 6 2021, 7:05 AM

LGTM. Thanks Hubert!

This revision is now accepted and ready to land.May 6 2021, 7:05 AM