This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Use std::make_unique
ClosedPublic

Authored by tpr on May 4 2021, 2:12 AM.

Details

Summary

Fix up my recent commit to use std::make_unique instead of
std::unique_ptr(new), as requested by David Blaikie.

Change-Id: Ic683d584b06d8d29ccd8179984a05024f8e84d2a

Diff Detail

Event Timeline

tpr created this revision.May 4 2021, 2:12 AM
tpr requested review of this revision.May 4 2021, 2:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 2:12 AM
tpr added a reviewer: dblaikie.May 4 2021, 2:14 AM
jhenderson accepted this revision.May 4 2021, 2:16 AM

LGTM. Could you post the actual Phabricator link to your previous patch or commit so that the link can be seen easily from this patch? Sufficient is DXXXXXX for the patch or rG<commit hash>.

This revision is now accepted and ready to land.May 4 2021, 2:16 AM
MaskRay accepted this revision.May 4 2021, 11:26 AM

We don't attach this Gerrit tag Change-Id: Ic683d584b06d8d29ccd8179984a05024f8e84d2a

tpr added a comment.May 6 2021, 12:42 AM

Previous commit being fixed up: rG1128311a19179ceca799ff0fbc4dd206ab56e560
I will also added that to the commit message.

This revision was automatically updated to reflect the committed changes.