This is an archive of the discontinued LLVM Phabricator instance.

Differential D101808

[mlir] Fix bug in TransferOpReduceRank when all dims are broadcasts
ClosedPublic

Authored by springerm on May 3 2021, 6:43 PM.

Details

Reviewers
ThomasRaoux
nicolasvasilache
aartbik
Commits
rGaa5828197971: [mlir] Fix bug in TransferOpReduceRank when all dims are broadcasts
Summary

TransferReadOps that are a scalar read + broadcast are handled by TransferReadToVectorLoadLowering.

Diff Detail

Event Timeline

springerm created this revision.May 3 2021, 6:43 PM
Herald added a reviewer: aartbik. · View Herald TranscriptMay 3 2021, 6:43 PM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald Transcript
springerm requested review of this revision.May 3 2021, 6:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 6:43 PM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
ThomasRaoux accepted this revision.May 3 2021, 6:50 PM

Thanks for the fix!

This revision is now accepted and ready to land.May 3 2021, 6:50 PM
This revision was landed with ongoing or failed builds.May 3 2021, 7:22 PM
Closed by commit rGaa5828197971: [mlir] Fix bug in TransferOpReduceRank when all dims are broadcasts (authored by springerm). · Explain Why
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rGaa5828197971: [mlir] Fix bug in TransferOpReduceRank when all dims are broadcasts.
Harbormaster completed remote builds in B102440: Diff 342621.May 3 2021, 8:43 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Vector/
3 lines

Diff 342623

mlir/lib/Dialect/Vector/VectorTransforms.cpp

Show First 20 Lines • Show All 2,964 Lines • ▼ Show 20 Lines AffineMap newMap = AffineMap::get(
map.getNumDims(), 0, map.getResults().take_back(reducedShapeRank), map.getNumDims(), 0, map.getResults().take_back(reducedShapeRank),
op.getContext()); op.getContext());
// Only remove the leading zeros if the rest of the map is a minor identity // Only remove the leading zeros if the rest of the map is a minor identity
// with broadasting. Otherwise we first want to permute the map. // with broadasting. Otherwise we first want to permute the map.
if (!newMap.isMinorIdentityWithBroadcasting()) if (!newMap.isMinorIdentityWithBroadcasting())
return failure(); return failure();
SmallVector<int64_t> newShape = llvm::to_vector<4>( SmallVector<int64_t> newShape = llvm::to_vector<4>(
originalVecType.getShape().take_back(reducedShapeRank)); originalVecType.getShape().take_back(reducedShapeRank));
// Vector rank cannot be zero. Handled by TransferReadToVectorLoadLowering.
if (newShape.empty())
return failure();
VectorType newReadType = VectorType newReadType =
VectorType::get(newShape, originalVecType.getElementType()); VectorType::get(newShape, originalVecType.getElementType());
ArrayAttr newInBounds = ArrayAttr newInBounds =
op.in_bounds() op.in_bounds()
? rewriter.getArrayAttr( ? rewriter.getArrayAttr(
op.in_boundsAttr().getValue().take_back(reducedShapeRank)) op.in_boundsAttr().getValue().take_back(reducedShapeRank))
: ArrayAttr(); : ArrayAttr();
Value newRead = rewriter.create<vector::TransferReadOp>( Value newRead = rewriter.create<vector::TransferReadOp>(
▲ Show 20 Lines • Show All 843 Lines • Show Last 20 Lines