This is an archive of the discontinued LLVM Phabricator instance.

Differential D101750

[clangd] Find implementors only when index is present.
ClosedPublic

Authored by usaxena95 on May 3 2021, 4:08 AM.

Details

Reviewers
sammccall
kadircet
Commits
rGc3d5f306e910: [clangd] Find implementors only when index is present.

Diff Detail

Event Timeline

usaxena95 created this revision.May 3 2021, 4:08 AM
Herald added subscribers: kadircet, arphaman. · View Herald TranscriptMay 3 2021, 4:08 AM
usaxena95 requested review of this revision.May 3 2021, 4:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 4:08 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
Harbormaster completed remote builds in B102261: Diff 342351.May 3 2021, 4:40 AM
kadircet accepted this revision.May 3 2021, 7:59 AM
This revision is now accepted and ready to land.May 3 2021, 7:59 AM
Closed by commit rGc3d5f306e910: [clangd] Find implementors only when index is present. (authored by usaxena95). · Explain WhyMay 3 2021, 8:16 AM
This revision was automatically updated to reflect the committed changes.
usaxena95 added a commit: rGc3d5f306e910: [clangd] Find implementors only when index is present..

Revision Contents

PathSize
clang-tools-extra/
clangd/
2 lines

Diff 342396

clang-tools-extra/clangd/XRefs.cpp

Show First 20 Lines • Show All 293 Lines • ▼ Show 20 Linesconst NamedDecl *getPreferredDecl(const NamedDecl *D) {
return D; return D;
} }
std::vector<LocatedSymbol> findImplementors(llvm::DenseSet<SymbolID> IDs, std::vector<LocatedSymbol> findImplementors(llvm::DenseSet<SymbolID> IDs,
RelationKind Predicate, RelationKind Predicate,
const SymbolIndex *Index, const SymbolIndex *Index,
llvm::StringRef MainFilePath) { llvm::StringRef MainFilePath) {
if (IDs.empty()) if (IDs.empty() || !Index)
return {}; return {};
static constexpr trace::Metric FindImplementorsMetric( static constexpr trace::Metric FindImplementorsMetric(
"find_implementors", trace::Metric::Counter, "case"); "find_implementors", trace::Metric::Counter, "case");
switch (Predicate) { switch (Predicate) {
case RelationKind::BaseOf: case RelationKind::BaseOf:
FindImplementorsMetric.record(1, "find-base"); FindImplementorsMetric.record(1, "find-base");
break; break;
case RelationKind::OverriddenBy: case RelationKind::OverriddenBy:
▲ Show 20 Lines • Show All 1,672 Lines • ▼ Show 20 Lines findExplicitReferences(
} }
}, },
AST.getHeuristicResolver()); AST.getHeuristicResolver());
return DeclRefs; return DeclRefs;
} }
} // namespace clangd } // namespace clangd
} // namespace clang } // namespace clang
No newline at end of file No newline at end of file