[WebAssembly] Reenable end-to-end test in wasm-eh.cpp

[aheejin]

Summary

This was temporarily disabled while we were reimplementing the new spec.

[tlively]

This is hopefully less controversial because the test already exists and this is just re-enabling it.

[dblaikie]

FWIW - please avoid end-to-end tests where possible (writing separate source to LLVM IR (in clang) and LLVM IR to assembly (in LLVM) tests). (recent discussions on the wasm simd instructions touched on this issue too)

[aheejin]

@dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if -exception-model=wasm reaches the backend compilation.

[dblaikie]

In D101735#2749716, @aheejin wrote:

@dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if -exception-model=wasm reaches the backend compilation.

Ah, and that flag is passed down through MCOptions or something like that (something purely in the programmatic API, not serialized into IR)? Fair enough - this is one of the exceptions to the "no end to end testing" rule - if it's the only way to demonstrate that the relevant MCOption was configured correctly, end-to-end testing is the best we've got there.

Thanks for the details!

clang/test/CodeGenCXX/wasm-eh.cpp

void test10() throw() {
   throw 3;
 }
 // WARNING-DEFAULT: warning: 'test10' has a non-throwing exception specification but can still throw
 // WARNING-DEFAULT: function declared non-throwing here
 
 // Here we only check if the command enables wasm exception handling in the
 // backend so that exception handling instructions can be generated in .s file.
 
-// TODO Reenable these lines after updating the backend to the new spec
-// R UN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -exception-model=wasm -target-feature +exception-handling -S -o - -std=c++11 | FileCheck %s --check-prefix=ASSEMBLY
+// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -exception-model=wasm -target-feature +exception-handling -S -o - -std=c++11 | FileCheck %s --check-prefix=ASSEMBLY
 
 // ASSEMBLY: try
 // ASSEMBLY: catch
 // ASSEMBLY: rethrow
 // ASSEMBLY: end_try