This is an archive of the discontinued LLVM Phabricator instance.

Differential D101622

[AMDGPU] Add implicit negative check for the set_gpr_idx tests
ClosedPublic

Authored by foad on Apr 30 2021, 6:20 AM.

Details

Reviewers
rampitec
arsenm
Commits
rG181c492ee72c: [AMDGPU] Add implicit negative check for the set_gpr_idx tests
Summary

The only effect of the optimization is to remove s_set_gpr_idx_*
instructions, and update_mir_test_checks.py always inserts CHECK: rather
than CHECK-NEXT: checks, so without this implicit negative check, the
tests would always pass even if the optimization did nothing.

Diff Detail

Event Timeline

foad created this revision.Apr 30 2021, 6:20 AM
Herald added subscribers: kerbowa, t-tye, tpr and 5 others. · View Herald TranscriptApr 30 2021, 6:20 AM
foad requested review of this revision.Apr 30 2021, 6:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2021, 6:20 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
arsenm accepted this revision.Apr 30 2021, 6:24 AM

update_mir_test_checks probably should have an option to use -NEXT

This revision is now accepted and ready to land.Apr 30 2021, 6:24 AM
This revision was landed with ongoing or failed builds.Apr 30 2021, 6:45 AM
Closed by commit rG181c492ee72c: [AMDGPU] Add implicit negative check for the set_gpr_idx tests (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rG181c492ee72c: [AMDGPU] Add implicit negative check for the set_gpr_idx tests.
Harbormaster completed remote builds in B101907: Diff 341870.Apr 30 2021, 7:06 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
AMDGPU/
2 lines

Diff 341885

llvm/test/CodeGen/AMDGPU/set-gpr-idx-peephole.mir

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -march=amdgcn -mcpu=gfx900 -run-pass si-pre-emit-peephole -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s # RUN: llc -march=amdgcn -mcpu=gfx900 -run-pass si-pre-emit-peephole -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s -implicit-check-not=S_SET_GPR_IDX
--- ---
name: simple name: simple
body: | body: |
bb.0: bb.0:
; GCN-LABEL: name: simple ; GCN-LABEL: name: simple
; GCN: S_SET_GPR_IDX_ON $sgpr2, 1, implicit-def $mode, implicit-def $m0, implicit $mode, implicit undef $m0 ; GCN: S_SET_GPR_IDX_ON $sgpr2, 1, implicit-def $mode, implicit-def $m0, implicit $mode, implicit undef $m0
▲ Show 20 Lines • Show All 466 Lines • Show Last 20 Lines