Page MenuHomePhabricator

Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass
ClosedPublic

Authored by wvoquine on Apr 29 2021, 2:51 PM.

Details

Diff Detail

Unit TestsFailed

TimeTest
80 msx64 debian > Clang.Driver::debug-pass-structure.c
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -fexperimental-new-pass-manager -fdebug-pass-structure -O3 -S -emit-llvm /mnt/disks/ssd0/agent/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1 | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/Driver/debug-pass-structure.c --check-prefix=NEWPM

Event Timeline

wvoquine created this revision.Apr 29 2021, 2:51 PM
wvoquine requested review of this revision.Apr 29 2021, 2:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2021, 2:51 PM
arsenm accepted this revision.Apr 29 2021, 3:12 PM
This revision is now accepted and ready to land.Apr 29 2021, 3:12 PM
bogner added a subscriber: bogner.Apr 29 2021, 3:48 PM
bogner added inline comments.
llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
266

Probably need to update this call to the constructor as well

xbolva00 added inline comments.
llvm/test/Transforms/LoadStoreVectorizer/X86/vectorize-i8-nested-add.ll
108

Precommit tests and rebase.

wvoquine updated this revision to Diff 341750.Apr 29 2021, 8:01 PM

Fixed the non-legacy pass compilation issue.

wvoquine marked 2 inline comments as done.Apr 29 2021, 8:04 PM
bogner accepted this revision.Apr 30 2021, 10:09 AM
wvoquine added a comment.EditedApr 30 2021, 10:12 AM

Could someone merge the change?

The failing clang test was updated in the ToT in such a way that it shouldn't be causing issues anymore.

bogner closed this revision.Apr 30 2021, 1:40 PM

Pushed "954272108587 Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass"