This is an archive of the discontinued LLVM Phabricator instance.

Differential D101402

[lld-macho] Don't put an antivirus test file in reproduce.s
ClosedPublic

Authored by int3 on Apr 27 2021, 2:58 PM.

Details

Reviewers
dyung
smeenai
Group Reviewers
Restricted Project
Commits
rG700402b00ecc: [lld-macho] Don't put an antivirus test file in reproduce.s
Summary

It appears that some antivirii do not recognize that "this is a
test": https://reviews.llvm.org/D101218#2720676

Diff Detail

Event Timeline

int3 created this revision.Apr 27 2021, 2:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 2:58 PM
int3 requested review of this revision.Apr 27 2021, 2:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 2:58 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
int3 mentioned this in D101218: [lld/mac] add test coverage for -sectcreate and -order_file with --reproduce.Apr 27 2021, 2:58 PM
smeenai accepted this revision.Apr 27 2021, 3:01 PM
smeenai added a subscriber: smeenai.

LGTM.

This is amazing.

This revision is now accepted and ready to land.Apr 27 2021, 3:01 PM
This revision was landed with ongoing or failed builds.Apr 27 2021, 3:03 PM
Closed by commit rG700402b00ecc: [lld-macho] Don't put an antivirus test file in reproduce.s (authored by int3). · Explain Why
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG700402b00ecc: [lld-macho] Don't put an antivirus test file in reproduce.s.
Harbormaster completed remote builds in B101272: Diff 340995.Apr 27 2021, 6:06 PM
dblaikie added a subscriber: dblaikie.May 2 2021, 1:08 PM
dblaikie added inline comments.
lld/test/MachO/reproduce.s
8

Maybe just "this is a test" or something would be more clear/not raise some weird suspicion when someone goes back to maintain this test about why viruses (or lack thereof) would be relevant to this test?

int3 added a comment.May 2 2021, 1:45 PM

I was trying to keep with the __COMPLETELY __legit theme :) I don't really think there's much risk of confusion, but I'm happy to stamp a change if you feel strongly about it

dblaikie added a comment.May 2 2021, 1:49 PM
In D101402#2732393, @int3 wrote:

I was trying to keep with the __COMPLETELY __legit theme :) I don't really think there's much risk of confusion, but I'm happy to stamp a change if you feel strongly about it

Eh, not especially strongly, no. Your call.

Revision Contents

PathSize
lld/
test/
MachO/
2 lines

Diff 340996

lld/test/MachO/reproduce.s

# REQUIRES: x86 # REQUIRES: x86
# RUN: rm -rf %t.dir # RUN: rm -rf %t.dir
# RUN: mkdir -p %t.dir/build1 # RUN: mkdir -p %t.dir/build1
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.dir/build1/foo.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.dir/build1/foo.o
# RUN: echo '_main' > %t.dir/main.exports # RUN: echo '_main' > %t.dir/main.exports
# RUN: echo '_main' > %t.dir/main.order # RUN: echo '_main' > %t.dir/main.order
# RUN: echo 'X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*' > %t.dir/sectdata.txt # RUN: echo 'not a virus' > %t.dir/sectdata.txt
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Maybe just "this is a test" or something would be more clear/not raise some weird suspicion when someone goes back to maintain this test about why viruses (or lack thereof) would be relevant to this test?

dblaikie: Maybe just "this is a test" or something would be more clear/not raise some weird suspicion…
# RUN: cd %t.dir # RUN: cd %t.dir
# RUN: %lld -platform_version macos 10.10.0 11.0 \ # RUN: %lld -platform_version macos 10.10.0 11.0 \
# RUN: -exported_symbols_list main.exports \ # RUN: -exported_symbols_list main.exports \
# RUN: -order_file main.order \ # RUN: -order_file main.order \
# RUN: -sectcreate __COMPLETELY __legit sectdata.txt \ # RUN: -sectcreate __COMPLETELY __legit sectdata.txt \
# RUN: build1/foo.o -o bar --reproduce repro1.tar # RUN: build1/foo.o -o bar --reproduce repro1.tar
# RUN: tar tf repro1.tar | FileCheck -DPATH='%:t.dir' --check-prefix=LIST %s # RUN: tar tf repro1.tar | FileCheck -DPATH='%:t.dir' --check-prefix=LIST %s
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines