This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] add test coverage for -sectcreate and -order_file with --reproduce
ClosedPublic

Authored by thakis on Apr 23 2021, 7:05 PM.

Details

Summary

Would've caught the (since fixed) regression in D97610.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Apr 23 2021, 7:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2021, 7:05 PM
thakis requested review of this revision.Apr 23 2021, 7:05 PM
int3 accepted this revision.Apr 23 2021, 9:05 PM
int3 added a subscriber: int3.

Completely legit 👍

This revision is now accepted and ready to land.Apr 23 2021, 9:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2021, 5:01 AM
dyung added a subscriber: dyung.Apr 27 2021, 12:46 PM

Hi, the file you create here sectdata.txt is being flagged as a virus by Windows Defender in our internal bot causing the file to be automatically deleted and the test to fail. Is there a reason why you need to use that particular string for the file? Can something else be used that won't trigger the antivirus?

int3 added a comment.Apr 27 2021, 2:58 PM

😂yeah I'm pretty sure @thakis only intended that to be a sort of "lorem ipsum" placeholder text. We can remove it for sure: D101402

thakis added a comment.May 3 2021, 7:53 AM

😂yeah I'm pretty sure @thakis only intended that to be a sort of "lorem ipsum" placeholder text. We can remove it for sure: D101402

Huh, I thought virus scanners are only supposed to warn on this if it's at offset 0. Yes, any string is fine. Sorry about this breaking your bots.