This is an archive of the discontinued LLVM Phabricator instance.

[NewPM] Invalidate AAManager after populating GlobalsAA
ClosedPublic

Authored by aeubanks on Apr 27 2021, 9:37 AM.

Details

Summary

GlobalsAA is only created at the beginning of the inliner pipeline. If
an AAManager is cached from previous passes, it won't get rebuilt to
include the newly created GlobalsAA.

Diff Detail

Event Timeline

aeubanks created this revision.Apr 27 2021, 9:37 AM
aeubanks requested review of this revision.Apr 27 2021, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 9:37 AM
mtrofin accepted this revision.May 3 2021, 10:30 AM

lgtm

This revision is now accepted and ready to land.May 3 2021, 10:30 AM
aeubanks updated this revision to Diff 342536.May 3 2021, 1:49 PM

don't mess with second GlobalsAA yet, that should be separated out since it's causing extra invalidation

I decided to separate the change to rebuild GlobalsAA in the optimization pipeline since that was causing extra loop analysis invalidation

aeubanks retitled this revision from [NewPM] Properly handle GlobalsAA in the default pipelines to [NewPM] Invalidate AAManager after populating GlobalsAA.May 3 2021, 1:50 PM
aeubanks edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.May 3 2021, 4:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 4:39 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript