This is an archive of the discontinued LLVM Phabricator instance.

[XCOFF] string constants handling for XCOFF
ClosedPublic

Authored by shchenz on Apr 26 2021, 2:19 AM.

Details

Summary

This is from the code review of D99785. To make sure same file name in symbol table and in .dwinfo section, we need to change string constants generation for AIX.

Handle string constants for XCOFF according to https://www.ibm.com/docs/en/aix/7.2?topic=constants-string

Diff Detail

Event Timeline

shchenz created this revision.Apr 26 2021, 2:19 AM
shchenz requested review of this revision.Apr 26 2021, 2:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2021, 2:19 AM

LGTM with comments.

llvm/include/llvm/MC/MCAsmInfo.h
348–349

Suggested expanded description here.

llvm/lib/MC/MCAsmInfoXCOFF.cpp
25

Add period to the end of the sentence.

llvm/lib/MC/MCAsmStreamer.cpp
63–68

New member functions can be const?

This revision is now accepted and ready to land.Apr 26 2021, 7:57 PM
shchenz updated this revision to Diff 340723.Apr 26 2021, 9:55 PM
shchenz marked 2 inline comments as done.

1: address @hubert.reinterpretcast comments

Thanks for your review @hubert.reinterpretcast

llvm/lib/MC/MCAsmStreamer.cpp
63–68

Good idea

This revision was landed with ongoing or failed builds.May 6 2021, 11:43 PM
This revision was automatically updated to reflect the committed changes.