This is an archive of the discontinued LLVM Phabricator instance.

Differential D101269

Remove obsolete using declaration that was just kept around to help with API adoption.
ClosedPublic

Authored by lattner on Apr 25 2021, 4:57 PM.

Details

Reviewers
rriddle
Commits
rGabd860eaef41: Remove obsolete using declaration that was just kept around to help with API…

Diff Detail

Event Timeline

lattner created this revision.Apr 25 2021, 4:57 PM
Herald added a reviewer: rriddle. · View Herald TranscriptApr 25 2021, 4:57 PM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald Transcript
lattner requested review of this revision.Apr 25 2021, 4:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2021, 4:57 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
lattner updated this revision to Diff 340403.Apr 25 2021, 5:04 PM

Remove another using declaration.

Harbormaster completed remote builds in B100838: Diff 340401.Apr 25 2021, 5:31 PM
Harbormaster completed remote builds in B100840: Diff 340403.Apr 25 2021, 5:40 PM
rriddle accepted this revision.Apr 26 2021, 10:50 AM
This revision is now accepted and ready to land.Apr 26 2021, 10:50 AM
Closed by commit rGabd860eaef41: Remove obsolete using declaration that was just kept around to help with API… (authored by lattner). · Explain WhyApr 26 2021, 11:53 AM
This revision was automatically updated to reflect the committed changes.
lattner added a commit: rGabd860eaef41: Remove obsolete using declaration that was just kept around to help with API….
lattner added a comment.Apr 26 2021, 11:53 AM

Thx for the review!

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
4 lines

Diff 340401

mlir/include/mlir/IR/PatternMatch.h

Show First 20 Lines • Show All 987 Lines • ▼ Show 20 Lines addImpl(Args &&... args) {
pdlPatterns.mergeIn(T(std::forward<Args>(args)...)); pdlPatterns.mergeIn(T(std::forward<Args>(args)...));
} }
MLIRContext *const context; MLIRContext *const context;
NativePatternListT nativePatterns; NativePatternListT nativePatterns;
PDLPatternModule pdlPatterns; PDLPatternModule pdlPatterns;
}; };
// TODO: OwningRewritePatternList is soft-deprecated and will be removed in the
// future.
using OwningRewritePatternList = RewritePatternSet;
} // end namespace mlir } // end namespace mlir
#endif // MLIR_PATTERN_MATCH_H #endif // MLIR_PATTERN_MATCH_H