This is an archive of the discontinued LLVM Phabricator instance.

[Analysis] Attribute alignment should not prevent tail call optimization
ClosedPublic

Authored by xbolva00 on Apr 24 2021, 4:58 AM.

Details

Diff Detail

Event Timeline

xbolva00 created this revision.Apr 24 2021, 4:58 AM
xbolva00 requested review of this revision.Apr 24 2021, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2021, 4:58 AM
dmgreen accepted this revision.Apr 24 2021, 9:35 AM

Thanks. LGTM

There is also some code in TargetLowering::isInTailCallPosition, but I believe that only gets used in expanding libcalls. Might be worth a check though, to see if it deserves the same treatment.

This revision is now accepted and ready to land.Apr 24 2021, 9:35 AM
xbolva00 updated this revision to Diff 340302.Apr 24 2021, 10:35 AM

Handle isInTailCallPosition too.

This revision was landed with ongoing or failed builds.Apr 24 2021, 10:58 AM
This revision was automatically updated to reflect the committed changes.