This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class
ClosedPublic

Authored by RamNalamothu on Apr 23 2021, 4:22 AM.

Details

Summary

The data member 'shouldEmitMoves' is only used in DwarfCFIException::beginFunction()
and 'shouldEmitCFI' in DwarfCFIExceptionBase serves its purpose.

Diff Detail

Event Timeline

RamNalamothu created this revision.Apr 23 2021, 4:22 AM
RamNalamothu requested review of this revision.Apr 23 2021, 4:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2021, 4:22 AM
RamNalamothu edited the summary of this revision. (Show Details)Apr 23 2021, 5:35 AM
MaskRay accepted this revision.EditedApr 23 2021, 11:40 AM

LGTM. I looked at the code just yesterday - to make -fno-asynchronous-unwind-tables -g work with more instrumentations:)

This revision is now accepted and ready to land.Apr 23 2021, 11:40 AM
This revision was landed with ongoing or failed builds.Apr 23 2021, 6:06 PM
This revision was automatically updated to reflect the committed changes.