This is an archive of the discontinued LLVM Phabricator instance.

Differential D101135

[Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives
ClosedPublic

Authored by zsrkmyn on Apr 22 2021, 11:08 PM.

Details

Reviewers
awarzynski
MaskRay
porglezomp
Commits
rG7faabe5fc91e: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives

Diff Detail

Event Timeline

zsrkmyn requested review of this revision.Apr 22 2021, 11:08 PM
zsrkmyn created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 11:08 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B100463: Diff 339886.Apr 22 2021, 11:44 PM
MaskRay added a comment.Apr 25 2021, 12:19 AM

Note, many prefixes are not called CHECK*...

zsrkmyn added a comment.Apr 25 2021, 8:41 PM
In D101135#2715124, @MaskRay wrote:

Note, many prefixes are not called CHECK*...

Yea, but most directives with CHECK prefix are already highlighted. This patch just adds EMPTY and COUNT support.

porglezomp accepted this revision.Apr 26 2021, 3:43 AM

Style nit on quote-vs-slash, but otherwise this looks good to me.

llvm/utils/vim/syntax/llvm.vim
237–238

Minor nit, I don't think there's any reason these patterns need to use quotes, they could be changed to slash to match all of the surrounding patterns

This revision is now accepted and ready to land.Apr 26 2021, 3:43 AM
zsrkmyn updated this revision to Diff 344713.May 12 2021, 1:38 AM
zsrkmyn marked an inline comment as done.
Harbormaster completed remote builds in B103978: Diff 344713.May 12 2021, 2:53 AM
zsrkmyn added a comment.May 16 2021, 6:40 PM

Would you mind helping me commit this patch if there's no further comment? Thanks :-)

Closed by commit rG7faabe5fc91e: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives (authored by zsrkmyn, committed by porglezomp). · Explain WhyMay 18 2021, 8:42 PM
This revision was automatically updated to reflect the committed changes.
porglezomp added a commit: rG7faabe5fc91e: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Revision Contents

PathSize
llvm/
utils/
vim/
syntax/
3 lines

Diff 339886

llvm/utils/vim/syntax/llvm.vim

Context not available.
syn match llvmSpecialComment /;\s*RUN:.*$/ syn match llvmSpecialComment /;\s*RUN:.*$/
syn match llvmSpecialComment /;\s*ALLOW_RETRIES:.*$/ syn match llvmSpecialComment /;\s*ALLOW_RETRIES:.*$/
syn match llvmSpecialComment /;\s*CHECK:.*$/ syn match llvmSpecialComment /;\s*CHECK:.*$/
syn match llvmSpecialComment "\v;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL):.*$" syn match llvmSpecialComment ";\s*CHECK-EMPTY:\s*$"
syn match llvmSpecialComment "\v;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL|COUNT-\d+):.*$"
porglezompUnsubmitted
Done
ReplyInline Actions

Minor nit, I don't think there's any reason these patterns need to use quotes, they could be changed to slash to match all of the surrounding patterns

porglezomp: Minor nit, I don't think there's any reason these patterns need to use quotes, they could be…
syn match llvmSpecialComment /;\s*XFAIL:.*$/ syn match llvmSpecialComment /;\s*XFAIL:.*$/
if version >= 508 || !exists("did_c_syn_inits") if version >= 508 || !exists("did_c_syn_inits")
Context not available.