Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Yea, but most directives with CHECK prefix are already highlighted. This patch just adds EMPTY and COUNT support.
Comment Actions
Style nit on quote-vs-slash, but otherwise this looks good to me.
llvm/utils/vim/syntax/llvm.vim | ||
---|---|---|
237–238 | Minor nit, I don't think there's any reason these patterns need to use quotes, they could be changed to slash to match all of the surrounding patterns |
Comment Actions
Would you mind helping me commit this patch if there's no further comment? Thanks :-)
Minor nit, I don't think there's any reason these patterns need to use quotes, they could be changed to slash to match all of the surrounding patterns