Page MenuHomePhabricator

[COST][AARCH64] Improve cost of reverse shuffles for AArch64.
ClosedPublic

Authored by ABataev on Tue, Apr 20, 10:43 AM.

Details

Summary

Introduced the cost of thre reverse shuffles for AArch64, currently just
copied the costs for PermuteSingleSrc.

Diff Detail

Event Timeline

ABataev created this revision.Tue, Apr 20, 10:43 AM
ABataev requested review of this revision.Tue, Apr 20, 10:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Apr 20, 10:43 AM
dmgreen added inline comments.
llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
1490

Can you add them here, before any "nx" scalable vectors.

1501

Can be 2. REV64; EXT

1504

Same here.

ABataev updated this revision to Diff 338968.Tue, Apr 20, 12:51 PM

Address comments.

dmgreen accepted this revision.Tue, Apr 20, 12:59 PM

Thanks. LGTM

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
1483

This can say something like "Reverse can are lowered with rev.

This revision is now accepted and ready to land.Tue, Apr 20, 12:59 PM
ABataev added inline comments.Tue, Apr 20, 12:59 PM
llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
1483

Ok,will add

This revision was landed with ongoing or failed builds.Tue, Apr 20, 1:49 PM
This revision was automatically updated to reflect the committed changes.