Page MenuHomePhabricator

AArch64: support mixed-size vector fp <-> int conversions in GlobalISel.
ClosedPublic

Authored by t.p.northover on Apr 20 2021, 7:36 AM.

Details

Reviewers
paquette
aemerson
Summary

Fairly simple, just a few extra patterns to handle the extra instructions.

Diff Detail

Event Timeline

t.p.northover created this revision.Apr 20 2021, 7:36 AM
t.p.northover requested review of this revision.Apr 20 2021, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 7:36 AM
This revision is now accepted and ready to land.Apr 20 2021, 8:52 AM
arsenm added a subscriber: arsenm.Apr 20 2021, 9:04 AM
arsenm added inline comments.
llvm/test/CodeGen/AArch64/GlobalISel/select-fp-casts.mir
644–646

Should drop the registers section and use the modern ":regbank" syntax

If these patterns are intended to fire only when using GlobalISel, then we have a separate file for those, AArch64InstrGISel.td.

llvm/utils/TableGen/GlobalISelEmitter.cpp
4467

debug line

t.p.northover closed this revision.Apr 22 2021, 7:04 AM

Thanks, committed as 2e72f6b5d with Amara & Matt's comments addressed (and the stray commented dump removed).