Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks @jnyfah for the patch!
It looks you need to rebase your branch to llvm upstream main branch. Because polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing see - https://polly.llvm.org/docs/ReleaseNotes.html.
Release note for the previous branch is now published and we can't change them. So now your patch should contain only the changes in clang/docs/UsersManual.rst and libcxx/docs/UsingLibcxx.rst.
Actually, I am not able to apply this patch with arc patch D100696.
Created and checked out branch arcpatch-D100696.
Checking patch polly/docs/ReleaseNotes.rst...
error: while searching for:
.. warning::
These release notes are for the next release of Polly and it describes the new features that have recently been committed to our development branch.
error: patch failed: polly/docs/ReleaseNotes.rst:6
Checking patch libcxx/docs/UsingLibcxx.rst...
Checking patch clang/docs/UsersManual.rst...
Applying patch polly/docs/ReleaseNotes.rst with 1 reject...
Rejected hunk #1.
@curdeius could you help here to understand why this message comes?
@jnyfah If you are missing something I am just telling you the steps -
- First fork the llvm github repository
- git clone https://github.com/jynfah/llvm-project
- git checkout -b type-fix
- make changes to files.
- git diff > mypatch.patch
- git commit -m "fix typo"
- go to reviews.llvm.org and login and click on differential then create diff and update the diff (mypatch.patch)
- complete remaining entries.
Then there is an arc tool way, install it from https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/.
after the 4th step, skip 5 and complete 6, and then do arc diff to create a revision from the terminal. You will be asked to verify credentials.
If reviewers asks you to make changes, checkout your local branch, make changes and then again do arc diff.
Don't forget to rebase by git pull --rebase https://github.com/llvm/llvm-project.git main
polly/docs/ReleaseNotes.rst | ||
---|---|---|
9 | This diff seems to be based on D100588 which changes "These releaes notes [...] and describe" to "These release notes [...] and it describes". IMHO the second part is incorrect (and reverted by this patch), or at least unnecessary, because 1) "release notes" is plural and 2) "describe" is a compound predicate. |
@jnyfah you may close this revision. changes are committed by https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a.
This diff seems to be based on D100588 which changes "These releaes notes [...] and describe" to "These release notes [...] and it describes". IMHO the second part is incorrect (and reverted by this patch), or at least unnecessary, because 1) "release notes" is plural and 2) "describe" is a compound predicate.