This is an archive of the discontinued LLVM Phabricator instance.

Fixed typos
ClosedPublic

Authored by jnyfah on Apr 16 2021, 11:34 PM.

Details

Reviewers
bollu
xgupta
curdeius
ldionne
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

jnyfah created this revision.Apr 16 2021, 11:34 PM
jnyfah requested review of this revision.Apr 16 2021, 11:34 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 16 2021, 11:34 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jnyfah edited reviewers, added: xgupta; removed: Restricted Project.Apr 16 2021, 11:38 PM
jnyfah removed a subscriber: libcxx-commits.
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2021, 11:38 PM
curdeius accepted this revision as: curdeius.Apr 17 2021, 12:14 AM
curdeius added a subscriber: curdeius.

LGTM. Thanks!

xgupta requested changes to this revision.Apr 17 2021, 12:23 AM

Thanks @jnyfah for the patch!

It looks you need to rebase your branch to llvm upstream main branch. Because polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing see - https://polly.llvm.org/docs/ReleaseNotes.html.

Release note for the previous branch is now published and we can't change them. So now your patch should contain only the changes in clang/docs/UsersManual.rst and libcxx/docs/UsingLibcxx.rst.

This revision now requires changes to proceed.Apr 17 2021, 12:23 AM
xgupta accepted this revision.Apr 17 2021, 12:27 AM

Oh sorry, Your patch is correct. I misunderstand something :)

This revision now requires review to proceed.Apr 17 2021, 12:27 AM

Actually, I am not able to apply this patch with arc patch D100696.

Created and checked out branch arcpatch-D100696.
Checking patch polly/docs/ReleaseNotes.rst...
error: while searching for:

.. warning::

These release notes are for the next release of Polly and it describes
the new features that have recently been committed to our development
branch.

error: patch failed: polly/docs/ReleaseNotes.rst:6
Checking patch libcxx/docs/UsingLibcxx.rst...
Checking patch clang/docs/UsersManual.rst...
Applying patch polly/docs/ReleaseNotes.rst with 1 reject...
Rejected hunk #1.

@curdeius could you help here to understand why this message comes?

@jnyfah If you are missing something I am just telling you the steps -

  1. First fork the llvm github repository
  2. git clone https://github.com/jynfah/llvm-project
  3. git checkout -b type-fix
  4. make changes to files.
  5. git diff > mypatch.patch
  6. git commit -m "fix typo"
  7. go to reviews.llvm.org and login and click on differential then create diff and update the diff (mypatch.patch)
  8. complete remaining entries.

Then there is an arc tool way, install it from https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/.
after the 4th step, skip 5 and complete 6, and then do arc diff to create a revision from the terminal. You will be asked to verify credentials.
If reviewers asks you to make changes, checkout your local branch, make changes and then again do arc diff.

Don't forget to rebase by git pull --rebase https://github.com/llvm/llvm-project.git main

Meinersbur added inline comments.
polly/docs/ReleaseNotes.rst
9

This diff seems to be based on D100588 which changes "These releaes notes [...] and describe" to "These release notes [...] and it describes". IMHO the second part is incorrect (and reverted by this patch), or at least unnecessary, because 1) "release notes" is plural and 2) "describe" is a compound predicate.

ldionne accepted this revision.Apr 20 2021, 6:01 AM
This revision is now accepted and ready to land.Apr 20 2021, 6:01 AM
ldionne closed this revision.Apr 21 2021, 2:26 PM