This is an archive of the discontinued LLVM Phabricator instance.

Fixed Typos
ClosedPublic

Authored by jnyfah on Apr 17 2021, 7:57 AM.

Details

Reviewers
xgupta
Mordante
Group Reviewers
Restricted Project
Commits
rG21bef4e11e48: [NFC] Fixed Typos

Diff Detail

Event Timeline

jnyfah requested review of this revision.Apr 17 2021, 7:57 AM
jnyfah created this revision.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 17 2021, 7:57 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
xgupta accepted this revision.Apr 17 2021, 8:01 AM
Mordante accepted this revision as: Mordante.Apr 17 2021, 9:32 AM
Mordante added a subscriber: Mordante.

Thanks for your contribution. Next time, please provide a patch with more context.
The instructions can be found at https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.
LGTM, but please wait for an approval of the libc++ group.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2021, 9:33 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah, committed by xgupta). · Explain Why
This revision was automatically updated to reflect the committed changes.

Nice work @jnyfah!

@Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch.

Nice work @jnyfah!

@Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch.

In general when a patch is blocked by a reviewer it shouldn't be committed. However the patch is trivial so not a big issue.
Secondly, if I'd known @curdeius approved it I would have approved as libc++.

Thanks, @Mordante for the tips, I remember from next time :)