Details
Details
- Reviewers
xgupta Mordante - Group Reviewers
Restricted Project - Commits
- rG21bef4e11e48: [NFC] Fixed Typos
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for your contribution. Next time, please provide a patch with more context.
The instructions can be found at https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.
LGTM, but please wait for an approval of the libc++ group.
Comment Actions
Nice work @jnyfah!
@Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch.
Comment Actions
In general when a patch is blocked by a reviewer it shouldn't be committed. However the patch is trivial so not a big issue.
Secondly, if I'd known @curdeius approved it I would have approved as libc++.