Page MenuHomePhabricator

Handle DW_FORM_strx[1-4] in llvm-dwp
AbandonedPublic

Authored by kimanh on Wed, Apr 14, 2:18 AM.

Details

Summary

Add suport for DW_FORM_STR[1-4] that are introduced in DWARF5. Adapted patch by tamur.

Diff Detail

Event Timeline

kimanh created this revision.Wed, Apr 14, 2:18 AM
kimanh requested review of this revision.Wed, Apr 14, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Apr 14, 2:18 AM
kimanh added a comment.EditedWed, Apr 14, 2:25 AM

Picking up patch by tamur: https://reviews.llvm.org/D75485

I've addressed the outstanding issues, i.e.:

  1. Adding test cases for each error case in parseCompileUnitHeader(StringRef Info)
  2. Changing the error message to reuse the message from Error in parseCompileUnitHeader(StringRef Info)
  3. Adapted tests (minor change: test error message, and added required header info to unsupported_cu_index_version.s)

As it seems (https://reviews.llvm.org/D77143) llvm-dwp does not yet support a compile unit index version of 5, which is used in DWARF5. Will investigate (any input is welcome) later. However, with this patch (originally from tamur), we can now generate dwps.

PTAL :-)

Hmm - perhaps you could commandeer the previous review, then update it? That'd make it easier to see any changes you've made from the previous review.

kimanh abandoned this revision.Fri, Apr 16, 12:45 AM

Updating the original review (https://reviews.llvm.org/D75485) and closing this one.