Page MenuHomePhabricator

kimanh (Kim-Anh Tran)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 11 2021, 5:32 AM (8 w, 1 d)

Recent Activity

Yesterday

kimanh added inline comments to D101894: [llvm-dwp] Add support for rnglists and loclists.
Thu, May 6, 2:15 AM · Restricted Project
kimanh updated the diff for D101894: [llvm-dwp] Add support for rnglists and loclists.

Simplify tests:

  • use hardocoded constants as offsets
  • simplify abbrev section and remove str section
Thu, May 6, 2:02 AM · Restricted Project

Wed, May 5

kimanh updated the diff for D101818: Add support for DWARFv5 type units (and v5 index) to llvm-dwp ....

Update variable name (clang-tidy).

Wed, May 5, 4:58 AM · Restricted Project
kimanh added a reviewer for D101894: [llvm-dwp] Add support for rnglists and loclists: dblaikie.
Wed, May 5, 4:54 AM · Restricted Project
kimanh updated the diff for D101894: [llvm-dwp] Add support for rnglists and loclists.

Minor: use wildcard in test.

Wed, May 5, 4:52 AM · Restricted Project
kimanh updated the diff for D101894: [llvm-dwp] Add support for rnglists and loclists.

Minor change: edit comment in test

Wed, May 5, 4:42 AM · Restricted Project
kimanh requested review of D101894: [llvm-dwp] Add support for rnglists and loclists.
Wed, May 5, 4:39 AM · Restricted Project

Tue, May 4

kimanh updated the diff for D101818: Add support for DWARFv5 type units (and v5 index) to llvm-dwp ....

Updated comment, and added extra output check to test.

Tue, May 4, 12:03 AM · Restricted Project

Mon, May 3

kimanh retitled D101818: Add support for DWARFv5 type units (and v5 index) to llvm-dwp ... from Add support for DWARFv5 type units (and v5 index) to llvm-dwp ... to Add support for DWARFv5 type units (and v5 index) to llvm-dwp ....
Mon, May 3, 11:56 PM · Restricted Project
kimanh requested review of D101818: Add support for DWARFv5 type units (and v5 index) to llvm-dwp ....
Mon, May 3, 11:55 PM · Restricted Project

Tue, Apr 27

kimanh added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Thanks for the review and the help with landing the patch :)!

Tue, Apr 27, 9:43 PM · Restricted Project

Mon, Apr 26

kimanh added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Ok, sounds good, removed the 64-bit DWARF parts now. If everything looks fine, could you help me to merge this patch?

Mon, Apr 26, 12:48 AM · Restricted Project
kimanh updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..
  • Removing 64-bit DWARF parts
Mon, Apr 26, 12:44 AM · Restricted Project

Fri, Apr 23

kimanh added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Thanks a lot for the reviews!

Fri, Apr 23, 2:22 AM · Restricted Project
kimanh updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..
  • removed Err parameter after already checking the header size
  • updated error message for compile unit length
  • adapted abbrev offset size (and thus also header size) for dwarf32/dwarf64
Fri, Apr 23, 1:58 AM · Restricted Project

Mon, Apr 19

kimanh updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

Re-uploading as merged commit.

Mon, Apr 19, 7:16 AM · Restricted Project
kimanh updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

Addressing reviewer comments:

Mon, Apr 19, 7:08 AM · Restricted Project
kimanh abandoned D100761: Address reviewer comments.

Accidentally created new revision. Closing.

Mon, Apr 19, 7:01 AM · Restricted Project
kimanh requested review of D100761: Address reviewer comments.
Mon, Apr 19, 7:00 AM · Restricted Project

Fri, Apr 16

kimanh added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Answering leftover TODOs except of the FIXME one.

Fri, Apr 16, 12:46 AM · Restricted Project
kimanh abandoned D100458: Handle DW_FORM_strx[1-4] in llvm-dwp.

Updating the original review (https://reviews.llvm.org/D75485) and closing this one.

Fri, Apr 16, 12:45 AM · Restricted Project
kimanh commandeered D75485: Support DW_FORM_strx* in llvm-dwp..

Commandeering revision.

Fri, Apr 16, 12:26 AM · Restricted Project
kimanh updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

Picking up patch and updating outstanding issues:

Fri, Apr 16, 12:22 AM · Restricted Project

Wed, Apr 14

kimanh added a comment to D100458: Handle DW_FORM_strx[1-4] in llvm-dwp.

Picking up patch by tamur: https://reviews.llvm.org/D75485

Wed, Apr 14, 2:25 AM · Restricted Project
kimanh requested review of D100458: Handle DW_FORM_strx[1-4] in llvm-dwp.
Wed, Apr 14, 2:19 AM · Restricted Project

Mar 24 2021

kimanh added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

We recently ran into this issue too. It seems as if the thread was forgotten about, and if some comments were not addressed yet. Ping @tamur @dblaikie : Are there any plans for this?

Mar 24 2021, 12:13 AM · Restricted Project

Mar 22 2021

kimanh added a comment to D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

I'm very sorry for the incorrect reduction, and thanks for fixing this!

Mar 22 2021, 7:38 AM · Restricted Project
kimanh added a comment to D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

It seems as if it's the same for windows (I don't have windows unfortunately to check):

Mar 22 2021, 5:57 AM · Restricted Project
kimanh added a comment to D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

Thanks for having a look, and for the explanation! Please let me know if I can do anything to help debugging this!

Mar 22 2021, 3:40 AM · Restricted Project
kimanh added a comment to D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

Unfortunately the test seems to run and fail on the ARM. I thoughty adding REQUIRES: x85 would skip no x86 ones, but maybe I did something wrong.

Mar 22 2021, 1:30 AM · Restricted Project

Mar 18 2021

kimanh added a comment to D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

Thanks a lot for the review Pavel! I've updated the test. If it looks fine like this, could you help me to commit this change?

Mar 18 2021, 6:46 AM · Restricted Project
kimanh updated the diff for D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.

Removing subprogram and base_type tags (as they are not needed for the test)

Mar 18 2021, 6:37 AM · Restricted Project

Mar 15 2021

kimanh added a reviewer for D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF: dblaikie.
Mar 15 2021, 2:55 AM · Restricted Project

Mar 14 2021

kimanh requested review of D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF.
Mar 14 2021, 11:19 PM · Restricted Project