- User Since
- Mar 11 2021, 5:32 AM (8 w, 1 d)
- use hardocoded constants as offsets
- simplify abbrev section and remove str section
Wed, May 5
Update variable name (clang-tidy).
Minor: use wildcard in test.
Minor change: edit comment in test
Tue, May 4
Updated comment, and added extra output check to test.
Mon, May 3
Tue, Apr 27
Thanks for the review and the help with landing the patch :)!
Mon, Apr 26
Ok, sounds good, removed the 64-bit DWARF parts now. If everything looks fine, could you help me to merge this patch?
- Removing 64-bit DWARF parts
Fri, Apr 23
Thanks a lot for the reviews!
- removed Err parameter after already checking the header size
- updated error message for compile unit length
- adapted abbrev offset size (and thus also header size) for dwarf32/dwarf64
Mon, Apr 19
Re-uploading as merged commit.
Addressing reviewer comments:
Accidentally created new revision. Closing.
Fri, Apr 16
Answering leftover TODOs except of the FIXME one.
Updating the original review (https://reviews.llvm.org/D75485) and closing this one.
Picking up patch and updating outstanding issues:
Wed, Apr 14
Picking up patch by tamur: https://reviews.llvm.org/D75485
Mar 24 2021
Mar 22 2021
I'm very sorry for the incorrect reduction, and thanks for fixing this!
It seems as if it's the same for windows (I don't have windows unfortunately to check):
Thanks for having a look, and for the explanation! Please let me know if I can do anything to help debugging this!
Unfortunately the test seems to run and fail on the ARM. I thoughty adding REQUIRES: x85 would skip no x86 ones, but maybe I did something wrong.
Mar 18 2021
Thanks a lot for the review Pavel! I've updated the test. If it looks fine like this, could you help me to commit this change?
Removing subprogram and base_type tags (as they are not needed for the test)