This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Force Symbols containing '.' to be quoted
ClosedPublic

Authored by loladiro on Apr 12 2021, 8:07 PM.

Details

Summary

In D87099, the mangler learned to quote export directives that contain
special characters. Only alhpanumerical characters as well as
'_', '$', '.' and '@' were exmpt from this quoting. However, at least
binutils considers an unquoted '.' to be syntax and object files
containing such symbols will cause errors during linking. Fix that
by removing '.' from the list of allowed exemptions.

Diff Detail

Event Timeline

loladiro created this revision.Apr 12 2021, 8:07 PM
loladiro requested review of this revision.Apr 12 2021, 8:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 8:07 PM

Can you add a testcase?

vtjnash updated this revision to Diff 361803.Jul 26 2021, 2:22 PM

adding test

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2021, 2:31 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.