Page MenuHomePhabricator

Update OpBase.td AttrDef class to define default value for returnType and convertFromStorage (NFC)
ClosedPublic

Authored by mehdi_amini on Apr 12 2021, 6:13 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 12 2021, 6:13 PM
mehdi_amini requested review of this revision.Apr 12 2021, 6:13 PM
rriddle accepted this revision.Apr 12 2021, 6:20 PM
rriddle added inline comments.
mlir/include/mlir/IR/OpBase.td
2711–2714

This description leads me to believe that this should just be $_self?

This revision is now accepted and ready to land.Apr 12 2021, 6:20 PM
mehdi_amini added inline comments.Apr 14 2021, 12:25 PM
mlir/include/mlir/IR/OpBase.td
2711–2714

What would you write? (I just copy/pasted it from: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/IR/OpBase.td#L791-L799 ). We should probably update both.