This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Log a message when gRPC support is off, but remote-index is configured
ClosedPublic

Authored by kadircet on Apr 8 2021, 6:39 AM.

Details

Summary

Before this change clangd would emit a diagnostic whenever remote-index
was configured but binary didn't have grpc support.

This can be annoying when projects are configuring remote-index through their
configs but developers have a clangd binary without the support.

Diff Detail

Event Timeline

kadircet created this revision.Apr 8 2021, 6:39 AM
kadircet requested review of this revision.Apr 8 2021, 6:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2021, 6:39 AM
kadircet updated this revision to Diff 336088.Apr 8 2021, 6:49 AM
  • Update the tests
kbobyrev accepted this revision.Apr 9 2021, 4:25 AM

Thanks!

This revision is now accepted and ready to land.Apr 9 2021, 4:25 AM