Refactor: simplify boolean conditional return statements in lib/Analysis

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements

[LegalizeAdulthood]

diff -U9999

[aaron.ballman]

LGTM!

~Aaron

[LegalizeAdulthood]

Can someone commit this for me, please? Thanks!

Richard Thomson <[e-mail]>

[jordan_rose]

In this case I think the change is all right, but many times we have a series of early returns ending with a "return true". In that case I'm not sure clang-tidy's version is clearer.

lib/Analysis/BodyFarm.cpp

static bool isDispatchBlock(QualType Ty) {
   const BlockPointerType *BPT = Ty->getAs<BlockPointerType>();
   if (!BPT)
     return false;
 
   // Check if the block pointer type takes no arguments and
   // returns void.
   const FunctionProtoType *FT =
   BPT->getPointeeType()->getAs<FunctionProtoType>();
-  if (!FT || !FT->getReturnType()->isVoidType() || FT->getNumParams() != 0)
-    return false;
-
-  return true;
+  return FT && FT->getReturnType()->isVoidType() && FT->getNumParams() == 0;
 }
 
 namespace {
 class ASTMaker {
 public:
   ASTMaker(ASTContext &C) : C(C) {}
   
   /// Create a new BinaryOperator representing a simple assignment.