Details
- Reviewers
t-tye - Commits
- rG37878de50367: Disable use of SCC bit from asm
Diff Detail
Event Timeline
Message / name is somewhat confusing since I assumed this meant the scc register
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4097–4098 | I don't think this should be using SMLoc to check the string content. Isn't there an already parsed token? |
Retitled.
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4097–4098 | Not since I did a function to parse all these bits together and in any order. I now have to search for it. Anyhow, it is just moved from the place below. |
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4099 | Could the GPU name be printed? I think that is done in other error messages? |
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4099 | Asm parser universally prints "on this GPU". If we want to be specific we probably need to update it everywhere. |
I don't think this should be using SMLoc to check the string content. Isn't there an already parsed token?