This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Rename linalg.pooling operations to have a FOp postfix for floating point
ClosedPublic

Authored by rsuderman on Apr 1 2021, 5:01 PM.

Details

Summary

Linalg pooling operations only support floating point currently but integer
variants will soon be needed. Renaming to uncluse a FOp postfix to clarify.

Diff Detail

Event Timeline

rsuderman created this revision.Apr 1 2021, 5:01 PM
rsuderman requested review of this revision.Apr 1 2021, 5:01 PM

Mostly a renaming proposal so I can look into the quantized pooling variant for TOSA.

mravishankar accepted this revision.Apr 1 2021, 11:07 PM
This revision is now accepted and ready to land.Apr 1 2021, 11:07 PM

Just a thought if we want to just rename them to F32. But this path is on deprecation, so I dont really care.

Just a thought if we want to just rename them to F32. But this path is on deprecation, so I dont really care.

We might as well stick to FOp just to match surrounding functions. Perhaps there an be another rename in the future.