Page MenuHomePhabricator

limo1996 (Jakub Lichman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2020, 7:49 AM (31 w, 4 d)

Recent Activity

Oct 12 2020

limo1996 accepted D89223: [mlir][Linalg] NFC - Automate the printing of canonicalizers and folders for nameds Linalg ops..

Looks good, thanks!

Oct 12 2020, 4:08 AM · Restricted Project

Oct 8 2020

limo1996 committed rGe547b1e2431f: [mlir] Rank reducing subview conversion to LLVM (authored by limo1996).
[mlir] Rank reducing subview conversion to LLVM
Oct 8 2020, 6:48 AM
limo1996 closed D88883: [mlir] Rank reducing subview conversion to LLVM.
Oct 8 2020, 6:48 AM · Restricted Project
limo1996 updated the diff for D88883: [mlir] Rank reducing subview conversion to LLVM.

Next wave of comments addressed

Oct 8 2020, 6:29 AM · Restricted Project
limo1996 updated the diff for D88883: [mlir] Rank reducing subview conversion to LLVM.

Comments of Nicolas incorporated

Oct 8 2020, 3:02 AM · Restricted Project
limo1996 committed rGe7cf723051cd: [mlir] Added strides check to rank reducing subview verification (authored by limo1996).
[mlir] Added strides check to rank reducing subview verification
Oct 8 2020, 1:40 AM
limo1996 closed D88879: [mlir] Added strides check to rank reducing subview verification.
Oct 8 2020, 1:39 AM · Restricted Project
limo1996 updated the diff for D88879: [mlir] Added strides check to rank reducing subview verification.

OK->success, error messages changed a bit

Oct 8 2020, 12:39 AM · Restricted Project

Oct 7 2020

limo1996 updated the diff for D88879: [mlir] Added strides check to rank reducing subview verification.

Comments of nicolas addressed

Oct 7 2020, 8:46 AM · Restricted Project

Oct 6 2020

limo1996 requested review of D88883: [mlir] Rank reducing subview conversion to LLVM.
Oct 6 2020, 2:57 AM · Restricted Project
limo1996 requested review of D88879: [mlir] Added strides check to rank reducing subview verification.
Oct 6 2020, 2:15 AM · Restricted Project

Sep 30 2020

limo1996 committed rG0b17d4754a94: [mlir][Linalg] Tile sizes for Conv ops vectorization added as pass arguments (authored by limo1996).
[mlir][Linalg] Tile sizes for Conv ops vectorization added as pass arguments
Sep 30 2020, 4:32 AM
limo1996 closed D88533: [mlir][Linalg] Tile sizes for Conv ops vectorization added as pass arguments.
Sep 30 2020, 4:32 AM · Restricted Project
limo1996 committed rG14088a6f5d1a: [mlir] Added support for rank reducing subviews (authored by limo1996).
[mlir] Added support for rank reducing subviews
Sep 30 2020, 4:16 AM
limo1996 closed D88534: [mlir] Added support for rank reducing subviews.
Sep 30 2020, 4:16 AM · Restricted Project
limo1996 added a comment to D88533: [mlir][Linalg] Tile sizes for Conv ops vectorization added as pass arguments.

In general, I wouldn't couple vectorization flags to tiling flags (well, maybe have tiling as a precondition) because we may want to tile several times. But this is already an improvement over the current state.

Sep 30 2020, 12:49 AM · Restricted Project
limo1996 requested review of D88534: [mlir] Added support for rank reducing subviews.
Sep 30 2020, 12:43 AM · Restricted Project
limo1996 requested review of D88533: [mlir][Linalg] Tile sizes for Conv ops vectorization added as pass arguments.
Sep 30 2020, 12:15 AM · Restricted Project

Sep 23 2020

limo1996 committed rG5711eaf608ad: [mlir] Added support for f64 memref printing in runner utils (authored by limo1996).
[mlir] Added support for f64 memref printing in runner utils
Sep 23 2020, 5:40 AM
limo1996 closed D88143: [mlir] Added support for f64 memref printing in runner utils.
Sep 23 2020, 5:39 AM · Restricted Project
limo1996 requested review of D88143: [mlir] Added support for f64 memref printing in runner utils.
Sep 23 2020, 4:53 AM · Restricted Project

Sep 17 2020

limo1996 committed rG347d59b16c71: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass (authored by limo1996).
[mlir][Linalg] Convolution tiling added to ConvOp vectorization pass
Sep 17 2020, 2:40 AM
limo1996 closed D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 17 2020, 2:40 AM · Restricted Project
limo1996 updated the diff for D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.

rebased

Sep 17 2020, 2:26 AM · Restricted Project
limo1996 added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 17 2020, 1:50 AM · Restricted Project

Sep 15 2020

limo1996 updated the diff for D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.

NoTile -> noTile, TileSize -> tileSize

Sep 15 2020, 9:06 AM · Restricted Project
limo1996 added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 15 2020, 7:52 AM · Restricted Project
limo1996 updated the diff for D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.

Refactored "Magic numbers" away by introducing NoTile and TileSize constants in ConvOpVectorization
rewrite pattern.

Sep 15 2020, 7:50 AM · Restricted Project
limo1996 added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 15 2020, 7:23 AM · Restricted Project
limo1996 added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 15 2020, 6:45 AM · Restricted Project
limo1996 updated the diff for D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.

Comments of Alex addressed

Sep 15 2020, 6:45 AM · Restricted Project
limo1996 committed rGc20852300a35: [mlir][integration_test] Linalg Conv folder renamed to CPU (authored by limo1996).
[mlir][integration_test] Linalg Conv folder renamed to CPU
Sep 15 2020, 3:29 AM
limo1996 closed D87678: [mlir][integration_test] Linalg Conv folder renamed to CPU.
Sep 15 2020, 3:28 AM · Restricted Project
limo1996 added a comment to D87277: [mlir][Linalg] Integration tests for convolutions added..

@aartbik changed in this revision: https://reviews.llvm.org/D87678

Sep 15 2020, 3:09 AM · Restricted Project
limo1996 requested review of D87678: [mlir][integration_test] Linalg Conv folder renamed to CPU.
Sep 15 2020, 3:08 AM · Restricted Project
limo1996 requested review of D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Sep 15 2020, 2:23 AM · Restricted Project

Sep 10 2020

limo1996 added inline comments to D86619: [mlir] Conv ops vectorization pass.
Sep 10 2020, 12:08 AM · Restricted Project
limo1996 committed rGfea175b59fbd: [mlir][Linalg] Small refactoring of ConvOpVectorization (authored by limo1996).
[mlir][Linalg] Small refactoring of ConvOpVectorization
Sep 10 2020, 12:06 AM
limo1996 closed D87354: [mlir][Linalg] Small refactoring of ConvOpVectorization.
Sep 10 2020, 12:06 AM · Restricted Project
limo1996 updated the diff for D87354: [mlir][Linalg] Small refactoring of ConvOpVectorization.

synced

Sep 10 2020, 12:04 AM · Restricted Project

Sep 9 2020

limo1996 committed rG53ffeea6d59a: [mlir][Linalg] Reduction dimensions specified in TC definition of ConvOps. (authored by limo1996).
[mlir][Linalg] Reduction dimensions specified in TC definition of ConvOps.
Sep 9 2020, 8:18 AM
limo1996 closed D87288: [mlir][Linalg] Reduction dimensions specified in TC definition of ConvOps..
Sep 9 2020, 8:17 AM · Restricted Project
limo1996 committed rGedf244217a48: [mlir][Linalg] Integration tests for convolutions added. (authored by limo1996).
[mlir][Linalg] Integration tests for convolutions added.
Sep 9 2020, 4:38 AM
limo1996 closed D87277: [mlir][Linalg] Integration tests for convolutions added..
Sep 9 2020, 4:38 AM · Restricted Project
limo1996 requested review of D87354: [mlir][Linalg] Small refactoring of ConvOpVectorization.
Sep 9 2020, 2:05 AM · Restricted Project

Sep 8 2020

limo1996 requested review of D87288: [mlir][Linalg] Reduction dimensions specified in TC definition of ConvOps..
Sep 8 2020, 8:05 AM · Restricted Project
limo1996 requested review of D87277: [mlir][Linalg] Integration tests for convolutions added..
Sep 8 2020, 4:27 AM · Restricted Project
limo1996 added inline comments to D86619: [mlir] Conv ops vectorization pass.
Sep 8 2020, 3:00 AM · Restricted Project
limo1996 committed rG83d82d1fb1cf: [mlir] Fix of broken build on windows caused by using uint (authored by limo1996).
[mlir] Fix of broken build on windows caused by using uint
Sep 8 2020, 2:44 AM
limo1996 committed rG67b37f571cc2: [mlir] Conv ops vectorization pass (authored by limo1996).
[mlir] Conv ops vectorization pass
Sep 8 2020, 1:48 AM
limo1996 closed D86619: [mlir] Conv ops vectorization pass.
Sep 8 2020, 1:48 AM · Restricted Project
limo1996 retitled D86619: [mlir] Conv ops vectorization pass from [mlir] Linalg to Vector pass added. to [mlir] Conv ops vectorization pass.
Sep 8 2020, 1:39 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

integration tests split into different commit

Sep 8 2020, 1:32 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

Moved conversion to core (kept only pass).
Removed getZero helper function.
Simplified code with vector and std intrinsics op creation.

Sep 8 2020, 1:19 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

All comments except for the migration to Linalg/Vectorization.cpp resolved.

Sep 8 2020, 12:21 AM · Restricted Project

Sep 7 2020

limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

Moved pass to test/lib.
Replaced start and end offset with Mask.
Introduced preconditions for input and kernel sizes.
Reflected changes in tests.

Sep 7 2020, 7:25 AM · Restricted Project

Sep 2 2020

limo1996 committed rG8d35080ebbea: [mlir][Linalg] Wrong tile size for convolutions fixed (authored by limo1996).
[mlir][Linalg] Wrong tile size for convolutions fixed
Sep 2 2020, 11:02 PM
limo1996 closed D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.
Sep 2 2020, 11:02 PM · Restricted Project
limo1996 updated the diff for D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.

Comments of nicolas resolved

Sep 2 2020, 7:03 AM · Restricted Project
limo1996 committed rGf5ed22f09dd9: [mlir][VectorToSCF] 128 byte alignment of alloc ops (authored by limo1996).
[mlir][VectorToSCF] 128 byte alignment of alloc ops
Sep 2 2020, 5:38 AM
limo1996 closed D86454: [mlir][VectorToSCF] 128 byte alignment of alloc ops.
Sep 2 2020, 5:38 AM · Restricted Project
limo1996 retitled D86638: [mlir][Linalg] Wrong tile size for convolutions fixed from [mlir][WIP] Tiling for convolutions to [mlir][Linalg] Wrong tile size for convolutions fixed.
Sep 2 2020, 5:21 AM · Restricted Project
limo1996 updated the summary of D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.
Sep 2 2020, 5:21 AM · Restricted Project
limo1996 updated the diff for D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.

Implementation changed as discussed here:
https://llvm.discourse.group/t/wrong-tile-size-for-convolution-ops/1699

Sep 2 2020, 5:18 AM · Restricted Project

Sep 1 2020

limo1996 added a comment to D86619: [mlir] Conv ops vectorization pass.

I haven't sync with him regarding implementation details but I think he has an overview of what my goal is and how do I want to achieve it as he is my co-host.

Sep 1 2020, 12:52 AM · Restricted Project

Aug 31 2020

limo1996 added a comment to D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.

Could we start a discourse post on this. Its more easy to document issues and discuss solutions there rather than on the patch.

Also, I am curious what other bugs you found in the convolution operation. Please add those to the discourse post if possible.

Aug 31 2020, 9:08 AM · Restricted Project
limo1996 closed D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

Landed as 8dace28f92056a04e02d913684d3f448ee1f295a

Aug 31 2020, 7:53 AM · Restricted Project

Aug 30 2020

limo1996 added a comment to D86619: [mlir] Conv ops vectorization pass.

@rriddle I think I've resolved all of your comments.. Do you have some more? Thanks.

Aug 30 2020, 1:11 PM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

Conversion tests added

Aug 30 2020, 1:07 PM · Restricted Project

Aug 27 2020

limo1996 added a comment to D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.

@limo1996 This is really nice find! I have been struggling with figuring out why convolutions are giving me errors in some cases, and I suspected something like, but wasnt able to nail this down.

There might be a better fix though. I'll take a look at this as well. For now I am going to just "Request changes" but I dont really have any changes to request. Just a placeholder for me to take a look again.

Aug 27 2020, 3:15 AM · Restricted Project

Aug 26 2020

limo1996 requested review of D86638: [mlir][Linalg] Wrong tile size for convolutions fixed.
Aug 26 2020, 9:35 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

fixed add_subdirectory

Aug 26 2020, 9:29 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

added missing add_subdirectory in CMakeLists

Aug 26 2020, 9:25 AM · Restricted Project
limo1996 added inline comments to D86619: [mlir] Conv ops vectorization pass.
Aug 26 2020, 8:38 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

more comments of rriddle addressed

Aug 26 2020, 8:38 AM · Restricted Project
limo1996 added inline comments to D86619: [mlir] Conv ops vectorization pass.
Aug 26 2020, 8:26 AM · Restricted Project
limo1996 updated the diff for D86619: [mlir] Conv ops vectorization pass.

comments of rriddle addressed

Aug 26 2020, 8:05 AM · Restricted Project
limo1996 added inline comments to D86619: [mlir] Conv ops vectorization pass.
Aug 26 2020, 8:05 AM · Restricted Project
limo1996 requested review of D86619: [mlir] Conv ops vectorization pass.
Aug 26 2020, 6:31 AM · Restricted Project

Aug 25 2020

limo1996 updated the diff for D86454: [mlir][VectorToSCF] 128 byte alignment of alloc ops.

Aart's comments addressed

Aug 25 2020, 8:38 AM · Restricted Project

Aug 24 2020

limo1996 requested review of D86454: [mlir][VectorToSCF] 128 byte alignment of alloc ops.
Aug 24 2020, 6:08 AM · Restricted Project

Aug 19 2020

limo1996 committed rGaeb338cc3e5a: [mlir][VectorToSCF] Fix of broken build - missing link to MLIRLinalgUtils (authored by limo1996).
[mlir][VectorToSCF] Fix of broken build - missing link to MLIRLinalgUtils
Aug 19 2020, 10:29 AM
limo1996 committed rG8dace28f9205: [mlir][VectorToSCF] Bug in TransferRead lowering fixed (authored by limo1996).
[mlir][VectorToSCF] Bug in TransferRead lowering fixed
Aug 19 2020, 8:35 AM
limo1996 updated the diff for D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

CHECK-NEXT -> CHECK

Aug 19 2020, 8:14 AM · Restricted Project
limo1996 added a comment to D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

I was under the impression that you were implementing the more general case but indeed not.
Then please just make sure the writes behave properly too, thanks!

Resigning as a reviewer to unblock as I am OOO until early Sept.

Aug 19 2020, 6:29 AM · Restricted Project
limo1996 updated the diff for D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

added test for transfer_write

Aug 19 2020, 6:27 AM · Restricted Project
limo1996 added a comment to D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

There are a few different places where patterns apply where we make the test that the permutation map is identity and that the rest is not yet supported.
Please update such places too and add tests to extend support more generally.

Thanks for extending this functionality!

Aug 19 2020, 4:01 AM · Restricted Project
limo1996 added a comment to D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

Can we have a test for this?

Aug 19 2020, 3:48 AM · Restricted Project
limo1996 updated the diff for D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

added test

Aug 19 2020, 3:47 AM · Restricted Project
limo1996 updated the diff for D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.

update

Aug 19 2020, 12:29 AM · Restricted Project
limo1996 requested review of D86197: [mlir][VectorToSCF] Bug in TransferRead lowering fixed.
Aug 19 2020, 12:06 AM · Restricted Project

Aug 18 2020

limo1996 committed rGa4b8c2de1d39: [mlir] VectorToSCF bug in setAllocAtFunctionEntry fixed. (authored by limo1996).
[mlir] VectorToSCF bug in setAllocAtFunctionEntry fixed.
Aug 18 2020, 12:13 AM
limo1996 closed D86086: [mlir] VectorToSCF bug in setAllocAtFunctionEntry fixed..
Aug 18 2020, 12:13 AM · Restricted Project

Aug 17 2020

limo1996 requested review of D86086: [mlir] VectorToSCF bug in setAllocAtFunctionEntry fixed..
Aug 17 2020, 9:10 AM · Restricted Project

Aug 12 2020

limo1996 committed rG9dd7ed24bf77: [mlir] Added support for Index type inside getZeroAttr function (authored by limo1996).
[mlir] Added support for Index type inside getZeroAttr function
Aug 12 2020, 9:22 AM
limo1996 closed D85833: [mlir] Added support for Index type inside getZeroAttr function.
Aug 12 2020, 9:22 AM · Restricted Project
limo1996 requested review of D85833: [mlir] Added support for Index type inside getZeroAttr function.
Aug 12 2020, 6:09 AM · Restricted Project

Aug 4 2020

limo1996 committed rG689096965d9a: [mlir][Linalg] Conv ops lowering to std calls added. (authored by limo1996).
[mlir][Linalg] Conv ops lowering to std calls added.
Aug 4 2020, 12:15 AM
limo1996 closed D84840: [mlir][Linalg] Conv ops lowering to std calls added..
Aug 4 2020, 12:15 AM · Restricted Project
limo1996 updated the diff for D84840: [mlir][Linalg] Conv ops lowering to std calls added..

rebased

Aug 4 2020, 12:13 AM · Restricted Project