Page MenuHomePhabricator
Differential D99154

[mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible
ClosedPublic
Actions

Authored by vinograd47 on Tue, Mar 23, 1:47 AM.

Details

Reviewers
ftynse
rriddle
mehdi_amini
aartbik
nicolasvasilache
Commits
rG18a2f479bf47: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible
Summary

Use new MemRefType::getMemorySpace method with generic Attribute
in cases, where there is no specific logic around the memory space.

Diff Detail

Event Timeline

vinograd47 created this revision.Tue, Mar 23, 1:47 AM
Herald added a reviewer: aartbik. · View Herald TranscriptTue, Mar 23, 1:47 AM
Herald added subscribers: dcaballe, cota, teijeong and 14 others. · View Herald Transcript
vinograd47 requested review of this revision.Tue, Mar 23, 1:47 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptTue, Mar 23, 1:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B95191: Diff 332561.Tue, Mar 23, 2:30 AM
mehdi_amini added a comment.Tue, Mar 23, 10:25 AM

Thanks for the cleanup!

rriddle accepted this revision.Tue, Mar 23, 5:05 PM
This revision is now accepted and ready to land.Tue, Mar 23, 5:05 PM
rriddle added a comment.Tue, Mar 23, 5:05 PM

Nice!

Closed by commit rG18a2f479bf47: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible (authored by vinograd47). · Explain WhyWed, Mar 24, 3:24 AM
This revision was automatically updated to reflect the committed changes.
vinograd47 added a commit: rG18a2f479bf47: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible.

Revision Contents
Changeset List

PathSize
mlir/
lib/
Conversion/
VectorToSCF/
8 lines
Dialect/
MemRef/
IR/
20 lines
Vector/
6 lines

Diff 332922

View Options

mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp

Loading...
View Options

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp

Loading...
View Options

mlir/lib/Dialect/Vector/VectorOps.cpp

Loading...