Page MenuHomePhabricator

[zorg] [PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite instead of LNT
ClosedPublic

Authored by Conanap on Mon, Mar 22, 11:15 AM.

Details

Summary

We would like to update the PowerPC RHEL buildbot (clang-ppc64le-rhel) to use cmake instead of LNT, so that we can streamline our process whenever we update CMakeList.txt

Diff Detail

Event Timeline

Conanap created this revision.Mon, Mar 22, 11:15 AM
Conanap requested review of this revision.Mon, Mar 22, 11:15 AM
This revision is now accepted and ready to land.Wed, Mar 24, 1:45 PM
jsji added inline comments.Thu, Mar 25, 2:47 PM
zorg/buildbot/builders/ClangBuilder.py
489

Typo? '%(builddir)s/test/test-suite or /test/sandbox/test-suite?

566

Are you sure we have all these logfiles in cmake step?

Conanap added inline comments.Tue, Mar 30, 10:51 AM
zorg/buildbot/builders/ClangBuilder.py
489

you are correct, thanks for catching this. I'll change the comment on commit.

566

this is a very good question that I'm not too sure about. I thought they would be generated on the fly; would you happen to have any idea @gkistanova ? @saghir @stefanp

Conanap updated this revision to Diff 335811.Wed, Apr 7, 8:03 AM

removed incorrect brackets

Conanap updated this revision to Diff 335812.Wed, Apr 7, 8:04 AM

Incorrectly updated this patch

Conanap updated this revision to Diff 335868.Wed, Apr 7, 10:48 AM

Removed logging as files are not available, updated comment and fix function call

This revision was landed with ongoing or failed builds.Thu, Apr 8, 7:15 AM
This revision was automatically updated to reflect the committed changes.
Conanap reopened this revision.Thu, Apr 8, 7:17 AM
This revision is now accepted and ready to land.Thu, Apr 8, 7:17 AM
jsji added inline comments.Thu, Apr 8, 7:39 AM
zorg/buildbot/builders/ClangBuilder.py
566

I think there should be some cmake log? Or else if the cmake failed, we won't be able to see what is wrong in cmake steps.?

Conanap added inline comments.Thu, Apr 8, 1:17 PM
zorg/buildbot/builders/ClangBuilder.py
566

I thought it might be enough to see it on stdout / err on the buildbot page but you make a fair point. Would adding a step just before to touch some log files sound like a good solution?

jsji accepted this revision.Thu, Apr 8, 1:25 PM
jsji added inline comments.
zorg/buildbot/builders/ClangBuilder.py
566

If the log are all in stdout/err then it is fine, no need to touch additional log.

Conanap updated this revision to Diff 336825.Mon, Apr 12, 7:17 AM

Not sure what happened with phabricator, but there's been no change since last diff and this is just for record sake.

This revision was landed with ongoing or failed builds.Mon, Apr 12, 1:35 PM
This revision was automatically updated to reflect the committed changes.