Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (224 w, 2 d)

Recent Activity

Tue, Dec 1

mgorny committed rGe1f613ce3c61: [lldb] [test] Reenable two passing tests on FreeBSD (authored by mgorny).
[lldb] [test] Reenable two passing tests on FreeBSD
Tue, Dec 1, 2:26 PM
mgorny added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

I've added some more debug as requested, and it confirmed that Linux and FreeBSD dyld are behaving differently here.

Linux triggers the breakpoint twice: first time in add state, including only /lib64/ld-linux-x86-64.so.2 and linux-vdso.so.1 in module list, and the second time in consistent state, adding soentries for all shared libraries.

FreeBSD triggers it only once, in consistent state and the remote list includes all libraries immediately

Thanks for investigating this. And I'm sorry for being so picky -- this is all very messy, and I am trying to understand things to avoid making an even bigger mess.

When you say "FreeBSD triggers it only once", which breakpoint are you referring to? The "rendezvous" breakpoint? Judging by the log's, I would say yes.

Tue, Dec 1, 8:07 AM
mgorny added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

Full logs below.

Tue, Dec 1, 4:06 AM
mgorny added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

I've added some more debug as requested, and it confirmed that Linux and FreeBSD dyld are behaving differently here.

Tue, Dec 1, 4:05 AM

Mon, Nov 30

mgorny requested review of D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress().
Mon, Nov 30, 5:47 AM
mgorny added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

GDB indeed handles it somehow. I'm going to investigate.

Mon, Nov 30, 2:58 AM
mgorny added a comment to D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach.

Seems reasonable(ish), but needs a test case. Do you need to launch a separate server instance, or would just a plain attach work?

Mon, Nov 30, 2:05 AM
mgorny added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

What's the state of TestBreakpointInGlobalConstructor.py after this change? Does it continue to fail?

Mon, Nov 30, 12:24 AM

Sun, Nov 29

mgorny added reviewers for D85278: [lld] Support building shared libLLD.so: espindola, grimar, atanasyan, MaskRay.
Sun, Nov 29, 9:09 AM · lld

Sat, Nov 28

mgorny requested review of D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach.
Sat, Nov 28, 4:12 AM

Thu, Nov 26

mgorny requested review of D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.
Thu, Nov 26, 8:56 AM
mgorny added a comment to D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet.

I was referring to:

Thu, Nov 26, 1:56 AM · Restricted Project
mgorny added a comment to D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet.

I disagree. Since we're repeating gdb protocol, it would be nice to use offsets consistent with the gdb protocol, even if it means some extra padding. I do realize that this is broken right now and not trivially fixable but I don't think we should make things worse.

Thu, Nov 26, 1:35 AM · Restricted Project
mgorny added a comment to D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet.

+@mgorny, as he's been navigating these waters lately...

So... I presume we can't just slap __attribute__((packed)) on the structure, because the kernel actually expects that the data structure will have the extra space for the padding. Is that so?

Even if we can't, I'm wondering if it wouldn't be cleaner to use two structures for this. Something like:

LLVM_PACKED_START
struct GPR {
  // as before...
};
/// Big comment explaining the purpose of padding
struct GPRBuffer: GPR {
  uint32_t pad;
};
LLVM_PACKED_END

and then using GPR or GPRBuffer accordingly. What do you think?

Thu, Nov 26, 12:24 AM · Restricted Project

Mon, Nov 23

mgorny requested review of D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP].
Mon, Nov 23, 6:55 AM
mgorny committed rGa8f6f4e8733c: [lldb] [test] Restore Windows-skip on 'process connect' tests (authored by mgorny).
[lldb] [test] Restore Windows-skip on 'process connect' tests
Mon, Nov 23, 5:28 AM
mgorny updated the diff for D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

Added system-debugserver feature to skip tests.

Mon, Nov 23, 3:16 AM
mgorny added a comment to D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

Still looks good to me. :) Jason, do you have any concerns?

Unfortunately, we still need a @skipIfOutOfTreeDebugserver equivalent....

Mon, Nov 23, 1:38 AM
mgorny updated the diff for D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

Rebase and fix TestRegisters.

Mon, Nov 23, 1:37 AM
mgorny committed rG18e4272a4fe4: [lldb] Prevent 'process connect' from using local-only plugins (authored by mgorny).
[lldb] Prevent 'process connect' from using local-only plugins
Mon, Nov 23, 12:49 AM
mgorny closed D91810: [lldb] Prevent 'process connect' from using local-only plugins.
Mon, Nov 23, 12:49 AM · Restricted Project
mgorny added inline comments to D91810: [lldb] Prevent 'process connect' from using local-only plugins.
Mon, Nov 23, 12:47 AM · Restricted Project
mgorny committed rG8018e7b447da: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Fix regset names and related tests
Mon, Nov 23, 12:29 AM
mgorny committed rG9367b57dadb7: [lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers (authored by mgorny).
[lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers
Mon, Nov 23, 12:29 AM
mgorny closed D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests.
Mon, Nov 23, 12:28 AM · Restricted Project
mgorny closed D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.
Mon, Nov 23, 12:28 AM · Restricted Project
mgorny added a comment to D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests.

I'll also add a TODO here wrt unsupported registers.

Mon, Nov 23, 12:27 AM · Restricted Project
mgorny added a comment to D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.

Ok, will add the comment and push.

Mon, Nov 23, 12:26 AM · Restricted Project
mgorny committed rG8f2f9a82e2cc: [lldb] [Process/Utility] Declare register overlaps between ST and MM (authored by mgorny).
[lldb] [Process/Utility] Declare register overlaps between ST and MM
Mon, Nov 23, 12:25 AM
mgorny committed rG7b7c372e3fca: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo (authored by mgorny).
[lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo
Mon, Nov 23, 12:25 AM
mgorny closed D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM.
Mon, Nov 23, 12:24 AM · Restricted Project
mgorny closed D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo.
Mon, Nov 23, 12:24 AM · Restricted Project
mgorny retitled D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers from [lldb] Fix qRegisterInfo to handle missing registers to [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.
Mon, Nov 23, 12:22 AM · Restricted Project

Sun, Nov 22

mgorny requested review of D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo.
Sun, Nov 22, 8:43 AM · Restricted Project

Sat, Nov 21

mgorny requested review of D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests.
Sat, Nov 21, 1:20 PM · Restricted Project
mgorny requested review of D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.
Sat, Nov 21, 1:19 PM · Restricted Project
mgorny committed rG8aea95f3cb4e: [lldb] Reland "Use translated full ftag values" (authored by mgorny).
[lldb] Reland "Use translated full ftag values"
Sat, Nov 21, 8:35 AM
mgorny closed D91504: [lldb] Use translated full ftag values.
Sat, Nov 21, 8:35 AM · Restricted Project
mgorny retitled D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM from [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP] to [lldb] [Process/Utility] Declare register overlaps between ST and MM.
Sat, Nov 21, 8:10 AM · Restricted Project

Fri, Nov 20

mgorny added a comment to D91907: Add missing dependencies, which caused link failure when building with -DBUILD_SHARED_LIBS:BOOL=ON.

Curious enough, I can't reproduce this failure.

Fri, Nov 20, 11:55 PM · Restricted Project
mgorny updated the diff for D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

Added aliases to all regsets, not just the first ones. Updated test status.

Fri, Nov 20, 11:36 AM
mgorny updated the diff for D91810: [lldb] Prevent 'process connect' from using local-only plugins.

Updated to pass can_debug parameter, as suggested by @labath.

Fri, Nov 20, 8:15 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Skipped python test on non-Darwin, xfailed shell test on Darwin, added respective comments.

Fri, Nov 20, 3:40 AM · Restricted Project
mgorny added a comment to D91504: [lldb] Use translated full ftag values.

Well... I think that will make the test fail on mac, as debugserver hasn't been updated.

This test comes from D12592, and is actually serves a very similar purpose to the test you just wrote. Normally, I would say we don't need both of them, but since we still have debugserver with the old behavior, and your new test is consistent with how we've (you've) been writing other register tests, maybe we could just slap @skipUnlessDarwin on TestRegisters.py, and put some comments (on both tests) that explain the situation and cross-reference each other (?)

Fri, Nov 20, 12:57 AM · Restricted Project
mgorny added a comment to D91810: [lldb] Prevent 'process connect' from using local-only plugins.

I think that the real fix here would be to change the plugin selection logic (Target::CreateProcess) to convey the fact that we're looking for a connectable plugin. The method already contains a FileSpec *core_file argument, which I guess is needed to select the proper core file subclass, so adding a can_connect argument would not be unreasonable (though not exactly pretty either).

Fri, Nov 20, 12:54 AM · Restricted Project
mgorny requested review of D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.
Fri, Nov 20, 12:47 AM
mgorny committed rGf0e2c5131eda: [lldb] [test/Register] XFAIL x86-fp-write on Darwin (authored by mgorny).
[lldb] [test/Register] XFAIL x86-fp-write on Darwin
Fri, Nov 20, 12:44 AM
mgorny committed rG3a230101fee6: Revert "[LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test" (authored by mgorny).
Revert "[LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test"
Fri, Nov 20, 12:44 AM
mgorny added inline comments to D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.
Fri, Nov 20, 12:40 AM · Restricted Project

Thu, Nov 19

mgorny requested review of D91810: [lldb] Prevent 'process connect' from using local-only plugins.
Thu, Nov 19, 11:11 AM · Restricted Project
mgorny reopened D91504: [lldb] Use translated full ftag values.

Does this change to TestRegister.py look good? It makes the test pass for me (and seems logically correct).

Thu, Nov 19, 6:51 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Update TestRegisters.py.

Thu, Nov 19, 6:50 AM · Restricted Project
mgorny added a comment to D91504: [lldb] Use translated full ftag values.

Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. Could you please fix the test?

Thu, Nov 19, 6:29 AM · Restricted Project
mgorny committed rGd8ff269f6776: [lldb] Add explicit 64-bit fip/fdp registers on x86_64 (authored by mgorny).
[lldb] Add explicit 64-bit fip/fdp registers on x86_64
Thu, Nov 19, 4:23 AM
mgorny committed rGc43abf043692: [lldb] Use translated full ftag values (authored by mgorny).
[lldb] Use translated full ftag values
Thu, Nov 19, 4:23 AM
mgorny closed D91504: [lldb] Use translated full ftag values.
Thu, Nov 19, 4:23 AM · Restricted Project
mgorny closed D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.
Thu, Nov 19, 4:23 AM · Restricted Project
mgorny updated the diff for D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM.

Updated to cover i386, reformatted the macro.

Thu, Nov 19, 4:04 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Declare MMSRegComp type explicitly to avoid warnings:

Thu, Nov 19, 3:22 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Simplified FreeBSD & Linux code as @labath suggested. Also added the scope thingy to tests.

Thu, Nov 19, 3:17 AM · Restricted Project
mgorny added inline comments to D91504: [lldb] Use translated full ftag values.
Thu, Nov 19, 1:47 AM · Restricted Project
mgorny added inline comments to D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM.
Thu, Nov 19, 1:06 AM · Restricted Project

Wed, Nov 18

mgorny added a comment to D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM.

@labath, what do you think about this approach? What really sucks is that we have to repeat the whole voodoo for i386 and amd64 separately.

Wed, Nov 18, 11:18 AM · Restricted Project
mgorny retitled D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM from [lldb] [Process/Utility] Declare register overlaps between ST and MM to [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP].
Wed, Nov 18, 11:17 AM · Restricted Project
mgorny requested review of D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM.
Wed, Nov 18, 11:17 AM · Restricted Project
mgorny updated the diff for D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.

Added contained/invalidate entries for FIP/FDP.

Wed, Nov 18, 11:08 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Updated Linux to use pointer comparison and FreeBSD. It's ready for review now, though I'd use a better suggestion for FreeBSD.

Wed, Nov 18, 10:40 AM · Restricted Project
mgorny added a comment to D91461: [build] normalize components dependencies.

Or to put it the other way, LINK_COMPONENTS is not equivalent to target_link_libraries with the PUBLIC keyword.

Do you think we should revert the whole patch, or only a subpart of it?

Wed, Nov 18, 8:28 AM · Restricted Project
mgorny added a comment to D91461: [build] normalize components dependencies.

Or to put it the other way, LINK_COMPONENTS is not equivalent to target_link_libraries with the PUBLIC keyword.

Wed, Nov 18, 6:52 AM · Restricted Project
mgorny added a comment to D91461: [build] normalize components dependencies.

This broke building LLDB with BUILD_SHARED_LIBS=ON:

Wed, Nov 18, 6:51 AM · Restricted Project
mgorny updated the diff for D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.

Updated the test comment.

Wed, Nov 18, 3:11 AM · Restricted Project
mgorny committed rG97a2eac3a924: [lldb] [test] Un-XFAIL tests on freebsd/i386 (authored by mgorny).
[lldb] [test] Un-XFAIL tests on freebsd/i386
Wed, Nov 18, 3:10 AM
mgorny committed rGb48ace051c4b: [lldb] [test] Un-XFAIL TestMultipleDebuggers.py (authored by mgorny).
[lldb] [test] Un-XFAIL TestMultipleDebuggers.py
Wed, Nov 18, 3:10 AM
mgorny committed rG5a75512eba7e: [lldb] [test] Mark command-process-connect.test XFAIL (authored by mgorny).
[lldb] [test] Mark command-process-connect.test XFAIL
Wed, Nov 18, 3:10 AM
mgorny committed rG3e1f1b406e92: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly (authored by mgorny).
[lldb] [test] Pass -mmmx to x86-gp-write test explicitly
Wed, Nov 18, 3:10 AM
mgorny closed D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Wed, Nov 18, 3:10 AM · Restricted Project
mgorny closed D91578: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly.
Wed, Nov 18, 3:10 AM · Restricted Project
mgorny added inline comments to D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.
Wed, Nov 18, 3:05 AM · Restricted Project
mgorny added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Wed, Nov 18, 2:37 AM · Restricted Project

Tue, Nov 17

mgorny requested review of D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Tue, Nov 17, 10:08 AM · Restricted Project

Mon, Nov 16

mgorny requested review of D91578: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly.
Mon, Nov 16, 4:06 PM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Port NetBSD plugin.

Mon, Nov 16, 10:07 AM · Restricted Project
mgorny updated the diff for D91504: [lldb] Use translated full ftag values.

Move the functions into a new file, add comment, use llvm::ArrayRef.

Mon, Nov 16, 8:59 AM · Restricted Project
mgorny added inline comments to D91504: [lldb] Use translated full ftag values.
Mon, Nov 16, 8:42 AM · Restricted Project
mgorny updated the diff for D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.

Fix wrong output num ($2 instead of $1) in x86-fp-read.test.

Mon, Nov 16, 6:53 AM · Restricted Project
mgorny updated the diff for D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.

Implemented requested changes. Clang-formatted. Extended fp-write tests to cover both writing fioff/fooff and fip/fdp.

Mon, Nov 16, 4:48 AM · Restricted Project
mgorny added inline comments to D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.
Mon, Nov 16, 4:11 AM · Restricted Project
mgorny committed rGb9734c6b44e5: [lldb] [Process/FreeBSDRemote] Optimize regset pointer logic (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Optimize regset pointer logic
Mon, Nov 16, 4:03 AM
mgorny committed rG68ca01eb50af: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic
Mon, Nov 16, 4:03 AM
mgorny committed rGe520487bf4bf: [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets
Mon, Nov 16, 4:03 AM
mgorny committed rG6adb55877c4b: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Access debug registers via offsets
Mon, Nov 16, 4:03 AM
mgorny closed D91411: [lldb] [Process/FreeBSDRemote] Optimize regset pointer logic.
Mon, Nov 16, 4:03 AM · Restricted Project
mgorny closed D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic.
Mon, Nov 16, 4:03 AM · Restricted Project
mgorny closed D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets.
Mon, Nov 16, 4:03 AM · Restricted Project
mgorny closed D91248: [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets.
Mon, Nov 16, 4:03 AM · Restricted Project
mgorny committed rG58abbf821ce8: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets (authored by mgorny).
[lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets
Mon, Nov 16, 3:21 AM
mgorny closed D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets.
Mon, Nov 16, 3:20 AM · Restricted Project
mgorny added inline comments to D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets.
Mon, Nov 16, 1:18 AM · Restricted Project

Sun, Nov 15

mgorny added a comment to D91504: [lldb] Use translated full ftag values.

I'll port to other platforms once we agree on the approach.

Sun, Nov 15, 10:28 AM · Restricted Project
mgorny requested review of D91504: [lldb] Use translated full ftag values.
Sun, Nov 15, 10:26 AM · Restricted Project