Page MenuHomePhabricator

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (211 w, 6 d)

Recent Activity

Wed, Jan 5

jsji added a reviewer for D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections : Restricted Project.
Wed, Jan 5, 8:52 AM · Restricted Project

Mon, Dec 20

jsji committed rG557a17eec06a: [docs]LLVM Tutorial: fix the typo in Cpu0 URL (authored by jsji).
[docs]LLVM Tutorial: fix the typo in Cpu0 URL
Mon, Dec 20, 1:47 PM

Dec 17 2021

jsji added inline comments to D114419: [XCOFF] change default program code csect alignment to 32.
Dec 17 2021, 7:43 AM · Restricted Project

Dec 16 2021

jsji added a comment to D114419: [XCOFF] change default program code csect alignment to 32.

Can you try adding a testcase for Os or Oz to see what happens? I suspect that this change might override the pref alignment settings in Lowering.

Dec 16 2021, 8:25 AM · Restricted Project

Dec 13 2021

jsji added a comment to D114419: [XCOFF] change default program code csect alignment to 32.

Do we have any data about the *size* change due to alignment change? especially for code with lots of small functions, like perlbench?

Dec 13 2021, 11:05 AM · Restricted Project

Dec 9 2021

jsji accepted D114569: [PowerPC] Require htm feature for HTM builtins.

LGTM. Thanks for fixing.

Dec 9 2021, 6:43 PM · Restricted Project

Dec 6 2021

jsji accepted D111485: [Powerpc] store byval parameter to parameter save area when needed.

LGTM since you have already double checked the compatiblity.

Dec 6 2021, 6:27 PM · Restricted Project

Nov 23 2021

jsji added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Thanks, looks much better now.

Nov 23 2021, 7:33 AM · Restricted Project, Restricted Project
jsji added a comment to D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD.

Test case clang/test/CodeGen/ppc-mm-malloc.c fails on powerpc BE buildbots with this changeset
https://lab.llvm.org/buildbot/#/builders/93/builds/6031
https://lab.llvm.org/buildbot/#/builders/100/builds/10836
https://lab.llvm.org/buildbot/#/builders/52/builds/12719

******************* TEST 'Clang :: CodeGen/ppc-mm-malloc.c' FAILED ********************
Script:
--
: 'RUN: at line 9';   /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/clang -target powerpc64-unknown-linux-gnu -S -emit-llvm /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/FileCheck /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c
: 'RUN: at line 10';   /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/clang -target powerpc64-unknown-freebsd13.0 -S -emit-llvm /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/FileCheck /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c
--
Exit Code: 2
Command Output (stderr):
--
In file included from /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c:12:
In file included from /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/lib/clang/14.0.0/include/ppc_wrappers/mm_malloc.h:15:
In file included from /usr/include/stdlib.h:25:
In file included from /usr/include/bits/libc-header-start.h:33:
In file included from /usr/include/features.h:434:
/usr/include/gnu/stubs.h:14:11: fatal error: 'gnu/stubs-64-v2.h' file not found
# include <gnu/stubs-64-v2.h>
          ^~~~~~~~~~~~~~~~~~~
1 error generated.
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/FileCheck /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/test/CodeGen/ppc-mm-malloc.c
--
********************
Nov 23 2021, 7:10 AM · Restricted Project
jsji committed rGb0784d1d1424: [PowerPC] Remove FreeBSD test in mm-malloc.c due to cross-compilation limitation (authored by jsji).
[PowerPC] Remove FreeBSD test in mm-malloc.c due to cross-compilation limitation
Nov 23 2021, 7:10 AM

Nov 22 2021

jsji committed rG8e2fd879e6f9: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD (authored by adalava).
[PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD
Nov 22 2021, 12:43 PM
jsji closed D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD.
Nov 22 2021, 12:43 PM · Restricted Project
jsji added inline comments to D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD.
Nov 22 2021, 12:40 PM · Restricted Project

Nov 18 2021

jsji added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Is there any way to filter these tests out on AIX in lit.local.cfg?

Nov 18 2021, 7:29 AM · Restricted Project, Restricted Project
jsji added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Can we use UNSUPPORTED instead of XFAIL since it is unsupported?

If 64-bit XCOFF object files will be supported in the future, I think it makes more sense to use XFAIL because these tests will still be run and pass after implementation.

Nov 18 2021, 7:28 AM · Restricted Project, Restricted Project
jsji added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Can we use UNSUPPORTED instead of XFAIL since it is unsupported?

Nov 18 2021, 7:05 AM · Restricted Project, Restricted Project

Nov 12 2021

jsji added a reviewer for D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1: Restricted Project.
Nov 12 2021, 1:39 PM · Restricted Project

Nov 11 2021

jsji accepted D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD.

LGTM. Thanks for enabling this for FreeBSD.

Nov 11 2021, 6:42 AM · Restricted Project
jsji accepted D113654: [AIX] Set D111860's test unsupported on AIX.
Nov 11 2021, 6:33 AM · Restricted Project

Nov 9 2021

jsji accepted D113471: [PowerPC] guard update form prepare with non-const increment with option.

LGTM.

Nov 9 2021, 6:31 AM · Restricted Project

Nov 5 2021

jsji added a comment to D113178: [PowerPC] use right register class for input operand of XXPERMDIs.

Of course the distinction is purely aesthetic, but I think it helps readability.

Nov 5 2021, 6:51 AM · Restricted Project
jsji accepted D113173: [AsmPrinter][ORE] use correct opcode name.
Nov 5 2021, 6:38 AM · Restricted Project

Nov 4 2021

jsji added inline comments to D113173: [AsmPrinter][ORE] use correct opcode name.
Nov 4 2021, 12:02 PM · Restricted Project
jsji added inline comments to D113178: [PowerPC] use right register class for input operand of XXPERMDIs.
Nov 4 2021, 6:46 AM · Restricted Project

Nov 2 2021

jsji committed rGf1d32a521e62: [AIX] Avoid depending on objdump (authored by jsji).
[AIX] Avoid depending on objdump
Nov 2 2021, 12:16 PM
jsji closed D112952: [AIX] Avoid depending on objdump.
Nov 2 2021, 12:16 PM · Restricted Project
jsji updated the diff for D112952: [AIX] Avoid depending on objdump.

Address comments.

Nov 2 2021, 11:09 AM · Restricted Project

Nov 1 2021

jsji updated the diff for D112952: [AIX] Avoid depending on objdump.

Use correct syntax.

Nov 1 2021, 7:29 PM · Restricted Project
jsji updated the diff for D112952: [AIX] Avoid depending on objdump.

Update

Nov 1 2021, 7:24 PM · Restricted Project
jsji updated the diff for D112952: [AIX] Avoid depending on objdump.

Address comment, support non AIX for nm.

Nov 1 2021, 7:20 PM · Restricted Project
jsji updated the summary of D112952: [AIX] Avoid depending on objdump.
Nov 1 2021, 1:02 PM · Restricted Project
jsji updated the diff for D112952: [AIX] Avoid depending on objdump.

Remove empty line.

Nov 1 2021, 12:49 PM · Restricted Project
jsji requested review of D112952: [AIX] Avoid depending on objdump.
Nov 1 2021, 12:48 PM · Restricted Project
jsji accepted D112380: [PowerPC] Enforce side effects to FPSCR read/set instructions.

LGTM. Thanks.

Nov 1 2021, 10:09 AM · Restricted Project
jsji accepted D106555: [PowerPC] handle more splat loads.

LGTM. Thanks.

Nov 1 2021, 8:45 AM · Restricted Project
jsji committed rGbd932f7499ff: [NFC][PowerPC] Update testcases using script (authored by jsji).
[NFC][PowerPC] Update testcases using script
Nov 1 2021, 8:38 AM
jsji accepted D111693: [PowerPC] Implement basic instruction macro fusion in Power10.

LGTM. Thanks.

Nov 1 2021, 8:29 AM · Restricted Project
jsji accepted D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64.

LGTM. Please hold a few days to see whether there are inputs from other reviewers. Thanks.

Nov 1 2021, 6:53 AM · Restricted Project
jsji committed rG838d8d1e2b93: [AIX][NFC] Unsupported object-c test (authored by jsji).
[AIX][NFC] Unsupported object-c test
Nov 1 2021, 6:45 AM
jsji added inline comments to D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain.
Nov 1 2021, 6:40 AM · Restricted Project

Oct 27 2021

jsji accepted D112593: [AIX] Disable cfi-version test on AIX.

Do you know will this section be supported in the future? If so, we can just make this case XFAIL.
But if there is no plan to support .dwframe section, we can just mark it as not emit like this patch does?

Oct 27 2021, 7:42 PM · Restricted Project
jsji added a comment to D112593: [AIX] Disable cfi-version test on AIX.

I think we are using trace table on AIX instead of .debug_frame/.eh_frame . So marking .debug_frame as not emitted on AIX should be right? @xingxue @hubert.reinterpretcast

Oct 27 2021, 6:49 AM · Restricted Project

Oct 26 2021

jsji added inline comments to D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64.
Oct 26 2021, 8:35 AM · Restricted Project
jsji accepted D112055: [PowerPC] Implement longdouble pack/unpack builtins.

LGTM with some nits.

Oct 26 2021, 8:12 AM · Restricted Project, Restricted Project
jsji added inline comments to D106555: [PowerPC] handle more splat loads.
Oct 26 2021, 8:01 AM · Restricted Project

Oct 24 2021

jsji added inline comments to D112380: [PowerPC] Enforce side effects to FPSCR read/set instructions.
Oct 24 2021, 7:55 PM · Restricted Project
jsji accepted D112390: [AIX][ZOS] Disable tests due to lack of Objective-C support.
Oct 24 2021, 7:42 PM · Restricted Project, Restricted Project
jsji committed rG7ea1fbe86d92: [AIX] Add i128 arg split tests (authored by jsji).
[AIX] Add i128 arg split tests
Oct 24 2021, 7:41 PM
jsji closed D112272: [AIX] Add i128 arg split tests.
Oct 24 2021, 7:41 PM · Restricted Project

Oct 22 2021

jsji accepted D108750: [PowerPC] common chains to reuse offsets to reduce register pressure.

LGTM. Thanks for working on this.

Oct 22 2021, 7:52 AM · Restricted Project
jsji updated the diff for D112272: [AIX] Add i128 arg split tests.

Address comments.

Oct 22 2021, 7:29 AM · Restricted Project

Oct 21 2021

jsji requested review of D112272: [AIX] Add i128 arg split tests.
Oct 21 2021, 2:14 PM · Restricted Project
jsji added inline comments to D108750: [PowerPC] common chains to reuse offsets to reduce register pressure.
Oct 21 2021, 8:39 AM · Restricted Project
jsji added inline comments to D108750: [PowerPC] common chains to reuse offsets to reduce register pressure.
Oct 21 2021, 8:32 AM · Restricted Project
jsji accepted D112196: [PowerPC] return early if there is no preparing candidate in the loop; NFC.

LGTM.

Oct 21 2021, 6:54 AM · Restricted Project

Oct 20 2021

jsji added inline comments to D108750: [PowerPC] common chains to reuse offsets to reduce register pressure.
Oct 20 2021, 2:13 PM · Restricted Project

Oct 15 2021

jsji committed rG42eea2b69bb9: [AIX] Enable int128 in 64 bit mode (authored by jsji).
[AIX] Enable int128 in 64 bit mode
Oct 15 2021, 9:23 AM
jsji closed D111078: [AIX] Enable int128 in 64 bit mode.
Oct 15 2021, 9:23 AM · Restricted Project, Restricted Project
jsji added a comment to D111078: [AIX] Enable int128 in 64 bit mode.

This LGTM as the start point to support int128 on AIX. We might need more patches involving libraries in the LLVM monorepo, we can do that progressively.

Agreed (although I find it slightly odd that the testing doesn't check the edge case where the argument value is split between r10 and the stack).

Oct 15 2021, 8:29 AM · Restricted Project, Restricted Project
jsji accepted D111782: [AIX][cmake] Set atomics related macros when build with xlclang.

LGTM. Let us deal with the LLVM_COMPILER_IS_GCC_COMPATIBLE in a follow up patch later.

Oct 15 2021, 6:49 AM · Restricted Project

Oct 14 2021

jsji added a reviewer for D109421: [PowerPC] Add intrinsic to convert between ppc_fp128 and fp128: shchenz.
Oct 14 2021, 7:19 PM · Restricted Project
jsji added a reviewer for D109751: [Clang] Support conversion between PPC double-double and IEEE float128: shchenz.
Oct 14 2021, 7:19 PM · Restricted Project
jsji committed rG4fee8a16915e: [NFC][compiler-rt][profile] Remove non-Posix -h option from test (authored by jsji).
[NFC][compiler-rt][profile] Remove non-Posix -h option from test
Oct 14 2021, 8:09 AM
jsji closed D111807: [NFC][compiler-rt][profile] Remove non-Posix -h option from test.
Oct 14 2021, 8:09 AM · Restricted Project
jsji requested review of D111807: [NFC][compiler-rt][profile] Remove non-Posix -h option from test.
Oct 14 2021, 7:41 AM · Restricted Project
jsji added inline comments to D111693: [PowerPC] Implement basic instruction macro fusion in Power10.
Oct 14 2021, 7:11 AM · Restricted Project
jsji added a comment to D111782: [AIX][cmake] Set atomics related macros when build with xlclang.

Can we set LLVM_COMPILER_IS_GCC_COMPATIBLE in ./llvm/cmake/modules/DetermineGCCCompatible.cmake instead?

Oct 14 2021, 6:40 AM · Restricted Project

Oct 13 2021

jsji added a comment to D111078: [AIX] Enable int128 in 64 bit mode.

ppc64-i128-abi.ll CHECK-P9 part depends on D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.

Oct 13 2021, 12:35 PM · Restricted Project, Restricted Project
jsji updated the diff for D111078: [AIX] Enable int128 in 64 bit mode.

Add AIX XCOFF triples to i128 tests, especially ppc64-i128-abi.ll.

Oct 13 2021, 11:53 AM · Restricted Project, Restricted Project
jsji accepted D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.

I think we should enable this for lit testing purpose.

Oct 13 2021, 11:38 AM · Restricted Project
jsji added a reviewer for D111433: [PowerPC] Respect rounding mode in the back end: qiucf.
Oct 13 2021, 7:11 AM · Restricted Project
jsji added a comment to D100651: [AIX] Support of Big archive (read).

Hi @jhenderson, @jsji , @DiggerLin,
As I said before, I do not have time to improve this PR before one or two months at least, as our priorities have shifted.
My proposal to @Esme about accepting the patch with minor changes was OK but now there are too much changes requested by reviewers.
So, I accept that you start an improvement / alternative version as long as you credit.

Please tag me when you will open your PR.
For your information, I have opened another PR about writing Big Archive here: https://reviews.llvm.org/D104367 .

Oct 13 2021, 6:32 AM · Restricted Project

Oct 12 2021

jsji committed rG666accf28331: [compiler-rt][profile] Enable profile tests for AIX (authored by jsji).
[compiler-rt][profile] Enable profile tests for AIX
Oct 12 2021, 8:01 PM
jsji closed D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 8:00 PM · Restricted Project
jsji added reviewers for D111078: [AIX] Enable int128 in 64 bit mode: shchenz, lkail.
Oct 12 2021, 6:53 PM · Restricted Project, Restricted Project
jsji added inline comments to D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 6:11 PM · Restricted Project
jsji added inline comments to D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 8:44 AM · Restricted Project
jsji added inline comments to D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 8:43 AM · Restricted Project
jsji added a comment to D100651: [AIX] Support of Big archive (read).

I can only suggest that you try implementing something yourself, perhaps by adopting and improving this patch, or starting an alternative version (inspired by this patch, and with credit given to @EGuesnet for their initial work, in the commit message).

Oct 12 2021, 7:59 AM · Restricted Project
jsji added a comment to D111078: [AIX] Enable int128 in 64 bit mode.

Ping @hubert.reinterpretcast Any further comments?

Oct 12 2021, 6:52 AM · Restricted Project, Restricted Project
jsji added a comment to D100651: [AIX] Support of Big archive (read).

In my opinion, this PR is complex enough. It might be accepted with as few changes as possible. So, without freelist, undocumented features... In a second time, you can create a new PR, to extend support of Big Archive, with new tests.

Oct 12 2021, 6:48 AM · Restricted Project

Oct 11 2021

jsji committed rG64d1d5f336c3: [AIX] Unsupported newly added AMDGPU clang test (authored by jsji).
[AIX] Unsupported newly added AMDGPU clang test
Oct 11 2021, 2:35 PM
jsji accepted D110855: [PowerPC] Implement scheduling model for Power10.

LGTM. Thanks!

Oct 11 2021, 7:28 AM · Restricted Project
jsji added a reviewer for D111541: [Object] Deduplicate the three createError functions: Esme.
Oct 11 2021, 6:40 AM · Restricted Project

Oct 9 2021

jsji accepted D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h.

Can you please add a testcase that include smmintrin.h but use SSSE3? Thanks.

Oct 9 2021, 1:22 PM · Restricted Project

Oct 8 2021

jsji committed rG75127bce6de7: [AIX][ZOS] Excluding merge-objc-interface.m from Tests (authored by qiongsiwu1).
[AIX][ZOS] Excluding merge-objc-interface.m from Tests
Oct 8 2021, 7:00 AM
jsji closed D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests.
Oct 8 2021, 7:00 AM · Restricted Project, Restricted Project
jsji accepted D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests.
Oct 8 2021, 6:53 AM · Restricted Project, Restricted Project
jsji accepted D111333: [PowerPC] Simplify PPC codegen test pre-inc-disable.ll.

LGTM. Thanks for improving the test.

Oct 8 2021, 6:28 AM · Restricted Project
jsji added a reviewer for D111333: [PowerPC] Simplify PPC codegen test pre-inc-disable.ll: Restricted Project.
Oct 8 2021, 6:27 AM · Restricted Project
jsji added a comment to D110945: [compiler-rt][profile] Enable profile tests for AIX.

Ping..

Oct 8 2021, 5:08 AM · Restricted Project

Oct 7 2021

jsji accepted D111354: [NFC] Including <string> in llvm-cxxdump/Error.cpp.

LGTM.

Oct 7 2021, 2:37 PM · Restricted Project

Oct 6 2021

jsji accepted D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.

Thanks for working on this.

Oct 6 2021, 12:59 PM · Unknown Object (Project), Restricted Project, Restricted Project
jsji accepted D97184: [XCOFF] support DWARF for 32-bit XCOFF for object output.

LGTM as the first prototype, let us get this in first, we can always refactor later if needed.

Oct 6 2021, 8:26 AM · Restricted Project
jsji retitled D97184: [XCOFF] support DWARF for 32-bit XCOFF for object output from [XCOFF] support DWARF for XCOFF for object output to [XCOFF] support DWARF for 32-bit XCOFF for object output.
Oct 6 2021, 8:26 AM · Restricted Project

Oct 5 2021

jsji updated the diff for D111078: [AIX] Enable int128 in 64 bit mode.

Address comments -- adding AIX triples to more existing tests.

Oct 5 2021, 9:43 AM · Restricted Project, Restricted Project
jsji added inline comments to D111078: [AIX] Enable int128 in 64 bit mode.
Oct 5 2021, 7:20 AM · Restricted Project, Restricted Project

Oct 4 2021

jsji requested review of D111078: [AIX] Enable int128 in 64 bit mode.
Oct 4 2021, 10:47 AM · Restricted Project, Restricted Project
jsji committed rG933e2469a2a8: [PowerPC][NFC] Remove reg name option in int128 test (authored by jsji).
[PowerPC][NFC] Remove reg name option in int128 test
Oct 4 2021, 8:32 AM

Oct 1 2021

jsji committed rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode (authored by jsji).
[AIX] Don't pass namedsects in LTO mode
Oct 1 2021, 12:23 PM