- User Since
- Dec 27 2017, 10:26 AM (160 w, 1 d)
Wed, Jan 20
Please add testcases.
Sun, Jan 17
Fri, Jan 15
Thu, Jan 14
Update encoding testcases.
Rebase and update tests.
Introduce AIX feature bit, and only append this on AIX.
Rename the feature name to be AIX specific.
Wed, Jan 13
Tue, Jan 12
@sfertile I have fixed the MC layer feature as well, please have another look. Thanks.
Update feature for MC Layer as well, also update encoding test to test triple.
Yes, this patch should only disable it for AIX.
See the changes in Taget Machine.
I don't know why you get that failure, I will check.
Rebase after landing D94449 to retrigger precommit tests.
Mon, Jan 11
I have added a Predicates in https://reviews.llvm.org/D94458 for a similar mne, maybe you can rebase this to use that.
This depends on D94449.
Can we try adding Predicates in InstAlias for xxspltd ?
LGTM , thanks for cleaning up .
Tue, Jan 5
Mon, Jan 4
Address comments. Thanks Simon.
Fri, Jan 1
@MaskRay Looks like this refactoring broke All ppc buildbots, please have a look or revert, thanks.
Wed, Dec 30
Thu, Dec 24
Wed, Dec 23
@nikic Looks like this commit (or previous 2 commits in InstCombine) is causing SEGV in stage2 compiler, breaking ppc64/lld/santizers muli-stage buildbots .
Dec 23 2020
Dec 22 2020
Yes, Clang still reject 5 operands, because that is what this patch should do. 😀
Dec 17 2020
@nickdesaulniers If you still find kernel using 2 operands tlbiel (not tlbie), can you please help to show what is the reason of using it? for what purpose does the Linux kernel use "tlbiel RB,RS"? Thanks.
tlbie is different from tlbiel.
Hmm...might be a while before we can test. Building ppc64le linux kernel with Clang's integrated assembler is a bit of a mess...
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 powernv_defconfig
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 arch/powerpc/mm/book3s64/hash_native.o
...(20+ errors emitted)...
Add comments about NDEBUG
Dec 16 2020
Update the NDEBUG
Perhaps GNU assembler has a pseudo-instruction for this? If it's not used significantly throughout the Linux kernel, maybe we should change the kernel to use the canonical form of the instruction?
I don't know where do you get the syntax of tlbiel with 2 operands.
Dec 15 2020
Fix the include as well.
Dec 11 2020
Can you elaborate what happens?
Although a refactor is coming, we should still avoid introducing more confusion if possible.
Please update the name and comments also. Thanks.
Dec 8 2020
Dec 7 2020
Thanks , LGTM as it is per discussion.
Dec 5 2020
In case you missed this due to previous failure in buildbot.
Dec 4 2020
Dec 1 2020
Nov 30 2020
LGTM. Please fix the clang-format warning. Thanks.
Fix llvm test as well
Thanks @qiucf for looking into this.
Nov 24 2020
LGTM. Some comment update please.
Ping.. Any further comments?
Nov 9 2020
Nov 8 2020
Nov 6 2020
LGTM. Thanks for improving this!
Nov 4 2020
Ping.. Any further comments?
Nov 2 2020
@gkistanova When do we reconfig build master to pickup new changes? Is it done automatically or manually? Thanks.