Page MenuHomePhabricator

Conanap (Albion Fung)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 24 2020, 6:53 AM (29 w, 2 d)

Recent Activity

Wed, Jan 13

Conanap requested review of D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs.
Wed, Jan 13, 11:49 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jan 12

Conanap added inline comments to D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.
Tue, Jan 12, 7:26 AM · Restricted Project, Restricted Project

Mon, Jan 4

Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Fixed a typo that prevented successful builds

Mon, Jan 4, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Removed unecessary ternary

Mon, Jan 4, 12:41 PM · Restricted Project, Restricted Project, Restricted Project
Conanap added a comment to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

initialize as a form of undef instead

Mon, Jan 4, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Addressed some comments for formatting and style

Mon, Jan 4, 12:17 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Dec 22

Conanap committed rG8a58f21f5b6c: [PowerPC][Power10] Exploit store rightmost vector element instructions (authored by kamaub).
[PowerPC][Power10] Exploit store rightmost vector element instructions
Tue, Dec 22, 9:07 AM
Conanap closed D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..
Tue, Dec 22, 9:07 AM · Restricted Project, Restricted Project

Thu, Dec 17

Conanap committed rGc2892978e919: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_… (authored by bsaleil).
[PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_…
Thu, Dec 17, 10:20 AM
Conanap closed D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.
Thu, Dec 17, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Dec 16

Conanap updated the diff for D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

Updated tests as per Amy and Lei's comments

Wed, Dec 16, 11:02 AM · Restricted Project, Restricted Project
Conanap commandeered D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

Will take over patch from Kamau

Wed, Dec 16, 10:58 AM · Restricted Project, Restricted Project

Dec 7 2020

Conanap added inline comments to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.
Dec 7 2020, 3:20 PM · Restricted Project, Restricted Project, Restricted Project

Dec 4 2020

Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Removed braces for single lines

Dec 4 2020, 7:20 AM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

Conanap added a comment to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

addressed a comment

Dec 3 2020, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2020

Conanap added a comment to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Replied to a comment

Dec 2 2020, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Addressed some formatting comments

Dec 2 2020, 1:07 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

clang format

Nov 16 2020, 12:13 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Clang-format

Nov 16 2020, 11:52 AM · Restricted Project, Restricted Project, Restricted Project

Nov 11 2020

Conanap updated the diff for D91279: [PowerPC] DForm instructions should be preferred when using zero register.

Updated a test case

Nov 11 2020, 9:36 AM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D91279: [PowerPC] DForm instructions should be preferred when using zero register.
Nov 11 2020, 9:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 5 2020

Conanap committed rG1af037f643fc: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI (authored by Conanap).
[PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI
Nov 5 2020, 12:36 PM
Conanap closed D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Nov 5 2020, 12:35 PM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2020

Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Updated a test file.

Nov 4 2020, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
Conanap added a comment to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

The unrelated change no longer shows as diff, thank you!

Nov 4 2020, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.

Addressed some formatting problems as well as corrected incorrect arguments for Hi case.

Nov 4 2020, 10:11 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2020

Conanap requested review of D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.
Oct 26 2020, 10:49 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2020

Conanap committed rGd30155feaa9c: [PowerPC] Implementation of 128-bit Binary Vector Rotate builtins (authored by Conanap).
[PowerPC] Implementation of 128-bit Binary Vector Rotate builtins
Oct 16 2020, 3:04 PM
Conanap closed D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.
Oct 16 2020, 3:04 PM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2020

Conanap added a comment to D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.

Addressed Nemenja's concerns.

Oct 13 2020, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.

Use regex match to check for variable order in IR instead.

Oct 13 2020, 1:06 PM · Restricted Project, Restricted Project, Restricted Project

Sep 30 2020

Conanap updated the diff for D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.

Addressed comments and corrected incorrect behaviour on Power10

Sep 30 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2020

Conanap updated the diff for D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.

Changed the location of fix and added extra test cases

Sep 28 2020, 12:24 PM · Restricted Project, Restricted Project, Restricted Project

Sep 23 2020

Conanap committed rG2e7117f84770: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge]… (authored by amyk).
[PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge]…
Sep 23 2020, 1:50 PM
Conanap committed rG88cdbeab417c: [PowerPC] Implement Vector signed/unsigned __int128 overloads for the… (authored by Conanap).
[PowerPC] Implement Vector signed/unsigned __int128 overloads for the…
Sep 23 2020, 1:50 PM
Conanap closed D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.
Sep 23 2020, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
Conanap closed D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.
Sep 23 2020, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
Conanap closed D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

Committed with Nemanja's comments addressed in the commit. Hash d7eb917a7cb793f49e16841fc24826b988dd5c8f

Sep 23 2020, 2:41 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

Conanap committed rGd7eb917a7cb7: [PowerPC] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins (authored by Conanap).
[PowerPC] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins
Sep 22 2020, 11:19 PM
Conanap added a comment to D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

It looks like this commit is causing a few failures on nearly all PPC bots and a sanitizer bot; would it be possible to revert this commit for now until the issue is resolved?

Sep 22 2020, 11:28 AM · Restricted Project
Conanap updated the diff for D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.

Changed implementation for vrlqnm as per Nemanja

Sep 22 2020, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

Conanap accepted D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.

lgtm

Sep 21 2020, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
Conanap accepted D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.

lgtm

Sep 21 2020, 2:35 PM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2020

Conanap added inline comments to D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.
Sep 20 2020, 11:27 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

Open Coded instead

Sep 20 2020, 11:26 PM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2020

Conanap updated the diff for D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

Open coded VMODS/UQ instead.

Sep 18 2020, 2:32 PM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2020

Conanap updated the diff for D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.

Added extra test case to demonstrate that the arguments will be reversed

Sep 17 2020, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
Conanap added inline comments to D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.
Sep 17 2020, 12:18 PM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2020

Conanap requested review of D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.
Sep 16 2020, 4:28 PM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

Conanap accepted D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.

LGTM

Sep 15 2020, 8:59 PM · Restricted Project, Restricted Project, Restricted Project
Conanap requested changes to D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.

Looks like there's some unit test failures; could you double check?

Sep 15 2020, 7:44 PM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rG05aa997d511e: [PowerPC] Implement __int128 vector divide operations (authored by Conanap).
[PowerPC] Implement __int128 vector divide operations
Sep 15 2020, 12:20 PM
Conanap closed D85453: [PowerPC] Implement __int128 vector divide operations.
Sep 15 2020, 12:19 PM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2020

Conanap committed rGc0f199e5667a: [PowerPC] Implement Thread Local Storage Support for Local Exec (authored by kamaub).
[PowerPC] Implement Thread Local Storage Support for Local Exec
Sep 14 2020, 12:17 PM
Conanap closed D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Sep 14 2020, 12:16 PM · Restricted Project, Restricted Project

Sep 11 2020

Conanap updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Added --no-show-raw-insn and updated test case accordingly

Sep 11 2020, 3:18 PM · Restricted Project, Restricted Project

Sep 9 2020

Conanap requested review of D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.
Sep 9 2020, 9:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 3 2020

Conanap updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Added back the test files that were accidentally removed in prev diff

Sep 3 2020, 9:45 PM · Restricted Project, Restricted Project
Conanap updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Added an extra test case

Sep 3 2020, 9:43 PM · Restricted Project, Restricted Project
Conanap accepted D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

Minor nit, okay if changed for commit

Sep 3 2020, 10:38 AM · Restricted Project, Restricted Project
Conanap added inline comments to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Sep 3 2020, 10:38 AM · Restricted Project, Restricted Project

Sep 2 2020

Conanap updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Added test case for non-zero offset, added a few flags to the RUN lines and removed some unecessary comments.

Sep 2 2020, 12:46 PM · Restricted Project, Restricted Project
Conanap commandeered D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Taking over for the patch

Sep 2 2020, 12:42 PM · Restricted Project, Restricted Project
Conanap committed rG5d1fe3f903b9: [PowerPC] Implemented Vector Multiply Builtins (authored by Conanap).
[PowerPC] Implemented Vector Multiply Builtins
Sep 2 2020, 12:16 PM
Conanap closed D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.
Sep 2 2020, 12:16 PM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2020

Conanap updated the diff for D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.

Included extra test cases

Aug 31 2020, 8:10 PM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2020

Conanap requested review of D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.
Aug 28 2020, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rG331dcc43eac2: [PowerPC] Implemented Vector Load with Zero and Signed Extend Builtins (authored by Conanap).
[PowerPC] Implemented Vector Load with Zero and Signed Extend Builtins
Aug 28 2020, 9:29 AM
Conanap closed D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Aug 28 2020, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Aug 12 2020

Conanap committed rG3136cbe29e74: [PowerPC] Implement Vector Shift Builtins (authored by Conanap).
[PowerPC] Implement Vector Shift Builtins
Aug 12 2020, 4:27 PM
Conanap closed D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Aug 12 2020, 4:27 PM · Restricted Project, Restricted Project, Restricted Project

Aug 10 2020

Conanap committed rGed66df6705a9: test commit (authored by Conanap).
test commit
Aug 10 2020, 6:19 PM

Aug 7 2020

Conanap added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Aug 7 2020, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Added shl tests, formatting fixes

Aug 7 2020, 12:13 PM · Restricted Project, Restricted Project, Restricted Project

Aug 6 2020

Conanap requested review of D85453: [PowerPC] Implement __int128 vector divide operations.
Aug 6 2020, 11:07 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Clang formatted relevant lines, combined LE and BE tests as they produced the same ASM.

Aug 4 2020, 4:44 PM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2020

Conanap retitled D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests from [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests to [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.
Jul 31 2020, 9:53 AM · Restricted Project, Restricted Project, Restricted Project

Jul 30 2020

Conanap updated the summary of D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Jul 30 2020, 11:31 AM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Jul 30 2020, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 30 2020, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Some updates on formatting and updated to match an updated test file.

Jul 30 2020, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2020

Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Replaced a forgotten test file.

Jul 29 2020, 7:37 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Fixed formatting based on bot feedback.

Jul 29 2020, 2:04 PM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2020

Conanap updated the diff for D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.

Recovered accidentally deleted test cases.

Jul 27 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Jul 27 2020, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Included sext test case.

Jul 27 2020, 1:08 PM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2020

Conanap added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Addressed formatting comments

Jul 24 2020, 3:01 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 24 2020, 3:01 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Converted the impelmentation to an open coded implementation and updated the test cases as appropriate.

Jul 24 2020, 2:44 PM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

Conanap updated the diff for D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.

Changed if def to use pwer10_vector

Jul 21 2020, 2:56 PM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2020

Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Return signature fix, added recognition for ISD:EXTLOAD, some code clean up.

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Fixed function names, test case clean up

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project, Restricted Project
Conanap created D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.
Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project, Restricted Project

Jul 16 2020

Conanap created D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.
Jul 16 2020, 8:24 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2020

Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Formatting fixes, fixed test case return type, updated builtins' signatures to correct signatures.

Jul 15 2020, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2020

Conanap updated the diff for D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Restored accidentally deleted pattern, removed duplicate tests, moved new tests to another pre-existing file instead.

Jul 14 2020, 1:06 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Jul 14 2020, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
Conanap added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Also removed instr def as it will be part of D83516.

Jul 14 2020, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Jul 14 2020, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Added tests, added extra comments.

Jul 14 2020, 10:42 AM · Restricted Project, Restricted Project, Restricted Project