Page MenuHomePhabricator

nemanjai (Nemanja Ivanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2015, 9:38 AM (289 w, 1 d)

Recent Activity

Fri, Aug 7

nemanjai added a comment to D85504: [Reassociate] [PowerPC] stop common out mul factors if fma is preferred on target.

There seems to be some (weak) correlation between this and https://reviews.llvm.org/D84309 which I am reworking to remove it from canonicalization. It may be worth looking into whether we can catch both issues in CGP.

Fri, Aug 7, 10:05 AM · Restricted Project
nemanjai added a comment to D80683: [SelectionDAG] Fix up SimplifyDemandedBits for ppcf128.

Ping.

Fri, Aug 7, 9:59 AM · Restricted Project
nemanjai added a comment to D83569: [PowerPC] Fix the killed flag in mi-peephole pass.

It seems like we keep adding more and more complexity here to handle these flags. Is there not a pass we can just run that will simply re-compute this stuff (at least for the use of this while we're in SSA)? What does LiveVariables do? We certainly end up running DCE after the MI peephole to get rid of dead instructions after the transformation. It seems like we should be able to do the same thing for killed/dead flags as well.

Fri, Aug 7, 9:55 AM · Restricted Project
nemanjai accepted D85391: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int.

Sure, it's PPC specific and the name should reflect that. Thanks. LGTM.

Fri, Aug 7, 5:13 AM · Restricted Project
nemanjai accepted D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.

I agree with Victor, please remove uses of future and use pwr10. All of this can be addressed when committing - another round of review is not required. LGTM.

Fri, Aug 7, 5:12 AM · Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Fri, Aug 7, 5:05 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Fri, Aug 7, 4:13 AM · Restricted Project, Restricted Project

Thu, Aug 6

nemanjai accepted D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.

Feel free to address the comment when committing the patch.

Thu, Aug 6, 12:52 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Thu, Aug 6, 7:12 AM · Restricted Project, Restricted Project

Wed, Aug 5

nemanjai updated the diff for D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
  • Move implementation completely into LLD
  • Add option to disable the optimization
  • Handle computation of the total offset when the access instruction has a non-zero displacement
  • Add tests with the new option as well as a test with non-zero displacement on the access instructions
Wed, Aug 5, 6:18 PM · Restricted Project, Restricted Project

Tue, Aug 4

nemanjai planned changes to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Need to account for a displacement on the access instruction and add some tests along the lines of

extern int Ext[40];
int test(int a) {
  return a + Ext[10];
}
Tue, Aug 4, 9:41 AM · Restricted Project, Restricted Project
nemanjai committed rG14d726acd604: [PowerPC] Don't remove single swap between the load and store (authored by nemanjai).
[PowerPC] Don't remove single swap between the load and store
Tue, Aug 4, 8:38 AM
nemanjai closed D84785: [PowerPC] Don't remove swap if there is only a single one between the load and store.
Tue, Aug 4, 8:38 AM · Restricted Project
nemanjai committed rG62a933b72c5b: [Support][PPC] Fix bot failures due to cd53ded557c3 (authored by nemanjai).
[Support][PPC] Fix bot failures due to cd53ded557c3
Tue, Aug 4, 7:01 AM
nemanjai added inline comments to rG36750ba5bd0e: [X86][AVX] isHorizontalBinOp - relax lane-crossing limits for AVX1-only targets..
Tue, Aug 4, 6:54 AM
nemanjai added inline comments to rG36750ba5bd0e: [X86][AVX] isHorizontalBinOp - relax lane-crossing limits for AVX1-only targets..
Tue, Aug 4, 6:44 AM

Mon, Aug 3

nemanjai added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

It would appear that this failure is not really related to this patch at all. Seems to fail with -O0/-O1 regardless of which patch is applied.
https://pastebin.com/1Mvz5KDz

Please let me know if there's something else I can help with.

Mon, Aug 3, 6:23 AM · Restricted Project
nemanjai updated subscribers of D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Mon, Aug 3, 6:13 AM · Restricted Project
nemanjai added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

It would appear that this failure is not really related to this patch at all. Seems to fail with -O0/-O1 regardless of which patch is applied.
https://pastebin.com/1Mvz5KDz

Mon, Aug 3, 6:13 AM · Restricted Project
nemanjai added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

I'll send you the results in a few minutes. Sorry about the delay - holiday here in Canada.

Mon, Aug 3, 5:43 AM · Restricted Project
nemanjai added inline comments to rGcd53ded557c3: [Support] Fix computeHostNumPhysicalCores() to respect affinity.
Mon, Aug 3, 5:06 AM

Fri, Jul 31

nemanjai added a comment to D84956: [zorg] Add Flang and MLIR PowerPC buildbot on Red Hat.

Since we are adding another bot, we need to adjust the number of threads that are used by LIT for all the bots running on that machine. Thanks.

Fri, Jul 31, 5:41 AM
nemanjai added inline comments to D84956: [zorg] Add Flang and MLIR PowerPC buildbot on Red Hat.
Fri, Jul 31, 5:06 AM
nemanjai closed D84901: [Sanitizers] Fix lint failure with Python 3.6.

I forgot to add the differential revision to the commit message.
Committed in https://reviews.llvm.org/rGacb3b8dce1cd

Fri, Jul 31, 4:27 AM · Restricted Project
nemanjai committed rGacb3b8dce1cd: [Sanitizers] Fix lint failure with Python 3.6 (authored by nemanjai).
[Sanitizers] Fix lint failure with Python 3.6
Fri, Jul 31, 4:22 AM

Thu, Jul 30

nemanjai updated the diff for D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Remove erroneous unrelated update.

Thu, Jul 30, 4:27 PM · Restricted Project, Restricted Project
nemanjai updated the diff for D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Fix up usage of unsigned long literal suffixes.
Add new rel-expr.
Fix up minor nits.
Shorten the test cases.

Thu, Jul 30, 4:26 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Thu, Jul 30, 4:03 PM · Restricted Project, Restricted Project
nemanjai added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

CC @simoatze, @wschmidt:

Would anyone with access to a Linux/PPC64 machine be willing to take a look if the open() syscall is receiving the right value (0600 from the testcase)?

Thu, Jul 30, 12:35 PM · Restricted Project
nemanjai added a comment to D84901: [Sanitizers] Fix lint failure with Python 3.6.

Sample of the build bot failure this resolves:
http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/6122/steps/ninja%20check%201/logs/stdio

Thu, Jul 30, 3:03 AM · Restricted Project

Wed, Jul 29

nemanjai requested review of D84901: [Sanitizers] Fix lint failure with Python 3.6.
Wed, Jul 29, 5:42 PM · Restricted Project

Tue, Jul 28

nemanjai added a comment to D84785: [PowerPC] Don't remove swap if there is only a single one between the load and store.

@wschmidt Sorry to ask you to go back to looking at LLVM code, but figured I'd add you for two reasons:

  1. If gcc has the same issue
  2. If the proposed fix is completely out to lunch :)
Tue, Jul 28, 4:59 PM · Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Tue, Jul 28, 12:40 PM · Restricted Project, Restricted Project
nemanjai accepted D84786: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC.

LGTM. Thank you.

Tue, Jul 28, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D84785: [PowerPC] Don't remove swap if there is only a single one between the load and store.

@wschmidt Sorry to ask you to go back to looking at LLVM code, but figured I'd add you for two reasons:

  1. If gcc has the same issue
  2. If the proposed fix is completely out to lunch :)
Tue, Jul 28, 11:50 AM · Restricted Project
nemanjai requested review of D84785: [PowerPC] Don't remove swap if there is only a single one between the load and store.
Tue, Jul 28, 11:49 AM · Restricted Project

Mon, Jul 27

nemanjai updated the diff for D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Add test cases for all the different instructions - thanks for your help producing these @NeHuang.
Run clang-format on the patch since the pre-commit build flagged a bunch of issues.

Mon, Jul 27, 9:39 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Mon, Jul 27, 9:24 AM · Restricted Project, Restricted Project
nemanjai added a comment to D83948: [PowerPC] Custom lowering for funnel shifts.

The fix to recover the regression: https://reviews.llvm.org/D84659

Mon, Jul 27, 7:26 AM · Restricted Project
Herald added a project to D84659: [PowerPC] Handle SUBFIC in reg+reg -> reg+imm transformation: Restricted Project.
Mon, Jul 27, 7:25 AM · Restricted Project
nemanjai accepted D83948: [PowerPC] Custom lowering for funnel shifts.

LGTM.

Mon, Jul 27, 7:16 AM · Restricted Project

Sat, Jul 25

nemanjai committed rGcdead4f89c0e: [PowerPC][NFC] Fix an assert that cannot trip from 7d076e19e31a (authored by nemanjai).
[PowerPC][NFC] Fix an assert that cannot trip from 7d076e19e31a
Sat, Jul 25, 5:33 PM
nemanjai added inline comments to rG7d076e19e31a: [PowerPC] Fix computation of offset for load-and-splat for permuted loads.
Sat, Jul 25, 5:24 PM

Fri, Jul 24

nemanjai added a comment to D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.
Fri, Jul 24, 12:43 PM · Restricted Project
nemanjai committed rG7d076e19e31a: [PowerPC] Fix computation of offset for load-and-splat for permuted loads (authored by nemanjai).
[PowerPC] Fix computation of offset for load-and-splat for permuted loads
Fri, Jul 24, 12:39 PM
nemanjai added a comment to rG59a76d957a26: Re-apply:" Emit DW_OP_implicit_value for Floating point constants".

Hi there!
I believe this patch is causing failures on the following (big endian) PowerPC buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/
http://lab.llvm.org:8011/builders/clang-ppc64be-linux

Example of the failures can be seen at: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51729

Could you please fix or pull this changeset if necessary? Thank you.

Fri, Jul 24, 11:33 AM

Wed, Jul 22

Herald added a project to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation: Restricted Project.
Wed, Jul 22, 1:46 PM · Restricted Project, Restricted Project
nemanjai added a comment to D84309: [InstCombine] Preserve FMA opportunities when combining PHI nodes.

Sounds like agreement. I'll move this to CGP. Thanks for the quick response.

Wed, Jul 22, 9:56 AM · Restricted Project
Herald added a project to D84309: [InstCombine] Preserve FMA opportunities when combining PHI nodes: Restricted Project.
Wed, Jul 22, 4:52 AM · Restricted Project
nemanjai accepted D83365: [PowerPC] start and end parameters for fixupIsDeadOrKill may exist in different block before RA.

LGTM. I am really sorry about not getting back to this earlier.

Wed, Jul 22, 2:14 AM · Restricted Project
nemanjai accepted D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation.

LGTM. The test case addition can be done on the commit.

Wed, Jul 22, 2:08 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 21

nemanjai added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

There is a lot of instances where this warning fires in the unit tests since gtest does not appear to use the override keyword. This in turn causes failures on bootstrap builds that use -Werror.
An example: http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/10717

Tue, Jul 21, 4:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Jul 20

nemanjai accepted D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.

The remaining comments are minor nits that can be addressed on commit. LGTM.

Mon, Jul 20, 9:16 PM · Restricted Project
nemanjai added a comment to D79625: [PowerPC] Extend .reloc directive on PowerPC.

Also, can you run clang-format so all the notifications go away and make this easier to review?

Mon, Jul 20, 9:16 PM · Restricted Project

Thu, Jul 16

nemanjai requested changes to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

The description includes ... however it is more preferable to use bitcast. It is not a question of preference but of correctness. The fp to int conversions truncate while bitcasts don't. The semantics of the builtins require that no truncation happen.

Thu, Jul 16, 11:01 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 15

nemanjai added inline comments to D68035: [PowerPC] Extend custom lower of vector truncate to handle wider input.
Wed, Jul 15, 3:17 PM · Restricted Project

Tue, Jul 14

nemanjai accepted D81442: [PowerPC] Add clang options to control MMA support.

Since clang will now add +/-mma to the TargetFeatures list, please add a test case that specifies -mattr=+/-mma to llc to show that llc accepts it.
Other than that, LGTM.

Tue, Jul 14, 4:48 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D83722: [PowerPC] Add options to control paired vector memops support.

Please re-upload this and provide the missing context.

Tue, Jul 14, 4:41 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC.

Seems fine to me, but of course, wait to hear from Sean/MaskRay.

Tue, Jul 14, 4:30 AM · Restricted Project
nemanjai added a comment to D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

@rzurob This cannot proceed without your approval since you requested changes.

Tue, Jul 14, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai accepted D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

LGTM aside from a minor nit regarding the description.

Tue, Jul 14, 4:11 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 13

nemanjai accepted D83617: [PowerPC] Fix combineVectorShuffle regression after D77448.

LGTM. Thanks for fixing this.

Mon, Jul 13, 4:31 PM · Restricted Project

Fri, Jul 10

nemanjai added inline comments to D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.
Fri, Jul 10, 12:18 PM · Restricted Project
nemanjai added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Fri, Jul 10, 11:44 AM · Restricted Project

Jul 10 2020

nemanjai accepted D83437: [PowerPC] Enable default support of quad precision operations.

LGTM. Thank you.

Jul 10 2020, 8:52 AM · Restricted Project
nemanjai added inline comments to D83437: [PowerPC] Enable default support of quad precision operations.
Jul 10 2020, 8:51 AM · Restricted Project
nemanjai accepted D79625: [PowerPC] Extend .reloc directive on PowerPC.

My remaining comments are minor and can be addressed on the commit. AFAICT, Sean's comments have been addressed as well so I think this is good to go. @sfertile if you have any objections, feel free to override my approval, otherwise this is good to go.

Jul 10 2020, 6:36 AM · Restricted Project

Jul 8 2020

nemanjai accepted D83255: [PowerPC] Split s34imm into two types.

Forgot to select Accept.

Jul 8 2020, 8:18 AM · Restricted Project
nemanjai added a comment to D83255: [PowerPC] Split s34imm into two types.

Minor nits, otherwise LGTM.

Jul 8 2020, 8:18 AM · Restricted Project

Jul 7 2020

nemanjai accepted D83308: [Power10] Implement Vector Replace Builtins in LLVM.

LGTM as long as the inheriting of GCCBuiltin is removed. This can be done on commit.

Jul 7 2020, 8:04 AM · Restricted Project

Jul 6 2020

nemanjai committed rG1b1539712e1e: [PowerPC] Do not RAUW combined nodes in VECTOR_SHUFFLE legalization (authored by nemanjai).
[PowerPC] Do not RAUW combined nodes in VECTOR_SHUFFLE legalization
Jul 6 2020, 8:11 PM
nemanjai accepted D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..

The remaining updates are straightforward so feel free to address my comments on the commit. LGTM otherwise.

Jul 6 2020, 4:18 PM · Restricted Project
nemanjai accepted D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.

Other than removing the assert, this LGTM.

Jul 6 2020, 3:22 PM · Restricted Project, Restricted Project
nemanjai requested changes to D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..

Pretty close to the way it should be but the indices do need to flip so I have to request changes.

Jul 6 2020, 2:33 PM · Restricted Project

Jul 2 2020

nemanjai committed rG16989f6f5c69: [LLD] Add required dependency after shared libs break due to ba5087f13025 (authored by nemanjai).
[LLD] Add required dependency after shared libs break due to ba5087f13025
Jul 2 2020, 10:49 AM
nemanjai committed rGa701dc5510ab: [PowerPC] Remove undefs from splat input when changing shuffle mask (authored by nemanjai).
[PowerPC] Remove undefs from splat input when changing shuffle mask
Jul 2 2020, 10:49 AM
nemanjai accepted D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests.

LGTM other than the naming nit.

Jul 2 2020, 10:47 AM · Restricted Project, Restricted Project
nemanjai added a comment to rGba5087f13025: ld64.lld: Add janky support for tbd files.

This fixes it:

diff --git a/lld/lib/ReaderWriter/MachO/CMakeLists.txt b/lld/lib/ReaderWriter/MachO/CMakeLists.txt
index 37d1de4..bdbfbee 100644
--- a/lld/lib/ReaderWriter/MachO/CMakeLists.txt
+++ b/lld/lib/ReaderWriter/MachO/CMakeLists.txt
@@ -24,6 +24,7 @@ add_lld_library(lldMachO
     Demangle
     Object
     Support
+    TextAPI
Jul 2 2020, 8:40 AM
nemanjai added a comment to rGba5087f13025: ld64.lld: Add janky support for tbd files.

The shared libs build of LLD is broken and it appears to be as a result of this patch:

tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o: In function `lld::mach_o::TAPIFile::doParse()':
MachONormalizedFileBinaryReader.cpp:(.text._ZN3lld6mach_o8TAPIFile7doParseEv[_ZN3lld6mach_o8TAPIFile7doParseEv]+0x60): undefined reference to `llvm::MachO::TextAPIReader::get(llvm::MemoryBufferRef)'
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o: In function `lld::mach_o::TAPIFile::loadFromInterface(llvm::MachO::InterfaceFile&)':
MachONormalizedFileBinaryReader.cpp:(.text._ZN3lld6mach_o8TAPIFile17loadFromInterfaceERN4llvm5MachO13InterfaceFileE[_ZN3lld6mach_o8TAPIFile17loadFromInterfaceERN4llvm5MachO13InterfaceFileE]+0x1dc): undefined reference to `llvm::MachO::mapToArchitectureSet(llvm::ArrayRef<llvm::MachO::Target>)'
MachONormalizedFileBinaryReader.cpp:(.text._ZN3lld6mach_o8TAPIFile17loadFromInterfaceERN4llvm5MachO13InterfaceFileE[_ZN3lld6mach_o8TAPIFile17loadFromInterfaceERN4llvm5MachO13InterfaceFileE]+0x30c): undefined reference to `llvm::MachO::mapToArchitectureSet(llvm::ArrayRef<llvm::MachO::Target>)'
Jul 2 2020, 8:05 AM
nemanjai added a comment to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.

Also, please add a couple of new test in test/CodeGen/PowerPC/p10-splatImm.ll so that when someone looks at this commit in the log, they can see that vec_splati and vec_splatid are meant to produce xxspltiw and xxspltidp (i.e. the same IR produced for the calls in this test, produces the desired instruction)..

Jul 2 2020, 3:10 AM · Restricted Project, Restricted Project
nemanjai requested changes to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.

If this patch does not include the back end codegen test cases for these, which patch does? I don't see any selection patterns or test cases for xxsplti32dx in ToT.
The implementation and test cases for xxspltiw are in ToT, so they don't appear to be a concern.

Jul 2 2020, 3:10 AM · Restricted Project, Restricted Project

Jul 1 2020

nemanjai accepted D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

LGTM.

Jul 1 2020, 12:59 PM · Restricted Project
nemanjai added a comment to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

LGTM other than the minor nit.

Jul 1 2020, 12:59 PM · Restricted Project
nemanjai accepted D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.

The nits can be addressed on commit. I don't think another review is required. LGTM.

Jul 1 2020, 6:27 AM · Restricted Project, Restricted Project

Jun 30 2020

nemanjai accepted D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

As far as I'm concerned, this is fine for now. We can remove these once all in-tree target have implemented their support.
LGTM but maybe give a couple of days for others to chime in.

Jun 30 2020, 1:05 PM · Restricted Project
nemanjai accepted D82859: [Power10] Implement VSX vector permute extended instruction.

LGTM. Thanks.

Jun 30 2020, 4:51 AM · Restricted Project

Jun 29 2020

nemanjai committed rGd2533d96e141: [PowerPC] Fix crash for shuffle canonicalization with elt 0 from RHS (authored by nemanjai).
[PowerPC] Fix crash for shuffle canonicalization with elt 0 from RHS
Jun 29 2020, 10:48 AM
nemanjai committed rG57ad8f4730c9: [PowerPC] Don't combine SCALAR_TO_VECTOR without VSX (authored by nemanjai).
[PowerPC] Don't combine SCALAR_TO_VECTOR without VSX
Jun 29 2020, 8:05 AM
nemanjai added a comment to D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.

Gentle ping. This is still an issue at 4c6548222b3c41d024581d28f42b3f02510bcfe3 and I have not heard anything about a fix. I know I sent that message on Friday night before the weekend so I am hoping that it did not get lost. If I need to file a bug report, I am more than happy to do so.

Jun 29 2020, 8:03 AM · Restricted Project

Jun 24 2020

nemanjai updated subscribers of D81537: [PowerPC] Support constrained fp operation for scalar fptosi/fptoui.
Jun 24 2020, 5:54 AM · Restricted Project

Jun 23 2020

nemanjai added inline comments to D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.
Jun 23 2020, 11:15 AM · Restricted Project

Jun 19 2020

nemanjai added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jun 19 2020, 3:14 PM · Restricted Project

Jun 18 2020

nemanjai committed rG1fed131660b2: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE (authored by nemanjai).
[PowerPC] Canonicalize shuffles to match more single-instruction masks on LE
Jun 18 2020, 8:12 PM
nemanjai closed D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.
Jun 18 2020, 8:12 PM · Restricted Project

Jun 15 2020

nemanjai added inline comments to D81457: [LLD][PowerPC] Add support for R_PPC64_PCREL34.
Jun 15 2020, 9:45 AM · Restricted Project
nemanjai added a comment to D81712: [NFC][PowerPC] Add a multiclass for fsetcc to define them in a uniform way.

This is a nice refactor. The only thing I would like to see is a statement to indicate that you have ensured that PPCGenDAGISel.inc is identical before and after this patch.

Jun 15 2020, 3:46 AM · Restricted Project

Jun 10 2020

nemanjai added a comment to D80175: [PowerPC][MachineCombiner] reassociate fma to expose more ILP.

Can you add a hidden option with init false? You can turn it true later on.
So that people can try with your option off and on? Thanks!

Jun 10 2020, 9:17 AM · Restricted Project

Jun 9 2020

nemanjai added a comment to rG3b7ec64d5974: [DebugInfo] Fix printing of unrecognised standard opcodes.

Oh, apparently Fangrui fixed it in rG81cca9876847.

Jun 9 2020, 11:32 AM
nemanjai added a comment to rG3b7ec64d5974: [DebugInfo] Fix printing of unrecognised standard opcodes.

AFAICT this patch is causing the follwing error

Jun 9 2020, 10:58 AM
nemanjai accepted D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang.

LGTM. Thanks Amy.

Jun 9 2020, 2:42 AM · Restricted Project, Restricted Project, Restricted Project