Page MenuHomePhabricator

nemanjai (Nemanja Ivanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2015, 9:38 AM (358 w, 5 d)

Recent Activity

Mon, Dec 6

nemanjai accepted D114062: [PowerPC] use lvx + splat directly for aligned splat load.

LGTM.

Mon, Dec 6, 6:09 AM · Restricted Project

Fri, Dec 3

nemanjai committed rGd6c0ef78876d: [PowerPC] Handle base load with reservation mnemonic (authored by nemanjai).
[PowerPC] Handle base load with reservation mnemonic
Fri, Dec 3, 7:13 AM

Thu, Dec 2

nemanjai accepted D114978: [PowerPC] Fix load/store selection infrastructure when load/store intrinsics are used on P10..

You might want to avoid adding new check prefixes in the tests if the sequence is exactly the same. Maybe just change it from CHECK-P9 to CHECK-P9UP. Otherwise LGTM.

Thu, Dec 2, 12:15 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D114589: [DAG] Enable ISD::EXTRACT_ELEMENT SimplifyDemandedBits handling.
Thu, Dec 2, 7:45 AM · Restricted Project
nemanjai added inline comments to D114589: [DAG] Enable ISD::EXTRACT_ELEMENT SimplifyDemandedBits handling.
Thu, Dec 2, 6:43 AM · Restricted Project

Wed, Dec 1

nemanjai added inline comments to D114800: [PowerPC] Replace MFVSRLD with MFVSRD when the vector is symmetrical.
Wed, Dec 1, 4:24 PM · Restricted Project
nemanjai requested changes to D114589: [DAG] Enable ISD::EXTRACT_ELEMENT SimplifyDemandedBits handling.
Wed, Dec 1, 3:48 PM · Restricted Project
nemanjai accepted D114676: [DAG][PowerPC] Enable initial ISD::BITCAST SimplifyDemandedBits/SimplifyMultipleUseDemandedBits big-endian handling.

LGTM. The PPC changes are fine AFAICT.

Wed, Dec 1, 2:59 PM · Restricted Project

Tue, Nov 30

nemanjai accepted D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk.

PPC64R12SetupStub is not only used by NOTOC->TOC code, but is also used by NOTOC->NOTOC long branches, so __long_branch_pcrel is not that bad. That said, if __gep_setup makes more sense, I am happy to use it, too.

Tue, Nov 30, 4:42 AM · Restricted Project
nemanjai accepted D114497: [PowerPC] Drop stdlib paths in freestanding tests.

Seems fine to me but maybe give @MaskRay a couple of days to see if this adequately addresses his comment.

Tue, Nov 30, 4:02 AM · Restricted Project
nemanjai accepted D114345: [PowerPC] Implement general back2back fusion.

LGTM.

Tue, Nov 30, 4:00 AM · Restricted Project
nemanjai added a comment to D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.

My comments are just minor nits that don't require another review and can be addressed when committing the patch.

Tue, Nov 30, 3:46 AM · Restricted Project
nemanjai added a comment to D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.

Nice work Yousuf. Can you start by adding the context for the patch (for example if you used git diff or git show then adding -U9999 will give you 9999 lines of surrounding context in the diff), and running clang format on the patch?

Tue, Nov 30, 3:24 AM · Restricted Project
nemanjai accepted D114540: Big-endian version of vpermxor.

LGTM.

Tue, Nov 30, 3:19 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D114778: [XCOFF][FastISel] make fast isel can lower general intrinsics.
Tue, Nov 30, 3:14 AM · Restricted Project

Mon, Nov 29

nemanjai requested changes to D112073: [PowerPC] Emit warning when SP is clobbered by asm.
Mon, Nov 29, 8:05 AM · Restricted Project
nemanjai added a comment to D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk.

How important is it for the thunk symbol names to match ld.bfd/ld.gold?

Mon, Nov 29, 7:05 AM · Restricted Project

Fri, Nov 26

nemanjai added inline comments to D114640: [PowerPC] Handle Vector Sum Reducation.
Fri, Nov 26, 10:23 AM · Restricted Project

Thu, Nov 25

nemanjai accepted D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

LGTM. Thanks for the update.

Thu, Nov 25, 8:55 AM · Restricted Project, Restricted Project

Wed, Nov 24

nemanjai committed rGdc1aa8eacd1e: [PowerPC] Add missed clang portion of c933c2eb3346 (authored by nemanjai).
[PowerPC] Add missed clang portion of c933c2eb3346
Wed, Nov 24, 10:43 AM
nemanjai accepted D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

LGTM aside from a name and return type change.

Wed, Nov 24, 10:10 AM · Restricted Project, Restricted Project
nemanjai added a comment to D114540: Big-endian version of vpermxor.

Please also add a test for this builtin to the front end test clang/test/CodeGen/builtins-ppc-crypto.c

Wed, Nov 24, 8:28 AM · Restricted Project, Restricted Project
nemanjai committed rGb7bf937bbee3: [PowerPC] Provide XL-compatible vec_round implementation (authored by nemanjai).
[PowerPC] Provide XL-compatible vec_round implementation
Wed, Nov 24, 4:44 AM
nemanjai closed D113642: [PowerPC] Provide XL-compatible vec_round implementation.
Wed, Nov 24, 4:44 AM · Restricted Project, Restricted Project

Tue, Nov 23

nemanjai committed rGc9cb8edc519e: [PowerPC] Allow scalars for asm constraint "v" with VSX (authored by nemanjai).
[PowerPC] Allow scalars for asm constraint "v" with VSX
Tue, Nov 23, 3:03 PM
nemanjai closed D113635: [PowerPC] Allow scalars for asm constraint "v" with VSX.
Tue, Nov 23, 3:03 PM · Restricted Project
nemanjai committed rGc933c2eb3346: [PowerPC] Add BCD add/sub/cmp builtins (authored by nemanjai).
[PowerPC] Add BCD add/sub/cmp builtins
Tue, Nov 23, 9:43 AM
nemanjai closed D114088: [PowerPC] Add BCD add/sub/cmp builtins.
Tue, Nov 23, 9:42 AM · Restricted Project, Restricted Project
nemanjai added a comment to D112455: msan: disble CHECK test on powerpc64.

Just out of curiosity, what does the test case expect? I see mention of Trap() causing a zero vs. non-zero exit code. I don't really follow that since a trap is a void function that doesn't return. But I suppose this is referring to the exit code from the program which I imagine will be something like SIGABRT. Should the invocation of not in the test case just have --crash?

Tue, Nov 23, 3:35 AM · Restricted Project
nemanjai added a comment to D114419: [XCOFF] change default program code csect alignment to 32.

Just out of curiosity, if the csect that contains a function is aligned at 2 bytes, how do we ensure loops within those functions are aligned at 32 bytes?

Tue, Nov 23, 3:09 AM · Restricted Project
nemanjai accepted D114426: tsan: disable signal_sync2.cpp test on powerpc64.

Although the "one in 10" estimate seems to be a bit inflated, the test case certainly seems to be flaky so I am not opposed to disabling it. Thank you.

Tue, Nov 23, 3:05 AM · Restricted Project

Mon, Nov 22

nemanjai added inline comments to D114088: [PowerPC] Add BCD add/sub/cmp builtins.
Mon, Nov 22, 9:36 AM · Restricted Project, Restricted Project
nemanjai accepted D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

This LGTM but lets give it a few days for others to chime in with their opinion.

Mon, Nov 22, 5:46 AM · Restricted Project

Thu, Nov 18

nemanjai added a comment to D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

Add a new CMake variable similar to LLVM_OPTIMIZED_TABLEGEN? I think most people don't need comments even for their !NDEBUG builds.

Thu, Nov 18, 3:00 AM · Restricted Project

Wed, Nov 17

nemanjai requested review of D114088: [PowerPC] Add BCD add/sub/cmp builtins.
Wed, Nov 17, 6:58 AM · Restricted Project, Restricted Project

Mon, Nov 15

nemanjai accepted D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays.

LGTM. Thank you.

Mon, Nov 15, 9:35 AM · Restricted Project
nemanjai accepted D113801: [PowerPC][NFC] Add a series of codegen tests for vector reductions..

Thanks for adding these. I look forward to seeing improvements to some of these as there are a number of them that currently produce fairly terrible code.

Mon, Nov 15, 9:31 AM · Restricted Project
nemanjai added inline comments to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Mon, Nov 15, 9:27 AM · Restricted Project
nemanjai added inline comments to D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..
Mon, Nov 15, 9:24 AM · Restricted Project, Restricted Project
nemanjai accepted D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.

LGTM other than minor nits.

Mon, Nov 15, 6:00 AM · Restricted Project
nemanjai added a comment to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.

Please rebase. Does not apply cleanly to ToT.

Mon, Nov 15, 5:31 AM · Restricted Project
nemanjai requested changes to D109751: [Clang] Support conversion between PPC double-double and IEEE float128.

Please provide a description for this patch which includes justification for why we want to allow conversion between the two types.
I am of the impression that allowing the two types to coexist in completely disjoint code should be fine, but I really don't see a compelling reason to allow conversions between the two types.

Mon, Nov 15, 4:54 AM · Restricted Project

Fri, Nov 12

nemanjai accepted D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

LGTM. There are some very minor nits that can be addressed on the commit.

Fri, Nov 12, 6:50 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D111362: [PowerPC] Add support for ROP protection for 32 bit..
Fri, Nov 12, 5:36 AM · Restricted Project

Wed, Nov 10

nemanjai requested review of D113642: [PowerPC] Provide XL-compatible vec_round implementation.
Wed, Nov 10, 8:13 PM · Restricted Project, Restricted Project
nemanjai requested review of D113635: [PowerPC] Allow scalars for asm constraint "v" with VSX.
Wed, Nov 10, 5:48 PM · Restricted Project
nemanjai committed rG5840f7197d05: [PowerPC] Respect rounding mode in the back end (authored by nemanjai).
[PowerPC] Respect rounding mode in the back end
Wed, Nov 10, 6:20 AM
nemanjai closed D111433: [PowerPC] Respect rounding mode in the back end.
Wed, Nov 10, 6:20 AM · Restricted Project

Nov 8 2021

nemanjai added a comment to D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

Hmm this seems to cause some trouble when building kernels and kernel modules on FreeBSD, which are built in -ffreestanding mode, and then you get weird relocations in kernel modules:

% readelf -a ../src/sys/amd64/compile/X/modules/usr/home/kostik/work/DEV/src/sys/modules/ufs/ufs_vnops.o | grep GOT | head -3
0000000001f7 004a0000002a R_X86_64_REX_GOTP 0000000000000000 stack_chk_guard - 4
00000000060d 004a0000002a R_X86_64_REX_GOTP 0000000000000000
stack_chk_guard - 4
0000000007c8 004a0000002a R_X86_64_REX_GOTP 0000000000000000 __stack_chk_guard - 4

Maybe this should have an additional check for freestanding mode?

Nov 8 2021, 4:52 AM · Restricted Project

Nov 6 2021

nemanjai added a comment to D113178: [PowerPC] use right register class for input operand of XXPERMDIs.

...
But this does introduce confusion about register classes -- it is suspicious that xxspltd operate on f0 instead of vs0.

Ha ha, yup! Confusion about register classes is kind of a fact of life with PPC's complex overlaying of registers in a single register file. It certainly takes some time to get your mind around FP/VR/VSR/ACC registers.

Nov 6 2021, 4:41 AM · Restricted Project

Nov 5 2021

nemanjai committed rG1cb9f37a17ab: [FreeBSD] Do not mark __stack_chk_guard as dso_local (authored by adalava).
[FreeBSD] Do not mark __stack_chk_guard as dso_local
Nov 5 2021, 5:30 AM
nemanjai closed D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.
Nov 5 2021, 5:30 AM · Restricted Project
nemanjai added a comment to D113178: [PowerPC] use right register class for input operand of XXPERMDIs.

I am not in favour of this patch. The reasons I added XXPERMDIs a long time ago are:

  1. To allow a single input operand for single register splat/swap. This is useful when the input is a load (since due to chains, having a load as an input will end up with both loads emitted - i.e. no CSE).
  2. Since this is primarily useful for loads that load a partial vector (LFIWZX, etc.) the input register class is vsfrc (i.e. all scalar floating point registers).
Nov 5 2021, 4:53 AM · Restricted Project
nemanjai accepted D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.

LGTM other than a number of stylistic changes. Feel free to address those on the commit. You also might want to give @amyk a bit of time to ensure her comments were adequately addressed.

Nov 5 2021, 4:13 AM · Restricted Project
nemanjai requested changes to D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf.

I believe you are planning an update for this patch. Requesting changes to take it off the queue until you have uploaded the updated version.

Nov 5 2021, 3:35 AM · Restricted Project
nemanjai accepted D113236: [PowerPC] use correct selection for v16i8/v8i16 splat load.

LGTM. Thanks for fixing this.

Nov 5 2021, 2:20 AM · Restricted Project

Nov 4 2021

nemanjai added inline comments to D106555: [PowerPC] handle more splat loads.
Nov 4 2021, 5:08 AM · Restricted Project

Nov 3 2021

nemanjai requested changes to D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Nov 3 2021, 5:25 PM · Restricted Project

Oct 26 2021

nemanjai added inline comments to D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.
Oct 26 2021, 5:45 AM · Restricted Project, Restricted Project
nemanjai accepted D112502: [PowerPC] expand SCEV with correct type.

Seems like an obvious fix. LGTM.

Oct 26 2021, 5:34 AM · Restricted Project
nemanjai added inline comments to D112443: [SelectionDAG] Optimize expansion for rotates/funnel shifts.
Oct 26 2021, 5:10 AM · Restricted Project
nemanjai added a comment to D112443: [SelectionDAG] Optimize expansion for rotates/funnel shifts.

FWIW, the PPC changes look fine.

Oct 26 2021, 4:57 AM · Restricted Project
nemanjai requested changes to D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Oct 26 2021, 4:55 AM · Restricted Project
nemanjai added inline comments to D107886: [PowerPC] Support huge frame size for PPC64.
Oct 26 2021, 4:55 AM · Restricted Project
nemanjai added inline comments to D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Oct 26 2021, 4:18 AM · Restricted Project
nemanjai added inline comments to D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.
Oct 26 2021, 4:18 AM · Restricted Project
nemanjai accepted D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

LGTM.

Oct 26 2021, 2:17 AM · Restricted Project

Oct 19 2021

nemanjai added inline comments to D111433: [PowerPC] Respect rounding mode in the back end.
Oct 19 2021, 2:28 AM · Restricted Project

Oct 14 2021

nemanjai added a comment to D111433: [PowerPC] Respect rounding mode in the back end.

Thanks for fixing this!

I guess the reason to restrict them only undef strict-fp is performance?

Right, preventing optimization around calls due to rounding mode without -frounding-math would be unnecessarily restrictive for most compilations.

Oct 14 2021, 6:42 AM · Restricted Project

Oct 13 2021

nemanjai added reviewers for D111433: [PowerPC] Respect rounding mode in the back end: rzurob, bmahjour.
Oct 13 2021, 7:08 AM · Restricted Project

Oct 8 2021

nemanjai requested review of D111433: [PowerPC] Respect rounding mode in the back end.
Oct 8 2021, 8:57 AM · Restricted Project
nemanjai accepted D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.

LGTM. This is already approved, but just wanted to indicate that I think the comments were addressed adequately.

Oct 8 2021, 8:40 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2021

nemanjai added a comment to D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.

Please change the condition as Jinsong suggested and change the leading comment to:

// On AIX, only emit the extended mnemonics for dcbt and dcbtst if
// the "modern assembler" is available.
Oct 6 2021, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2021

nemanjai accepted D108795: [PowerPC] Fix issue with lowering byval parameters..

Significantly simpler. LGTM, thank you.

Oct 5 2021, 3:36 PM · Restricted Project

Oct 1 2021

nemanjai added inline comments to D108795: [PowerPC] Fix issue with lowering byval parameters..
Oct 1 2021, 1:47 PM · Restricted Project
nemanjai committed rG369d785574f5: [PowerPC] Optimal sequence for doubleword vec_all_{eq|ne} on Power7 (authored by nemanjai).
[PowerPC] Optimal sequence for doubleword vec_all_{eq|ne} on Power7
Oct 1 2021, 6:27 AM

Sep 30 2021

nemanjai requested changes to D108795: [PowerPC] Fix issue with lowering byval parameters..

Please try out the simpler alternative of letting the legalizer take care of the store size. If that alternative is not possible, please add comments to the patch explaining why it is not.

Sep 30 2021, 8:14 PM · Restricted Project
nemanjai accepted D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int..

LGTM as long as the sign-extending test is added.

Sep 30 2021, 6:23 PM · Restricted Project, Restricted Project
nemanjai accepted D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin.

LGTM. Please run clang-format on the patch (only the modified lines).

Sep 30 2021, 6:00 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai accepted D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.

LGTM as long as you add the back end test.

Sep 30 2021, 5:57 PM · Restricted Project, Restricted Project
nemanjai accepted D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions.

LGTM with the test nit addressed.

Sep 30 2021, 5:30 PM · Restricted Project
nemanjai added a comment to D110631: tsan: fix tls_race3 test on darwin.

@saghir Since the bots have been failing for a few days now and there is no response, please try to figure out what commit this is a fix for so we can revert all related commits until we can get to the bottom of this problem.

Sep 30 2021, 1:56 PM · Restricted Project
nemanjai accepted D110273: [PowerPC] Fix lharx and lbarx builtin signatures.

LGTM. Thanks.

Sep 30 2021, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai committed rGfad14a17a490: [PowerPC] Truncate element index for vec_insert in altivec.h (authored by nemanjai).
[PowerPC] Truncate element index for vec_insert in altivec.h
Sep 30 2021, 3:58 AM
nemanjai accepted D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

LGTM.

Sep 30 2021, 3:19 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai requested changes to D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf.

I may be wrong, but I really think this is incorrect. Please do some functional (execution) testing on this. Also, please re-title this from "truncate results" to something like "truncate exponent parameter" or similar since you are not truncating the result but the parameter.

Sep 30 2021, 3:06 AM · Restricted Project

Sep 29 2021

nemanjai added a comment to D110631: tsan: fix tls_race3 test on darwin.

Hi,

This change seems to be causing issues with Power PC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/52/builds/10906. Can you please take a look to fix/revert the change? If there is anything I could do to help investigate, please let me know.

Thanks!

Sep 29 2021, 12:20 PM · Restricted Project
nemanjai committed rG09b67aa1c382: [PowerPC] Implement builtin for vbpermd (authored by nemanjai).
[PowerPC] Implement builtin for vbpermd
Sep 29 2021, 4:35 AM
nemanjai closed D107899: [PowerPC] Implement builtin for vbpermd.
Sep 29 2021, 4:35 AM · Restricted Project, Restricted Project
nemanjai committed rGc9539f957f57: [PowerPC] Define XL-compatible macros only for AIX and Linux (authored by nemanjai).
[PowerPC] Define XL-compatible macros only for AIX and Linux
Sep 29 2021, 4:15 AM
nemanjai closed D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux.
Sep 29 2021, 4:15 AM · Restricted Project

Sep 28 2021

nemanjai added a comment to D106191: [clang] Option control afn flag.

Added @jansvoboda11 to the review as it appears he was the one that added the original option.

Sep 28 2021, 6:41 PM · Restricted Project, Restricted Project
nemanjai added a reviewer for D106191: [clang] Option control afn flag: jansvoboda11.
Sep 28 2021, 6:41 PM · Restricted Project, Restricted Project
nemanjai accepted D106959: [PowerPC] swdiv builtins for XL compatibility.

LGTM. Please note in the commit message that this is simply a wrapper for a floating point divide. XL provided this builtin because it doesn't produce software estimates by default at -Ofast.

Sep 28 2021, 6:27 PM · Restricted Project, Restricted Project
nemanjai accepted D109178: [PowerPC] Disable vector types when not supported by subtarget features.

LGTM.

Sep 28 2021, 6:23 PM · Restricted Project
nemanjai accepted D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus..

LGTM. Thanks.

Sep 28 2021, 6:02 PM · Restricted Project, Restricted Project
nemanjai requested changes to D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

I really don't understand what happened now. It seems that you have simply reverted to an older version of this patch. The test case appears to not have been pre-committed any longer, the Power9 patterns and test cases are gone. What has happened here?

Sep 28 2021, 4:53 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai accepted D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

LGTM.

Sep 28 2021, 4:49 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D110629: tsan: fix cur_thread alignment.

Thank you for fixing this.

Sep 28 2021, 4:40 PM · Restricted Project
nemanjai added inline comments to D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Sep 28 2021, 5:42 AM · Restricted Project