Page MenuHomePhabricator
People gkistanova

gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (420 w, 3 d)

Recent Activity
View All

Wed, Apr 7

gkistanova committed rZORGa9e099490c78: Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder." (authored by gkistanova).
Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder."
Wed, Apr 7, 12:40 PM
gkistanova added a reverting change for rZORG13c3c22377e3: Respect jobs property for LIT tests in UnifiedTreeBuilder.: rZORGa9e099490c78: Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder.".
Wed, Apr 7, 12:40 PM
gkistanova added a comment to D97389: added section on CI system.

Thanks for updating the LLVM Developer Policy, Christian.
It looks good with a couple nit picks.

Wed, Apr 7, 12:02 PM · Restricted Project

Tue, Apr 6

gkistanova accepted D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Tue, Apr 6, 12:52 PM
gkistanova accepted D99985: Enable build_standalone in LibcxxAndAbiBuilder.

LGTM

Tue, Apr 6, 12:51 PM
gkistanova added a comment to D99894: [zorg] Add buildbot for HIP.

Everything else looks Ok.

Tue, Apr 6, 10:26 AM
gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Looks fine.

Tue, Apr 6, 10:15 AM

Thu, Mar 25

gkistanova accepted D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Thu, Mar 25, 12:02 PM

Wed, Mar 24

gkistanova added a comment to D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

Hm. This is weird.
I see a wrong patch assigned to this review now.,

Wed, Mar 24, 3:30 PM · Restricted Project
gkistanova accepted D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

LGTM

Wed, Mar 24, 3:22 PM · Restricted Project
gkistanova accepted D98647: [zorg][PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

LGTM

Wed, Mar 24, 1:57 PM · Restricted Project
gkistanova accepted D99097: [zorg] [PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite instead of LNT.

LGTM

Wed, Mar 24, 1:45 PM · Restricted Project, Restricted Project
gkistanova accepted D99216: [libc] Add a full build worker and two builders to run on it..

LGTM

Wed, Mar 24, 1:42 PM
gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Almost there.
One problem to fix.

Wed, Mar 24, 1:40 PM

Tue, Mar 23

gkistanova committed rZORG13c3c22377e3: Respect jobs property for LIT tests in UnifiedTreeBuilder. (authored by gkistanova).
Respect jobs property for LIT tests in UnifiedTreeBuilder.
Tue, Mar 23, 11:01 AM

Sat, Mar 20

gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

I have added the support you need to UnifiedTreeBuilder.

Sat, Mar 20, 11:57 AM
gkistanova committed rZORG8f5c30cb3af8: Added support for a new src_to_build_dir argument to UnifiedTreeBuilder to… (authored by gkistanova).
Added support for a new src_to_build_dir argument to UnifiedTreeBuilder to…
Sat, Mar 20, 11:48 AM
gkistanova committed rZORG5a63cfb04642: Added support for a new src_to_build_dir argument to LLVMBuildFactory to… (authored by gkistanova).
Added support for a new src_to_build_dir argument to LLVMBuildFactory to…
Sat, Mar 20, 11:46 AM

Fri, Mar 19

gkistanova accepted D98961: Add a mailer config for MLIR testing bots to Google build monitoring mailing-list.

LGTM

Fri, Mar 19, 8:12 PM
gkistanova added a comment to D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

There are few comments for the buildbot part.

Fri, Mar 19, 2:10 PM · Restricted Project

Mar 12 2021

gkistanova accepted D97943: [XCore] Build fewer components. Run 4 parallel jobs..

LGTM

Mar 12 2021, 10:31 PM

Mar 2 2021

gkistanova accepted D97607: Added openmp doxygen; increased the doxygent step timeout, as it could take a long time without anything in TTY..

LGTM

Mar 2 2021, 7:49 PM · Restricted Project
gkistanova accepted D97626: Add check-flang option to some of the Flang builders..

LGTM

Mar 2 2021, 7:49 PM
gkistanova accepted D97678: Add Flang builder for latest gcc..

Looks good with a couple of nit picks.
Please see my comments in line.

Mar 2 2021, 7:48 PM
gkistanova accepted D97685: Add Flang builder for latest llvm and libc++..

Looks good with a couple nit picks.
Please see my comments in line.

Mar 2 2021, 7:45 PM
gkistanova accepted D97270: Add buildbot for Clang for XCore target on Ubuntu host..

It is good with a couple of small things to address.

Mar 2 2021, 7:37 PM
gkistanova requested changes to D97326: [zorg] Adjust libcxx buildbot config on AIX.

It seems this patch needs more attention.
Please see my comments above.

Mar 2 2021, 6:15 PM
gkistanova reopened D97326: [zorg] Adjust libcxx buildbot config on AIX.

I'm not sure I follow what are you trying to achieve by changing the src_root.

Mar 2 2021, 6:14 PM
gkistanova committed rZORG4cd2689758e9: Fixed mistype in LibcxxAndAbiBuilder.py introduced by… (authored by gkistanova).
Fixed mistype in LibcxxAndAbiBuilder.py introduced by…
Mar 2 2021, 5:43 PM
gkistanova accepted D97492: Enable mlir integration tests on the mlir-nvidia bot..

Christian, do you need a help with committing this patch? You should be good if you have LLVM commit permissions, but please let me know if you want me to commit.

Mar 2 2021, 12:08 PM

Feb 24 2021

gkistanova committed rZORG388283cab6e6: Fixed misspelled builder name for e-mail notifications. (authored by gkistanova).
Fixed misspelled builder name for e-mail notifications.
Feb 24 2021, 7:19 PM

Feb 21 2021

gkistanova accepted D97180: Add myself to be notified for sie-linux-builder failures..

LGTM

Feb 21 2021, 11:27 PM · Restricted Project
gkistanova accepted D96814: [zorg] Add runtimes buildbot for AIX.

LGTM.

Feb 21 2021, 11:26 PM
gkistanova accepted D96857: Add flang release buildbot..

LGTM

Feb 21 2021, 11:25 PM
gkistanova accepted D96858: Add flang release with assertions buildbot..

LGTM

Feb 21 2021, 11:25 PM
gkistanova committed rZORGc8a67928ed44: One GitHubStatusPush reporter is enough for our needs. (authored by gkistanova).
One GitHubStatusPush reporter is enough for our needs.
Feb 21 2021, 11:02 PM
gkistanova committed rZORGa7c344aac55c: Added builders to build the release/* branches. (authored by gkistanova).
Added builders to build the release/* branches.
Feb 21 2021, 10:39 PM
gkistanova accepted D96859: Add flang debug new driver buildbot..

LGTM

Feb 21 2021, 9:35 PM
gkistanova committed rZORG715a15486bbe: And missing import log. (authored by gkistanova).
And missing import log.
Feb 21 2021, 9:28 PM
gkistanova committed rZORG40fad5ed61e6: NFC. Changed getLntSchedulers() to follow the code style of the rest of the… (authored by gkistanova).
NFC. Changed getLntSchedulers() to follow the code style of the rest of the…
Feb 21 2021, 9:14 PM
gkistanova committed rZORG8fcbe87507f1: NFC. Better names, more logs. (authored by gkistanova).
NFC. Better names, more logs.
Feb 21 2021, 9:09 PM
gkistanova committed rZORGdbb86b2e3711: Some builders.py cleaning. (authored by gkistanova).
Some builders.py cleaning.
Feb 21 2021, 8:39 PM

Feb 18 2021

gkistanova committed rZORG121236994a46: Updated requirements. (authored by gkistanova).
Updated requirements.
Feb 18 2021, 1:41 PM

Feb 17 2021

gkistanova committed rZORG9dd7fae7a9e8: Updated tags and removed redundant configure args for llvm-clang-x86_64… (authored by gkistanova).
Updated tags and removed redundant configure args for llvm-clang-x86_64…
Feb 17 2021, 10:37 PM
gkistanova committed rZORGa0380870f2f3: NFC. Some getSingleBranchSchedulers code cleaning. (authored by gkistanova).
NFC. Some getSingleBranchSchedulers code cleaning.
Feb 17 2021, 8:08 PM

Feb 10 2021

gkistanova committed rZORGa5620382beb1: Support branches with the ForceSchedulers. (authored by gkistanova).
Support branches with the ForceSchedulers.
Feb 10 2021, 9:11 PM

Feb 8 2021

gkistanova accepted D95867: Support compatibility with buildbot 2.10..

Thanks, Stevan!

Feb 8 2021, 9:19 PM
gkistanova accepted D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Thanks!

Feb 8 2021, 9:18 PM
gkistanova accepted D96129: Add flang out-of-tree new driver buildbot..

LGTM

Feb 8 2021, 9:15 PM

Feb 4 2021

gkistanova accepted D94885: Add SIE linux build bot.

LGTM

Feb 4 2021, 8:22 PM · Restricted Project
gkistanova committed rZORGebc8133a89be: Removed lld-x86_64-freebsd builder. (authored by gkistanova).
Removed lld-x86_64-freebsd builder.
Feb 4 2021, 8:12 PM
gkistanova requested changes to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Almost there. One more change it will be ready to land.

Feb 4 2021, 8:06 PM
gkistanova accepted D96073: Add Python binary path to CMake arguments for the clang-ppc64le-linux builder.

LGTM

Feb 4 2021, 7:43 PM · Restricted Project, Restricted Project

Jan 22 2021

gkistanova requested changes to D94885: Add SIE linux build bot.

Please see my comments inline.

Jan 22 2021, 12:02 AM · Restricted Project

Jan 21 2021

gkistanova accepted D95054: Add a libc aarch64 worker and a debug builder running on it..

LGTM.

Jan 21 2021, 11:57 PM
gkistanova accepted D94600: Fix Windows-on-Arm buildbots.

LGTM.

Jan 21 2021, 5:58 PM
gkistanova accepted D94886: Update name to workers.py file in documentation.

Thanks, Douglas, for fixing this!

Jan 21 2021, 5:15 PM · Restricted Project

Dec 12 2020

gkistanova committed rZORGa59a01630178: Fixed bad identation in ClangLTOBuilder. (authored by gkistanova).
Fixed bad identation in ClangLTOBuilder.
Dec 12 2020, 9:34 PM
gkistanova accepted D92903: Added DoxygenDocsBuilder to build and publish doxygen documentation..

LGTM.

Dec 12 2020, 9:05 PM
gkistanova accepted D92905: Added getHtmlDocsBuildFactory to build and publish LNT documentation..

LGTM.

Dec 12 2020, 9:05 PM

Dec 8 2020

gkistanova accepted D91474: [buildbot] Fix worker for ThinLTO whole program devirtualization.

Hi Teresa,

Dec 8 2020, 9:18 PM
gkistanova committed rZORGe0fad68331d7: Listen for the main branch. (authored by gkistanova).
Listen for the main branch.
Dec 8 2020, 6:25 PM
gkistanova committed rZORG87fcb5ae44d7: Improved InformativeMailNotifier. (authored by gkistanova).
Improved InformativeMailNotifier.
Dec 8 2020, 5:53 PM

Dec 6 2020

gkistanova committed rZORGaef83363104c: Added GitPoller and schedulers for the llvm-lnt repo. (authored by gkistanova).
Added GitPoller and schedulers for the llvm-lnt repo.
Dec 6 2020, 9:06 PM
gkistanova committed rZORGad0febf854a3: Do not collapse buildrequests with different properties. (authored by gkistanova).
Do not collapse buildrequests with different properties.
Dec 6 2020, 8:57 PM

Dec 1 2020

gkistanova accepted D91809: [libc++] Remove several bots that now exist in Buildkite.

I guess that's D92426.

Dec 1 2020, 4:43 PM
gkistanova accepted D92426: [libc++] Remove now unused libc++ workers.

LGTM

Dec 1 2020, 4:41 PM
gkistanova requested changes to D91809: [libc++] Remove several bots that now exist in Buildkite.
Dec 1 2020, 1:27 PM
gkistanova reopened D91809: [libc++] Remove several bots that now exist in Buildkite.

Sorry if I wasn't clear enough with my request.

Dec 1 2020, 1:27 PM

Nov 30 2020

gkistanova accepted D91205: Update string formatting for AnnotatedCommand to support Python >3.7. .

LGTM

Nov 30 2020, 6:09 PM · Restricted Project
gkistanova added a comment to D91809: [libc++] Remove several bots that now exist in Buildkite.

Does any worker go away too?

Nov 30 2020, 12:30 PM

Nov 25 2020

gkistanova committed rZORGacf138fae1ad: Do not collapse build requests with different property sets. (authored by gkistanova).
Do not collapse build requests with different property sets.
Nov 25 2020, 9:15 PM

Nov 17 2020

gkistanova accepted D91400: Updates to ALCF Theta Buildbot.

LGTM.

Nov 17 2020, 10:22 PM · Restricted Project
gkistanova committed rZORGa6fe99bffd1d: Support reloading the buildbot config. (authored by gkistanova).
Support reloading the buildbot config.
Nov 17 2020, 9:12 PM
gkistanova committed rZORG609931a6e83a: Added support for buid targets to UnifiedTreeBuilder. (authored by gkistanova).
Added support for buid targets to UnifiedTreeBuilder.
Nov 17 2020, 8:51 PM

Nov 10 2020

gkistanova committed rZORG834282c5275a: Changed builddir to match the builder name. builddir must be unique. (authored by gkistanova).
Changed builddir to match the builder name. builddir must be unique.
Nov 10 2020, 7:25 PM

Nov 9 2020

gkistanova accepted D91116: Add flang docs to SphinxDocsBuilder..

LGTM

Nov 9 2020, 9:18 PM · Restricted Project, Restricted Project
gkistanova added a comment to D90959: [zorg][Fuchsia] Run check-lld with 32 jobs.

Specifying 32 jobs as a hard coded value in the build factory does not look right. You may want to parametrize this somehow.

Nov 9 2020, 1:28 PM · Restricted Project
gkistanova accepted D90986: Worker for Theta supercomputer at ALCF with Flang builder.

LGTM

Nov 9 2020, 1:17 PM · Restricted Project
gkistanova accepted D91031: Add new worker debian-akiko-m68k for Linux 32-bit M68k.

LGTM

Nov 9 2020, 1:17 PM
gkistanova accepted D90883: Updated the step completition detection for annotated steps..

Thanks, Vlad!
Looks good with a nitpick.

Nov 9 2020, 1:15 PM · Restricted Project

Nov 6 2020

gkistanova added a comment to D89824: Add a LLDB buildbot builder for FreeBSD .

Thanks for changing the names,
Please feel free to commit.

Nov 6 2020, 9:58 AM

Nov 3 2020

gkistanova committed rZORG533cd1f06216: NFC. Updated comment. (authored by gkistanova).
NFC. Updated comment.
Nov 3 2020, 7:34 PM
gkistanova committed rZORG6e6cb73964c3: Limit clang-sparc64-linux-multistage to Sparc target. (authored by glaubitz).
Limit clang-sparc64-linux-multistage to Sparc target.
Nov 3 2020, 11:06 AM
gkistanova closed D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.
Nov 3 2020, 11:06 AM
gkistanova committed rZORGe08eebb6e751: Limit parallel link jobs to 4 for clang-sparc64-linux-multistage. (authored by glaubitz).
Limit parallel link jobs to 4 for clang-sparc64-linux-multistage.
Nov 3 2020, 11:06 AM
gkistanova closed D90530: [zorg] Limit parallel link jobs to 4 for clang-sparc64-linux-multistage.
Nov 3 2020, 11:06 AM

Nov 2 2020

gkistanova accepted D89824: Add a LLDB buildbot builder for FreeBSD .

LGTM with a nitpick.

Nov 2 2020, 9:52 PM
gkistanova accepted D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.

Hi Adrian,

Nov 2 2020, 9:50 PM
gkistanova accepted D90530: [zorg] Limit parallel link jobs to 4 for clang-sparc64-linux-multistage.

LGTM.

Nov 2 2020, 9:49 PM

Oct 30 2020

gkistanova committed rZORG6e69134d8602: Configure reporters for production and staging buildbot differently. (authored by gkistanova).
Configure reporters for production and staging buildbot differently.
Oct 30 2020, 8:46 PM
gkistanova committed rZORG43a84c669d6c: NFC. Some comments and code formatting. (authored by gkistanova).
NFC. Some comments and code formatting.
Oct 30 2020, 6:10 PM
gkistanova committed rZORGfad99832df6b: Extra mail notifiers should not report to blamelist. We have a designated… (authored by gkistanova).
Extra mail notifiers should not report to blamelist. We have a designated…
Oct 30 2020, 5:57 PM

Oct 29 2020

gkistanova committed rZORGee7625f29798: Updated requirements. (authored by gkistanova).
Updated requirements.
Oct 29 2020, 8:42 PM
gkistanova committed rZORG327577737ff6: Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC (authored by glaubitz).
Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC
Oct 29 2020, 12:10 AM
gkistanova closed D90148: [zorg] Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC.
Oct 29 2020, 12:10 AM

Oct 28 2020

gkistanova accepted D90263: [zorg][PowerPC] Add tags for builders.

LGTM.

Oct 28 2020, 12:18 PM
gkistanova accepted D90148: [zorg] Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC.

LGTM.

Oct 28 2020, 12:18 PM
gkistanova accepted D90308: [flang] Switch from check-all to check-flang.

LGTM.

Oct 28 2020, 12:16 PM

Oct 27 2020

gkistanova committed rZORG70bbd3b38576: Posix paths in CMAKE_C_COMPILER and CMAKE_CXX_COMPILER. (authored by gkistanova).
Posix paths in CMAKE_C_COMPILER and CMAKE_CXX_COMPILER.
Oct 27 2020, 10:43 AM