User Details
- User Since
- Mar 22 2013, 2:32 PM (420 w, 3 d)
Wed, Apr 7
Thanks for updating the LLVM Developer Policy, Christian.
It looks good with a couple nit picks.
Tue, Apr 6
Everything else looks Ok.
Looks fine.
Thu, Mar 25
Wed, Mar 24
Hm. This is weird.
I see a wrong patch assigned to this review now.,
LGTM
LGTM
LGTM
LGTM
Almost there.
One problem to fix.
Tue, Mar 23
Sat, Mar 20
I have added the support you need to UnifiedTreeBuilder.
Fri, Mar 19
LGTM
There are few comments for the buildbot part.
Mar 12 2021
LGTM
Mar 2 2021
LGTM
LGTM
Looks good with a couple of nit picks.
Please see my comments in line.
Looks good with a couple nit picks.
Please see my comments in line.
It is good with a couple of small things to address.
It seems this patch needs more attention.
Please see my comments above.
I'm not sure I follow what are you trying to achieve by changing the src_root.
Christian, do you need a help with committing this patch? You should be good if you have LLVM commit permissions, but please let me know if you want me to commit.
Feb 24 2021
Feb 21 2021
LGTM
Feb 18 2021
Feb 17 2021
Feb 10 2021
Feb 8 2021
Thanks, Stevan!
Thanks!
Feb 4 2021
Almost there. One more change it will be ready to land.
LGTM
Jan 22 2021
Please see my comments inline.
Jan 21 2021
LGTM.
Thanks, Douglas, for fixing this!
Dec 12 2020
LGTM.
LGTM.
Dec 8 2020
Hi Teresa,
Dec 6 2020
Dec 1 2020
I guess that's D92426.
Sorry if I wasn't clear enough with my request.
Nov 30 2020
LGTM
Does any worker go away too?
Nov 25 2020
Nov 17 2020
LGTM.
Nov 10 2020
Nov 9 2020
LGTM
Specifying 32 jobs as a hard coded value in the build factory does not look right. You may want to parametrize this somehow.
LGTM
LGTM
Thanks, Vlad!
Looks good with a nitpick.
Nov 6 2020
Thanks for changing the names,
Please feel free to commit.
Nov 3 2020
Nov 2 2020
LGTM with a nitpick.
Hi Adrian,
LGTM.
Oct 30 2020
Oct 29 2020
Oct 28 2020
LGTM.