Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (177 w, 18 h)

Recent Activity

Thu, Oct 15

stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Fixed a couple of comments.
Moved the R_PPC64_DTPREL34 case first and adjusted the dynamic thread offset
there before falling through to the common case.

Thu, Oct 15, 4:01 AM · Restricted Project

Tue, Oct 13

stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Fixed the issue where the 0x8000 offset was not being considered.

Tue, Oct 13, 10:53 AM · Restricted Project
stefanp added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Tue, Oct 13, 10:25 AM · Restricted Project
stefanp accepted D88738: [PowerPC][PCRelative] Turn on TLS support for PCRel by default.

LGTM

Tue, Oct 13, 6:03 AM · Restricted Project

Fri, Oct 9

stefanp committed rG0741a2c9caca: [Clang][unittests][NFC] Break up test in Callbacks.cpp (authored by stefanp).
[Clang][unittests][NFC] Break up test in Callbacks.cpp
Fri, Oct 9, 6:54 AM
stefanp closed D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.
Fri, Oct 9, 6:54 AM · Restricted Project

Thu, Oct 8

stefanp updated the diff for D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.

Added the missing header file.
Added the license comment.

Thu, Oct 8, 7:25 AM · Restricted Project

Tue, Oct 6

stefanp added a comment to D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.

Related to this please see Nemanja's comment on https://reviews.llvm.org/D82485.

Tue, Oct 6, 4:23 AM · Restricted Project
stefanp added reviewers for D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp: gribozavr, ymandel, eduucaldas.
Tue, Oct 6, 4:20 AM · Restricted Project
stefanp requested review of D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.
Tue, Oct 6, 4:18 AM · Restricted Project

Fri, Oct 2

stefanp added a comment to D88591: [WebAssembly] Emulate v128.const efficiently.

I can confirm that this changeset is causing the timeout on the clang-ppc64be-linux buildbot.
The following was run on a Big Endian Power PC machine.

Fri, Oct 2, 9:34 AM · Restricted Project
stefanp updated the summary of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Fri, Oct 2, 9:14 AM · Restricted Project
stefanp added a comment to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

All of the dependencies of this patch have now been committed.

Fri, Oct 2, 9:13 AM · Restricted Project
stefanp added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Fri, Oct 2, 9:09 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Rebased to top of trunk.
Fixed a couple of comments.
Removed some lines that are not required form the test.

Fri, Oct 2, 9:09 AM · Restricted Project

Thu, Oct 1

stefanp added a comment to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Ok, thank you MaskRay.
Sorry, in my head I didn't put the error together with what you had said previously.

Thu, Oct 1, 5:01 PM · Restricted Project
stefanp added a comment to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Looks like .rela.dyn is located in different places depending on the machine.
From two different bots:

# GDTOIE-RELOC: Relocation section '.rela.dyn' at offset 0x10118 contains 2 entries:
                ^
<stdin>:2:1: note: scanning from here
Relocation section '.rela.dyn' at offset 0x10128 contains 2 entries:

or

# GDTOIE-RELOC: Relocation section '.rela.dyn' at offset 0x10118 contains 2 entries:
                ^
<stdin>:2:1: note: scanning from here
Relocation section '.rela.dyn' at offset 0x10148 contains 2 entries:
Thu, Oct 1, 12:13 PM · Restricted Project
stefanp reopened D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Reopening this to see why the test failed.

Thu, Oct 1, 12:07 PM · Restricted Project
stefanp added a reverting change for rG79122868f9a3: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General…: rG5f3e565f59ee: Revert "[LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS….
Thu, Oct 1, 11:29 AM
stefanp committed rG5f3e565f59ee: Revert "[LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS… (authored by stefanp).
Revert "[LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS…
Thu, Oct 1, 11:29 AM
stefanp added a reverting change for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic: rG5f3e565f59ee: Revert "[LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS….
Thu, Oct 1, 11:29 AM · Restricted Project
stefanp committed rG79122868f9a3: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General… (authored by stefanp).
[LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General…
Thu, Oct 1, 11:01 AM
stefanp closed D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Thu, Oct 1, 11:01 AM · Restricted Project
stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Updated the comment.

Thu, Oct 1, 4:18 AM · Restricted Project

Wed, Sep 30

stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Further reduced the test case.

Wed, Sep 30, 11:05 AM · Restricted Project
stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Removed the last test from the test assembly file.

Wed, Sep 30, 9:35 AM · Restricted Project
stefanp accepted D88586: [zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot.

LGTM

Wed, Sep 30, 9:14 AM · Restricted Project

Tue, Sep 29

stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Updated a number of formatting issues.
Updated the test case to remove instructions that are not needed.

Tue, Sep 29, 8:05 AM · Restricted Project

Fri, Sep 25

stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Rebased this patch on top of master and on top of the updated D87318.
This patch does depend on D87318.

Fri, Sep 25, 11:58 AM · Restricted Project
stefanp added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Fri, Sep 25, 9:14 AM · Restricted Project
stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Addressed a number of nits.
Added an NFC change before this patch and rebased this patch.

Fri, Sep 25, 9:13 AM · Restricted Project
stefanp committed rG8c53282d64b2: [PowerPC][NFC] Merged two switch entries. (authored by stefanp).
[PowerPC][NFC] Merged two switch entries.
Fri, Sep 25, 7:49 AM
stefanp committed rGd224175230d1: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits (authored by stefanp).
[PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits
Fri, Sep 25, 4:39 AM
stefanp closed D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Fri, Sep 25, 4:39 AM · Restricted Project
stefanp updated the diff for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

Fixed last nits.

Fri, Sep 25, 4:38 AM · Restricted Project

Wed, Sep 23

stefanp updated the diff for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

Added const in two places.
Added split-file.

Wed, Sep 23, 3:54 AM · Restricted Project

Tue, Sep 22

stefanp updated the diff for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

Added PHDRS to try to avoid large binary files.

Tue, Sep 22, 5:41 PM · Restricted Project
stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Fixed spacing that I missed.

Tue, Sep 22, 5:20 PM · Restricted Project
stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

Rebased this patch to Top of Trunk.
Fixed all of the error to errorOrWarn.
Made use of NOP.

Tue, Sep 22, 5:18 PM · Restricted Project
stefanp updated the diff for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

Fixed 24 to 26 bits as the 24 bits was not correct.
Added mayUseShortThunk handling.

Tue, Sep 22, 11:55 AM · Restricted Project
stefanp added a comment to D87071: [Scheduling] Add a mutation to schedule GOT indirect instructions close to each other for linker optimization.

Overall I think that the patch looks good. I just had a couple of comments.
Thank you for finding the issues related to the peephole!

Tue, Sep 22, 8:47 AM · Restricted Project
stefanp committed rG7e78d89052b1: [PowerPC] Fix for compiler side issue in PCRelative Local Exec (authored by stefanp).
[PowerPC] Fix for compiler side issue in PCRelative Local Exec
Tue, Sep 22, 6:28 AM
stefanp closed D88030: [PowerPC] Fix for compiler side issue in PCRelative Local Exec.
Tue, Sep 22, 6:28 AM · Restricted Project
stefanp committed rGc0071862bb42: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec (authored by stefanp).
[PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec
Tue, Sep 22, 3:49 AM
stefanp closed D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Tue, Sep 22, 3:49 AM · Restricted Project

Mon, Sep 21

stefanp accepted D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.

You can probably merge pcrel-tls-local-dynamic-address-load-reloc.s and pcrel-tls-local-dynamic-value-load-reloc.s.
They are short test cases and they are testing almost exactly the same thing.

Mon, Sep 21, 2:09 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Added the linker script to the test file.
Added a check for the GOT.

Mon, Sep 21, 12:15 PM · Restricted Project
stefanp added reviewers for D88030: [PowerPC] Fix for compiler side issue in PCRelative Local Exec: NeHuang, sfertile, Restricted Project.
Mon, Sep 21, 9:29 AM · Restricted Project
stefanp requested review of D88030: [PowerPC] Fix for compiler side issue in PCRelative Local Exec.
Mon, Sep 21, 9:28 AM · Restricted Project
stefanp added inline comments to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Mon, Sep 21, 7:59 AM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Updated error to errorOrWarn.
Merged the two test files.
Removed extra assembly from test case.

Mon, Sep 21, 7:59 AM · Restricted Project

Sep 18 2020

stefanp added a comment to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

@MaskRay
FYI: All of the dependent patches have landed so you should now be able to just apply this patch on top of trunk.

Sep 18 2020, 12:11 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Updated the patch to use the NOP constant.

Sep 18 2020, 12:08 PM · Restricted Project
stefanp added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Sep 18 2020, 10:52 AM · Restricted Project
stefanp added reviewers for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits: sfertile, NeHuang, Restricted Project.
Sep 18 2020, 9:24 AM · Restricted Project
stefanp requested review of D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Sep 18 2020, 9:23 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Updated test case to check for .got.
Used warningOrErr.
Used NOP.

Sep 18 2020, 7:14 AM · Restricted Project

Sep 15 2020

stefanp committed rG65f6810d3a4b: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec (authored by stefanp).
[LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec
Sep 15 2020, 7:08 AM
stefanp closed D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Sep 15 2020, 7:07 AM · Restricted Project

Sep 14 2020

stefanp added inline comments to D87486: [ELF] Define a reportRangeError() overload for thunks and tidy up recent PPC64 thunk range errors.
Sep 14 2020, 8:59 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Replace error() with errorOrWarn().

Sep 14 2020, 7:34 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Fixed formatting in source file.
Fixed spacing in test file.

Sep 14 2020, 7:28 AM · Restricted Project
stefanp added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Sep 14 2020, 6:12 AM · Restricted Project

Sep 11 2020

stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

I've updated the description to only use the correct version of the relocation: R_PPC64_GOT_TLSGD_PCREL34.

Sep 11 2020, 2:36 PM · Restricted Project
stefanp updated the summary of D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Sep 11 2020, 2:00 PM · Restricted Project
stefanp added inline comments to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Sep 11 2020, 12:06 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Fixed formatting and comments in a few places.
Added --soname to the test file.

Sep 11 2020, 12:05 PM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Thank you for the reviews!

Sep 11 2020, 7:20 AM · Restricted Project
stefanp updated the summary of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Sep 11 2020, 4:02 AM · Restricted Project
stefanp updated the summary of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Sep 11 2020, 3:58 AM · Restricted Project
stefanp added reviewers for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic: NeHuang, sfertile.
Sep 11 2020, 3:56 AM · Restricted Project
stefanp requested review of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Sep 11 2020, 3:55 AM · Restricted Project

Sep 8 2020

stefanp added a comment to D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

It seems that most builders do have the extra_configure_args parameter but the builder that we use here does not.
You may have to add the parameter to the build factory to get this to work.

Sep 8 2020, 3:31 PM · Restricted Project
stefanp accepted D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

This mostly LGTM.
From my perspective you can add no-show-raw-insn on commit.

Sep 8 2020, 12:08 PM · Restricted Project, Restricted Project
stefanp requested review of D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Sep 8 2020, 11:50 AM · Restricted Project

Sep 3 2020

stefanp retitled D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec from [PowerPC] Add support for TLS Initial Exec to [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Sep 3 2020, 12:22 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Removed a couple of variables that could be inlined.
Added an error in case the offset from the 4 byte alignment is 2 or 3.
Moved checks in the test case.

Sep 3 2020, 12:21 PM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Fixed a couple of things on the test case.
Added the function name inside <>:.
Removed the .size directives.
Added SYMBOL-NEXT: where possible.

Sep 3 2020, 10:38 AM · Restricted Project
stefanp added inline comments to D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Sep 3 2020, 4:32 AM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Removed the linker script that was not needed.
Added a quick summary of the test case.

Sep 3 2020, 4:32 AM · Restricted Project
stefanp committed rGf4f29b956c62: [PowerPC] Fix missing TLS symbol type. (authored by stefanp).
[PowerPC] Fix missing TLS symbol type.
Sep 3 2020, 3:57 AM
stefanp closed D86777: [PowerPC] Fix missing TLS symbol type..
Sep 3 2020, 3:57 AM · Restricted Project
stefanp updated the diff for D86777: [PowerPC] Fix missing TLS symbol type..

Fixed nit and moved the position of the case in the switch.

Sep 3 2020, 3:34 AM · Restricted Project

Sep 1 2020

stefanp added a comment to D86777: [PowerPC] Fix missing TLS symbol type..

I'll not say this is a bug. For an undefined symbol, STT_TLS is not strictly required. For a definition, STT_TLS is indeed better.

Sep 1 2020, 12:18 PM · Restricted Project

Aug 31 2020

stefanp updated the summary of D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Aug 31 2020, 12:52 PM · Restricted Project
stefanp requested review of D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Aug 31 2020, 12:51 PM · Restricted Project

Aug 28 2020

stefanp requested review of D86777: [PowerPC] Fix missing TLS symbol type..
Aug 28 2020, 4:58 AM · Restricted Project

Aug 26 2020

stefanp requested review of D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Aug 26 2020, 4:08 AM · Restricted Project

Aug 24 2020

stefanp accepted D86343: [PowerPC] Use SDISel instead of FISel for calls and TOC-based accesses with PC-Rel.

LGTM

Aug 24 2020, 1:51 PM · Restricted Project
stefanp added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Aug 24 2020, 12:09 PM · Restricted Project, Restricted Project

Aug 21 2020

stefanp committed rG0cadd162b7c1: Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0 (authored by stefanp).
Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0
Aug 21 2020, 11:23 AM
stefanp committed rG02e02f5398d0: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD (authored by stefanp).
[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD
Aug 21 2020, 10:56 AM
stefanp closed D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 21 2020, 10:56 AM · Restricted Project
stefanp requested changes to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Also, please add a test where the offset is not zero.
So the assembly would be for example:

paddi 3, 13, x@TPREL+8, 0
Aug 21 2020, 5:55 AM · Restricted Project, Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Adjusted one comment and moved the code around to merge the two errorOrWarn.

Aug 21 2020, 3:46 AM · Restricted Project

Aug 20 2020

stefanp accepted D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Only minor nits form me.
LGTM.

Aug 20 2020, 2:27 PM · Restricted Project, Restricted Project
stefanp accepted D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Couple of nits.
LGTM

Aug 20 2020, 2:00 PM · Restricted Project, Restricted Project
stefanp added inline comments to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 20 2020, 4:20 AM · Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Updated the comment to make it more concise.
Updated the test case to add the missing : .

Aug 20 2020, 4:19 AM · Restricted Project

Aug 19 2020

stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Fix some formatting.
Fix a couple of nits.
Add the --triple to the test case.

Aug 19 2020, 11:21 AM · Restricted Project