- User Since
- May 29 2017, 8:02 AM (177 w, 18 h)
Thu, Oct 15
Fixed a couple of comments.
Moved the R_PPC64_DTPREL34 case first and adjusted the dynamic thread offset
there before falling through to the common case.
Tue, Oct 13
Fixed the issue where the 0x8000 offset was not being considered.
Fri, Oct 9
Thu, Oct 8
Added the missing header file.
Added the license comment.
Tue, Oct 6
Related to this please see Nemanja's comment on https://reviews.llvm.org/D82485.
Fri, Oct 2
I can confirm that this changeset is causing the timeout on the clang-ppc64be-linux buildbot.
The following was run on a Big Endian Power PC machine.
All of the dependencies of this patch have now been committed.
Rebased to top of trunk.
Fixed a couple of comments.
Removed some lines that are not required form the test.
Thu, Oct 1
Ok, thank you MaskRay.
Sorry, in my head I didn't put the error together with what you had said previously.
Looks like .rela.dyn is located in different places depending on the machine.
From two different bots:
# GDTOIE-RELOC: Relocation section '.rela.dyn' at offset 0x10118 contains 2 entries: ^ <stdin>:2:1: note: scanning from here Relocation section '.rela.dyn' at offset 0x10128 contains 2 entries:
# GDTOIE-RELOC: Relocation section '.rela.dyn' at offset 0x10118 contains 2 entries: ^ <stdin>:2:1: note: scanning from here Relocation section '.rela.dyn' at offset 0x10148 contains 2 entries:
Reopening this to see why the test failed.
Updated the comment.
Wed, Sep 30
Further reduced the test case.
Removed the last test from the test assembly file.
Tue, Sep 29
Updated a number of formatting issues.
Updated the test case to remove instructions that are not needed.
Fri, Sep 25
Addressed a number of nits.
Added an NFC change before this patch and rebased this patch.
Fixed last nits.
Wed, Sep 23
Added const in two places.
Tue, Sep 22
Added PHDRS to try to avoid large binary files.
Fixed spacing that I missed.
Rebased this patch to Top of Trunk.
Fixed all of the error to errorOrWarn.
Made use of NOP.
Fixed 24 to 26 bits as the 24 bits was not correct.
Added mayUseShortThunk handling.
Overall I think that the patch looks good. I just had a couple of comments.
Thank you for finding the issues related to the peephole!
Mon, Sep 21
You can probably merge pcrel-tls-local-dynamic-address-load-reloc.s and pcrel-tls-local-dynamic-value-load-reloc.s.
They are short test cases and they are testing almost exactly the same thing.
Added the linker script to the test file.
Added a check for the GOT.
Updated error to errorOrWarn.
Merged the two test files.
Removed extra assembly from test case.
Sep 18 2020
FYI: All of the dependent patches have landed so you should now be able to just apply this patch on top of trunk.
Updated the patch to use the NOP constant.
Updated test case to check for .got.
Sep 15 2020
Sep 14 2020
Replace error() with errorOrWarn().
Fixed formatting in source file.
Fixed spacing in test file.
Sep 11 2020
I've updated the description to only use the correct version of the relocation: R_PPC64_GOT_TLSGD_PCREL34.
Fixed formatting and comments in a few places.
Added --soname to the test file.
Thank you for the reviews!
Sep 8 2020
It seems that most builders do have the extra_configure_args parameter but the builder that we use here does not.
You may have to add the parameter to the build factory to get this to work.
This mostly LGTM.
From my perspective you can add no-show-raw-insn on commit.
Sep 3 2020
Removed a couple of variables that could be inlined.
Added an error in case the offset from the 4 byte alignment is 2 or 3.
Moved checks in the test case.
Fixed a couple of things on the test case.
Added the function name inside <>:.
Removed the .size directives.
Added SYMBOL-NEXT: where possible.
Removed the linker script that was not needed.
Added a quick summary of the test case.
Fixed nit and moved the position of the case in the switch.
Sep 1 2020
Aug 31 2020
Aug 28 2020
Aug 26 2020
Aug 24 2020
Aug 21 2020
Also, please add a test where the offset is not zero.
So the assembly would be for example:
paddi 3, 13, x@TPREL+8, 0
Adjusted one comment and moved the code around to merge the two errorOrWarn.
Aug 20 2020
Only minor nits form me.
Couple of nits.
Updated the comment to make it more concise.
Updated the test case to add the missing : .
Aug 19 2020
Fix some formatting.
Fix a couple of nits.
Add the --triple to the test case.