Page MenuHomePhabricator

saghir (Ahsan Saghir)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2018, 1:02 PM (102 w, 1 d)

Recent Activity

Fri, Oct 23

saghir committed rGedb27912a3ec: [PowerPC] Add intrinsics for MMA (authored by bsaleil).
[PowerPC] Add intrinsics for MMA
Fri, Oct 23, 11:16 AM
saghir closed D89345: [PowerPC] Add intrinsics for MMA.
Fri, Oct 23, 11:16 AM · Restricted Project, Restricted Project
saghir updated the summary of D89345: [PowerPC] Add intrinsics for MMA.
Fri, Oct 23, 7:30 AM · Restricted Project, Restricted Project

Thu, Oct 15

saghir committed rZORG2fc811d0946a: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot (authored by saghir).
[zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot
Thu, Oct 15, 12:51 PM
saghir closed D88746: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot.
Thu, Oct 15, 12:51 PM · Restricted Project
saghir retitled D88746: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot from [zorg] [PowerPC] Limit number of threads to 32 on clang-ppc64le-rhel buildbot to [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot.
Thu, Oct 15, 12:48 PM · Restricted Project
saghir updated the diff for D88746: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot.

Updating number of threads to 20.

Thu, Oct 15, 12:47 PM · Restricted Project

Tue, Oct 13

saghir added reviewers for D89345: [PowerPC] Add intrinsics for MMA: Restricted Project, bsaleil.
Tue, Oct 13, 2:51 PM · Restricted Project, Restricted Project
saghir requested review of D89345: [PowerPC] Add intrinsics for MMA.
Tue, Oct 13, 2:50 PM · Restricted Project, Restricted Project
saghir committed rGf3202b30b8e6: [PowerPC] Add assemble disassemble intrinsics for MMA (authored by saghir).
[PowerPC] Add assemble disassemble intrinsics for MMA
Tue, Oct 13, 11:22 AM
saghir closed D88739: [PowerPC] Add assemble disassemble intrinsics for MMA.
Tue, Oct 13, 11:22 AM · Restricted Project

Fri, Oct 2

saghir added reviewers for D88746: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot: Restricted Project, stefanp, lei.
Fri, Oct 2, 10:28 AM · Restricted Project
saghir requested review of D88746: [zorg] [PowerPC] Limit number of threads to 20 on clang-ppc64le-rhel buildbot.
Fri, Oct 2, 10:27 AM · Restricted Project
saghir updated the diff for D88739: [PowerPC] Add assemble disassemble intrinsics for MMA.

Formatting change

Fri, Oct 2, 10:07 AM · Restricted Project
saghir added reviewers for D88739: [PowerPC] Add assemble disassemble intrinsics for MMA: bsaleil, Restricted Project.
Fri, Oct 2, 7:53 AM · Restricted Project
saghir requested review of D88739: [PowerPC] Add assemble disassemble intrinsics for MMA.
Fri, Oct 2, 7:52 AM · Restricted Project

Sep 30 2020

saghir committed rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA (authored by saghir).
[PowerPC] Add outer product instructions for MMA
Sep 30 2020, 4:07 PM
saghir closed D88043: [PowerPC] Add outer product instructions for MMA.
Sep 30 2020, 4:07 PM · Restricted Project
saghir committed rZORGc2cc01b14ef8: [zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot (authored by saghir).
[zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot
Sep 30 2020, 9:24 AM
saghir closed D88586: [zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot.
Sep 30 2020, 9:24 AM · Restricted Project
saghir added reviewers for D88586: [zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot: stefanp, nemanjai, Restricted Project.
Sep 30 2020, 9:09 AM · Restricted Project
saghir requested review of D88586: [zorg] [PowerPC] Limit number of threads to 64 on clang-ppc64le-rhel buildbot.
Sep 30 2020, 9:07 AM · Restricted Project

Sep 29 2020

saghir updated the diff for D88043: [PowerPC] Add outer product instructions for MMA.

Fixed typos and indentation.

Sep 29 2020, 12:11 PM · Restricted Project
saghir updated the diff for D88043: [PowerPC] Add outer product instructions for MMA.

Rebased after dependant patches were committed.

Sep 29 2020, 7:46 AM · Restricted Project

Sep 23 2020

saghir closed D87993: [zorg] [PowerPC] set lld as the default linker on ppc64le-clang-rhel bot.
Sep 23 2020, 7:01 AM · Restricted Project
saghir committed rZORGf6a1fc1366bd: [zorg] [PowerPC] set lld as the default linker on ppc64le-clang-rhel bot (authored by saghir).
[zorg] [PowerPC] set lld as the default linker on ppc64le-clang-rhel bot
Sep 23 2020, 7:01 AM

Sep 22 2020

saghir added a comment to D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

Thanks for looking. Indeed, it looks like an issue with the disk being full on the bot.

Sep 22 2020, 11:15 AM · Restricted Project

Sep 21 2020

saghir updated the summary of D88043: [PowerPC] Add outer product instructions for MMA.
Sep 21 2020, 1:53 PM · Restricted Project
saghir updated the summary of D88043: [PowerPC] Add outer product instructions for MMA.
Sep 21 2020, 1:52 PM · Restricted Project
saghir retitled D88043: [PowerPC] Add outer product instructions for MMA from [PowerPC] Add instruction definitions for MMA to [PowerPC] Add outer product instructions for MMA.
Sep 21 2020, 1:52 PM · Restricted Project
saghir requested review of D88043: [PowerPC] Add outer product instructions for MMA.
Sep 21 2020, 1:49 PM · Restricted Project

Sep 20 2020

saghir added reviewers for D87993: [zorg] [PowerPC] set lld as the default linker on ppc64le-clang-rhel bot: stefanp, Restricted Project.
Sep 20 2020, 3:09 PM · Restricted Project
saghir requested review of D87993: [zorg] [PowerPC] set lld as the default linker on ppc64le-clang-rhel bot.
Sep 20 2020, 3:08 PM · Restricted Project

Sep 9 2020

saghir abandoned D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

Since significantly different changes are needed to make this work, another patch will be posted for review, closing this one.

Sep 9 2020, 11:15 AM · Restricted Project
saghir added a comment to D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

Thank you for the inputs everyone. I will take a look at the changes needed to be done to make this work. Thanks!

Sep 9 2020, 7:02 AM · Restricted Project

Sep 8 2020

saghir added inline comments to D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.
Sep 8 2020, 2:56 PM · Restricted Project
saghir added a reviewer for D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot: zacharyselk.
Sep 8 2020, 2:48 PM · Restricted Project
saghir updated the summary of D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.
Sep 8 2020, 2:42 PM · Restricted Project
saghir updated the diff for D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

fix indentation

Sep 8 2020, 2:40 PM · Restricted Project
saghir requested review of D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.
Sep 8 2020, 2:32 PM · Restricted Project

Sep 2 2020

saghir committed rGa27398a8151d: [PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024 (authored by saghir).
[PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024
Sep 2 2020, 1:29 PM
saghir closed D87053: [PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024.
Sep 2 2020, 1:29 PM · Restricted Project
saghir added a reviewer for D87053: [PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024: jsji.
Sep 2 2020, 1:19 PM · Restricted Project
saghir added reviewers for D87053: [PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024: Restricted Project, nemanjai.
Sep 2 2020, 12:54 PM · Restricted Project
saghir requested review of D87053: [PowerPC] Update MemorySanitizer test to cater for number of CPUs > 1024.
Sep 2 2020, 12:51 PM · Restricted Project

Jul 28 2020

saghir committed rG811828a01d64: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC (authored by saghir).
[PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC
Jul 28 2020, 12:23 PM
saghir closed D84786: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC.
Jul 28 2020, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
saghir added a reviewer for D84786: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC: hfinkel.
Jul 28 2020, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
saghir added reviewers for D84786: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC: Restricted Project, nemanjai.
Jul 28 2020, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
saghir requested review of D84786: [PowerPC] Mark allocator_oom_test.cpp unsupported on PowerPC.
Jul 28 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2020

saghir committed rGf4c337ab85c0: [PowerPC] Add support for vector bool __int128 for Power10 (authored by saghir).
[PowerPC] Add support for vector bool __int128 for Power10
Jun 23 2020, 7:27 PM
saghir closed D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 23 2020, 7:27 PM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2020

saghir added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 22 2020, 4:07 PM · Restricted Project, Restricted Project, Restricted Project

Jun 18 2020

saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Updated comment.

Jun 18 2020, 4:27 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Updated comment to reflect the change in allowed types.

Jun 18 2020, 3:54 PM · Restricted Project, Restricted Project, Restricted Project
saghir accepted D81126: [PowerPC] Fix for PC Relative call protocol.

LGTM

Jun 18 2020, 12:01 PM · Restricted Project

Jun 17 2020

saghir added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 17 2020, 3:39 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Updated tests features to check.

Jun 17 2020, 3:39 PM · Restricted Project, Restricted Project, Restricted Project
saghir added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 17 2020, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
saghir added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 17 2020, 1:28 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Updated tests.

Jun 17 2020, 1:28 PM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2020

saghir committed rG37e72f47a41d: [PowerPC] Add -m[no-]power10-vector clang and llvm option (authored by saghir).
[PowerPC] Add -m[no-]power10-vector clang and llvm option
Jun 16 2020, 1:12 PM
saghir closed D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.
Jun 16 2020, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Updated comment for allowing __int128 for vector bool.

Jun 16 2020, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.

Addressed comments.

Jun 16 2020, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
saghir added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 11:00 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2020

saghir created D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 14 2020, 7:11 PM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2020

saghir updated the diff for D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

Updated the diff based on latest changes in master.

Jun 5 2020, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2020

saghir updated the diff for D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

Addressed nit

Jun 2 2020, 6:40 PM · Restricted Project, Restricted Project, Restricted Project
saghir added inline comments to D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.
Jun 2 2020, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

Removed P10Altivec.

Jun 2 2020, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

May 29 2020

saghir added inline comments to D80757: [PowerPC] Add clang option -m[no-]pcrel.
May 29 2020, 1:06 PM · Restricted Project, Restricted Project

May 28 2020

saghir accepted D80757: [PowerPC] Add clang option -m[no-]pcrel.

Other than the nit, this looks good to me.

May 28 2020, 2:20 PM · Restricted Project, Restricted Project
saghir created D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.
May 28 2020, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

May 22 2020

saghir accepted D79854: [PowerPC] Prevent legalization loop from promoting SELECT_CC from v4i32 to v4i32.

LGTM other than the nits that Stefan mentioned.

May 22 2020, 6:57 AM · Restricted Project

May 21 2020

saghir added inline comments to D80294: Add support for vmsumudm.
May 21 2020, 4:49 PM · Restricted Project, Restricted Project
saghir added a comment to D80294: Add support for vmsumudm.

I think this overall looks good, but just curious, why was the builtin support removed?

May 21 2020, 6:59 AM · Restricted Project, Restricted Project

May 20 2020

saghir updated the diff for D80294: Add support for vmsumudm.

Removing the builtin support.

May 20 2020, 1:43 PM · Restricted Project, Restricted Project
saghir updated the summary of D80294: Add support for vmsumudm.
May 20 2020, 9:48 AM · Restricted Project, Restricted Project
saghir updated the diff for D80294: Add support for vmsumudm.

Added vec_msum builtin for vmsumudm.

May 20 2020, 9:48 AM · Restricted Project, Restricted Project
saghir created D80294: Add support for vmsumudm.
May 20 2020, 7:01 AM · Restricted Project, Restricted Project

May 19 2020

saghir closed D55892: [OpenMP] 'close' map-type-modifier code generation.

Support for 'close' map-type-modifier code generation in clang has been added by patch D65341. This revision can be closed.

May 19 2020, 4:00 PM · Restricted Project, Restricted Project

Apr 29 2019

saghir committed rL359517: Add __builtin_dcbf support for PPC.
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:53 PM
saghir committed rG3962d6da1779: Add __builtin_dcbf support for PPC (authored by saghir).
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:24 PM
saghir committed rC359517: Add __builtin_dcbf support for PPC.
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:23 PM
saghir closed D59843: [PowerPC] Add support for __dcbf builtin.
Apr 29 2019, 4:23 PM · Restricted Project, Restricted Project

Apr 26 2019

saghir added a comment to rL359083: Let llvm-cvtres (and lld-link) report duplicate resources.

Hi, your patch seems to be causing buildbot failures for the following buildbots:
https://lab.llvm.org:8011/builders/clang-ppc64be-linux
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Apr 26 2019, 12:48 PM

Apr 15 2019

saghir added a comment to D59843: [PowerPC] Add support for __dcbf builtin.

Looks good to me.
Then only thing I noticed was that in the description in the LanguageExtensions.rst file you use plural to refer to the chache builtins. Of course, you only added one builtin but I know that in the future you plan to add more builtins of the same type so I wouldn't worry about that wording now.

Apr 15 2019, 1:50 PM · Restricted Project, Restricted Project

Apr 14 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Moved cache builtins section to PowerPC Language extensions in LanguageExtensions.rst

Apr 14 2019, 10:23 PM · Restricted Project, Restricted Project

Apr 9 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Added documentation in clang/docs/LanguageExtensions.rst

Apr 9 2019, 9:52 PM · Restricted Project, Restricted Project

Apr 5 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Removed check for basic block in dcbf.ll

Apr 5 2019, 1:26 PM · Restricted Project, Restricted Project

Mar 26 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Updated test in dcbf.ll

Mar 26 2019, 2:18 PM · Restricted Project, Restricted Project
saghir edited reviewers for D59843: [PowerPC] Add support for __dcbf builtin, added: hfinkel; removed: llvm-commits.
Mar 26 2019, 1:53 PM · Restricted Project, Restricted Project
saghir created D59843: [PowerPC] Add support for __dcbf builtin.
Mar 26 2019, 1:49 PM · Restricted Project, Restricted Project

Feb 13 2019

saghir accepted D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

LGTM

Feb 13 2019, 12:31 PM · Restricted Project

Feb 7 2019

saghir added inline comments to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 7 2019, 5:51 PM · Restricted Project
saghir requested changes to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 7 2019, 2:31 PM · Restricted Project

Dec 19 2018

saghir created D55892: [OpenMP] 'close' map-type-modifier code generation.
Dec 19 2018, 10:24 AM · Restricted Project, Restricted Project

Dec 14 2018

saghir updated the diff for D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier.

Made following changes:

  • added more tests for checking diagnostic error messages.
  • added initialization of modifiers' location in OMPMapClause.
  • improved variable names to depict multiple modifiers as opposed to a single modifier.
  • improved comments.
Dec 14 2018, 7:08 PM · Restricted Project