For a list of mixed integer and SSA values (used for offsets, sizes
and strides in OffsetSizeAndStrideOpInterface) return the entries as
SSA values.
Details
Details
- Reviewers
nicolasvasilache hanchung
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
40 ms | x64 debian > Flang.Semantics::resolve102.f90 |
Event Timeline
Comment Actions
just few style nits.
mlir/include/mlir/Interfaces/ViewLikeInterface.td | ||
---|---|---|
183 ↗ | (On Diff #327183) | Add a period at the end. |
218 ↗ | (On Diff #327183) | ditto |
253 ↗ | (On Diff #327183) | ditto |
mlir/lib/Interfaces/ViewLikeInterface.cpp | ||
11–12 ↗ | (On Diff #327183) | Add a blank line between these two. |
43–44 ↗ | (On Diff #327183) | Add a blank line between two methods. |
Comment Actions
Moving the utility methods to StandardDialect/Utils since keep it on
ViewInterface is a layering violation. Also drop the interface methods
that use that utility.
Comment Actions
@nicolasvasilache suggestion abandoning this patch. The intent is to make the use of OpFoldResult more common, and having a fall back to get Value would affect that.
Can you use integers.getAsValueRange<IntegerAttr>() instead?