Page MenuHomePhabricator

hanchung (Han-Chung Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 8:20 PM (65 w, 6 d)

Recent Activity

Yesterday

hanchung abandoned D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mon, Apr 12, 11:53 PM · Restricted Project
hanchung accepted D100325: [mlir][spirv] Put debug-only variable in LLVM_DEBUG.
Mon, Apr 12, 11:46 AM · Restricted Project

Sun, Apr 11

hanchung accepted D100272: [mlir][Linalg] Disable const -> linalg.generic when fused op is illegal..
Sun, Apr 11, 10:42 PM · Restricted Project

Thu, Apr 8

Herald added a reviewer for D97720: Fix tile-and-pad when padding doesn't span all dimension: mravishankar.

do we still need this?

Thu, Apr 8, 9:31 PM · Restricted Project
hanchung accepted D100145: [mlir][Linalg] Drop unit-trip loops of reductions only if other reduction loops exists..
Thu, Apr 8, 9:30 PM · Restricted Project
hanchung committed rGc3614358452e: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op (authored by hanchung).
[mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op
Thu, Apr 8, 12:16 PM
hanchung closed D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 12:15 PM · Restricted Project
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 11:45 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Thu, Apr 8, 11:45 AM · Restricted Project
hanchung updated the summary of D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 10:43 AM · Restricted Project
hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Also added the implementation of SPIRVTypeConverter::getOptions().

Thu, Apr 8, 10:43 AM · Restricted Project
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 10:42 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Thu, Apr 8, 10:42 AM · Restricted Project
hanchung abandoned D100111: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Thu, Apr 8, 7:40 AM · Restricted Project
hanchung abandoned D100110: [mlir][spirv] Timely fail type conversion.
Thu, Apr 8, 7:39 AM · Restricted Project
hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Fixed, and enhanced the test that loads i1. (now it will return i1 to make sure there is no such issue again.)

Thu, Apr 8, 7:37 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

fix i1 issues

Thu, Apr 8, 7:35 AM · Restricted Project
hanchung requested review of D100111: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Thu, Apr 8, 7:34 AM · Restricted Project
hanchung requested review of D100110: [mlir][spirv] Timely fail type conversion.
Thu, Apr 8, 7:34 AM · Restricted Project

Wed, Apr 7

hanchung accepted D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation.

Haven't prototyped based on the patch, but overall it looks good to me.

Wed, Apr 7, 11:24 PM · Restricted Project
hanchung accepted D100058: [mlir][spirv] Timely fail type conversion.
Wed, Apr 7, 11:14 PM · Restricted Project

Tue, Apr 6

hanchung planned changes to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

@antiagainst is going to add some support to SPIR-V, and I will rebase on it and rework a bit.

Tue, Apr 6, 9:54 AM · Restricted Project
hanchung accepted D99756: [mlir][tosa] Add tosa.table lowering to linalg.generic.
Tue, Apr 6, 1:12 AM · Restricted Project

Sun, Apr 4

hanchung accepted D99820: [mlir][Linalg] Add callbacks to fusion of elementwise operations to control fusion..
Sun, Apr 4, 11:51 PM · Restricted Project
hanchung accepted D99819: [mlir][Linalg] NFC: Move populatePatterns* method into linalg namespace..
Sun, Apr 4, 10:56 PM · Restricted Project
hanchung requested changes to D99756: [mlir][tosa] Add tosa.table lowering to linalg.generic.

Sorry for the late review...

Sun, Apr 4, 9:11 AM · Restricted Project

Thu, Apr 1

hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

I hit a really weird thing... and I can only repro with this PR...

Thu, Apr 1, 8:57 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

use build-in function

Thu, Apr 1, 8:38 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

fix debug build

Thu, Apr 1, 8:34 AM · Restricted Project
hanchung requested review of D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 1, 6:47 AM · Restricted Project

Tue, Mar 30

hanchung committed rGf58463345415: Added static verification for Linalg Ops. (authored by inho9606).
Added static verification for Linalg Ops.
Tue, Mar 30, 7:11 AM
hanchung closed D98390: Added static verification for Linalg Ops..
Tue, Mar 30, 7:11 AM · Restricted Project

Mon, Mar 29

hanchung accepted D99485: [mlir][Linalg] Drop spurious error message.

nice cleanup!

Mon, Mar 29, 8:04 AM · Restricted Project
hanchung accepted D98390: Added static verification for Linalg Ops..

Thanks!

Mon, Mar 29, 5:01 AM · Restricted Project

Thu, Mar 25

hanchung added a comment to D98390: Added static verification for Linalg Ops..

It looks like there is a failure in tile-and-fuse-tensors.mlir. Could you check the file/test, so we can make build bots happy?

Thu, Mar 25, 6:05 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Thu, Mar 25, 12:06 AM · Restricted Project

Tue, Mar 23

hanchung requested changes to D98390: Added static verification for Linalg Ops..
Tue, Mar 23, 11:12 AM · Restricted Project

Thu, Mar 18

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Thu, Mar 18, 11:05 PM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Thu, Mar 18, 11:01 PM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Thu, Mar 18, 9:58 AM · Restricted Project

Tue, Mar 16

hanchung requested changes to D98390: Added static verification for Linalg Ops..

Inho and I had an offline discussion today, and we found that this doesn't work in some cases. E.g., if there is an affine_map is affine_map<(i) -> (10 - i)>. I will wait for Inho's fix and review it later.

Tue, Mar 16, 5:39 AM · Restricted Project

Mar 12 2021

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Mar 12 2021, 10:59 AM · Restricted Project
hanchung planned changes to D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mar 12 2021, 5:35 AM · Restricted Project
hanchung added a comment to D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..

It seems like I should fix bunch of tests...

Mar 12 2021, 5:30 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..

@inho9606, please add invalid ops to test/Dialect/Linalg/invalid.mlir

Mar 12 2021, 4:50 AM · Restricted Project
hanchung requested review of D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mar 12 2021, 4:23 AM · Restricted Project

Mar 11 2021

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Mar 11 2021, 11:29 PM · Restricted Project
hanchung added a comment to D98390: Added static verification for Linalg Ops..

Probably need a test that fails as well and verify the error message. You can use -verify-diagnostics on the command line, and match the error using // expected-error . See other tests that have this.

Mar 11 2021, 12:20 PM · Restricted Project
hanchung added a comment to D98390: Added static verification for Linalg Ops..

@aartbik could you help check if the change in sparse_nd.mlir is correct?

Mar 11 2021, 11:26 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 11 2021, 2:49 AM · Restricted Project

Mar 10 2021

hanchung committed rG2ce4caf4143b: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to… (authored by inho9606).
Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to…
Mar 10 2021, 4:06 AM
hanchung closed D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 4:06 AM · Restricted Project
hanchung accepted D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 3:52 AM · Restricted Project
hanchung committed rGd5d4fb635ee0: [mlir][linalg] Add support for using scalar attributes in TC ops. (authored by hanchung).
[mlir][linalg] Add support for using scalar attributes in TC ops.
Mar 10 2021, 1:52 AM
hanchung closed D97876: [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 10 2021, 1:51 AM · Restricted Project
hanchung retitled D97876: [mlir][linalg] Add support for using scalar attributes in TC ops. from [mlir][linalg] Fix issues in scalar attributes. to [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 10 2021, 1:49 AM · Restricted Project
hanchung added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 1:19 AM · Restricted Project

Mar 9 2021

hanchung added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 9 2021, 4:17 AM · Restricted Project

Mar 8 2021

hanchung requested changes to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 8 2021, 11:35 PM · Restricted Project
hanchung requested changes to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.

Please provide a rationale for making this change in the commit description. Why is it necessary? Is there any op that will customize the behavior and why can't it do so by overloading the functions instead?

Mar 8 2021, 4:23 AM · Restricted Project

Mar 4 2021

hanchung committed rGb47c6c686c86: [mlir][linalg] Add suffix "Op" to pooling TC ops. (authored by hanchung).
[mlir][linalg] Add suffix "Op" to pooling TC ops.
Mar 4 2021, 7:09 AM
hanchung closed D97946: [mlir][linalg] Add suffix "Op" to pooling TC ops..
Mar 4 2021, 7:09 AM · Restricted Project
hanchung requested review of D97946: [mlir][linalg] Add suffix "Op" to pooling TC ops..
Mar 4 2021, 6:32 AM · Restricted Project

Mar 3 2021

hanchung committed rG83c56aa4ee82: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops. (authored by hanchung).
[mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops.
Mar 3 2021, 11:47 AM
hanchung closed D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 11:47 AM · Restricted Project
hanchung requested review of D97876: [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 3 2021, 11:25 AM · Restricted Project
hanchung updated the summary of D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 11:25 AM · Restricted Project
hanchung added a comment to D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

LGTM for depthwise op_def. the ods changes aren't needed for this change, right ? if yes feel free to split and submit the op_def part.

Mar 3 2021, 11:25 AM · Restricted Project
hanchung updated the diff for D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

split patches because scalar attribute is not needed in the same patch

Mar 3 2021, 11:23 AM · Restricted Project
hanchung updated the diff for D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

Fix tests

Mar 3 2021, 11:03 AM · Restricted Project
hanchung updated the summary of D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 10:44 AM · Restricted Project
hanchung updated the diff for D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

Redefine the depthwise conv op which returns a 5-D output.

Mar 3 2021, 10:40 AM · Restricted Project
hanchung accepted D97800: [mlir] Remove incorrect folding for SubTensorInsertOp.
Mar 3 2021, 9:40 AM · Restricted Project
hanchung committed rG497b7b8c00fc: [mlir][linalg] Delete unused vars if there are shaped-only operands. (authored by hanchung).
[mlir][linalg] Delete unused vars if there are shaped-only operands.
Mar 3 2021, 9:36 AM
hanchung closed D97851: [mlir][linalg] Delete unused vars if there are shaped-only operands..
Mar 3 2021, 9:36 AM · Restricted Project
hanchung requested review of D97851: [mlir][linalg] Delete unused vars if there are shaped-only operands..
Mar 3 2021, 5:44 AM · Restricted Project

Mar 2 2021

hanchung requested changes to D97800: [mlir] Remove incorrect folding for SubTensorInsertOp.
Mar 2 2021, 11:12 PM · Restricted Project
hanchung accepted D97709: [mlir] Add LinalgInterface method to clone with a given BlockAndValueMapping..
Mar 2 2021, 1:07 PM · Restricted Project
hanchung requested review of D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 2 2021, 1:06 PM · Restricted Project
hanchung committed rGc0f8115c73b7: [mlir][linalg] Only generate one var for an attrUse. (authored by hanchung).
[mlir][linalg] Only generate one var for an attrUse.
Mar 2 2021, 12:49 PM
hanchung closed D97794: [mlir][linalg] Only generate one var for an attrUse..
Mar 2 2021, 12:48 PM · Restricted Project
hanchung updated the summary of D97794: [mlir][linalg] Only generate one var for an attrUse..
Mar 2 2021, 12:32 PM · Restricted Project
hanchung requested review of D97794: [mlir][linalg] Only generate one var for an attrUse..
Mar 2 2021, 12:31 PM · Restricted Project
hanchung accepted D97707: [mlir] Utility method for getting mixed integer and values list as just values..

just few style nits.

Mar 2 2021, 11:20 AM · Restricted Project

Feb 26 2021

hanchung committed rGbfd3771c9eec: [mlir][linalg] Add pooling ops to Linalg TC ops. (authored by hanchung).
[mlir][linalg] Add pooling ops to Linalg TC ops.
Feb 26 2021, 7:18 AM
hanchung closed D97385: [mlir][linalg] Add pooling ops to Linalg TC ops..
Feb 26 2021, 7:18 AM · Restricted Project
hanchung updated the summary of D97385: [mlir][linalg] Add pooling ops to Linalg TC ops..
Feb 26 2021, 6:54 AM · Restricted Project
hanchung committed rG855a11960497: [mlir][linalg] Allow TC ops taking an unused shaped operand. (authored by hanchung).
[mlir][linalg] Allow TC ops taking an unused shaped operand.
Feb 26 2021, 6:46 AM
hanchung closed D97384: [mlir][linalg] Allow TC ops taking an unused shaped operand..
Feb 26 2021, 6:46 AM · Restricted Project
hanchung added a comment to D96891: Support tile-and-pad when padding doesn't span all dimension.

I didn't intend to click approval...

Feb 26 2021, 12:11 AM · Restricted Project
hanchung accepted D96891: Support tile-and-pad when padding doesn't span all dimension.

Otherwise we need to change the semantics of PadOp to accept [%size...] attributes.

I think the pad op can accept [%size ...] ? See https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/Linalg/roundtrip.mlir#L30-L37

Feb 26 2021, 12:10 AM · Restricted Project

Feb 24 2021

hanchung updated the diff for D97384: [mlir][linalg] Allow TC ops taking an unused shaped operand..

fix and add more comments

Feb 24 2021, 11:50 AM · Restricted Project
hanchung committed rG21895a2beff7: [mlir][linalg] Reuse the symbol if attribute uses are identical. (authored by hanchung).
[mlir][linalg] Reuse the symbol if attribute uses are identical.
Feb 24 2021, 11:43 AM
hanchung closed D97383: [mlir][linalg] Reuse the symbol if attribute uses are identical..
Feb 24 2021, 11:43 AM · Restricted Project
hanchung committed rG705068cb8c4d: [mlir][linalg] Support for using output values in TC definitions. (authored by hanchung).
[mlir][linalg] Support for using output values in TC definitions.
Feb 24 2021, 11:38 AM
hanchung closed D97312: [mlir][linalg] Support for using output values in TC definitions..
Feb 24 2021, 11:38 AM · Restricted Project
hanchung updated the diff for D97384: [mlir][linalg] Allow TC ops taking an unused shaped operand..

rebase

Feb 24 2021, 11:21 AM · Restricted Project
hanchung updated the diff for D97312: [mlir][linalg] Support for using output values in TC definitions..

rename def test and remove unused attributes

Feb 24 2021, 11:21 AM · Restricted Project
hanchung updated the diff for D97385: [mlir][linalg] Add pooling ops to Linalg TC ops..

rebase

Feb 24 2021, 11:13 AM · Restricted Project
hanchung updated the diff for D97312: [mlir][linalg] Support for using output values in TC definitions..

rebase and add comments

Feb 24 2021, 11:12 AM · Restricted Project