Page MenuHomePhabricator
People rdzhabarov

rdzhabarov (Roman Dzhabarov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 2 2020, 10:29 AM (28 w, 4 d)

Recent Activity
View All

Jan 21 2021

rdzhabarov added a comment to D94868: [mlir] Enable passing crash reproducer stream factory method.

nice!

Jan 21 2021, 2:40 PM · Restricted Project, Restricted Project

Jan 20 2021

rdzhabarov added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Jan 20 2021, 9:24 AM · Restricted Project, Restricted Project

Jan 19 2021

rdzhabarov added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Jan 19 2021, 12:07 PM · Restricted Project, Restricted Project

Nov 2 2020

rdzhabarov added inline comments to D90573: [mlir] Set random starting index.
Nov 2 2020, 10:44 AM · Restricted Project
rdzhabarov added inline comments to D90573: [mlir] Set random starting index.
Nov 2 2020, 9:34 AM · Restricted Project

Oct 27 2020

rdzhabarov added inline comments to D90266: [mlir] Optimize the parsing of ElementsAttr hex strings.
Oct 27 2020, 3:54 PM · Restricted Project
rdzhabarov accepted D90266: [mlir] Optimize the parsing of ElementsAttr hex strings.

Pretty cool improvement!

Oct 27 2020, 3:42 PM · Restricted Project

Oct 21 2020

rdzhabarov committed rG281e0f3636a3: [mlir] Simplify DDR matching patterns with equal operands for operators where… (authored by rdzhabarov).
[mlir] Simplify DDR matching patterns with equal operands for operators where…
Oct 21 2020, 2:32 PM
rdzhabarov closed D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..
Oct 21 2020, 2:32 PM · Restricted Project

Oct 19 2020

rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

comments.

Oct 19 2020, 9:51 PM · Restricted Project

Oct 16 2020

rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

fix wording.

Oct 16 2020, 5:12 PM · Restricted Project
rdzhabarov added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

fixed.

Oct 16 2020, 5:02 PM · Restricted Project
rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

comments.

Oct 16 2020, 5:01 PM · Restricted Project
rdzhabarov added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

commented.

Oct 16 2020, 4:43 PM · Restricted Project
rdzhabarov added a reviewer for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable.: jpienaar.
Oct 16 2020, 3:11 PM · Restricted Project
rdzhabarov requested review of D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..
Oct 16 2020, 3:10 PM · Restricted Project

Oct 13 2020

rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

updating to latest.

Oct 13 2020, 10:01 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

fixing gcc5 issues.

Oct 13 2020, 9:46 PM · Restricted Project
rdzhabarov reopened D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

gcc5 was not happy with StringRef in the emplace call to a map<std::string, ...> , will be fixing it.

Oct 13 2020, 9:45 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

@mehdi_amini is there any way to run those tests prior merging?

Oct 13 2020, 9:08 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

to fix merge conflict.

Oct 13 2020, 3:56 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

added TODO.

Oct 13 2020, 3:32 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Thanks for quick review @jpienaar!

Oct 13 2020, 3:24 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

@jpienaar comments addressed

Oct 13 2020, 11:50 AM · Restricted Project

Oct 12 2020

rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

update.

Oct 12 2020, 6:01 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

comments

Oct 12 2020, 5:57 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Addressed comments.

Oct 12 2020, 5:57 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Will update this Cl in a bit.

Oct 12 2020, 3:37 PM · Restricted Project
rdzhabarov added reviewers for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name.: jpienaar, rriddle.
Oct 12 2020, 11:28 AM · Restricted Project
rdzhabarov added inline comments to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 11:06 AM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

fixing clang-tidy, revert leftovers from merge conflict.

Oct 12 2020, 11:01 AM · Restricted Project
rdzhabarov added inline comments to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 10:51 AM · Restricted Project
rdzhabarov requested review of D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 10:36 AM · Restricted Project