This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] [docs] Update the list of supported architectures on Windows
ClosedPublic

Authored by mstorsjo on Feb 16 2021, 10:58 PM.

Download Raw Diff

Details

Reviewers

labath
omjavaid
amccarth

Commits

rGae14f3fdbfa8: [LLDB] [docs] Update the list of supported architectures on Windows

Summary

It was pointed out to me that the docs previously only said i386 was supported, while I'd expect that at least x86_64 is on the same level, and AArch64 should work pretty well for basic things at least.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mstorsjo created this revision.Feb 16 2021, 10:58 PM

Herald added subscribers: pengfei, arphaman, kristof.beyls. · View Herald TranscriptFeb 16 2021, 10:58 PM

mstorsjo requested review of this revision.Feb 16 2021, 10:58 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2021, 10:58 PM

Harbormaster completed remote builds in B89490: Diff 324194.Feb 17 2021, 12:37 AM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 17 2021, 12:37 AM

Do we support 32 bit Arm specifically? (I'm not very familiar with Windows targets)

@omjavaid Has done some testing on the latest Windows On Arm which is AArch64. I think you should probably say "ARM and AArch64 support is more" but he can comment on how well it works.

lldb/docs/index.rst
81	"experimental"

In D96840#2567890, @DavidSpickett wrote:

Do we support 32 bit Arm specifically? (I'm not very familiar with Windows targets)

Yes, I implemented support for both ARM and AArch64 in late 2019.

@omjavaid Has done some testing on the latest Windows On Arm which is AArch64. I think you should probably say "ARM and AArch64 support is more" but he can comment on how well it works.

Possibly yes. I was referring to an issue for the ARM part that I never got time to fix properly, see D70840. Other than that, I don't know of any issues with the AArch64 part, but I haven't used it very much either, fwiw.

omjavaid added inline comments.Feb 17 2021, 2:33 AM

lldb/docs/index.rst
80–81	s/ARM/ARM and AArch64/ Also add a line to reflect lack of python support.

mstorsjo added inline comments.Feb 17 2021, 2:39 AM

lldb/docs/index.rst
80–81	Sure, I can label the AArch64 bit experimental too. I wouldn't include comments about python here though. The fact that it's not easy to build LLDB with python for windows/aarch64 isn't an intrinsic feature of LLDB or something that is missing in LLDB, that's just python. It is actually possible to cross compile LLDB with python support for windows/aarch64, at least for the mingw target. Python itself is a bit tricky to cross compile, but once that cross compilation itself works, building it for windows/aarch64 isn't any worse than for x86. In https://github.com/mstorsjo/llvm-mingw/issues/73 there's ongoing efforts in building and packaging LLDB for windows with python enabled. As it's primarily cross compiled, it's a bit tricky for running tests though.

Fixed the typo, labeling the AArch64 support experimental too.

Ping, does this form look acceptable?

I'm in no position to evaluate the functionality of lldb on Windows. I've spent the last few months trying to understand why 900+ tests spontaneously started failing on Windows.

amccarth resigned from this revision.Feb 19 2021, 9:24 AM

Sounds reasonable. I'm sure x86_64 is in at least as good as shape as i386.

This revision is now accepted and ready to land.Feb 21 2021, 12:04 PM

Closed by commit rGae14f3fdbfa8: [LLDB] [docs] Update the list of supported architectures on Windows (authored by mstorsjo). · Explain WhyFeb 21 2021, 12:24 PM

This revision was automatically updated to reflect the committed changes.

mstorsjo added a commit: rGae14f3fdbfa8: [LLDB] [docs] Update the list of supported architectures on Windows.

Revision Contents

Path

Size

lldb/

docs/

index.rst

5 lines

Diff 325331

lldb/docs/index.rst

	Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
	LLDB is known to work on the following platforms, but ports to new platforms			LLDB is known to work on the following platforms, but ports to new platforms
	are welcome:			are welcome:

	* macOS debugging for i386, x86_64 and AArch64			* macOS debugging for i386, x86_64 and AArch64
	* iOS, tvOS, and watchOS simulator debugging on i386, x86_64 and AArch64			* iOS, tvOS, and watchOS simulator debugging on i386, x86_64 and AArch64
	* iOS, tvOS, and watchOS device debugging on ARM and AArch64			* iOS, tvOS, and watchOS device debugging on ARM and AArch64
	* Linux user-space debugging for i386, x86_64 and PPC64le			* Linux user-space debugging for i386, x86_64 and PPC64le
	* FreeBSD user-space debugging for i386 and x86_64			* FreeBSD user-space debugging for i386 and x86_64
	* Windows user-space debugging for i386 (*)			* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)

	(*) Support for Windows is under active development. Basic functionality is			(*) Support for Windows is under active development. Basic functionality is
	expected to work, with functionality improving rapidly.			expected to work, with functionality improving rapidly. ARM and AArch64 support
				is more experimental, with more known issues than the others.
				DavidSpickettUnsubmitted Not Done Reply Inline Actions "experimental" DavidSpickett: "experimental"
				omjavaidUnsubmitted Not Done Reply Inline Actions s/ARM/ARM and AArch64/ Also add a line to reflect lack of python support. omjavaid: s/ARM/ARM and AArch64/ Also add a line to reflect lack of python support.
				mstorsjoAuthorUnsubmitted Done Reply Inline Actions Sure, I can label the AArch64 bit experimental too. I wouldn't include comments about python here though. The fact that it's not easy to build LLDB with python for windows/aarch64 isn't an intrinsic feature of LLDB or something that is missing in LLDB, that's just python. It is actually possible to cross compile LLDB with python support for windows/aarch64, at least for the mingw target. Python itself is a bit tricky to cross compile, but once that cross compilation itself works, building it for windows/aarch64 isn't any worse than for x86. In https://github.com/mstorsjo/llvm-mingw/issues/73 there's ongoing efforts in building and packaging LLDB for windows with python enabled. As it's primarily cross compiled, it's a bit tricky for running tests though. mstorsjo: Sure, I can label the AArch64 bit experimental too. I wouldn't include comments about python…

	Get Involved			Get Involved
	------------			------------

	Check out the LLVM source-tree with git and find the sources in the `lldb`			Check out the LLVM source-tree with git and find the sources in the `lldb`
	subdirectory:			subdirectory:

	::			::
	▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines