Page MenuHomePhabricator

omjavaid (Muhammad Omair Javaid)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2015, 4:38 PM (288 w, 5 d)

Recent Activity

Today

omjavaid added a reverting change for rG63ace7796254: [lld-macho] Initial support for common symbols: rG8112d494d344: Revert "[lld-macho] Initial support for common symbols".
Thu, Sep 24, 12:29 AM
omjavaid committed rG8112d494d344: Revert "[lld-macho] Initial support for common symbols" (authored by omjavaid).
Revert "[lld-macho] Initial support for common symbols"
Thu, Sep 24, 12:29 AM
omjavaid added a reverting change for rGcd7cb0c30305: [lld-macho] Implement and test resolution of common symbols: rGc367f93e8539: Revert "[lld-macho] Implement and test resolution of common symbols".
Thu, Sep 24, 12:29 AM
omjavaid committed rGc367f93e8539: Revert "[lld-macho] Implement and test resolution of common symbols" (authored by omjavaid).
Revert "[lld-macho] Implement and test resolution of common symbols"
Thu, Sep 24, 12:29 AM
omjavaid added a reverting change for D86909: [lld-macho] Initial support for common symbols: rG8112d494d344: Revert "[lld-macho] Initial support for common symbols".
Thu, Sep 24, 12:29 AM · Restricted Project
omjavaid added a reverting change for D86910: [lld-macho] Implement and test resolution of common symbols: rGc367f93e8539: Revert "[lld-macho] Implement and test resolution of common symbols".
Thu, Sep 24, 12:29 AM · Restricted Project
omjavaid reopened D86910: [lld-macho] Implement and test resolution of common symbols.

Temporarily reverted this change as it predecessor broke LLDB build on Arm. https://reviews.llvm.org/D86909
http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409

Thu, Sep 24, 12:29 AM · Restricted Project
omjavaid requested changes to D86909: [lld-macho] Initial support for common symbols.
Thu, Sep 24, 12:27 AM · Restricted Project
omjavaid reopened D86909: [lld-macho] Initial support for common symbols.

I have temporarily reverted this change as i broke LLDB build on Arm http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409

Thu, Sep 24, 12:27 AM · Restricted Project

Tue, Sep 22

omjavaid added a reverting change for rG55f9f87da2c2: Reapply Revert "RegAllocFast: Rewrite and improve": rG73a6a164b84a: Revert "Reapply Revert "RegAllocFast: Rewrite and improve"".
Tue, Sep 22, 2:40 AM
omjavaid committed rG73a6a164b84a: Revert "Reapply Revert "RegAllocFast: Rewrite and improve"" (authored by omjavaid).
Revert "Reapply Revert "RegAllocFast: Rewrite and improve""
Tue, Sep 22, 2:40 AM

Mon, Sep 21

omjavaid updated the diff for D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.

This adds a rst page qemu-testing.rst that describes content which was previously written in README.txt.

Mon, Sep 21, 4:15 AM · Restricted Project

Mon, Sep 14

omjavaid added a reviewer for D87442: [lldb] Show flags for memory regions: labath.
Mon, Sep 14, 9:55 PM · Restricted Project
Herald added a reviewer for D87442: [lldb] Show flags for memory regions: JDevlieghere.

This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written.

Mon, Sep 14, 9:54 PM · Restricted Project
omjavaid added inline comments to D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.
Mon, Sep 14, 12:20 AM · Restricted Project

Mon, Sep 7

omjavaid updated the diff for D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.

This diff addresses issues highlighted in review.

Mon, Sep 7, 12:00 AM · Restricted Project

Sun, Sep 6

omjavaid committed rG769533216666: Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to… (authored by omjavaid).
Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to…
Sun, Sep 6, 9:13 PM
omjavaid closed D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.
Sun, Sep 6, 9:13 PM · Restricted Project, Restricted Project
omjavaid committed rG9bee13f89085: Move targetHasSVE function to lldbtest.py (authored by omjavaid).
Move targetHasSVE function to lldbtest.py
Sun, Sep 6, 8:38 PM
omjavaid closed D86872: [LLDB] Move targetHasSVE function to lldbtest.py.
Sun, Sep 6, 8:38 PM · Restricted Project
omjavaid accepted D87186: Add ARM64 Windows on Arm buildbots.

Looks good to me.

Sun, Sep 6, 8:02 PM

Wed, Sep 2

omjavaid added a comment to D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote.

@labath ping!

Wed, Sep 2, 2:07 AM
omjavaid added a comment to D82863: [LLDB] Add support to resize SVE registers at run-time.

@labath ping!

Wed, Sep 2, 2:07 AM
omjavaid updated the diff for D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.
Wed, Sep 2, 1:09 AM · Restricted Project, Restricted Project
omjavaid updated the diff for D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.

Adding changes to FreeBSD/* missed earlier.

Wed, Sep 2, 1:07 AM · Restricted Project, Restricted Project

Tue, Sep 1

omjavaid updated the diff for D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.

Fixed last diff it contained an invalid change.

Tue, Sep 1, 10:33 AM · Restricted Project, Restricted Project
omjavaid added a comment to D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.

NativeRegisterContextLinux_arm still uses "Plugins/Process/Utility/lldb-arm-register-enums.h" which I intend to deal in a later patch.

Tue, Sep 1, 10:30 AM · Restricted Project, Restricted Project
omjavaid requested review of D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface.
Tue, Sep 1, 10:27 AM · Restricted Project, Restricted Project

Mon, Aug 31

omjavaid updated the diff for D82866: [LLDB] Test SVE dynamic resize with multiple threads.

Update after moving SVE supported function to lldbtest.py

Mon, Aug 31, 7:08 AM
omjavaid updated the diff for D82853: [LLDB] Support custom expedited register set in gdb-remote.

Fixed review comments.

Mon, Aug 31, 7:07 AM
omjavaid updated the diff for D82855: [LLDB] Send SVE vg register in custom expedited registerset .

Added test case for vg testing.

Mon, Aug 31, 7:06 AM
omjavaid requested review of D86872: [LLDB] Move targetHasSVE function to lldbtest.py.
Mon, Aug 31, 4:42 AM · Restricted Project

Aug 24 2020

omjavaid added a comment to D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.

I didn't look at the scripts in detail but I have a few general (high level) comments:

  • I also feel this should go under lldb/scripts.
  • Can we put the documentations as RST under lldb/docs so it's rendered on the website? We already have bunch of developer resources there. That will certainly help with discovery.
  • LLVM generally encourages scripts to be written in Python. While it doesn't look like this will work out of the box on Windows, I can imagine someone might be interested in that down the line. I also think the bar is lower for new contributors to write Python than bash. I'm kind of on the fence here because there's a reasonable balance between just running commands and control flow, but then I've been scarred by the build-script-impl disaster in Swift so I lean towards better safe than sorry.
Aug 24 2020, 5:32 PM · Restricted Project
omjavaid added a comment to D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset.

The new API looks fairly confusing. This doesn't sound like something that the SB users should generally know or care about. What would the GetByteOffset function return in the generic case?
I don't find the explanation in the summary convincing. Presumably, you should be able to verify the proper behavior by checking the data (and its size) that the SBValue object holds. If that returns the right thing, who cares about the value of the offset field?

Aug 24 2020, 5:22 PM
omjavaid updated the diff for D82866: [LLDB] Test SVE dynamic resize with multiple threads.

This update changes this test;s dependence on register offset API.

Aug 24 2020, 5:19 PM
omjavaid committed rG4283320b7286: [LLDB] Fix SVE offset calculation in NativeRegisterContextLinux_arm64 (authored by omjavaid).
[LLDB] Fix SVE offset calculation in NativeRegisterContextLinux_arm64
Aug 24 2020, 4:43 PM
omjavaid updated the diff for D82866: [LLDB] Test SVE dynamic resize with multiple threads.

Updated after changes to TestSVERegister.py for detecting SVE support using /proc/cpuinfo

Aug 24 2020, 3:28 AM
omjavaid updated the diff for D82855: [LLDB] Send SVE vg register in custom expedited registerset .

Updated after changes to parent rev D82853

Aug 24 2020, 3:25 AM
omjavaid updated the diff for D82853: [LLDB] Support custom expedited register set in gdb-remote.

This reworks previous implementation by returning a vector containing register numbers to be expedited. Default case is minimal set of generic registers or complete register set 0.

Aug 24 2020, 3:21 AM

Aug 19 2020

omjavaid committed rGbd791e97f8bb: [LLDB] Minor fix in TestSVERegisters.py for AArch64/Linux buildbot (authored by omjavaid).
[LLDB] Minor fix in TestSVERegisters.py for AArch64/Linux buildbot
Aug 19 2020, 3:51 AM
omjavaid added a comment to D82855: [LLDB] Send SVE vg register in custom expedited registerset .

@labath ping!

Aug 19 2020, 3:20 AM
omjavaid updated the diff for D82855: [LLDB] Send SVE vg register in custom expedited registerset .

This revision updated after rebase.

Aug 19 2020, 3:20 AM
omjavaid added a comment to D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote.

@labath ping!

Aug 19 2020, 3:13 AM
omjavaid added a comment to D82853: [LLDB] Support custom expedited register set in gdb-remote.

@labath ping!

Aug 19 2020, 3:13 AM
omjavaid added a comment to D82863: [LLDB] Add support to resize SVE registers at run-time.

@labath ping!

Aug 19 2020, 3:12 AM
omjavaid added a comment to D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset.

@labath ping!

Aug 19 2020, 3:12 AM
omjavaid committed rG567ba6c468b9: [LLDB] Add ptrace register access for AArch64 SVE registers (authored by omjavaid).
[LLDB] Add ptrace register access for AArch64 SVE registers
Aug 19 2020, 3:11 AM
omjavaid closed D79699: Add ptrace register access for AArch64 SVE registers.
Aug 19 2020, 3:11 AM · Restricted Project
omjavaid committed rGaf4f40c376f5: [LLDB] NativeThreadLinux invalidate register cache on stop (authored by omjavaid).
[LLDB] NativeThreadLinux invalidate register cache on stop
Aug 19 2020, 12:31 AM
omjavaid closed D84501: NativeThreadLinux invalidate register cache on stop.
Aug 19 2020, 12:31 AM · Restricted Project
omjavaid committed rG090306fc80db: Convert SVE macros into c++ constants and inlines (authored by omjavaid).
Convert SVE macros into c++ constants and inlines
Aug 19 2020, 12:29 AM
omjavaid closed D85641: [LLDB] Convert SVE macros into c++ constants and inlines.
Aug 19 2020, 12:28 AM · Restricted Project

Aug 17 2020

omjavaid updated the diff for D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.

In light of review comments I have come up with this new sceheme for setting up QEMU VM based testing environment for LLDB.

Aug 17 2020, 3:50 PM · Restricted Project
omjavaid updated the diff for D85641: [LLDB] Convert SVE macros into c++ constants and inlines.

This update fixes SVE namespace name to lower case and fixes a typo in previous update.

Aug 17 2020, 4:04 AM · Restricted Project
omjavaid updated the diff for D79699: Add ptrace register access for AArch64 SVE registers.

This update adds check for SVE support using /proc/cpuinfo in SVE testcases. Also tests case to read predicate registers with 5 different values instead of 0xff.

Aug 17 2020, 4:03 AM · Restricted Project

Aug 13 2020

omjavaid added a comment to D79699: Add ptrace register access for AArch64 SVE registers.

@labath Any further action needed on this change? I have updated test main.c for doing asm write to SVE regs and then reading them back during testing. Also i have removed NativeProcessLinux_arm64 dependence on LinuxPTraceDefines_arm64sve.h. We are using sys root's ptrace.h as SVE marcros are back ported in most versions of ptrace.h.

Aug 13 2020, 3:27 AM · Restricted Project

Aug 10 2020

omjavaid updated the diff for D79699: Add ptrace register access for AArch64 SVE registers.

This patch fixes review items from last review cycles. Now we do not use LinuxPTraceDefines_arm64sve.h for NativeProcessLinux_arm64 as these defs are already back ported into libc ptrace.h available on most distros. LLDB arm64 build bot and release builders should already have the header included.

Aug 10 2020, 5:36 AM · Restricted Project
omjavaid requested review of D85641: [LLDB] Convert SVE macros into c++ constants and inlines.
Aug 10 2020, 5:30 AM · Restricted Project

Aug 8 2020

omjavaid committed rGc888694a8eda: [LLDB] Fix timeout value on expect_gdbremote_sequence (authored by omjavaid).
[LLDB] Fix timeout value on expect_gdbremote_sequence
Aug 8 2020, 11:58 AM
omjavaid closed D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence.
Aug 8 2020, 11:57 AM · Restricted Project

Aug 7 2020

omjavaid updated the diff for D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence.

Fixed as suggested by @JDevlieghere

Aug 7 2020, 3:00 PM · Restricted Project
omjavaid reopened D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform..

This breaks LLDB arm-linux buildbot http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/2651

Aug 7 2020, 1:10 PM · Restricted Project
omjavaid requested review of D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence.
Aug 7 2020, 3:41 AM · Restricted Project

Aug 6 2020

omjavaid committed rG94a5919946a0: [LLDB] Skip test_launch_simple from TestTargetAPI.py on Arm/AArch64 Linux (authored by omjavaid).
[LLDB] Skip test_launch_simple from TestTargetAPI.py on Arm/AArch64 Linux
Aug 6 2020, 5:39 AM
omjavaid accepted D85134: [lldb][AArch64] Correct compile options for Neon corefile.

Thanks for fixing this. SVE was just a typo orignal core files were generated without SVE flag on a aarch64-linux target.

Aug 6 2020, 5:29 AM · Restricted Project
omjavaid requested changes to D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD.
Aug 6 2020, 4:33 AM · Restricted Project, Restricted Project
omjavaid reopened D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD.

FYI I have reverted this change as it was breaking multiple buildbots.

Aug 6 2020, 4:33 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG030ddc0a0bb9: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD: rGd9e191cb178a: Revert "[ELF] Allow sections after a non-SHF_ALLOC section to be covered by….
Aug 6 2020, 4:31 AM
omjavaid committed rGd9e191cb178a: Revert "[ELF] Allow sections after a non-SHF_ALLOC section to be covered by… (authored by omjavaid).
Revert "[ELF] Allow sections after a non-SHF_ALLOC section to be covered by…
Aug 6 2020, 4:31 AM
omjavaid added a reverting change for D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD: rGd9e191cb178a: Revert "[ELF] Allow sections after a non-SHF_ALLOC section to be covered by….
Aug 6 2020, 4:31 AM · Restricted Project, Restricted Project
omjavaid updated subscribers of D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo.

@JDevlieghere This change is is failing LLDB Windows buildbot since build 18051. Can you please fix that?

Thanks for the heads up. I had just pushed a fix:

commit 927afdffbb1deebd83b86d024b67687d758521d0 
Author: Jonas Devlieghere <jonas@devlieghere.com>
Date:   Wed Aug 5 15:37:50 2020 -0700

    [lldb] Skip test_launch_simple on Windows

    Because stdio manipulation unsupported on Windows.
Aug 6 2020, 3:37 AM · Restricted Project

Jul 24 2020

omjavaid updated the diff for D84501: NativeThreadLinux invalidate register cache on stop.

Corrected a typo.

Jul 24 2020, 2:06 AM · Restricted Project
omjavaid updated the diff for D79699: Add ptrace register access for AArch64 SVE registers.

In this update I have moved ConfigureRegisterContext insider InvalidateAllRegisters in light of D84501 where we move InvalidateAllRegisters on every stop rather than doing so before step/resume

Jul 24 2020, 2:03 AM · Restricted Project
Herald added a reviewer for D84501: NativeThreadLinux invalidate register cache on stop: rengolin.
Jul 24 2020, 2:01 AM · Restricted Project

Jul 23 2020

omjavaid added inline comments to D79699: Add ptrace register access for AArch64 SVE registers.
Jul 23 2020, 8:27 PM · Restricted Project
omjavaid added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.

@omjavaid might be interested in checking that.

Jul 23 2020, 3:10 AM · Restricted Project
omjavaid updated the diff for D79699: Add ptrace register access for AArch64 SVE registers.

This update fixes issues highlighted in last review iteration.

Jul 23 2020, 12:09 AM · Restricted Project

Jul 22 2020

omjavaid added inline comments to D79699: Add ptrace register access for AArch64 SVE registers.
Jul 22 2020, 8:29 PM · Restricted Project
omjavaid added inline comments to D79699: Add ptrace register access for AArch64 SVE registers.
Jul 22 2020, 7:47 PM · Restricted Project

Jul 21 2020

omjavaid committed rGb621e8c787b3: [LLDB] Fix build on windows caused by LinuxPTraceDefines_arm64sve.h (authored by omjavaid).
[LLDB] Fix build on windows caused by LinuxPTraceDefines_arm64sve.h
Jul 21 2020, 4:48 AM
omjavaid committed rG510e37c88c12: Revert "Revert "AArch64 SVE register infos and core file support"" (authored by omjavaid).
Revert "Revert "AArch64 SVE register infos and core file support""
Jul 21 2020, 2:32 AM
omjavaid added a reverting change for rGd9920e0199b4: Revert "AArch64 SVE register infos and core file support": rG510e37c88c12: Revert "Revert "AArch64 SVE register infos and core file support"".
Jul 21 2020, 2:32 AM
omjavaid committed rG6960e39eff0a: [LLDB] Fix LinuxPTraceDefines_arm64sve.h for AArch64 Linux host (authored by omjavaid).
[LLDB] Fix LinuxPTraceDefines_arm64sve.h for AArch64 Linux host
Jul 21 2020, 2:32 AM
omjavaid committed rG62ccfb6ed0be: [LLDB] Fix Arm/AArch64 Linux broken build (authored by omjavaid).
[LLDB] Fix Arm/AArch64 Linux broken build
Jul 21 2020, 1:47 AM

Jul 20 2020

omjavaid committed rGd9920e0199b4: Revert "AArch64 SVE register infos and core file support" (authored by omjavaid).
Revert "AArch64 SVE register infos and core file support"
Jul 20 2020, 5:38 AM
omjavaid added a reverting change for rG7e017de0ad62: AArch64 SVE register infos and core file support: rGd9920e0199b4: Revert "AArch64 SVE register infos and core file support".
Jul 20 2020, 5:38 AM
omjavaid committed rG7e017de0ad62: AArch64 SVE register infos and core file support (authored by omjavaid).
AArch64 SVE register infos and core file support
Jul 20 2020, 5:21 AM
omjavaid closed D77047: AArch64 SVE register infos and core file support.
Jul 20 2020, 5:21 AM · Restricted Project
omjavaid committed rG7ca9b589c453: Remove Linux sysroot dependencies of SVE PT macros (authored by omjavaid).
Remove Linux sysroot dependencies of SVE PT macros
Jul 20 2020, 2:55 AM
omjavaid committed rG4923dca9bd8f: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64 (authored by omjavaid).
Remove use of multiple reg index enums by RegisterContextPOSIX_arm64
Jul 20 2020, 2:55 AM
omjavaid closed D83541: Remove Linux sysroot dependencies of SVE PT macros.
Jul 20 2020, 2:55 AM · Restricted Project
omjavaid closed D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64.
Jul 20 2020, 2:55 AM · Restricted Project
omjavaid updated the diff for D83541: Remove Linux sysroot dependencies of SVE PT macros.

One minor last minute change.

Jul 20 2020, 2:17 AM · Restricted Project
omjavaid updated the diff for D77047: AArch64 SVE register infos and core file support.

This update makes minor adjustments before merge in light of final comments.

Jul 20 2020, 2:14 AM · Restricted Project

Jul 17 2020

omjavaid updated the diff for D79699: Add ptrace register access for AArch64 SVE registers.

This revision updates SVE ptrace support to reflect changes we made in SVE core file support specially around handling of FPSR and FPCR.

Jul 17 2020, 4:20 AM · Restricted Project

Jul 16 2020

omjavaid added inline comments to D77047: AArch64 SVE register infos and core file support.
Jul 16 2020, 4:01 PM · Restricted Project
omjavaid updated the diff for D77047: AArch64 SVE register infos and core file support.

This update plugs the holes susceptible to bugs by endianity variations. I have used DataExtractor GetU16 to read flags and vl from user_sve_header. Also removed the memset and replaced it with SetFromMemoryData function.

Jul 16 2020, 3:59 PM · Restricted Project
omjavaid updated the diff for D77047: AArch64 SVE register infos and core file support.

In this update I have addressed issues highlighted in last review iteration.

Jul 16 2020, 5:06 AM · Restricted Project
omjavaid added inline comments to D77047: AArch64 SVE register infos and core file support.
Jul 16 2020, 4:42 AM · Restricted Project

Jul 15 2020

omjavaid committed rG3c2299612945: [LLDB] Disable lldb-vscode test_terminate_commands test on Arm (authored by omjavaid).
[LLDB] Disable lldb-vscode test_terminate_commands test on Arm
Jul 15 2020, 3:34 PM