Page MenuHomePhabricator

DavidSpickett (David Spickett)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 3:51 AM (120 w, 6 d)

Recent Activity

Tue, Jan 12

DavidSpickett added a comment to D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms.

Do you have python enabled in the build? (https://lldb.llvm.org/resources/build.html#preliminaries)

Tue, Jan 12, 2:52 AM · Restricted Project

Thu, Jan 7

DavidSpickett committed rG801c7866e6d4: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA (authored by DavidSpickett).
[lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA
Thu, Jan 7, 2:52 AM
DavidSpickett closed D94084: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA.
Thu, Jan 7, 2:51 AM · Restricted Project

Tue, Jan 5

DavidSpickett added a reviewer for D94084: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA: omjavaid.
Tue, Jan 5, 5:44 AM · Restricted Project
DavidSpickett requested review of D94084: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA.
Tue, Jan 5, 5:43 AM · Restricted Project

Tue, Dec 22

DavidSpickett committed rG781a816d4cac: [llvm][Arm/AArch64] Format extension flags in CPU test failures (authored by DavidSpickett).
[llvm][Arm/AArch64] Format extension flags in CPU test failures
Tue, Dec 22, 3:13 AM
DavidSpickett closed D93448: [llvm][Arm/AArch64] Format extension flags in CPU test failures.
Tue, Dec 22, 3:13 AM · Restricted Project
DavidSpickett added a comment to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..

Great, thanks for the explanation.

Tue, Dec 22, 1:22 AM · Restricted Project
DavidSpickett committed rGa6783cd7b65d: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures (authored by DavidSpickett).
[llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures
Tue, Dec 22, 1:07 AM
DavidSpickett closed D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Tue, Dec 22, 1:07 AM · Restricted Project

Mon, Dec 21

DavidSpickett added a comment to D92006: Refactoring the attribute plugin example to fit the new API.

The last update didn't update the expected errors. I have done so in 9a93f95fce91fb4616cee0f307b564b253789282 and it's now passing. (I think it missed the bots since they don't build examples)

Mon, Dec 21, 8:49 AM · Restricted Project
DavidSpickett committed rG9a93f95fce91: [clang] Fix expected errors in plugin attribute example (authored by DavidSpickett).
[clang] Fix expected errors in plugin attribute example
Mon, Dec 21, 8:48 AM
DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
  • Remove double AEK_NONE in arm1136jf-s test
Mon, Dec 21, 2:49 AM · Restricted Project

Dec 18 2020

DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
  • Remove unused includes
Dec 18 2020, 8:13 AM · Restricted Project
DavidSpickett added a comment to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..

I assume that the signal displays without tag bits just like any other SEGV?

Dec 18 2020, 2:44 AM · Restricted Project
DavidSpickett planned changes to D93226: [lldb] Apply KeyValueExtractorGDBRemote to qProcessInfo.
Dec 18 2020, 2:21 AM · Restricted Project
DavidSpickett planned changes to D93225: [lldb] Add helper class for dealing with key:value; GDB responses.

Have you looked at the how llvm YAML and JSON libraries handle (de)serialization? I was hoping that we could implement something similar to that...

Dec 18 2020, 2:21 AM · Restricted Project

Dec 17 2020

DavidSpickett added a comment to D93448: [llvm][Arm/AArch64] Format extension flags in CPU test failures.

For reference: https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#using-a-predicate-formatter

Dec 17 2020, 3:09 AM · Restricted Project
DavidSpickett added a comment to D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.

@MarkMurrayARM Just updated to properly format the struct, the example in the summary is updated to what you'll get.

Dec 17 2020, 3:08 AM · Restricted Project
DavidSpickett added reviewers for D93448: [llvm][Arm/AArch64] Format extension flags in CPU test failures: MarkMurrayARM, dmgreen.
Dec 17 2020, 3:05 AM · Restricted Project
DavidSpickett requested review of D93448: [llvm][Arm/AArch64] Format extension flags in CPU test failures.
Dec 17 2020, 3:02 AM · Restricted Project
DavidSpickett committed rG7f8779e4e66b: [llvm][AArch64] Actually check expected FPU for CPUs (authored by DavidSpickett).
[llvm][AArch64] Actually check expected FPU for CPUs
Dec 17 2020, 1:16 AM
DavidSpickett closed D93387: [llvm][AArch64] Actually check expected FPU for CPUs.
Dec 17 2020, 1:16 AM · Restricted Project

Dec 16 2020

DavidSpickett updated the summary of D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Dec 16 2020, 8:00 AM · Restricted Project
DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.

Added a custom formatter for the params struct.
(the default is to print the bytes of the struct)

Dec 16 2020, 7:59 AM · Restricted Project
DavidSpickett updated the summary of D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Dec 16 2020, 6:33 AM · Restricted Project
DavidSpickett added inline comments to D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Dec 16 2020, 5:19 AM · Restricted Project
DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
  • clang format
Dec 16 2020, 5:18 AM · Restricted Project
DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.

Change test params to a structure.

Dec 16 2020, 5:17 AM · Restricted Project
DavidSpickett added inline comments to D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Dec 16 2020, 5:07 AM · Restricted Project
DavidSpickett updated the diff for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
  • replace const char* with StringRef in test params
Dec 16 2020, 5:06 AM · Restricted Project
DavidSpickett added a reviewer for D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures: MarkMurrayARM.

I will add a better expect printer for the extension bitfields in a future change, just reorganising the tests here.

Dec 16 2020, 5:02 AM · Restricted Project
DavidSpickett requested review of D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.
Dec 16 2020, 4:59 AM · Restricted Project
DavidSpickett added a reviewer for D93387: [llvm][AArch64] Actually check expected FPU for CPUs: MarkMurrayARM.
Dec 16 2020, 3:01 AM · Restricted Project
DavidSpickett requested review of D93387: [llvm][AArch64] Actually check expected FPU for CPUs.
Dec 16 2020, 3:01 AM · Restricted Project

Dec 15 2020

DavidSpickett added a comment to D93285: [ARM][AArch64] Test case debugging output.

No problem, I'll have something for review in a few days.

Dec 15 2020, 5:27 AM · Restricted Project
DavidSpickett added a comment to D93285: [ARM][AArch64] Test case debugging output.

Also the commit msg " Test case debugging output" should include which test cases, "target parser test cases" would do fine.

Dec 15 2020, 2:09 AM · Restricted Project
DavidSpickett added a comment to D93285: [ARM][AArch64] Test case debugging output.

I see the idea to give some immediate improvement but I think there's more to be done to inform the user properly:

  • Convert all of the runs of ASSERT_TRUE to individual tests using a test fixture (or two), for example [0]
  • Creating a custom assertion message that includes the CPU name and the feature [1]
  • Treating the features as a set, so we can say in one go "the features <list> are missing", instead of a one by one check
  • Printing feature names when we do find a missing bit, you an ask the target parser for that
Dec 15 2020, 2:03 AM · Restricted Project

Dec 14 2020

DavidSpickett added reviewers for D93225: [lldb] Add helper class for dealing with key:value; GDB responses: labath, jasonmolenda.

I realise it's a lot to review but if you have any initial comments on the usability that'd be great. My main point here was to make the if-else chain a bit "safer" and more easily extended. The parsing logic itself I did not change, to keep things clear (though I would like to improve it later).

Dec 14 2020, 8:36 AM · Restricted Project
DavidSpickett requested review of D93226: [lldb] Apply KeyValueExtractorGDBRemote to qProcessInfo.
Dec 14 2020, 8:29 AM · Restricted Project
DavidSpickett requested review of D93225: [lldb] Add helper class for dealing with key:value; GDB responses.
Dec 14 2020, 8:27 AM · Restricted Project
DavidSpickett committed rGaabaca336358: [llvm-objdump] Use "--" for long options in --help text (authored by DavidSpickett).
[llvm-objdump] Use "--" for long options in --help text
Dec 14 2020, 5:11 AM
DavidSpickett closed D92310: [llvm-objdump] Use "--" for long options in --help text.
Dec 14 2020, 5:11 AM · Restricted Project

Dec 10 2020

DavidSpickett added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 10 2020, 5:50 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 10 2020, 4:10 AM · Restricted Project, Restricted Project

Dec 9 2020

DavidSpickett added a comment to D92310: [llvm-objdump] Use "--" for long options in --help text.

Ping on -macho vs --macho question. Anyone else want to chime in?

Dec 9 2020, 4:15 AM · Restricted Project

Dec 2 2020

DavidSpickett planned changes to D92378: [llvm-objdump] Only print unrecognized CPU warning once.

Actually, more generally this warning shouldn't be printed directly to errs() in the lower-level code, but rather somehow fed back to the tool

Dec 2 2020, 4:16 AM · Restricted Project

Dec 1 2020

DavidSpickett requested review of D92378: [llvm-objdump] Only print unrecognized CPU warning once.
Dec 1 2020, 3:28 AM · Restricted Project

Nov 30 2020

DavidSpickett committed rGc3d484673fa7: [llvm-objdump] Require x86 target for mcpu/attr test (authored by DavidSpickett).
[llvm-objdump] Require x86 target for mcpu/attr test
Nov 30 2020, 5:58 AM
DavidSpickett committed rGc2ead57ccf74: [llvm-objdump] Document --mattr=help in --help output (authored by DavidSpickett).
[llvm-objdump] Document --mattr=help in --help output
Nov 30 2020, 4:53 AM
DavidSpickett closed D92305: [llvm-objdump] Document --mattr=help in --help output.
Nov 30 2020, 4:53 AM · Restricted Project
DavidSpickett updated the diff for D92305: [llvm-objdump] Document --mattr=help in --help output.
  • Double # for comment
  • Add dashes to ELF header
Nov 30 2020, 4:51 AM · Restricted Project
DavidSpickett added a comment to D92310: [llvm-objdump] Use "--" for long options in --help text.

For reference it's listed as --macho in https://llvm.org/docs/CommandGuide/llvm-objdump.html#cmdoption-llvm-objdump-macho. However that page is missing some of the "requires -macho" statements so could be a mistake.

Nov 30 2020, 4:30 AM · Restricted Project
DavidSpickett requested review of D92310: [llvm-objdump] Use "--" for long options in --help text.
Nov 30 2020, 3:58 AM · Restricted Project
DavidSpickett updated the summary of D92305: [llvm-objdump] Document --mattr=help in --help output.
Nov 30 2020, 3:57 AM · Restricted Project
DavidSpickett updated the diff for D92305: [llvm-objdump] Document --mattr=help in --help output.
  • Added test for mcpu/mattr=help
  • clang-format
Nov 30 2020, 3:56 AM · Restricted Project
DavidSpickett committed rGa7f8d96b16a3: [lldb] Use llvm::Optional for port in LaunchGDBServer (authored by DavidSpickett).
[lldb] Use llvm::Optional for port in LaunchGDBServer
Nov 30 2020, 3:20 AM
DavidSpickett closed D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer.
Nov 30 2020, 3:20 AM · Restricted Project
DavidSpickett added a comment to D92305: [llvm-objdump] Document --mattr=help in --help output.

This is a follow up to discussion on: https://reviews.llvm.org/D92217

Nov 30 2020, 2:54 AM · Restricted Project
DavidSpickett requested review of D92305: [llvm-objdump] Document --mattr=help in --help output.
Nov 30 2020, 2:51 AM · Restricted Project
DavidSpickett abandoned D92217: [llvm-objdump] Remove -mcpu=help from help text.

I'll tackle the obvious bits first, thanks for the info.

Nov 30 2020, 2:27 AM · Restricted Project
DavidSpickett committed rG98e87f76d0f4: [lldb] Error when there are no ports to launch a gdbserver on (authored by DavidSpickett).
[lldb] Error when there are no ports to launch a gdbserver on
Nov 30 2020, 2:19 AM
DavidSpickett closed D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 30 2020, 2:19 AM · Restricted Project
DavidSpickett updated the diff for D91634: [lldb] Error when there are no ports to launch a gdbserver on.
  • Document default constructor behaviour.
Nov 30 2020, 2:04 AM · Restricted Project
DavidSpickett committed rGb5fbc60e4de4: [clang-format] State where clang-format-diff.py should be run from (authored by DavidSpickett).
[clang-format] State where clang-format-diff.py should be run from
Nov 30 2020, 2:01 AM
DavidSpickett closed D91799: [clang-format] State where clang-format-diff.py should be run from.
Nov 30 2020, 2:00 AM · Restricted Project

Nov 27 2020

DavidSpickett planned changes to D92217: [llvm-objdump] Remove -mcpu=help from help text.
Nov 27 2020, 3:34 AM · Restricted Project
DavidSpickett added a comment to D92217: [llvm-objdump] Remove -mcpu=help from help text.

I figured it needed a file at least to know which target it should list cpus for, but now I see what I was doing wrong:

$ ./bin/llvm-objdump --mcpu=help /tmp/arm64.o -d
Nov 27 2020, 3:34 AM · Restricted Project
DavidSpickett requested review of D92217: [llvm-objdump] Remove -mcpu=help from help text.
Nov 27 2020, 1:49 AM · Restricted Project

Nov 26 2020

DavidSpickett updated the diff for D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer.
  • Reformat GDBRemoteCommunicationServerPlatform.h to fix include order.
Nov 26 2020, 4:09 AM · Restricted Project
DavidSpickett added inline comments to D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 26 2020, 4:06 AM · Restricted Project
DavidSpickett updated the diff for D91634: [lldb] Error when there are no ports to launch a gdbserver on.
  • Use auto for map find
  • Document PortMap functions
  • Remove unnecessary casts
  • Move tests to Process/gdb-remote
  • Cleanup Expected asserts
Nov 26 2020, 4:05 AM · Restricted Project

Nov 24 2020

DavidSpickett added inline comments to D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 24 2020, 7:56 AM · Restricted Project
DavidSpickett added inline comments to D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer.
Nov 24 2020, 7:54 AM · Restricted Project
DavidSpickett added a reviewer for D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer: labath.
Nov 24 2020, 7:50 AM · Restricted Project
DavidSpickett updated the summary of D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 24 2020, 7:50 AM · Restricted Project
DavidSpickett requested review of D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer.
Nov 24 2020, 7:48 AM · Restricted Project
DavidSpickett updated the diff for D91634: [lldb] Error when there are no ports to launch a gdbserver on.
  • Move PortMap into a class we can unittest
  • Use llvm::Expected for GetNextAvailablePort
Nov 24 2020, 7:47 AM · Restricted Project

Nov 20 2020

DavidSpickett added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

FYI my change to add the memory tagging flag (https://reviews.llvm.org/D87442) has landed so you will have some conflicts.

Nov 20 2020, 3:51 AM · Restricted Project
DavidSpickett committed rG32541685b2a9: [lldb][AArch64/Linux] Show memory tagged memory regions (authored by DavidSpickett).
[lldb][AArch64/Linux] Show memory tagged memory regions
Nov 20 2020, 3:22 AM
DavidSpickett closed D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.
Nov 20 2020, 3:22 AM · Restricted Project
DavidSpickett added a comment to D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.

I'm going to stick with the test format as it is. No doubt I'll need to clean it up based on what future MTE tests look like.

Nov 20 2020, 3:21 AM · Restricted Project

Nov 19 2020

DavidSpickett added reviewers for D91799: [clang-format] State where clang-format-diff.py should be run from: djasper, sylvestre.ledru.
Nov 19 2020, 8:36 AM · Restricted Project
DavidSpickett requested review of D91799: [clang-format] State where clang-format-diff.py should be run from.
Nov 19 2020, 8:31 AM · Restricted Project
DavidSpickett updated the diff for D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.
  • Use assertIn
  • Cleanup Status/Error handling
  • Refactor test so it runs once and we skip based on whether it returns a value or hits a breakpoint.
  • Seperated exit codes for non MTE toolchain and non MTE target, for more specific skip reasons.
Nov 19 2020, 7:05 AM · Restricted Project

Nov 18 2020

DavidSpickett retitled D87442: [lldb][AArch64/Linux] Show memory tagged memory regions from [lldb] Show flags for memory regions to [lldb][AArch64/Linux] Show memory tagged memory regions.
Nov 18 2020, 6:43 AM · Restricted Project
DavidSpickett updated the diff for D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.

Updated the way the test works.

  • If you build without MTE in the toolchain the binary just returns the magic failure number.
  • If you do have an MTE toolchain but your target doesn't have MTE then it will also fail with the magic return code.
Nov 18 2020, 6:42 AM · Restricted Project
DavidSpickett added a comment to D91634: [lldb] Error when there are no ports to launch a gdbserver on.

I hadn't considered using a unit test instead, I'll give that a go.

Nov 18 2020, 5:31 AM · Restricted Project
DavidSpickett committed rG50f12ade2de1: [lldb] Fix a couple of remote llgs tests (authored by DavidSpickett).
[lldb] Fix a couple of remote llgs tests
Nov 18 2020, 3:37 AM
DavidSpickett closed D91612: [lldb] Fix a couple of remote llgs tests.
Nov 18 2020, 3:36 AM · Restricted Project
DavidSpickett added a reviewer for D91634: [lldb] Error when there are no ports to launch a gdbserver on: labath.
Nov 18 2020, 2:41 AM · Restricted Project

Nov 17 2020

DavidSpickett updated the summary of D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 17 2020, 8:01 AM · Restricted Project
DavidSpickett updated the summary of D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 17 2020, 8:01 AM · Restricted Project
DavidSpickett added a comment to D91634: [lldb] Error when there are no ports to launch a gdbserver on.

I have found existing tests that launch an lldb-server with specific arguments, using an existing lldb-server platform to do it.

Nov 17 2020, 8:01 AM · Restricted Project
DavidSpickett requested review of D91634: [lldb] Error when there are no ports to launch a gdbserver on.
Nov 17 2020, 7:52 AM · Restricted Project
DavidSpickett added a reviewer for D91612: [lldb] Fix a couple of remote llgs tests: labath.

For reference the argument was removed in: https://reviews.llvm.org/D90313

Nov 17 2020, 4:06 AM · Restricted Project
DavidSpickett added a reviewer for D91612: [lldb] Fix a couple of remote llgs tests: JDevlieghere.

I presume these tests aren't commonly run or have been masked by the expected failures.

Nov 17 2020, 4:04 AM · Restricted Project
DavidSpickett requested review of D91612: [lldb] Fix a couple of remote llgs tests.
Nov 17 2020, 4:02 AM · Restricted Project

Nov 12 2020

DavidSpickett added inline comments to D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.
Nov 12 2020, 6:15 AM · Restricted Project

Nov 11 2020

DavidSpickett added inline comments to D87442: [lldb][AArch64/Linux] Show memory tagged memory regions.
Nov 11 2020, 2:37 AM · Restricted Project