Page MenuHomePhabricator

DavidSpickett (David Spickett)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 3:51 AM (141 w, 6 d)

Recent Activity

Fri, Jun 11

DavidSpickett added a reviewer for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR): momchil.velikov.

Momchil this is the patch to fix what we were talking about. Walking the whole type might be a bit much but it should exit early 99% of the time.

Fri, Jun 11, 8:18 AM · Restricted Project
DavidSpickett added a comment to D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).

Though globalisel doesn't crash with the reported snippet, it does crash on the added tests when we spill to memory. I still need to look into that but I don't think it should block this. (unless the bug reporter turns out to be using globalisel)

Fri, Jun 11, 8:17 AM · Restricted Project
DavidSpickett updated the summary of D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Fri, Jun 11, 8:14 AM · Restricted Project
DavidSpickett requested review of D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Fri, Jun 11, 8:13 AM · Restricted Project
DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.

Rebase

Fri, Jun 11, 6:16 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Rebase

Fri, Jun 11, 6:16 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

Rebase

Fri, Jun 11, 6:16 AM · Restricted Project
DavidSpickett updated the diff for D97282: [lldb][AArch64] Add memory-tagging qSupported feature.

Rebase.

Fri, Jun 11, 6:15 AM · Restricted Project
DavidSpickett updated the diff for D97281: [lldb][AArch64] Add class for managing memory tags.

Rebase

Fri, Jun 11, 6:10 AM · Restricted Project

Thu, Jun 10

DavidSpickett added a comment to rGd69c4372bfbe: [CodeGen] remove instcombine from codegen tests; NFC.

I didn't see any bot fail mails (but that might be intentional?).

Thu, Jun 10, 8:31 AM
DavidSpickett added a comment to rGd69c4372bfbe: [CodeGen] remove instcombine from codegen tests; NFC.

Opened https://bugs.llvm.org/show_bug.cgi?id=50659

Thu, Jun 10, 8:25 AM
DavidSpickett added a comment to rGd69c4372bfbe: [CodeGen] remove instcombine from codegen tests; NFC.

+1 to limiting it to new pass manager. (good spot btw, I was very confused why this was failing for me)

Thu, Jun 10, 4:45 AM
DavidSpickett added a comment to D95425: Implementation of global.get/set for reftypes in LLVM IR.

Also affecting riscv-v (riscvv?) so I've reverted the change.

Thu, Jun 10, 3:12 AM · Restricted Project, Restricted Project
DavidSpickett added a reverting change for rG31859f896cf9: Implementation of global.get/set for reftypes in LLVM IR: rG64de8763aa7c: Revert "Implementation of global.get/set for reftypes in LLVM IR".
Thu, Jun 10, 3:12 AM
DavidSpickett committed rG64de8763aa7c: Revert "Implementation of global.get/set for reftypes in LLVM IR" (authored by DavidSpickett).
Revert "Implementation of global.get/set for reftypes in LLVM IR"
Thu, Jun 10, 3:12 AM
DavidSpickett added a reverting change for D95425: Implementation of global.get/set for reftypes in LLVM IR: rG64de8763aa7c: Revert "Implementation of global.get/set for reftypes in LLVM IR".
Thu, Jun 10, 3:11 AM · Restricted Project, Restricted Project
DavidSpickett committed rG7fb1f62d12c6: [clang][Arm] Require arm and aarch64 target for bf16 intrinsics test (authored by DavidSpickett).
[clang][Arm] Require arm and aarch64 target for bf16 intrinsics test
Thu, Jun 10, 2:46 AM
DavidSpickett added a comment to D95425: Implementation of global.get/set for reftypes in LLVM IR.

Hi @pmatos, this has caused SVE related failures on our AArch64 bot (and probably others):
https://lab.llvm.org/buildbot/#/builders/43/builds/7187

Thu, Jun 10, 2:08 AM · Restricted Project, Restricted Project

Wed, Jun 9

DavidSpickett accepted D103963: [zorg] Remove settings that match defaults from Linaro bots.

LGTM, thanks.

Wed, Jun 9, 9:39 AM
DavidSpickett added a comment to D103957: [zorg] Rename Linaro's AArch64 and ARM bots to use consistent names.

If you're using arc it doesn't update the description for you unfortunately. (I wish it did) You can "edit revision" and change it there, but either way the message that you push with is the one that ends up in the repo, the phab one is just for phab.

Wed, Jun 9, 6:24 AM
DavidSpickett added inline comments to D103470: [zorg] Add AArch64 SVE vector-length-specific (VLS) bot.
Wed, Jun 9, 6:22 AM
DavidSpickett accepted D103468: [zorg] Cleanup clang-cmake-{armv7,aarch64}-quick bots.
Wed, Jun 9, 5:52 AM
DavidSpickett accepted D103957: [zorg] Rename Linaro's AArch64 and ARM bots to use consistent names.
Wed, Jun 9, 5:52 AM
DavidSpickett added a reviewer for D103957: [zorg] Rename Linaro's AArch64 and ARM bots to use consistent names: DavidSpickett.

You should mention in the commit msg that this also removes the libcxx bot names, which moved to buildkite a while ago.

Wed, Jun 9, 5:51 AM
DavidSpickett added inline comments to D103470: [zorg] Add AArch64 SVE vector-length-specific (VLS) bot.
Wed, Jun 9, 5:36 AM
DavidSpickett added a reviewer for D103468: [zorg] Cleanup clang-cmake-{armv7,aarch64}-quick bots: DavidSpickett.
Wed, Jun 9, 5:31 AM
DavidSpickett committed rG11ad9e31eb3b: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb (authored by DavidSpickett).
[compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb
Wed, Jun 9, 1:50 AM
DavidSpickett closed D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb.
Wed, Jun 9, 1:50 AM · Restricted Project
DavidSpickett added a comment to D103701: [lldb] Set return status to failed when adding a command error.

1 failure on MacOS "lldb-api :: commands/register/register/register_command/TestRegisters.py", http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/detail/lldb-cmake/32693/pipeline/, hence the revert.

Wed, Jun 9, 1:46 AM · Restricted Project
DavidSpickett added a reverting change for rGe05b03cf4f45: [lldb] Set return status to failed when adding a command error: rGdb93e4e70aa4: Revert "[lldb] Set return status to failed when adding a command error".
Wed, Jun 9, 1:43 AM
DavidSpickett committed rGdb93e4e70aa4: Revert "[lldb] Set return status to failed when adding a command error" (authored by DavidSpickett).
Revert "[lldb] Set return status to failed when adding a command error"
Wed, Jun 9, 1:43 AM
DavidSpickett added a reverting change for D103701: [lldb] Set return status to failed when adding a command error: rGdb93e4e70aa4: Revert "[lldb] Set return status to failed when adding a command error".
Wed, Jun 9, 1:43 AM · Restricted Project

Tue, Jun 8

DavidSpickett added a comment to D103701: [lldb] Set return status to failed when adding a command error.

I've gone ahead and landed it, will revert on failures.

Tue, Jun 8, 1:43 AM · Restricted Project
DavidSpickett committed rGe05b03cf4f45: [lldb] Set return status to failed when adding a command error (authored by DavidSpickett).
[lldb] Set return status to failed when adding a command error
Tue, Jun 8, 1:41 AM
DavidSpickett closed D103701: [lldb] Set return status to failed when adding a command error.
Tue, Jun 8, 1:41 AM · Restricted Project
DavidSpickett added a comment to rG98a7563261ff: [scudo] Mark ARM64 as supported platform.

Yes moving the bots to clang 12 did the trick.

Tue, Jun 8, 1:21 AM

Mon, Jun 7

DavidSpickett accepted D103744: [lldb][docs] Remove mention of subversion. NFC..

LGTM

Mon, Jun 7, 12:32 AM · Restricted Project
DavidSpickett accepted D103184: [AArch64] handle -Wa,-march=.

LGTM

Mon, Jun 7, 12:27 AM · Restricted Project

Fri, Jun 4

DavidSpickett added a comment to D103701: [lldb] Set return status to failed when adding a command error.

I can run this for you on macOS and Linux x86 which I think should cover every test.

Fri, Jun 4, 9:22 AM · Restricted Project
DavidSpickett added a comment to D103701: [lldb] Set return status to failed when adding a command error.

There are likely other tests that aren't enabled for x86/AArch64 or sets of registers that I don't have on my machines. So if this change is welcome then the plan would be to land this as is and monitor the bots for a week or so, revert and reland with test fixups as needed.

Fri, Jun 4, 9:03 AM · Restricted Project
DavidSpickett requested review of D103701: [lldb] Set return status to failed when adding a command error.
Fri, Jun 4, 9:00 AM · Restricted Project
DavidSpickett accepted D103184: [AArch64] handle -Wa,-march=.

LGTM; any additional thoughts @DavidSpickett ?

Fri, Jun 4, 1:38 AM · Restricted Project

Thu, Jun 3

DavidSpickett added a reviewer for D103626: [lldb][AArch64] Remove non address bits from memory read arguments: omjavaid.

The side effect here is that you do "memory read <tagged ptr>" and you see untagged addresses for the lines. It's not really that confusing but maybe something we should make a general decision about.

Thu, Jun 3, 9:12 AM · Restricted Project
DavidSpickett requested review of D103626: [lldb][AArch64] Remove non address bits from memory read arguments.
Thu, Jun 3, 9:09 AM · Restricted Project
DavidSpickett retitled D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb from [compiler-rt] Require fast unwinder for symbolize_stack_fp test to [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb.
Thu, Jun 3, 2:06 AM · Restricted Project
DavidSpickett committed rGf4543dce5db5: [clang][ARM] Remove arm2/3/6/7m CPU names (authored by DavidSpickett).
[clang][ARM] Remove arm2/3/6/7m CPU names
Thu, Jun 3, 1:56 AM
DavidSpickett closed D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.
Thu, Jun 3, 1:55 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.

Clang format

Thu, Jun 3, 1:55 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb.

Use thumb feature instead.

Thu, Jun 3, 1:50 AM · Restricted Project

Wed, Jun 2

DavidSpickett added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Back to green https://lab.llvm.org/buildbot/#/builders/43/builds/6834, thanks!

Wed, Jun 2, 7:23 AM · Restricted Project
DavidSpickett committed rG8c363efecc56: [compiler-rt][lsan] Increase libdl_deadlock test timeout (authored by DavidSpickett).
[compiler-rt][lsan] Increase libdl_deadlock test timeout
Wed, Jun 2, 6:38 AM
DavidSpickett added a comment to D102046: [sanitizer] Fall back to fast unwinder.

I have implemented that requires for Arm in https://reviews.llvm.org/D103512.

Wed, Jun 2, 6:03 AM · Restricted Project
DavidSpickett committed rGba99359796ba: [compiler-rt][asan] Enable unwind-tables for Arm Linux (authored by DavidSpickett).
[compiler-rt][asan] Enable unwind-tables for Arm Linux
Wed, Jun 2, 6:00 AM
DavidSpickett closed D103463: [compiler-rt][asan] Enable unwind-tables for Arm Linux.
Wed, Jun 2, 5:59 AM · Restricted Project
DavidSpickett added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Since this change LLVM :: Analysis/CostModel/AArch64/bitreverse.ll is failing.

Wed, Jun 2, 5:54 AM · Restricted Project
DavidSpickett retitled D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb from [compiler-rt] Require fast unwinder for test to [compiler-rt] Require fast unwinder for symbolize_stack_fp test.
Wed, Jun 2, 4:21 AM · Restricted Project
DavidSpickett added a reviewer for D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb: MaskRay.
Wed, Jun 2, 4:12 AM · Restricted Project
DavidSpickett requested review of D103512: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb.
Wed, Jun 2, 4:09 AM · Restricted Project
DavidSpickett added a comment to rGa6e5a4b464be: [NFC][scudo] Re-enable check in the test.

This test is failing on our v7 bot: https://lab.llvm.org/buildbot/#/builders/59/builds/1938

Wed, Jun 2, 3:55 AM
DavidSpickett added inline comments to D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.
Wed, Jun 2, 3:38 AM · Restricted Project, Restricted Project
DavidSpickett retitled D103028: [clang][ARM] Remove arm2/3/6/7m CPU names from [llvm][ARM] Add CPU defs for arm2/3/6/7m to [clang][ARM] Remove arm2/3/6/7m CPU names.
Wed, Jun 2, 3:37 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.

Instead of adding CPUs to llvm, remove them from clang.

Wed, Jun 2, 3:36 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D103184: [AArch64] handle -Wa,-march=.
$ cat /tmp/test.s
irg x0, x0
$ aarch64-unknown-linux-gnu-as -march=armv8.5-a+memtag -march=armv8.1-a /tmp/test.s -o /dev/null
/tmp/test.s: Assembler messages:
/tmp/test.s:1: Error: selected processor does not support `irg x0,x0'
Wed, Jun 2, 2:30 AM · Restricted Project
DavidSpickett added a comment to D103184: [AArch64] handle -Wa,-march=.

I understand it's a little bit confusing here, but I was simply trying to match GCC's behavior (please see the example in my last comment) unless I misunderstood its output. I definitely agree having consistent behaviors between Arm and Aarch64 in Clang is more reasonable (in fact that was what I implemented at first) and maybe we should fork from gcc, WDYT?

Wed, Jun 2, 1:46 AM · Restricted Project

Tue, Jun 1

DavidSpickett added a reviewer for D103463: [compiler-rt][asan] Enable unwind-tables for Arm Linux: zatrazz.

https://lab.llvm.org/buildbot/#/builders/26/builds/2096, the sanitizer-common test needs to be handled in its own way since it's disabling things itself.

Tue, Jun 1, 8:02 AM · Restricted Project
DavidSpickett updated the diff for D103463: [compiler-rt][asan] Enable unwind-tables for Arm Linux.

Remove newline

Tue, Jun 1, 8:00 AM · Restricted Project
DavidSpickett requested review of D103463: [compiler-rt][asan] Enable unwind-tables for Arm Linux.
Tue, Jun 1, 7:59 AM · Restricted Project
DavidSpickett added a comment to D102046: [sanitizer] Fall back to fast unwinder.

We have the same test failing on thumb because the fast unwinder doesn't (can't, for various reasons) work. Perhaps:

// REQUIRES: fast-unwinder-works
Tue, Jun 1, 7:02 AM · Restricted Project
DavidSpickett added a comment to D103184: [AArch64] handle -Wa,-march=.

Thanks for taking this up! I never got the time for it.

Tue, Jun 1, 1:57 AM · Restricted Project

Wed, May 26

DavidSpickett added a comment to D102757: [lldb] Remove non address bits when looking up memory regions.

One thing that you might think of would be the top bits set for kernel alloations. However if we're using the masks and TBI correctly those will be left intact.

Wed, May 26, 4:16 AM · Restricted Project
DavidSpickett added a comment to D102757: [lldb] Remove non address bits when looking up memory regions.

Now that we are stripping away top byte is there any information that may be useful for the remote side and we are removing that on the host side. I am thinking why we should strip top byte on host side rather than making it the responsibility of the remote end?

Wed, May 26, 4:09 AM · Restricted Project
DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.

Rebase

Wed, May 26, 3:53 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Rebase, fix up SendPacketAndWaitForResponse use.

Wed, May 26, 3:52 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

I was looking at the wrong file, this adds the header.

Wed, May 26, 3:44 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

Rebase, which brings in the header pcc mentioned.

Wed, May 26, 3:40 AM · Restricted Project
DavidSpickett updated the diff for D97282: [lldb][AArch64] Add memory-tagging qSupported feature.
Wed, May 26, 3:38 AM · Restricted Project
DavidSpickett updated the diff for D97282: [lldb][AArch64] Add memory-tagging qSupported feature.

Rebase

Wed, May 26, 3:37 AM · Restricted Project
DavidSpickett updated the diff for D97281: [lldb][AArch64] Add class for managing memory tags.

Rebase

Wed, May 26, 3:36 AM · Restricted Project
DavidSpickett resigned from D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support.

Resigning to remove my requested changes, if that works. Looks good from my point of view.

Wed, May 26, 3:17 AM · Restricted Project
DavidSpickett added a comment to D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support.

I realised my mistake, I thought this was adding a new core file but in fact it's using the one you added for the register tests. So now the outfile is there the test passes.

Wed, May 26, 3:14 AM · Restricted Project

Tue, May 25

DavidSpickett committed rG8427053f8192: [clang][ARM] When handling multiple -mimplicit-it mark all as used (authored by DavidSpickett).
[clang][ARM] When handling multiple -mimplicit-it mark all as used
Tue, May 25, 7:53 AM
DavidSpickett closed D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used.
Tue, May 25, 7:53 AM · Restricted Project
DavidSpickett retitled D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used from [clang][ARM] When handling multiple -mimplcit-it mark all as used to [clang][ARM] When handling multiple -mimplicit-it mark all as used.
Tue, May 25, 7:01 AM · Restricted Project
DavidSpickett added a reviewer for D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used: mstorsjo.

You could argue that one of them is actually "unused" but I tried -march which also takes the last value and that does not warn when it ignores earlier values.

Tue, May 25, 7:00 AM · Restricted Project
DavidSpickett requested review of D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used.
Tue, May 25, 6:57 AM · Restricted Project
DavidSpickett added a comment to D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

David, could you please route that bug to whoever is now responsible for leading that group?

Tue, May 25, 4:36 AM
DavidSpickett committed rGde7729d47a8b: [clang][ARM] Remove non-existent arm9312 CPU (authored by DavidSpickett).
[clang][ARM] Remove non-existent arm9312 CPU
Tue, May 25, 1:58 AM
DavidSpickett closed D103024: [clang][ARM] Remove non-existent arm9312 CPU.
Tue, May 25, 1:58 AM · Restricted Project
DavidSpickett committed rG0cd2629d97e7: [llvm][ARM] Remove non-existent arm1176j-s CPU (authored by DavidSpickett).
[llvm][ARM] Remove non-existent arm1176j-s CPU
Tue, May 25, 1:57 AM
DavidSpickett closed D103022: [llvm][ARM] Remove non-existent arm1176j-s CPU.
Tue, May 25, 1:57 AM · Restricted Project
DavidSpickett committed rG5f4d383a5935: [clang][ARM] Remove non-existent arm1136jz-s CPU (authored by DavidSpickett).
[clang][ARM] Remove non-existent arm1136jz-s CPU
Tue, May 25, 1:55 AM
DavidSpickett closed D103019: [clang][ARM] Remove non-existent arm1136jz-s CPU.
Tue, May 25, 1:55 AM · Restricted Project
DavidSpickett planned changes to D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.

@nickdesaulniers Can you confirm whether the kernel CI report you got was intentionally setting armv3m? If the build isn't setting an mcpu then removing the CPUs won't actually break it, though what it generates likely wouldn't run correctly.

Tue, May 25, 1:18 AM · Restricted Project, Restricted Project

Mon, May 24

DavidSpickett added reviewers for D103028: [clang][ARM] Remove arm2/3/6/7m CPU names: nickdesaulniers, peter.smith, ostannard.

@nickdesaulniers With this you won't get warnings for https://github.com/ClangBuiltLinux/linux/issues/921.

Mon, May 24, 7:42 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D103028: [clang][ARM] Remove arm2/3/6/7m CPU names.
Mon, May 24, 7:40 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D103024: [clang][ARM] Remove non-existent arm9312 CPU: nickdesaulniers, peter.smith, ostannard.
Mon, May 24, 7:04 AM · Restricted Project
DavidSpickett requested review of D103024: [clang][ARM] Remove non-existent arm9312 CPU.
Mon, May 24, 7:04 AM · Restricted Project
DavidSpickett added reviewers for D103022: [llvm][ARM] Remove non-existent arm1176j-s CPU: nickdesaulniers, peter.smith, ostannard.
Mon, May 24, 6:55 AM · Restricted Project
DavidSpickett requested review of D103022: [llvm][ARM] Remove non-existent arm1176j-s CPU.
Mon, May 24, 6:54 AM · Restricted Project
DavidSpickett added a comment to D103019: [clang][ARM] Remove non-existent arm1136jz-s CPU.

GCC also doesn't recognise it: https://gcc.gnu.org/onlinedocs/gcc-6.1.0/gcc/ARM-Options.html

Mon, May 24, 6:51 AM · Restricted Project