Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (319 w, 5 d)

Recent Activity

Thu, Jul 30

arphaman updated the diff for D84908: [darwin][compiler-rt] build libclang_rt.<os>sim.a Apple Silicon slice, if SDK supports it.

don't check if the SDK isn't present.

Thu, Jul 30, 9:42 AM

Wed, Jul 29

arphaman requested review of D84908: [darwin][compiler-rt] build libclang_rt.<os>sim.a Apple Silicon slice, if SDK supports it.
Wed, Jul 29, 8:12 PM
arphaman committed rGdc22182d1f74: [darwin] build and link with a separate compiler-rt builtins library (authored by arphaman).
[darwin] build and link with a separate compiler-rt builtins library
Wed, Jul 29, 3:34 PM
arphaman closed D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators.
Wed, Jul 29, 3:34 PM · Restricted Project, Restricted Project

Fri, Jul 24

Herald added projects to D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators: Restricted Project, Restricted Project.
Fri, Jul 24, 4:12 PM · Restricted Project, Restricted Project

Thu, Jul 23

arphaman accepted D83688: [Bitcode] Avoid duplicating linker option when upgrading.
Thu, Jul 23, 12:22 PM · Restricted Project

Mon, Jul 20

arphaman added inline comments to D66854: [index-while-building] PathIndexer.
Mon, Jul 20, 9:16 PM

Tue, Jul 14

GitHub <noreply@github.com> committed rG2137d5bc9d95: Merge pull request #1408 from hyp/eng/canonicalize-1016-triple (authored by arphaman).
Merge pull request #1408 from hyp/eng/canonicalize-1016-triple
Tue, Jul 14, 4:56 PM
arphaman committed rG9fd29837db79: macOS 11 support: add a temporary macOS 10.16 -> macOS 11 triple… (authored by arphaman).
macOS 11 support: add a temporary macOS 10.16 -> macOS 11 triple…
Tue, Jul 14, 4:56 PM
GitHub <noreply@github.com> committed rG7b8a7c4b08dc: Merge pull request #1397 from hyp/apple-silicon-macos11 (authored by arphaman).
Merge pull request #1397 from hyp/apple-silicon-macos11
Tue, Jul 14, 4:56 PM
arphaman committed rGb6ea8265b6ba: Fix the driver logic for dealing with macOS version checks for Mac Catalyst… (authored by arphaman).
Fix the driver logic for dealing with macOS version checks for Mac Catalyst…
Tue, Jul 14, 4:56 PM
arphaman committed rG744ac977d611: [macho] emit LC_BUILD_VERSION load command for supported OSes and platforms (authored by arphaman).
[macho] emit LC_BUILD_VERSION load command for supported OSes and platforms
Tue, Jul 14, 4:56 PM
arphaman committed rG5aa7d5b69cb6: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if… (authored by arphaman).
canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if…
Tue, Jul 14, 4:56 PM
arphaman committed rG05f0eaeff4f6: [darwin][driver] pass the minimum supported OS version to the linker if it's… (authored by arphaman).
[darwin][driver] pass the minimum supported OS version to the linker if it's…
Tue, Jul 14, 4:55 PM
arphaman committed rGd0b68290c81c: [darwin][driver] isMacosxVersionLT should check against the minimum supported… (authored by arphaman).
[darwin][driver] isMacosxVersionLT should check against the minimum supported…
Tue, Jul 14, 4:55 PM
arphaman committed rG551c3a711322: [darwin][driver] NFC, split addStartObjectFileArgs into multiple functions (authored by arphaman).
[darwin][driver] NFC, split addStartObjectFileArgs into multiple functions
Tue, Jul 14, 4:55 PM
arphaman committed rG2776fa1951d0: [darwin][driver] Do not link with libarclite when building for Apple Silicon… (authored by arphaman).
[darwin][driver] Do not link with libarclite when building for Apple Silicon…
Tue, Jul 14, 4:55 PM
arphaman committed rG3e9a7de65274: test fix: add missing system-darwin REQUIRES (authored by arphaman).
test fix: add missing system-darwin REQUIRES
Tue, Jul 14, 4:55 PM
arphaman committed rG8ce5b6b2112c: [clang][driver] set macOS as the target OS for -arch arm64 when clang is… (authored by arphaman).
[clang][driver] set macOS as the target OS for -arch arm64 when clang is…
Tue, Jul 14, 4:55 PM
arphaman committed rG6be6e117b4aa: [clang][driver] allow macOS 11 OS version in the driver (authored by arphaman).
[clang][driver] allow macOS 11 OS version in the driver
Tue, Jul 14, 4:55 PM
arphaman committed rG927d93379271: [cmake] configure the host triple on an Apple Silicon machine correctly (authored by arphaman).
[cmake] configure the host triple on an Apple Silicon machine correctly
Tue, Jul 14, 4:55 PM
arphaman committed rG1206ecdf02c5: [Triple] support macOS 11 os version number (authored by arphaman).
[Triple] support macOS 11 os version number
Tue, Jul 14, 4:55 PM
GitHub <noreply@github.com> committed rG8880a4cb0e16: Merge pull request #1308 from martinboehme/cherrypick-no-undeclared-includes-fix (authored by arphaman).
Merge pull request #1308 from martinboehme/cherrypick-no-undeclared-includes-fix
Tue, Jul 14, 4:54 PM
GitHub <noreply@github.com> committed rGbca7b4310255: Merge pull request #1282 from vedantk/cherry (authored by arphaman).
Merge pull request #1282 from vedantk/cherry
Tue, Jul 14, 4:53 PM
GitHub <noreply@github.com> committed rG5a55401d9423: Merge pull request #1230 from hyp/cherry… (authored by arphaman).
Merge pull request #1230 from hyp/cherry…
Tue, Jul 14, 4:51 PM
arphaman committed rG998001ceeb67: [clang][VerifyDiagnosticConsumer] Support filename wildcards (authored by arames).
[clang][VerifyDiagnosticConsumer] Support filename wildcards
Tue, Jul 14, 4:50 PM
GitHub <noreply@github.com> committed rGb1269c320697: Merge pull request #1227 from hyp/eng/PR-59361291 (authored by arphaman).
Merge pull request #1227 from hyp/eng/PR-59361291
Tue, Jul 14, 4:50 PM
arphaman committed rG8267d57f077c: [clang][Preprocessor] Replace the slow translateFile call by a new, faster… (authored by arphaman).
[clang][Preprocessor] Replace the slow translateFile call by a new, faster…
Tue, Jul 14, 4:50 PM
GitHub <noreply@github.com> committed rG9873fdc47867: Merge pull request #1225 from hyp/fixup-implicit-func-tests (authored by arphaman).
Merge pull request #1225 from hyp/fixup-implicit-func-tests
Tue, Jul 14, 4:50 PM
arphaman committed rGbf6720f2973c: [test] NFC, add missing declarations and include to test files to avoid… (authored by arphaman).
[test] NFC, add missing declarations and include to test files to avoid…
Tue, Jul 14, 4:50 PM
arphaman committed rGe4de877390d5: Revert "Merge pull request #754 from Bigcheese/scan-deps-stable" (authored by arphaman).
Revert "Merge pull request #754 from Bigcheese/scan-deps-stable"
Tue, Jul 14, 4:22 PM
arphaman added a reverting change for rG8bd683f83e1f: Merge pull request #754 from Bigcheese/scan-deps-stable: rGe4de877390d5: Revert "Merge pull request #754 from Bigcheese/scan-deps-stable".
Tue, Jul 14, 4:22 PM
arphaman committed rGfe07d64a36bd: Add CODEOWNERS to protect the branch (authored by arphaman).
Add CODEOWNERS to protect the branch
Tue, Jul 14, 4:21 PM
GitHub <noreply@github.com> committed rG5cf370d4f491: Merge pull request #688 from hyp/cherry_ibuiltin (authored by arphaman).
Merge pull request #688 from hyp/cherry_ibuiltin
Tue, Jul 14, 4:18 PM
arphaman committed rG3328095992b8: [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver include Clang… (authored by arphaman).
[driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver include Clang…
Tue, Jul 14, 4:18 PM
GitHub <noreply@github.com> committed rG5e17daf351ca: Merge pull request #626 from ornata/apple/stable/20200108 (authored by arphaman).
Merge pull request #626 from ornata/apple/stable/20200108
Tue, Jul 14, 4:15 PM
GitHub <noreply@github.com> committed rG15d75a0030a1: Merge pull request #615 from hyp/revert-dvfe (authored by arphaman).
Merge pull request #615 from hyp/revert-dvfe
Tue, Jul 14, 4:15 PM
arphaman committed rG0304533e700d: Revert "Reland: Dead Virtual Function Elimination" (authored by arphaman).
Revert "Reland: Dead Virtual Function Elimination"
Tue, Jul 14, 4:15 PM
arphaman added a reverting change for rG3b598b9c867a: Reland: Dead Virtual Function Elimination: rG0304533e700d: Revert "Reland: Dead Virtual Function Elimination".
Tue, Jul 14, 4:15 PM
arphaman added a comment to D66854: [index-while-building] PathIndexer.

Sure, will do.

Tue, Jul 14, 11:04 AM

Jul 6 2020

arphaman accepted D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver.
Jul 6 2020, 1:38 PM · Restricted Project
arphaman added a comment to D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver.

Please add a test-case as well.

Jul 6 2020, 12:50 PM · Restricted Project

Jun 30 2020

arphaman committed rGc8f1d442d085: split darwin-version-min-load-command.s into Arm64 subtest to avoid failures (authored by arphaman).
split darwin-version-min-load-command.s into Arm64 subtest to avoid failures
Jun 30 2020, 3:14 PM
arphaman committed rG24a1447b0285: [macho] emit LC_BUILD_VERSION load command for supported OSes and platforms (authored by arphaman).
[macho] emit LC_BUILD_VERSION load command for supported OSes and platforms
Jun 30 2020, 11:59 AM
arphaman closed D82836: [macho] emit LC_BUILD_VERSION load command for supported OSes and platforms.
Jun 30 2020, 11:59 AM · Restricted Project

Jun 29 2020

arphaman accepted D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.

LGTM.

Jun 29 2020, 10:00 PM · Restricted Project
arphaman created D82836: [macho] emit LC_BUILD_VERSION load command for supported OSes and platforms.
Jun 29 2020, 9:28 PM · Restricted Project
arphaman committed rGbb162dfe252a: [clang] attempt to fix a linux test failure for the darwin-ld-platform-version… (authored by arphaman).
[clang] attempt to fix a linux test failure for the darwin-ld-platform-version…
Jun 29 2020, 8:25 PM
arphaman committed rG6792a6077889: [darwin][driver] pass the minimum supported OS version to the linker if it's… (authored by arphaman).
[darwin][driver] pass the minimum supported OS version to the linker if it's…
Jun 29 2020, 7:30 PM
arphaman created D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16.
Jun 29 2020, 5:13 PM
arphaman committed rGf7a14514ee63: [darwin][driver] isMacosxVersionLT should check against the minimum supported… (authored by arphaman).
[darwin][driver] isMacosxVersionLT should check against the minimum supported…
Jun 29 2020, 12:29 PM
arphaman closed D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version.
Jun 29 2020, 12:29 PM · Restricted Project, Restricted Project
arphaman added a comment to D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .

I'll fix up Clang.Preprocessor::aarch64-target-features.c test this morning.

Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project

Jun 26 2020

arphaman added a comment to D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .

@t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the right target features when we're passing in a11 or older, so that's why my test file has the INFER-A12 separate line. Do you think this is a bug? This is decided here:

Jun 26 2020, 6:33 PM · Restricted Project, Restricted Project
arphaman created D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .
Jun 26 2020, 6:33 PM · Restricted Project, Restricted Project
arphaman created D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version.
Jun 26 2020, 5:21 PM · Restricted Project, Restricted Project
arphaman committed rG2b00cacb2835: [darwin][driver] NFC, split addStartObjectFileArgs into multiple functions (authored by arphaman).
[darwin][driver] NFC, split addStartObjectFileArgs into multiple functions
Jun 26 2020, 5:17 PM
arphaman committed rG253988f0f400: [darwin][driver] Do not link with libarclite when building for Apple Silicon… (authored by arphaman).
[darwin][driver] Do not link with libarclite when building for Apple Silicon…
Jun 26 2020, 5:17 PM

Jun 25 2020

arphaman accepted D82610: [compiler-rt] Add support for arm64 macOS.
Jun 25 2020, 4:56 PM · Restricted Project

Jun 23 2020

arphaman committed rG1a342ff3753d: test fix: add missing system-darwin REQUIRES (authored by arphaman).
test fix: add missing system-darwin REQUIRES
Jun 23 2020, 9:36 PM
arphaman committed rG050ed9720f84: [cmake] configure the host triple on an Apple Silicon machine correctly (authored by arphaman).
[cmake] configure the host triple on an Apple Silicon machine correctly
Jun 23 2020, 9:36 PM
arphaman committed rG565603cc94d7: [clang][driver] set macOS as the target OS for -arch arm64 when clang is… (authored by arphaman).
[clang][driver] set macOS as the target OS for -arch arm64 when clang is…
Jun 23 2020, 9:36 PM
arphaman closed D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`.
Jun 23 2020, 9:35 PM · Restricted Project
arphaman added a comment to D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`.

LGTM.

Not sure if it makes more sense to break the patch into two commits:

  • config.guess change is for building the correct host triple on apple silicon machine without explicitly specify it.
  • the driver change is for better default on Apple silicon Mac.
Jun 23 2020, 8:31 PM · Restricted Project
arphaman created D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`.
Jun 23 2020, 7:26 PM · Restricted Project
arphaman committed rGf724ce0d73eb: [clang][driver] allow macOS 11 OS version in the driver (authored by arphaman).
[clang][driver] allow macOS 11 OS version in the driver
Jun 23 2020, 3:39 PM

Jun 22 2020

arphaman committed rG1c4a42a4d88e: [Triple] support macOS 11 os version number (authored by arphaman).
[Triple] support macOS 11 os version number
Jun 22 2020, 11:05 PM
arphaman closed D82337: [Triple] support macOS 11 os version number.
Jun 22 2020, 11:04 PM · Restricted Project
arphaman added inline comments to D82337: [Triple] support macOS 11 os version number.
Jun 22 2020, 11:04 PM · Restricted Project
arphaman added inline comments to D82337: [Triple] support macOS 11 os version number.
Jun 22 2020, 5:45 PM · Restricted Project
arphaman created D82337: [Triple] support macOS 11 os version number.
Jun 22 2020, 4:41 PM · Restricted Project

Jun 12 2020

arphaman added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 12 2020, 2:49 PM · Restricted Project

Jun 8 2020

arphaman added a comment to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.

Can you still modify the state of -Wundef with #pragma clang diagnostic? Could you add a test to cover it.

Jun 8 2020, 3:33 PM · Restricted Project
arphaman added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 8 2020, 3:33 PM · Restricted Project

Jun 5 2020

arphaman committed rG2ba016cd5ce5: [arm][darwin] Don't generate libcalls for wide shifts on Darwin (authored by arphaman).
[arm][darwin] Don't generate libcalls for wide shifts on Darwin
Jun 5 2020, 3:44 PM
arphaman committed rG5eedf07ab999: [apple clang] disable in-process CC1 to preserve crashlog compatibility (authored by arphaman).
[apple clang] disable in-process CC1 to preserve crashlog compatibility
Jun 5 2020, 11:15 AM
arphaman closed D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility.
Jun 5 2020, 11:14 AM · Restricted Project

May 29 2020

arphaman created D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility.
May 29 2020, 3:52 PM · Restricted Project

May 18 2020

arphaman accepted D79916: Map -O to -O1 instead of -O2.

IOW, this LGTM if Alex and Gerolf are happy.

May 18 2020, 3:45 PM · Restricted Project

May 14 2020

arphaman committed rG11d612ac99a6: [clang][Preprocessor] Replace the slow translateFile call by a new, faster… (authored by arphaman).
[clang][Preprocessor] Replace the slow translateFile call by a new, faster…
May 14 2020, 2:43 PM
arphaman closed D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.
May 14 2020, 2:42 PM · Restricted Project
arphaman updated the diff for D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.

Added test and a comment.

May 14 2020, 11:57 AM · Restricted Project
arphaman added inline comments to D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.
May 14 2020, 11:57 AM · Restricted Project
arphaman committed rG10b49315faa6: [test] NFC, add missing declarations and include to test files to avoid… (authored by arphaman).
[test] NFC, add missing declarations and include to test files to avoid…
May 14 2020, 10:18 AM

May 13 2020

arphaman updated the diff for D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.

Drop caching, it's not need for the speedup.

May 13 2020, 2:10 PM · Restricted Project
arphaman added a comment to D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.

@jkorous it looks like dropping caching works too, this achieves similar perf results.

May 13 2020, 2:09 PM · Restricted Project
arphaman added a comment to D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.

IIUC the issue is that SourceManager::translateFile() basically consists of two blocks of code:

// First, check the main file ID, since it is common to look for a
// location in the main file.
if (MainFileID.isValid()) {
  bool Invalid = false;
  const SLocEntry &MainSLoc = getSLocEntry(MainFileID, &Invalid);
  if (Invalid)
    return FileID();

  if (MainSLoc.isFile()) {
    const ContentCache *MainContentCache =
        MainSLoc.getFile().getContentCache();
    if (MainContentCache && MainContentCache->OrigEntry == SourceFile)
      return MainFileID;
  }
}

and

  // The location we're looking for isn't in the main file; look
  // through all of the local source locations.
...

The comments suggest that the first block is a heuristic related to our case and the second block I would assume being the expensive part. SourceManager::getFileEntryRefForID implementation seems similar to the first block.

It makes sense to me to avoid the expensive search. I'm just wondering - how much speedup do we get with caching the value?

May 13 2020, 1:03 PM · Restricted Project
arphaman updated the diff for D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.

fix assertion in the unit test.

May 13 2020, 10:50 AM · Restricted Project

May 12 2020

arphaman created D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check.
May 12 2020, 6:52 PM · Restricted Project

Apr 2 2020

arphaman accepted D77321: utils: Tweak clang-parse-diagnostics-file for modules includes.
Apr 2 2020, 2:06 PM
arphaman added a comment to D77321: utils: Tweak clang-parse-diagnostics-file for modules includes.

LGTM. Looks like we don't have tests for this script, it would be nice to add some in the future, but that shouldn't block this.

Apr 2 2020, 2:06 PM

Apr 1 2020

arphaman added a comment to D69936: [IPRA][ARM] Spill extra registers at -Oz.

This is also failing on our expensive checks bot http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/ FYI

Apr 1 2020, 8:09 PM · Restricted Project
arphaman added a comment to D69936: [IPRA][ARM] Spill extra registers at -Oz.

Unfortunately this change causes the following failure for a clang that's built with LLVM_EXPENSIVE_CHECKS=On when building compiler-rt for armv7k:

Apr 1 2020, 8:09 PM · Restricted Project

Mar 27 2020

arphaman accepted D76670: [VirtualFileSystem] Support directory entries in the YAMLVFSWriter.

Great, that looks better, thanks! LGTM

Mar 27 2020, 3:27 PM · Restricted Project
arphaman accepted D76671: [FileCollector] Add a method to add a whole directory and it contents..
Mar 27 2020, 3:27 PM · Restricted Project
arphaman added a comment to D76671: [FileCollector] Add a method to add a whole directory and it contents..

LGTM with one comment that needs to be fixed

Mar 27 2020, 2:53 PM · Restricted Project
arphaman added a comment to D76670: [VirtualFileSystem] Support directory entries in the YAMLVFSWriter.

It looks like you're now adding a dependency on a real filesystem to the VFS writer due to calls to fs::is_directory. I think it should be possible to use a VFS write to construct a VFS file without an underlying filesystem, or with an underlying filesystem that doesn't represent the state of your constructed VFS. Is there another way to achieve this goal without depending on the underlying filesystem?

Mar 27 2020, 12:01 PM · Restricted Project
arphaman added inline comments to D76671: [FileCollector] Add a method to add a whole directory and it contents..
Mar 27 2020, 12:01 PM · Restricted Project

Mar 25 2020

arphaman added a comment to D75849: [compiler-rt] Allow golang race detector to run on musl-c.

Hi @graywolf-at-work, @dvyukov

This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error:

clang-11: warning: include path for libstdc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: race_darwin_amd64.syso: No such file or directory.

Example: http://lab.llvm.org:8080/green/job/clang-stage1-RA/7900/consoleFull#-87031640a1ca8a51-895e-46c6-af87-ce24fa4cd561

Can you please take a look at this issue as soon as you can? Let me know if you need help reproducing this.

Mar 25 2020, 4:16 PM · Restricted Project, Restricted Project
arphaman added a comment to D75849: [compiler-rt] Allow golang race detector to run on musl-c.

This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error:

Mar 25 2020, 3:44 PM · Restricted Project, Restricted Project