Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (395 w, 1 d)

Recent Activity

Fri, Jan 14

arphaman requested review of D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.
Fri, Jan 14, 11:14 AM

Tue, Jan 11

arphaman accepted D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.

LGTM with one comment. This is great, thanks!

Tue, Jan 11, 11:56 AM · Restricted Project

Mon, Jan 10

arphaman accepted D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

LGTM, Cheers!

Mon, Jan 10, 2:46 PM · Restricted Project

Wed, Jan 5

arphaman committed rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS (authored by egorzhdan).
[Clang] Extract availability mapping from VersionMap for watchOS/tvOS
Wed, Jan 5, 5:00 PM
arphaman closed D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.
Wed, Jan 5, 5:00 PM · Restricted Project
arphaman accepted D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

LGTM

Wed, Jan 5, 9:20 AM · Restricted Project

Tue, Jan 4

arphaman added a comment to D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like ios_tvos in the constructed SDK settings?

Tue, Jan 4, 3:45 PM · Restricted Project
arphaman added a comment to D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

I think we would still want to diagnose any mismatches between class properties that override a class property in the superclass. do you think that would be useful? You can adjust the lookup to take that into account.

Tue, Jan 4, 3:42 PM · Restricted Project

Dec 20 2021

arphaman added a comment to D115497: [Inline] Disable deferred inlining.

This change caused the following regression on the EXPENSIVE_CHECKS=on green dragon CI, where clang is unable to compile compiler-rt for armv7:

Dec 20 2021, 6:29 PM · Restricted Project
arphaman updated subscribers of D114498: [sanitizer] Run Stack compression in background thread.

@vitalybuka Hi, this change caused some test failures on green dragon apple CI. This is the bot: https://green.lab.llvm.org/green/job/clang-stage1-RA/. The following tests are failing:

Dec 20 2021, 2:34 PM · Restricted Project
arphaman added a comment to D115759: Add a flag to force tsan's background thread.

@vitalybuka This change caused a regression on Darwin CI for tsan -,
This is the CI job: https://green.lab.llvm.org/green/job/clang-stage1-RA, and the build: https://green.lab.llvm.org/green/job/clang-stage1-RA/26354/
ThreadSanitizer-x86_64.Darwin.dlopen.cpp is now failing because the initializer that you added runs before flags is initialized when it's being dlopened . Could you take a look at this issue?

Dec 20 2021, 1:43 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:35 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:35 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:34 PM · Restricted Project
arphaman requested review of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:31 PM · Restricted Project

Dec 8 2021

arphaman updated subscribers of D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands.
Dec 8 2021, 5:54 PM · Restricted Project
arphaman requested review of D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands.
Dec 8 2021, 5:54 PM · Restricted Project
arphaman requested review of D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path.
Dec 8 2021, 3:25 PM · Restricted Project
arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Dec 8 2021, 2:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Dec 8 2021, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 7 2021

arphaman committed rG0756aa397856: [macho] add support for emitting macho files with two build version load… (authored by arphaman).
[macho] add support for emitting macho files with two build version load…
Dec 7 2021, 6:18 PM
arphaman closed D112189: [macho] add support for emitting macho files with two build version load commands.
Dec 7 2021, 6:18 PM · Restricted Project

Dec 6 2021

arphaman accepted D114971: [clang][deps] Handle symlinks in minimizing FS.

This looks good to me! I agree, an enum class would be cleaner though.

Dec 6 2021, 9:03 AM · Restricted Project

Dec 2 2021

arphaman added a comment to D114968: [clang][deps] Avoid reading file for stat calls.

Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files.

Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most likely to avoid inconsistencies when the file changes on the filesystem between stat and read. Is that correct, @arphaman? If so, I think I should abandon this patch.

Agreed; that consistency is important. I don't think stat should be decoupled from reading the file.

Dec 2 2021, 11:58 PM · Restricted Project

Nov 29 2021

arphaman accepted D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Sorry for delay, this LGTM. Thanks for doing this cleanup!

Nov 29 2021, 7:37 PM · Restricted Project, Restricted Project

Nov 19 2021

arphaman committed rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax).
Allow __attribute__((swift_attr)) in attribute push pragmas
Nov 19 2021, 1:00 PM
arphaman closed D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.
Nov 19 2021, 1:00 PM · Restricted Project
arphaman added a comment to D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.

I will commit this on behalf of @beccadax as she doesn't have commit access yet.

Nov 19 2021, 12:08 PM · Restricted Project

Nov 5 2021

arphaman committed rGa00944ebeab1: [clang] 'unused-but-set-variable' warning should not apply to __block objective… (authored by arphaman).
[clang] 'unused-but-set-variable' warning should not apply to __block objective…
Nov 5 2021, 7:48 AM
arphaman closed D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.
Nov 5 2021, 7:48 AM · Restricted Project

Oct 29 2021

arphaman requested review of D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.
Oct 29 2021, 3:15 PM · Restricted Project
arphaman committed rGa43d1aa85256: [clang] Make 'align-mismatch' warning work without an associated function… (authored by arphaman).
[clang] Make 'align-mismatch' warning work without an associated function…
Oct 29 2021, 1:39 PM
arphaman closed D109402: Make 'align-mismatch' warning work without an associated function declaration.
Oct 29 2021, 1:39 PM · Restricted Project

Oct 28 2021

arphaman accepted D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.

Looks good to me. Can you post the patch with the full context next time so that it's easier to review?

Oct 28 2021, 6:48 PM · Restricted Project
arphaman committed rG3d0d7d8c5b66: [clang][driver][darwin] support -target with Mac Catalyst triple without OS… (authored by arphaman).
[clang][driver][darwin] support -target with Mac Catalyst triple without OS…
Oct 28 2021, 6:46 PM

Oct 20 2021

arphaman updated subscribers of D112189: [macho] add support for emitting macho files with two build version load commands.
Oct 20 2021, 3:37 PM · Restricted Project
arphaman requested review of D112189: [macho] add support for emitting macho files with two build version load commands.
Oct 20 2021, 3:33 PM · Restricted Project

Sep 20 2021

arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Sep 20 2021, 12:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 7 2021

arphaman requested review of D109402: Make 'align-mismatch' warning work without an associated function declaration.
Sep 7 2021, 4:20 PM · Restricted Project

Sep 2 2021

arphaman accepted D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling.

LGTM, thanks

Sep 2 2021, 8:40 AM · Restricted Project
arphaman accepted D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation.
Sep 2 2021, 8:36 AM · Restricted Project
arphaman added a comment to D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation.

Could you add a test case for this change? Maybe a unit test?

Sep 2 2021, 8:32 AM · Restricted Project
arphaman added a comment to D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation.

Could you add a test case for this change? Maybe a unit test?

Sep 2 2021, 8:32 AM · Restricted Project

Aug 5 2021

arphaman accepted D106862: [clang] Remove misleading assertion in FullSourceLoc.
Aug 5 2021, 10:50 AM · Restricted Project

Aug 2 2021

arphaman accepted D106864: [clang][cli] Expose -fno-cxx-modules in cc1.

Thanks, LGTM

Aug 2 2021, 12:48 PM · Restricted Project
arphaman committed rGf575f371822f: [clang][darwin] Add support for the -mtargetos= option to the driver (authored by arphaman).
[clang][darwin] Add support for the -mtargetos= option to the driver
Aug 2 2021, 12:46 PM
arphaman closed D106316: [clang][darwin] Add support for the -mtargetos= option to the driver.
Aug 2 2021, 12:45 PM · Restricted Project

Jul 29 2021

arphaman accepted D106862: [clang] Remove misleading assertion in FullSourceLoc.

I think this approach makes sense for now. It's unfortunate that the constructor of FullSourceLoc is unable to validate this requirement, do you know how many clients that you describe as modifying their ID to make them valid are there?

Jul 29 2021, 8:18 AM · Restricted Project
arphaman added inline comments to D106864: [clang][cli] Expose -fno-cxx-modules in cc1.
Jul 29 2021, 8:15 AM · Restricted Project

Jul 22 2021

arphaman added a comment to D105960: [clang][driver][darwin] Add driver support for Mac Catalyst.

I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37.

Jul 22 2021, 11:13 AM · Restricted Project
arphaman committed rG40d2d0c41298: [clang][test] Add -fuse-ld= to test case added in 2542c1a5a130 to resolve test… (authored by arphaman).
[clang][test] Add -fuse-ld= to test case added in 2542c1a5a130 to resolve test…
Jul 22 2021, 11:13 AM
arphaman added a comment to D105960: [clang][driver][darwin] Add driver support for Mac Catalyst.

I think this should be fixed if I add -fuse-ld= to the invocation. Let me commit that fix to see if it's fixed.

Jul 22 2021, 11:10 AM · Restricted Project
arphaman added a comment to D105960: [clang][driver][darwin] Add driver support for Mac Catalyst.

Hi. I think this patch may have led to the test failure we're seeing on our clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8840986998954824016):

Command Output (stderr):
--
/b/s/w/ir/x/w/llvm-project/clang/test/Driver/darwin-ld.c:146:29: error: LINK_VERSION_MIN_MACABI: expected string not found in input
// LINK_VERSION_MIN_MACABI: "-maccatalyst_version_min" "13.1.0"
                            ^
<stdin>:5:15: note: scanning from here
 "/usr/bin/ld" "-demangle" "-lto_library" "/b/s/w/ir/x/w/staging/llvm_build/lib/libLTO.dylib" "-dynamic" "-arch" "x86_64" "-macosx_version_min" "10.6.0" "-o" "a.out" "-lcrt1.10.6.o" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld.c.tmp.o" "-lSystem"
              ^
<stdin>:5:118: note: possible intended match here
 "/usr/bin/ld" "-demangle" "-lto_library" "/b/s/w/ir/x/w/staging/llvm_build/lib/libLTO.dylib" "-dynamic" "-arch" "x86_64" "-macosx_version_min" "10.6.0" "-o" "a.out" "-lcrt1.10.6.o" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld.c.tmp.o" "-lSystem"
                                                                                                                     ^

Input file: <stdin>
Check file: /b/s/w/ir/x/w/llvm-project/clang/test/Driver/darwin-ld.c

-dump-input=help explains the following input dump.

Input was:
<<<<<<
             1: Fuchsia clang version 13.0.0 (https://llvm.googlesource.com/a/llvm-project ae4e8f7d528f650e0f2730a7f166fb0ef7e31588) 
             2: Target: x86_64-apple-darwin10 
             3: Thread model: posix 
             4: InstalledDir: /b/s/w/ir/x/w/staging/llvm_build/bin 
             5:  "/usr/bin/ld" "-demangle" "-lto_library" "/b/s/w/ir/x/w/staging/llvm_build/lib/libLTO.dylib" "-dynamic" "-arch" "x86_64" "-macosx_version_min" "10.6.0" "-o" "a.out" "-lcrt1.10.6.o" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld.c.tmp.o" "-lSystem" 
check:146'0                   X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
check:146'1                                                                                                                          ?                                                                                                                                                                possible intended match
             6: Fuchsia clang version 13.0.0 (https://llvm.googlesource.com/a/llvm-project ae4e8f7d528f650e0f2730a7f166fb0ef7e31588) 
check:146'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             7: Target: x86_64-apple-macosx10.7 
check:146'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             8: Thread model: posix 
check:146'0     ~~~~~~~~~~~~~~~~~~~~
             9: InstalledDir: /b/s/w/ir/x/w/staging/llvm_build/bin 
check:146'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            10:  "/usr/bin/ld" "-demangle" "-lto_library" "/b/s/w/ir/x/w/staging/llvm_build/lib/libLTO.dylib" "-dynamic" "-arch" "x86_64" "-macosx_version_min" "10.7.0" "-o" "a.out" "-lcrt1.10.6.o" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld.c.tmp.o" "-lSystem" 
check:146'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
>>>>>>

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  Clang :: Driver/darwin-ld.c

Would you mind taking a look and sending out a fix or revert?

Jul 22 2021, 11:06 AM · Restricted Project
arphaman committed rG2542c1a5a130: [clang][driver][darwin] Add driver support for Mac Catalyst (authored by arphaman).
[clang][driver][darwin] Add driver support for Mac Catalyst
Jul 22 2021, 10:21 AM
arphaman closed D105960: [clang][driver][darwin] Add driver support for Mac Catalyst.
Jul 22 2021, 10:20 AM · Restricted Project

Jul 21 2021

arphaman committed rG9643d11e1d7f: [clang][sema] NFC, include DarwinSDKInfo header instead of using the forward… (authored by arphaman).
[clang][sema] NFC, include DarwinSDKInfo header instead of using the forward…
Jul 21 2021, 12:47 PM
arphaman committed rGeb26ba9da8ae: [clang][darwin] add support for remapping macOS availability to Mac Catalyst… (authored by arphaman).
[clang][darwin] add support for remapping macOS availability to Mac Catalyst…
Jul 21 2021, 11:33 AM
arphaman closed D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability.
Jul 21 2021, 11:32 AM · Restricted Project, Restricted Project

Jul 20 2021

arphaman committed rG5f557616c6b1: [clang] Fix the capitalization of the DarwinSDKInfoTest unittest filename to… (authored by arphaman).
[clang] Fix the capitalization of the DarwinSDKInfoTest unittest filename to…
Jul 20 2021, 2:53 PM
arphaman committed rG808bbc2c4702: [clang][darwin] Add support for macOS -> Mac Catalyst (authored by arphaman).
[clang][darwin] Add support for macOS -> Mac Catalyst
Jul 20 2021, 2:26 PM
arphaman closed D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class.
Jul 20 2021, 2:26 PM · Restricted Project, Restricted Project
arphaman committed rG05a6d74c4845: [clang] NFC, move DarwinSDKInfo to lib/Basic (authored by arphaman).
[clang] NFC, move DarwinSDKInfo to lib/Basic
Jul 20 2021, 1:23 PM
arphaman committed rGa8262a383bc6: [clang][darwin] add support for Mac Catalyst availability (authored by arphaman).
[clang][darwin] add support for Mac Catalyst availability
Jul 20 2021, 12:52 PM
arphaman closed D105052: [clang][darwin] add support for Mac Catalyst availability.
Jul 20 2021, 12:52 PM · Restricted Project
arphaman committed rGc68f247275ee: [clang-scan-deps] ignore top-level module dependencies that aren't actually… (authored by arphaman).
[clang-scan-deps] ignore top-level module dependencies that aren't actually…
Jul 20 2021, 11:12 AM
arphaman closed D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported.
Jul 20 2021, 11:11 AM · Restricted Project

Jul 19 2021

arphaman added a comment to D106316: [clang][darwin] Add support for the -mtargetos= option to the driver.

Looks good in general. Just one corner case that we need to decide with direction we go, following command builds arm64-ios and x86_64-ios-simulator:
clang -arch arm64 -arch x86_64 -c -o test.o test.c -mios-version-min=14
Should we document and deprecate that behavior?

Jul 19 2021, 8:13 PM · Restricted Project
arphaman updated the diff for D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class.

Addressed review comments.

Jul 19 2021, 8:10 PM · Restricted Project, Restricted Project
arphaman requested review of D106316: [clang][darwin] Add support for the -mtargetos= option to the driver.
Jul 19 2021, 2:46 PM · Restricted Project

Jul 15 2021

arphaman requested review of D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported.
Jul 15 2021, 1:57 PM · Restricted Project

Jul 14 2021

arphaman accepted D106012: [Support] Get correct number of physical cores on Apple Silicon.
Jul 14 2021, 1:28 PM · Restricted Project

Jul 13 2021

arphaman requested review of D105960: [clang][driver][darwin] Add driver support for Mac Catalyst.
Jul 13 2021, 10:22 PM · Restricted Project
arphaman added a comment to D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class.

This patch depends on a small NFC commit that moves DarwinSDKInfo over to lib/Basic from lib/Driver, which isn't up on phabricator.

Jul 13 2021, 10:06 PM · Restricted Project, Restricted Project
arphaman added a comment to D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability.

Could the DarwinSDKInfo changes be tested directly with C++ unit tests? Since this stuff is in Basic it'd be nice to test it separately from the driver. If so, maybe they could also mostly land in a separate prep commit (except the update to clang::parseDarwinSDKInfo which is what changes the Driver behaviour).

Jul 13 2021, 10:05 PM · Restricted Project, Restricted Project
arphaman added inline comments to D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability.
Jul 13 2021, 10:04 PM · Restricted Project, Restricted Project
arphaman updated the diff for D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability.

Split patch and address review comments

Jul 13 2021, 10:04 PM · Restricted Project, Restricted Project
arphaman updated the diff for D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class.

fix typo

Jul 13 2021, 10:02 PM · Restricted Project, Restricted Project
arphaman requested review of D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class.
Jul 13 2021, 9:58 PM · Restricted Project, Restricted Project
arphaman updated the diff for D105052: [clang][darwin] add support for Mac Catalyst availability.

Sorry, took a bit longer than anticipated. I updated the patch to address reviewer's comments

Jul 13 2021, 4:40 PM · Restricted Project

Jul 8 2021

arphaman added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Looks like this patch causes a number of issues for us, I will work with @jansvoboda11 to see if there's some way to resolve them.

Jul 8 2021, 8:11 AM · Restricted Project

Jun 30 2021

arphaman added a comment to D105052: [clang][darwin] add support for Mac Catalyst availability.

Thanks for the feedback, I'll update this patch tomorrow.

Jun 30 2021, 7:57 PM · Restricted Project
arphaman requested review of D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability.
Jun 30 2021, 7:56 PM · Restricted Project, Restricted Project

Jun 28 2021

arphaman requested review of D105052: [clang][darwin] add support for Mac Catalyst availability.
Jun 28 2021, 12:36 PM · Restricted Project

Jun 23 2021

arphaman added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

I've started testing this change. I'll let you know how it looks in a few days.

Jun 23 2021, 1:25 PM · Restricted Project

Jun 17 2021

arphaman added a comment to D104462: [clang][lex] Add minimizer option to pad the output to the input size.

I agree with Duncan, it would be good to avoid modifying the existing test cases if possible

Jun 17 2021, 1:50 PM · Restricted Project

Jun 16 2021

arphaman accepted D104348: [index] Fix performance regression with indexing macros.

Thanks, LGTM!

Jun 16 2021, 10:07 AM · Restricted Project

Jun 11 2021

arphaman committed rG22dea6923155: [clang][ObjC] allow the use of NSAttributedString * argument type with format… (authored by arphaman).
[clang][ObjC] allow the use of NSAttributedString * argument type with format…
Jun 11 2021, 1:25 PM

Jun 10 2021

arphaman accepted D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library.

Thanks, LGTM

Jun 10 2021, 8:58 AM · Restricted Project
arphaman accepted D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library.

Thanks, LGTM

Jun 10 2021, 8:56 AM · Restricted Project
arphaman accepted D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Jun 10 2021, 8:45 AM · Restricted Project
arphaman accepted D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library.
Jun 10 2021, 8:43 AM · Restricted Project

May 24 2021

arphaman added a comment to D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.

Hey, thanks for following up on this PR. I've done some more digging and I think we can remove this Darwin-specific workaround in the near future. I'm hoping to provide an update in the next few weeks.

May 24 2021, 11:41 AM · Restricted Project
arphaman accepted D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered.

I think this is good to go, I haven't observed any issues with this patch so far in my testing. LGTM

May 24 2021, 11:23 AM · Restricted Project

May 19 2021

arphaman added a reviewer for D102633: [clang-scan-deps] Improvements to thread usage: aganea.

It might be good for @aganea to take a look as well.

May 19 2021, 2:35 PM · Restricted Project, Restricted Project
arphaman committed rG50be48b0f3c8: [clang][ObjC] Allow different availability annotation on a method (authored by arphaman).
[clang][ObjC] Allow different availability annotation on a method
May 19 2021, 12:14 PM
arphaman closed D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement.
May 19 2021, 12:14 PM · Restricted Project

May 14 2021

arphaman updated the diff for D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement.

Do not apply this to 'deprecated' availability annotations - the user has no way to check for deprecated as respondsToSelector will still return true even if the class has marked the method as deprecated.

May 14 2021, 12:37 PM · Restricted Project
arphaman added inline comments to D102494: [Clang,Driver] Default to Darwin_libsystem_m veclib on iOS based targets..
May 14 2021, 11:01 AM · Restricted Project
arphaman accepted D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support..
May 14 2021, 8:52 AM · Restricted Project
arphaman added inline comments to D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support..
May 14 2021, 7:34 AM · Restricted Project