- User Since
- Jun 25 2014, 4:17 PM (319 w, 5 d)
Thu, Jul 30
don't check if the SDK isn't present.
Wed, Jul 29
Fri, Jul 24
Thu, Jul 23
Mon, Jul 20
Tue, Jul 14
Sure, will do.
Jul 6 2020
Please add a test-case as well.
Jun 30 2020
Jun 29 2020
I'll fix up Clang.Preprocessor::aarch64-target-features.c test this morning.
Jun 26 2020
@t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the right target features when we're passing in a11 or older, so that's why my test file has the INFER-A12 separate line. Do you think this is a bug? This is decided here:
Jun 25 2020
Jun 23 2020
Jun 22 2020
Jun 12 2020
Jun 8 2020
Can you still modify the state of -Wundef with #pragma clang diagnostic? Could you add a test to cover it.
Jun 5 2020
May 29 2020
May 18 2020
May 14 2020
Added test and a comment.
May 13 2020
Drop caching, it's not need for the speedup.
@jkorous it looks like dropping caching works too, this achieves similar perf results.
fix assertion in the unit test.
May 12 2020
Apr 2 2020
LGTM. Looks like we don't have tests for this script, it would be nice to add some in the future, but that shouldn't block this.
Apr 1 2020
This is also failing on our expensive checks bot http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/ FYI
Unfortunately this change causes the following failure for a clang that's built with LLVM_EXPENSIVE_CHECKS=On when building compiler-rt for armv7k:
Mar 27 2020
Great, that looks better, thanks! LGTM
LGTM with one comment that needs to be fixed
It looks like you're now adding a dependency on a real filesystem to the VFS writer due to calls to fs::is_directory. I think it should be possible to use a VFS write to construct a VFS file without an underlying filesystem, or with an underlying filesystem that doesn't represent the state of your constructed VFS. Is there another way to achieve this goal without depending on the underlying filesystem?
Mar 25 2020
This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error: