Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (342 w, 3 d)

Recent Activity

Wed, Jan 6

arphaman accepted D94197: Fix failing triple test for macOS 11 with non-zero minor versions..

LGTM, thanks

Wed, Jan 6, 2:55 PM · Restricted Project

Tue, Jan 5

arphaman accepted D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp.
Tue, Jan 5, 11:02 AM · Restricted Project

Fri, Dec 18

arphaman accepted D93148: Basic: Add native support for stdin to SourceManager and FileManager.

Nice, it looks cleaner than the override of file contents that was used before. Left one NIT comment

Fri, Dec 18, 4:31 PM · Restricted Project
arphaman accepted D92531: Basic: Support named pipes natively in SourceManager.
Fri, Dec 18, 4:01 PM · Restricted Project
arphaman added a comment to D92531: Basic: Support named pipes natively in SourceManager.

Left one minor suggestion , but LGTM otherwise

Fri, Dec 18, 4:01 PM · Restricted Project

Dec 16 2020

arphaman added inline comments to D92788: [clangd] NFC: Use SmallVector<T> where possible.
Dec 16 2020, 6:44 PM · Restricted Project
arphaman added inline comments to D92788: [clangd] NFC: Use SmallVector<T> where possible.
Dec 16 2020, 10:31 AM · Restricted Project

Dec 15 2020

arphaman accepted D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays.

Thanks!

Dec 15 2020, 8:52 AM · Restricted Project

Dec 8 2020

arphaman accepted D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef.
Dec 8 2020, 2:19 PM · Restricted Project

Dec 4 2020

arphaman committed rGdb226cdf4cf9: [objc] diagnose protocol conformance in categories with direct members (authored by arphaman).
[objc] diagnose protocol conformance in categories with direct members
Dec 4 2020, 3:57 PM
arphaman closed D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces.
Dec 4 2020, 3:57 PM · Restricted Project
arphaman committed rGeddd1d192bca: [clang] add a `swift_async_name` attribute (authored by arphaman).
[clang] add a `swift_async_name` attribute
Dec 4 2020, 3:56 PM
arphaman closed D92355: [clang] add a `swift_async_name` attribute.
Dec 4 2020, 3:56 PM · Restricted Project
arphaman committed rG03dcd57ecf99: [clang] add a new `swift_attr` attribute (authored by arphaman).
[clang] add a new `swift_attr` attribute
Dec 4 2020, 3:56 PM
arphaman closed D92354: [clang] add a new `swift_attr` attribute.
Dec 4 2020, 3:56 PM · Restricted Project
arphaman added a comment to D92355: [clang] add a `swift_async_name` attribute.

There's no information in either the attribute definition in Attr.td or in the documentation as to what subject this attribute applies to.

Dec 4 2020, 11:01 AM · Restricted Project
arphaman updated the diff for D92355: [clang] add a `swift_async_name` attribute.

address review comments

Dec 4 2020, 11:01 AM · Restricted Project
arphaman added a comment to D92354: [clang] add a new `swift_attr` attribute.

Thanks for taking a look.

Dec 4 2020, 9:29 AM · Restricted Project
arphaman updated the diff for D92354: [clang] add a new `swift_attr` attribute.

Updated for review comments

Dec 4 2020, 9:28 AM · Restricted Project

Dec 3 2020

arphaman requested review of D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces.
Dec 3 2020, 1:04 PM · Restricted Project

Nov 30 2020

arphaman requested review of D92355: [clang] add a `swift_async_name` attribute.
Nov 30 2020, 4:17 PM · Restricted Project
arphaman requested review of D92354: [clang] add a new `swift_attr` attribute.
Nov 30 2020, 4:11 PM · Restricted Project

Nov 11 2020

arphaman accepted D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.

This make sense to me, thank you

Nov 11 2020, 4:59 PM · Restricted Project
arphaman committed rG3df3b62018c0: [clang] ns_error_domain attribute also supports CFString typed variables (authored by arphaman).
[clang] ns_error_domain attribute also supports CFString typed variables
Nov 11 2020, 8:51 AM
arphaman closed D90891: [clang] ns_error_domain attribute also supports CFString typed variables.
Nov 11 2020, 8:50 AM · Restricted Project

Nov 5 2020

arphaman requested review of D90891: [clang] ns_error_domain attribute also supports CFString typed variables.
Nov 5 2020, 2:37 PM · Restricted Project

Nov 4 2020

arphaman added inline comments to D86105: [darwin] Disable the -Wpsabi warning.
Nov 4 2020, 3:01 PM
arphaman updated the diff for D86105: [darwin] Disable the -Wpsabi warning.

Address Ahmed's comments.

Nov 4 2020, 2:57 PM

Nov 2 2020

arphaman committed rG701456b52355: [darwin] add support for __isPlatformVersionAtLeast check for if (@available) (authored by arphaman).
[darwin] add support for __isPlatformVersionAtLeast check for if (@available)
Nov 2 2020, 4:28 PM
arphaman closed D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available).
Nov 2 2020, 4:28 PM · Restricted Project, Restricted Project
arphaman accepted D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC.

LGTM, thanks for cleaning it up

Nov 2 2020, 3:25 PM · Restricted Project
arphaman accepted D90478: Basic: Split out DirectoryEntry.h, NFC.
Nov 2 2020, 3:24 PM · Restricted Project
arphaman added inline comments to D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available).
Nov 2 2020, 3:20 PM · Restricted Project, Restricted Project

Oct 28 2020

arphaman added a comment to D60193: [OpenCL] Added addrspace_cast operator.

This warrants a revert since it's breaking ABI compatibility for our libclang's users. @Anastasia will you be able to take a look at this soon? I plan on reverting this patch in a couple of weeks if the issue is still unresolved.

Oct 28 2020, 11:32 PM · Restricted Project
arphaman requested review of D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available).
Oct 28 2020, 11:03 PM · Restricted Project, Restricted Project
arphaman accepted D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage.

This approach seems like a reasonable compromise, thanks! LGTM.

Oct 28 2020, 8:50 PM · Restricted Project, Restricted Project

Oct 27 2020

arphaman added a comment to D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage.

What's wrong with using Optional<FileEntryRef> instead of MaybeFileEntryRef?

Oct 27 2020, 9:25 AM · Restricted Project, Restricted Project

Oct 26 2020

arphaman accepted D89488: FileManager: Shrink FileEntryRef to the size of a pointer.
Oct 26 2020, 5:15 PM · Restricted Project
arphaman added inline comments to D89488: FileManager: Shrink FileEntryRef to the size of a pointer.
Oct 26 2020, 9:33 AM · Restricted Project

Oct 23 2020

arphaman accepted D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef.
Oct 23 2020, 4:56 PM · Restricted Project
arphaman accepted D89498: HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC.
Oct 23 2020, 4:53 PM
arphaman accepted D89514: clangd: Stop calling FileEntryRef::FileEntryRef.

LGTM with a nit.

Oct 23 2020, 4:52 PM
arphaman accepted D89521: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC.
Oct 23 2020, 4:50 PM · Restricted Project

Oct 21 2020

arphaman committed rGde1016ce5cdc: [driver][arm64] Set target CPU to A12 for compiler invocations that (authored by arphaman).
[driver][arm64] Set target CPU to A12 for compiler invocations that
Oct 21 2020, 11:36 PM
arphaman closed D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .
Oct 21 2020, 11:35 PM · Restricted Project, Restricted Project

Oct 20 2020

arphaman updated the diff for D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .

Don't try to fallback to the "apple-a12" cpu type when the user explicitly specifies an older cpu. The default is still "apple-a12".

Oct 20 2020, 11:32 PM · Restricted Project, Restricted Project
arphaman accepted D67030: ContentCache: Simplify by always owning the MemoryBuffer.
Oct 20 2020, 3:22 PM · Restricted Project
arphaman accepted D89763: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain.
Oct 20 2020, 1:03 PM · Restricted Project
arphaman accepted D89469: FileManager: Test FileManager::getFileRef.
Oct 20 2020, 9:49 AM · Restricted Project
arphaman added a comment to D89469: FileManager: Test FileManager::getFileRef.

Thanks. Could you expand the comment in the test that this test path specifically exercises the behavior produced by the RedirectingFileSystem?

Oct 20 2020, 9:49 AM · Restricted Project
arphaman requested changes to D89763: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain.
Oct 20 2020, 8:16 AM · Restricted Project

Oct 19 2020

arphaman accepted D89431: clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC.
Oct 19 2020, 9:46 PM · Restricted Project
arphaman accepted D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC.
Oct 19 2020, 9:45 PM · Restricted Project
arphaman accepted D89427: clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer).
Oct 19 2020, 9:43 PM · Restricted Project

Oct 14 2020

arphaman accepted D89409: clang/Frontend: Mostly stop using SourceManager::getBuffer, NFC.
Oct 14 2020, 6:38 PM · Restricted Project
arphaman accepted D89411: clang/CodeGen: Stop using SourceManager::getBuffer, NFC.
Oct 14 2020, 6:37 PM · Restricted Project
arphaman accepted D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC.
Oct 14 2020, 6:37 PM · Restricted Project
arphaman accepted D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC.
Oct 14 2020, 6:35 PM · Restricted Project
arphaman accepted D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics.
Oct 14 2020, 10:53 AM · Restricted Project

Oct 13 2020

arphaman accepted D89280: Support: Allow use of MemoryBufferRef with line_iterator.
Oct 13 2020, 9:22 AM · Restricted Project
arphaman accepted D89279: Support: Add operator== for MemoryBufferRef and split out MemoryBufferRef.h.
Oct 13 2020, 9:22 AM · Restricted Project

Oct 12 2020

arphaman accepted D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC.
Oct 12 2020, 12:42 PM · Restricted Project
arphaman added inline comments to D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC.
Oct 12 2020, 9:53 AM · Restricted Project
arphaman added inline comments to D66782: SourceManager: Prefer Optional<MemoryBufferRef> over MemoryBuffer*.
Oct 12 2020, 9:43 AM · Restricted Project

Sep 29 2020

arphaman committed rG119274748bce: NFC, add a missing stdlib include for the use of abort (authored by arphaman).
NFC, add a missing stdlib include for the use of abort
Sep 29 2020, 8:51 AM

Sep 28 2020

arphaman accepted D86230: [SourceManager] Skip module maps when searching files for macro arguments.

Hmm if this unit tests doesn't reproduce it then you don't need to add it. But no further objections from me on this change.

Sep 28 2020, 11:02 AM · Restricted Project
arphaman accepted D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.

LGTM, Thanks!

Sep 28 2020, 11:00 AM · Restricted Project

Sep 15 2020

arphaman added a comment to D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.

Could you add a test-case that verifies that passing -Wno-format-insufficient-args suppresses warn_printf_insufficient_data_args?

Sep 15 2020, 1:49 PM · Restricted Project
arphaman added a comment to D86230: [SourceManager] Skip module maps when searching files for macro arguments.

Okay, that's fair. Is there any way to trigger the computeMacroArgsCache outside of libclang, to create a clang-specific test case?

Sep 15 2020, 1:47 PM · Restricted Project
arphaman added a comment to D86231: [SourceManager] Explicitly check for potential iterator underflow.

Thanks!

Sep 15 2020, 1:40 PM · Restricted Project
arphaman accepted D86231: [SourceManager] Explicitly check for potential iterator underflow.
Sep 15 2020, 1:40 PM · Restricted Project

Sep 4 2020

arphaman accepted D86992: [libclang] Expose Rewriter in libclang API.

LGTM, with one comment below:

Sep 4 2020, 1:31 PM · Restricted Project
arphaman accepted D86991: [libclang] Expose couple AST details.
Sep 4 2020, 1:29 PM · Restricted Project

Sep 2 2020

arphaman added a comment to D86992: [libclang] Expose Rewriter in libclang API.

I think the methods that use the rewriter should be prefixed with clang_Rewriter_ to match the naming convention, e.g. clang_Rewriter_removeText, clang_Rewriter_dispose, clang_Rewriter_create.

Sep 2 2020, 1:52 PM · Restricted Project
arphaman added a comment to D86991: [libclang] Expose couple AST details.

These methods should be prefixed with clang_Cursor_ to match the naming convention.

Sep 2 2020, 1:49 PM · Restricted Project
arphaman added a comment to D86231: [SourceManager] Explicitly check for potential iterator underflow.

Do you have a test case? Please add a comment stating why the check is needed.

Sep 2 2020, 1:46 PM · Restricted Project

Sep 1 2020

arphaman added a comment to D82777: Clang Driver: Use Apple ld64's new @response-file support..

got it, we'll do what we can to release it as soon as possible in Xcode

Sep 1 2020, 9:04 PM · Restricted Project
arphaman accepted D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Sep 1 2020, 9:49 AM · Restricted Project

Aug 31 2020

arphaman added a comment to D86840: [WIP] Fix Rewriter.

@jkorous if the ambiguity between char/token ranges is a problem, how about adding a getRangeCharSize that takes an unambiguous CharSourceRange range, or even making getRangeSize take the CharSourceRange instead?

Aug 31 2020, 4:15 PM
arphaman added a comment to D86230: [SourceManager] Skip module maps when searching files for macro arguments.

Could you please add a comment stating why it's necessary to skip the module map files? Is the problem caused by the module map file that's included in the include hierarchy when it's an external module?

Aug 31 2020, 4:11 PM · Restricted Project

Aug 18 2020

arphaman accepted D66854: [index-while-building] PathIndexer.
Aug 18 2020, 11:38 AM · Restricted Project

Aug 17 2020

arphaman updated the diff for D86105: [darwin] Disable the -Wpsabi warning.

add missing test fix

Aug 17 2020, 5:39 PM
arphaman requested review of D86105: [darwin] Disable the -Wpsabi warning.
Aug 17 2020, 1:26 PM

Aug 13 2020

arphaman committed rGc2807b2e56c0: [darwin][driver] fix isMacosxVersionLT minimum supported OS version check (authored by arphaman).
[darwin][driver] fix isMacosxVersionLT minimum supported OS version check
Aug 13 2020, 12:07 PM

Jul 30 2020

arphaman updated the diff for D84908: [darwin][compiler-rt] build libclang_rt.<os>sim.a Apple Silicon slice, if SDK supports it.

don't check if the SDK isn't present.

Jul 30 2020, 9:42 AM

Jul 29 2020

arphaman requested review of D84908: [darwin][compiler-rt] build libclang_rt.<os>sim.a Apple Silicon slice, if SDK supports it.
Jul 29 2020, 8:12 PM
arphaman committed rGdc22182d1f74: [darwin] build and link with a separate compiler-rt builtins library (authored by arphaman).
[darwin] build and link with a separate compiler-rt builtins library
Jul 29 2020, 3:34 PM
arphaman closed D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators.
Jul 29 2020, 3:34 PM · Restricted Project, Restricted Project

Jul 24 2020

Herald added projects to D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators: Restricted Project, Restricted Project.
Jul 24 2020, 4:12 PM · Restricted Project, Restricted Project

Jul 23 2020

arphaman accepted D83688: [Bitcode] Avoid duplicating linker option when upgrading.
Jul 23 2020, 12:22 PM · Restricted Project

Jul 20 2020

arphaman added inline comments to D66854: [index-while-building] PathIndexer.
Jul 20 2020, 9:16 PM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG2137d5bc9d95: Merge pull request #1408 from hyp/eng/canonicalize-1016-triple (authored by arphaman).
Merge pull request #1408 from hyp/eng/canonicalize-1016-triple
Jul 14 2020, 4:56 PM
arphaman committed rG9fd29837db79: macOS 11 support: add a temporary macOS 10.16 -> macOS 11 triple… (authored by arphaman).
macOS 11 support: add a temporary macOS 10.16 -> macOS 11 triple…
Jul 14 2020, 4:56 PM
GitHub <noreply@github.com> committed rG7b8a7c4b08dc: Merge pull request #1397 from hyp/apple-silicon-macos11 (authored by arphaman).
Merge pull request #1397 from hyp/apple-silicon-macos11
Jul 14 2020, 4:56 PM
arphaman committed rGb6ea8265b6ba: Fix the driver logic for dealing with macOS version checks for Mac Catalyst… (authored by arphaman).
Fix the driver logic for dealing with macOS version checks for Mac Catalyst…
Jul 14 2020, 4:56 PM
arphaman committed rG744ac977d611: [macho] emit LC_BUILD_VERSION load command for supported OSes and platforms (authored by arphaman).
[macho] emit LC_BUILD_VERSION load command for supported OSes and platforms
Jul 14 2020, 4:56 PM
arphaman committed rG5aa7d5b69cb6: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if… (authored by arphaman).
canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if…
Jul 14 2020, 4:56 PM
arphaman committed rG05f0eaeff4f6: [darwin][driver] pass the minimum supported OS version to the linker if it's… (authored by arphaman).
[darwin][driver] pass the minimum supported OS version to the linker if it's…
Jul 14 2020, 4:55 PM
arphaman committed rGd0b68290c81c: [darwin][driver] isMacosxVersionLT should check against the minimum supported… (authored by arphaman).
[darwin][driver] isMacosxVersionLT should check against the minimum supported…
Jul 14 2020, 4:55 PM
arphaman committed rG551c3a711322: [darwin][driver] NFC, split addStartObjectFileArgs into multiple functions (authored by arphaman).
[darwin][driver] NFC, split addStartObjectFileArgs into multiple functions
Jul 14 2020, 4:55 PM