Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (260 w, 2 d)

Recent Activity

Yesterday

JDevlieghere accepted D93649: [lldb/Lua] add support for Lua function breakpoint.

LGTM

Mon, Jan 25, 1:58 PM · Restricted Project
JDevlieghere committed rGf50b8ee71fae: [YAML I/O] Fix bug in emission of empty sequence (authored by JDevlieghere).
[YAML I/O] Fix bug in emission of empty sequence
Mon, Jan 25, 1:36 PM
JDevlieghere closed D95280: [YAML I/O] Fix bug in emission of empty sequence.
Mon, Jan 25, 1:35 PM · Restricted Project

Fri, Jan 22

JDevlieghere accepted D95279: Support: Remove duplicated code in {File,clang::ModulesDependency}Collector, NFC.

LGTM, thanks for cleaning this up!

Fri, Jan 22, 7:04 PM · Restricted Project, Restricted Project
JDevlieghere updated the summary of D95280: [YAML I/O] Fix bug in emission of empty sequence.
Fri, Jan 22, 5:39 PM · Restricted Project
JDevlieghere requested review of D95280: [YAML I/O] Fix bug in emission of empty sequence.
Fri, Jan 22, 5:36 PM · Restricted Project
JDevlieghere committed rG3a50ed84f482: [lldb] FixFileSystem::GetExternalPath for VFS API change (authored by JDevlieghere).
[lldb] FixFileSystem::GetExternalPath for VFS API change
Fri, Jan 22, 3:04 PM
JDevlieghere abandoned D95092: [VFS] Add a WorkingDirectoryFileSystem.

Superseded by D95188

Fri, Jan 22, 2:17 PM · Restricted Project
JDevlieghere abandoned D94811: [lldb] Fix fallthrough with strictly virtual working directory..

Superseded by D95188

Fri, Jan 22, 2:17 PM · Restricted Project
JDevlieghere committed rG0be9ca7c0f9a: [VFS] Fix inconsistencies between relative paths and fallthrough. (authored by JDevlieghere).
[VFS] Fix inconsistencies between relative paths and fallthrough.
Fri, Jan 22, 2:16 PM
JDevlieghere closed D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem.
Fri, Jan 22, 2:16 PM · Restricted Project
JDevlieghere added inline comments to D95261: [lldb/test] Reduce API test tools configuration boilerplate.
Fri, Jan 22, 1:04 PM · Restricted Project
JDevlieghere accepted D94937: [lldb/Lua] add initial Lua typemaps.

LGTM

Fri, Jan 22, 11:01 AM · Restricted Project
JDevlieghere added a comment to D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS..

Overall this looks good. I wonder if abstracting the ExternalRedirect as a small wrapper class around a SmallString would help. There's a few operations that are repeated, like the example below, and it could also house the logic that's currently in the lambda.

Fri, Jan 22, 9:57 AM · Restricted Project, Restricted Project
JDevlieghere accepted D94857: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC).
Fri, Jan 22, 9:16 AM · Restricted Project

Thu, Jan 21

JDevlieghere added a reviewer for D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem: nathawes.
Thu, Jan 21, 8:21 PM · Restricted Project
JDevlieghere added inline comments to D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem.
Thu, Jan 21, 7:47 PM · Restricted Project
JDevlieghere updated the diff for D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem.
  • Implement makeCanonical using canonicalize
  • Add missing call to makeCanonical is isLocal
Thu, Jan 21, 7:07 PM · Restricted Project
JDevlieghere accepted D95185: lldb: repair the standalone build for Windows.

LGTM but I'd like @teemperor to have a look too as he authored the original change.

Thu, Jan 21, 5:21 PM · Restricted Project
JDevlieghere added a reviewer for D95185: lldb: repair the standalone build for Windows: teemperor.
Thu, Jan 21, 5:20 PM · Restricted Project
JDevlieghere requested review of D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem.
Thu, Jan 21, 5:18 PM · Restricted Project

Wed, Jan 20

JDevlieghere accepted D95096: [lldb][import-std-module] Do some basic file checks before trying to import a module.

LGTM!

Wed, Jan 20, 8:02 PM · Restricted Project
JDevlieghere committed rGbaf6c2987e57: [lldb] Upstream eCore_arm_arm64e enum value in ArchSpec (authored by JDevlieghere).
[lldb] Upstream eCore_arm_arm64e enum value in ArchSpec
Wed, Jan 20, 7:40 PM
JDevlieghere closed D95110: [lldb] Upstream eCore_arm_arm64e enum value.
Wed, Jan 20, 7:40 PM · Restricted Project
JDevlieghere updated the summary of D95110: [lldb] Upstream eCore_arm_arm64e enum value.
Wed, Jan 20, 6:46 PM · Restricted Project
JDevlieghere committed rGf354b87df237: [dsymutil] Compare object modification times using second precision (authored by JDevlieghere).
[dsymutil] Compare object modification times using second precision
Wed, Jan 20, 6:46 PM
JDevlieghere added a comment to D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.

Fixed in f354b87df23799ee0b6c718894140c846eafc82d

Wed, Jan 20, 6:45 PM · Restricted Project
JDevlieghere requested review of D95110: [lldb] Upstream eCore_arm_arm64e enum value.
Wed, Jan 20, 6:29 PM · Restricted Project
JDevlieghere added a comment to D94937: [lldb/Lua] add initial Lua typemaps.

I replied before I actually tried to understand what your'e trying to achieve, and it's still not entirely clear to me. I think what you need is something similar like python-typemaps.swig which helps swig understand char** types and such.

Wed, Jan 20, 3:30 PM · Restricted Project
JDevlieghere added a comment to D95100: [lldb/Commands] Fix short option collision for `process launch`.

@jingham should weigh in here, but I think we kind of guarantee (at least informally) that the command options to be stable. Is there an alternative way to fix this without breaking the existing option?

Wed, Jan 20, 3:22 PM · Restricted Project
JDevlieghere requested changes to D95096: [lldb][import-std-module] Do some basic file checks before trying to import a module.
Wed, Jan 20, 3:20 PM · Restricted Project
JDevlieghere accepted D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

Thanks!

Wed, Jan 20, 2:20 PM · Restricted Project
JDevlieghere requested review of D95092: [VFS] Add a WorkingDirectoryFileSystem.
Wed, Jan 20, 2:17 PM · Restricted Project
JDevlieghere abandoned D94845: [llvm] Don't disable fallthrough for strictly virtual working directory..
Wed, Jan 20, 2:11 PM · Restricted Project
JDevlieghere added inline comments to D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC).
Wed, Jan 20, 1:17 PM · Restricted Project
JDevlieghere accepted D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

LGTM with the inline comment addressed.

Wed, Jan 20, 1:15 PM · Restricted Project
JDevlieghere added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

Is this good? :)

Wed, Jan 20, 12:19 PM · Restricted Project

Tue, Jan 19

JDevlieghere added a comment to D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.

As also reported at https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20210118/872711.html "Re: [llvm] 48d2068 - [dsymutil] Warn on timestmap mismatch between object file and debug map" about the re-revert https://github.com/llvm/llvm-project/commit/48d2068fb738302b9fba91c9bf8e4b051c3909eb "[dsymutil] Warn on timestmap mismatch between object file and debug map" (but for which there appears to be no Phabricator review of its own):

I have no idea what this warning is all about, and what exactly triggers it, but it looks like it breaks the

# Check if the C compiler supports the "visibility" function attribute
# If supported, defines HAVE_FUNC_ATTRIBUTE_VISIBILITY
AX_GCC_FUNC_ATTRIBUTE(visibility)

configure check used by Little-CMS (https://github.com/mm2/Little-CMS/blob/a0fc38ddd55a0341dafa7414ac624c1f09271401/configure.ac#L70; e.g. built as part of building LibreOffice), when building on macOS:

configure:15908: checking for __attribute__((visibility))
configure:15930: /Users/stephan/Software/llvm/inst/bin/clang -m64 -mmacosx-version-min=10.15 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -fno-sanitize-recover=all -ferror-limit=0 -o conftest  -ggdb2 -Xclang -debug-info-kind=constructor -O0 -fstrict-aliasing -fstrict-overflow  -I/Users/stephan/Software/lo/core/include  -I/Users/stephan/Software/adoptopenjdk.net/OpenJDK15U-jdk_x64_mac_hotspot_15.0.1_9/jdk-15.0.1+9/Contents/Home/include  -I/Users/stephan/Software/adoptopenjdk.net/OpenJDK15U-jdk_x64_mac_hotspot_15.0.1_9/jdk-15.0.1+9/Contents/Home/include/darwin  conftest.c  >&5
warning: /Users/stephan/Software/lo/TMPDIR/conftest-01e065.o: timestamp mismatch between object file (2021-01-18 19:22:51.045749227) and debug map (2021-01-18 19:22:51.000000000)
warning: /Users/stephan/Software/lo/TMPDIR/conftest-01e065.o: timestamp mismatch between object file (2021-01-18 19:22:51.045749227) and debug map (2021-01-18 19:22:51.000000000)
configure:15930: $? = 0
configure:15943: result: no

That is, the warning output apparently confuses the AX_GCC_FUNC_ATTRIBUTE logic and makes it erroneously assume that Clang does not support attribute((visibility)).

Tue, Jan 19, 3:48 PM · Restricted Project
JDevlieghere added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

" (+ one additional test in the Swift fork)" --- Sounds like this can be a separate patch which should Swift folks a heads-up. I don't know how to test Swift and probably someone else can do it:)

Tue, Jan 19, 1:38 PM · Restricted Project
JDevlieghere added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

Looks like a nice cleanup. The only part I am not sure of is the part about removing $(RM) $(ARCHIVE_OBJECTS). Is that necessary?
I'm not sure why is that line there, but if I had to guess, I would say it's to ensure that lldb (on macos) reads debug info from the archive file instead of the original .o files. If it's not required, it may be better to leave it in. Otherwise, someone from Apple should say whether that is ok (testing archives is only really interesting on fruity platforms).

I can add back it under the ifeq "$(OS)" "Darwin" guard if Apple folks think it is useful.

Tue, Jan 19, 12:56 PM · Restricted Project
JDevlieghere accepted D94991: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are correct on Safari.

Ship it

Tue, Jan 19, 12:41 PM · Restricted Project
JDevlieghere committed rGa4b42c621b9e: [llvm] Protect signpost map with a mutex (authored by JDevlieghere).
[llvm] Protect signpost map with a mutex
Tue, Jan 19, 11:42 AM
JDevlieghere closed D94285: [llvm] Protect signpost map with a mutex.
Tue, Jan 19, 11:42 AM · Restricted Project
JDevlieghere accepted D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate.

LGTM

Tue, Jan 19, 10:14 AM · Restricted Project
JDevlieghere added inline comments to D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate.
Tue, Jan 19, 8:43 AM · Restricted Project
JDevlieghere added inline comments to D94285: [llvm] Protect signpost map with a mutex.
Tue, Jan 19, 8:41 AM · Restricted Project
JDevlieghere updated the diff for D94285: [llvm] Protect signpost map with a mutex.

Use SmartMutex and SmartScopedLock.

Tue, Jan 19, 8:41 AM · Restricted Project
JDevlieghere accepted D94959: [lldb][docs] Add a doc page for enums and constants.

Sounds like something to tablegen ;-) Joking aside, this seems easy enough to auto-generate with clang tooling, so LGTM as a temporary measure.

Tue, Jan 19, 8:35 AM · Restricted Project

Mon, Jan 18

JDevlieghere requested changes to D94937: [lldb/Lua] add initial Lua typemaps.

We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick?

Mon, Jan 18, 4:40 PM · Restricted Project
JDevlieghere accepted D94899: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project.

Cool. That was one of the reasons I suggested having the SB API documentation integrated with the rest of the docs.

Mon, Jan 18, 9:01 AM · Restricted Project
JDevlieghere accepted D94900: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one.

LGTM

Mon, Jan 18, 9:00 AM · Restricted Project

Fri, Jan 15

JDevlieghere committed rG999f5da6b308: [debugserver] Fix inverted if block that resulted in us using the private… (authored by JDevlieghere).
[debugserver] Fix inverted if block that resulted in us using the private…
Fri, Jan 15, 5:42 PM
JDevlieghere requested review of D94845: [llvm] Don't disable fallthrough for strictly virtual working directory..
Fri, Jan 15, 4:23 PM · Restricted Project
JDevlieghere added a comment to D94811: [lldb] Fix fallthrough with strictly virtual working directory..

Personally I'd just like to get rid of the shouldUseExternalFS and let the underlying FS take care of it, which I believe would better fit the abstraction but would be a change in behavior (as pointed out in https://reviews.llvm.org/D65677#inline-604694).

Fri, Jan 15, 3:20 PM · Restricted Project
JDevlieghere updated subscribers of D94811: [lldb] Fix fallthrough with strictly virtual working directory..
Fri, Jan 15, 10:56 AM · Restricted Project
JDevlieghere requested review of D94811: [lldb] Fix fallthrough with strictly virtual working directory..
Fri, Jan 15, 10:56 AM · Restricted Project

Thu, Jan 14

JDevlieghere added inline comments to D93106: [dsymutil][DWARFLinker][NFC] make AddressManager not depending on the order of checks for relocations..
Thu, Jan 14, 10:05 AM · Restricted Project
JDevlieghere accepted D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.

LGTM. Thanks for driving this!

Thu, Jan 14, 10:03 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D94285: [llvm] Protect signpost map with a mutex.

ping

Thu, Jan 14, 9:41 AM · Restricted Project

Wed, Jan 13

JDevlieghere committed rG48d2068fb738: [dsymutil] Warn on timestmap mismatch between object file and debug map (authored by JDevlieghere).
[dsymutil] Warn on timestmap mismatch between object file and debug map
Wed, Jan 13, 9:16 AM

Tue, Jan 12

JDevlieghere committed rGf1d5cbbdee55: [dsymutil] Add preliminary support for DWARF 5. (authored by JDevlieghere).
[dsymutil] Add preliminary support for DWARF 5.
Tue, Jan 12, 9:56 PM
JDevlieghere closed D94323: [dsymutil] Add preliminary support for DWARF 5..
Tue, Jan 12, 9:56 PM · Restricted Project
JDevlieghere committed rG35e4998f0c9a: [dsymutil] Fix spurious space in REQUIRES: line (authored by JDevlieghere).
[dsymutil] Fix spurious space in REQUIRES: line
Tue, Jan 12, 8:14 PM
JDevlieghere committed rGad735badb69f: [dsymutil] s/dwarfdump/llvm-dwarfdump/ in test (authored by JDevlieghere).
[dsymutil] s/dwarfdump/llvm-dwarfdump/ in test
Tue, Jan 12, 7:59 PM
JDevlieghere committed rG8a47d875b071: [dsymutil] Copy eh_frame content into the dSYM companion file. (authored by JDevlieghere).
[dsymutil] Copy eh_frame content into the dSYM companion file.
Tue, Jan 12, 7:50 PM
JDevlieghere closed D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Tue, Jan 12, 7:50 PM · Restricted Project
JDevlieghere committed rGe5553b9a6ab9: [dsymutil] Warn on timestmap mismatch between object file and debug map (authored by JDevlieghere).
[dsymutil] Warn on timestmap mismatch between object file and debug map
Tue, Jan 12, 6:58 PM
JDevlieghere closed D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.
Tue, Jan 12, 6:58 PM · Restricted Project
JDevlieghere added inline comments to D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.
Tue, Jan 12, 11:56 AM · Restricted Project
JDevlieghere requested review of D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.
Tue, Jan 12, 11:24 AM · Restricted Project
JDevlieghere added inline comments to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Tue, Jan 12, 10:39 AM · Restricted Project, Restricted Project
JDevlieghere updated subscribers of D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Tue, Jan 12, 10:38 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D94323: [dsymutil] Add preliminary support for DWARF 5..
Tue, Jan 12, 9:20 AM · Restricted Project
JDevlieghere updated the diff for D94323: [dsymutil] Add preliminary support for DWARF 5..

Address @avl's review comments.

Tue, Jan 12, 9:19 AM · Restricted Project
JDevlieghere added inline comments to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Tue, Jan 12, 9:14 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Tue, Jan 12, 8:52 AM · Restricted Project

Mon, Jan 11

JDevlieghere added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 7:14 PM · Restricted Project
JDevlieghere updated the diff for D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..

Address code review feedback

Mon, Jan 11, 7:14 PM · Restricted Project
JDevlieghere added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 5:06 PM · Restricted Project
JDevlieghere updated the diff for D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 5:06 PM · Restricted Project
JDevlieghere committed rGf9902514fe54: [MC] Make getEHFrameSection const like every other getter (NFC) (authored by JDevlieghere).
[MC] Make getEHFrameSection const like every other getter (NFC)
Mon, Jan 11, 4:56 PM
JDevlieghere updated subscribers of D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 4:17 PM · Restricted Project
JDevlieghere requested review of D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 4:17 PM · Restricted Project
JDevlieghere updated the diff for D94323: [dsymutil] Add preliminary support for DWARF 5..
Mon, Jan 11, 11:31 AM · Restricted Project
JDevlieghere updated the diff for D94323: [dsymutil] Add preliminary support for DWARF 5..
Mon, Jan 11, 11:30 AM · Restricted Project
JDevlieghere added inline comments to D93106: [dsymutil][DWARFLinker][NFC] make AddressManager not depending on the order of checks for relocations..
Mon, Jan 11, 10:20 AM · Restricted Project

Sun, Jan 10

JDevlieghere accepted D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching.

LGTM

Sun, Jan 10, 6:51 PM · Restricted Project
JDevlieghere added a comment to D94374: [CMake] Remove dead code setting policies to NEW.

LGTM for LLDB

Sun, Jan 10, 6:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Jan 8

JDevlieghere committed rG04359eece132: [DWARFLinker] Link against BinaryFormat (authored by JDevlieghere).
[DWARFLinker] Link against BinaryFormat
Fri, Jan 8, 6:59 PM
JDevlieghere committed rG272355128f48: [debugserver] Various plist changes (authored by JDevlieghere).
[debugserver] Various plist changes
Fri, Jan 8, 6:55 PM
JDevlieghere closed D94320: [debugserver] Various plist changes.
Fri, Jan 8, 6:55 PM · Restricted Project
JDevlieghere committed rG7a204362f5c6: [DWARFLinker] Print the unsupport DWARF form as part of the warning (authored by JDevlieghere).
[DWARFLinker] Print the unsupport DWARF form as part of the warning
Fri, Jan 8, 6:52 PM
JDevlieghere added inline comments to D94323: [dsymutil] Add preliminary support for DWARF 5..
Fri, Jan 8, 5:26 PM · Restricted Project
JDevlieghere added a comment to D94323: [dsymutil] Add preliminary support for DWARF 5..
In D94323#2487899, @avl wrote:

If I understood correctly, It looks like this change is not enough to work properly for DWARF5.

Fri, Jan 8, 5:25 PM · Restricted Project
JDevlieghere updated the diff for D94323: [dsymutil] Add preliminary support for DWARF 5..
Fri, Jan 8, 5:20 PM · Restricted Project
JDevlieghere updated the summary of D94323: [dsymutil] Add preliminary support for DWARF 5..
Fri, Jan 8, 11:15 AM · Restricted Project
JDevlieghere updated the diff for D94323: [dsymutil] Add preliminary support for DWARF 5..
Fri, Jan 8, 11:11 AM · Restricted Project
JDevlieghere requested review of D94323: [dsymutil] Add preliminary support for DWARF 5..
Fri, Jan 8, 11:10 AM · Restricted Project
JDevlieghere committed rG311b247c9fb5: [lldb] Remove stale LLDB-Info.plist (authored by JDevlieghere).
[lldb] Remove stale LLDB-Info.plist
Fri, Jan 8, 10:12 AM
JDevlieghere requested review of D94320: [debugserver] Various plist changes.
Fri, Jan 8, 10:10 AM · Restricted Project