- User Since
- Jan 31 2016, 7:15 AM (242 w, 1 d)
Wed, Sep 16
I think this will be very useful. LGTM!
Tue, Sep 15
Mon, Sep 14
Fri, Sep 11
Remove spurious change
The reproducer instrumentation part LGTM.
Thu, Sep 10
LGTM. This must've been broken for a while. I'll re-enable running the API tests on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ so we can catch this earlier.
Thanks! I'll land it for you.
Wed, Sep 9
Tue, Sep 8
Sounds reasonable to me. I'll split it up in two patches. I'll update this one to use the double dashes so we can land the functionality and keep things consistent with the rest of LLDB. I'll create another patch to do the handling of raw commands to use a heuristic.
You need to add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in so that the standalone builds know what value was set in the LLVM build. I think with the current patch the other projects won't inherit the value and just default to ON?
Wed, Sep 2
Thanks, should be fixed by 426fa35b655ffb8647d9d69580a69627c0d19024
- Remove custom parsing and use the command options insofar possible.
- Require -- as a delimiter when language and code are specified together.
Tue, Sep 1
This is great, thanks for taking the time to fix all this.
Other than a small style nit this LGTM
Mon, Aug 31
Fri, Aug 28
- Fix LLDB.framework path
- Don't try to guess the LLDB.framework location
Thu, Aug 27
Wed, Aug 26
- Address code review feedback
- Run the verifier when replaying a reproducer
- Add SBReplayOptions instead of adding another overload
- Add --reproducer-skip-verify flag
Tue, Aug 25
A large part of this patch is concerned with parsing which worries me from a maintenance perspective. Did you consider using Yaml I/O? While I'm not a particularly big fan of the format, the benefits of being able to (de)serialize any class by implementing the appropriate traits are quite significant. We already have traits implemented for a bunch of utility classes, such as ArchSpec and FileSpec which we could reuse for this. I know changing the format would be invasive, but I think it might be worth it in the long term.
- Make CHECK-line more specific
- Add tests
- Extract common code from CommandObjectReproducerDump and CommandObjectReproducerVerify into GetLoaderFromPathOrCurrent
- Address code review feedback
Mon, Aug 24
This will require a test and maybe some code deduplication in CommandObjectReproducer but I already wanted to put the patch up in case I can't get to that today.
If I understand the patch correctly, the speedup is gained by caching the mode instead of trying to recompute it every time we call colorsEnabled()? This seems like a huge speedup for such a small thing, maybe I'm missing something?
Sat, Aug 22
The target should be created for everyone calling the finish_swig_python function. Let's say (not so) hypothetically I want to create bindings for Python 2 and Python 3. I'll call finish_swig_python, twice, once for each Python version:
Aug 21 2020
- Add test.
- Implement dump method.
I wasn't sure how to test this but Jason told me I can set LLDB_APPLE_DSYMFORUUID_EXECUTABLE.