Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (242 w, 1 d)

Recent Activity

Wed, Sep 16

JDevlieghere committed rG57dd92746a53: [lldb] Return FileSP and StreamFileSP by value in IOHandler (NFC) (authored by JDevlieghere).
[lldb] Return FileSP and StreamFileSP by value in IOHandler (NFC)
Wed, Sep 16, 9:15 PM
JDevlieghere accepted D87637: [lldb/test] Enable faulthandler in dotest.

I think this will be very useful. LGTM!

Wed, Sep 16, 1:59 PM · Restricted Project

Tue, Sep 15

JDevlieghere committed rG127faae7529a: [lldb] Add -l/--language option to script command (authored by JDevlieghere).
[lldb] Add -l/--language option to script command
Tue, Sep 15, 9:40 AM
JDevlieghere closed D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 15, 9:40 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D86996: [lldb] Add -l/--language option to script command.

This looks fine (sorry about the delay, I've been OOO).

Tue, Sep 15, 9:16 AM · Restricted Project, Restricted Project

Mon, Sep 14

JDevlieghere accepted D87626: Fix .debug_aranges parsing..

Nice catch!

Mon, Sep 14, 9:39 PM · Restricted Project

Fri, Sep 11

JDevlieghere committed rG33eb64704292: [lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor (authored by JDevlieghere).
[lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor
Fri, Sep 11, 5:37 PM
JDevlieghere closed D87545: [lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor .
Fri, Sep 11, 5:37 PM · Restricted Project
JDevlieghere committed rG76e3a27c16d2: [lldb] Add test for CFMutableDictionaryRef (authored by JDevlieghere).
[lldb] Add test for CFMutableDictionaryRef
Fri, Sep 11, 4:11 PM
JDevlieghere updated the diff for D87545: [lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor .

Remove spurious change

Fri, Sep 11, 1:23 PM · Restricted Project
JDevlieghere requested review of D87545: [lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor .
Fri, Sep 11, 12:43 PM · Restricted Project
JDevlieghere committed rGbd2f7ad6036c: Revert "[examples] Adjust ThinLtoInstrumentationLayer for emit signature change" (authored by JDevlieghere).
Revert "[examples] Adjust ThinLtoInstrumentationLayer for emit signature change"
Fri, Sep 11, 9:23 AM
JDevlieghere added a comment to D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.

The reproducer instrumentation part LGTM.

Fri, Sep 11, 8:48 AM · Restricted Project
JDevlieghere committed rGbfbaf172ce99: [examples] Adjust ThinLtoInstrumentationLayer for emit signature change (authored by JDevlieghere).
[examples] Adjust ThinLtoInstrumentationLayer for emit signature change
Fri, Sep 11, 8:34 AM

Thu, Sep 10

JDevlieghere committed rGbc0a35f3b7dd: [lldb] Add missing LLDB_REGISTER_CONSTRUCTOR in SBPlatform (authored by JDevlieghere).
[lldb] Add missing LLDB_REGISTER_CONSTRUCTOR in SBPlatform
Thu, Sep 10, 6:50 PM
JDevlieghere committed rZORGf63e49a069fa: [lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell (authored by JDevlieghere).
[lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell
Thu, Sep 10, 10:54 AM
JDevlieghere accepted D87466: [lldb, tests] Correctly configure the yaml2obj paths.

LGTM. This must've been broken for a while. I'll re-enable running the API tests on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ so we can catch this earlier.

Thu, Sep 10, 10:06 AM · Restricted Project
JDevlieghere committed rGe5d92691bdf1: Fix typo in dsymutil.rst (authored by YangZhihui).
Fix typo in dsymutil.rst
Thu, Sep 10, 9:46 AM
JDevlieghere closed D87438: Fix typo in dsymutil.rst.
Thu, Sep 10, 9:46 AM · Restricted Project
JDevlieghere accepted D87438: Fix typo in dsymutil.rst.

Thanks! I'll land it for you.

Thu, Sep 10, 9:44 AM · Restricted Project

Wed, Sep 9

JDevlieghere committed rG2955a27abc25: [lldb] Pass the arch as part of the triple in the ARCH_CFLAGS (authored by JDevlieghere).
[lldb] Pass the arch as part of the triple in the ARCH_CFLAGS
Wed, Sep 9, 2:41 PM
JDevlieghere added inline comments to D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.
Wed, Sep 9, 9:38 AM · Restricted Project
JDevlieghere accepted D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS.

Thanks!

Wed, Sep 9, 9:00 AM · Restricted Project

Tue, Sep 8

JDevlieghere added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

I assume you mean people *not* having a "localhost" entry?

I believe the issue was with people having a modified version that replaces localhost with some other IP address.

I didn't even realize that was an option. Yes, this patch would break that. I'll have to take another approach, then.

You might check the "git log" on any files that have "127.0.0.1" in them for details.

Do you happen to have any references (bugs etc.) for those kinds of issues?

Looks like rLLDB202424 is the patch that did most of this. There may be more context in rdar://problem/16154630 but I don't have access to that.

Tue, Sep 8, 8:11 PM · Restricted Project
JDevlieghere accepted D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

LGTM

Tue, Sep 8, 3:47 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere updated the diff for D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 8, 3:33 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

If an LLVM install disabled LLVM_ENABLE_WARNINGS, should other builds inherit that? I would think no, but is there a precedent for that that to be the case?

Tue, Sep 8, 3:11 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere added a comment to D86996: [lldb] Add -l/--language option to script command.

Sounds reasonable to me. I'll split it up in two patches. I'll update this one to use the double dashes so we can land the functionality and keep things consistent with the rest of LLDB. I'll create another patch to do the handling of raw commands to use a heuristic.

Tue, Sep 8, 11:20 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

You need to add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in so that the standalone builds know what value was set in the LLVM build. I think with the current patch the other projects won't inherit the value and just default to ON?

Tue, Sep 8, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 2

JDevlieghere committed rG3746906193c1: [lldb] Add reproducer verifier (authored by JDevlieghere).
[lldb] Add reproducer verifier
Wed, Sep 2, 10:21 PM
JDevlieghere closed D86497: [lldb] Add reproducer verifier.
Wed, Sep 2, 10:20 PM · Restricted Project, Restricted Project
JDevlieghere committed rGfa95e3559335: [lldb] Pass -fno-objc-exceptions for objcxx targets (authored by JDevlieghere).
[lldb] Pass -fno-objc-exceptions for objcxx targets
Wed, Sep 2, 10:00 PM
JDevlieghere committed rG426fa35b655f: [lldb] Always record both the working and home directory. (authored by JDevlieghere).
[lldb] Always record both the working and home directory.
Wed, Sep 2, 8:53 PM
JDevlieghere added a comment to D86497: [lldb] Add reproducer verifier.

Thanks, should be fixed by 426fa35b655ffb8647d9d69580a69627c0d19024

Wed, Sep 2, 8:53 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D86996: [lldb] Add -l/--language option to script command.
Wed, Sep 2, 11:58 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D86996: [lldb] Add -l/--language option to script command.

I agree that silly, but maybe the same fix should then be applied to the expr command (and any other command with similar behavior).

Sure, we can use the same trick in other places that use OptionsWithRaw. I'll do that in a separate patch.

Wed, Sep 2, 9:47 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D86821: [lldb] Make the majority of the lit configuration values optional for the API tests.
Wed, Sep 2, 9:42 AM · Restricted Project
JDevlieghere added inline comments to D86821: [lldb] Make the majority of the lit configuration values optional for the API tests.
Wed, Sep 2, 9:38 AM · Restricted Project
JDevlieghere added a comment to D86996: [lldb] Add -l/--language option to script command.

I agree that silly, but maybe the same fix should then be applied to the expr command (and any other command with similar behavior).

Wed, Sep 2, 9:27 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D86996: [lldb] Add -l/--language option to script command.

So CommandObjectRaw does support arguments, but they way it works is that you need to have a delimiter for the 'raw' part which is --. If you have that, then you can just use invoke the normal option parsing like CommandObjectExpression does. The handcrafted implementation here adds a completely new lldb command syntax which has a 'raw' part without the -- which seems inconsistent (not saying that the syntax here is worse or better than script --language foo --, but it's just inconsistent with the way the rest of LLDB works). It's obviously also missing the other quirky things that are part of the command syntax (e.g., quoting arguments isn't supported and so on).

Wed, Sep 2, 1:48 AM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D86996: [lldb] Add -l/--language option to script command.
  • Remove custom parsing and use the command options insofar possible.
  • Require -- as a delimiter when language and code are specified together.
Wed, Sep 2, 1:45 AM · Restricted Project, Restricted Project

Tue, Sep 1

JDevlieghere edited reviewers for D86996: [lldb] Add -l/--language option to script command, added: kastiglione; removed: l.frisken.
Tue, Sep 1, 10:52 PM · Restricted Project, Restricted Project
JDevlieghere planned changes to D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 1, 10:51 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 1, 6:43 PM · Restricted Project, Restricted Project
JDevlieghere committed rG9390b346fc20: [lldb] Move ScriptCommand and RegexCommand under Commands (NFC) (authored by JDevlieghere).
[lldb] Move ScriptCommand and RegexCommand under Commands (NFC)
Tue, Sep 1, 5:34 PM
JDevlieghere accepted D86987: [lldb/interpreter] Improve REPL init file compatibility.
Tue, Sep 1, 4:16 PM · Restricted Project
JDevlieghere added a comment to D86953: [lldb] Refactor the tab completion test utilities and document found bugs.

This is great, thanks for taking the time to fix all this.

Tue, Sep 1, 9:26 AM
JDevlieghere added a comment to D86913: Add raw_fd_stream that supports reading/seeking/writing.

Other than a small style nit this LGTM

Tue, Sep 1, 9:04 AM · Restricted Project
JDevlieghere added a comment to D86497: [lldb] Add reproducer verifier.

Hello. I have an auto-bisecting multi-stage bot that has identified this change as breaking release (without assertions) testing on Fedora 33 x86-64. Can we get a quick fix or revert this change for now?

FAIL: lldb-shell :: Reproducer/Functionalities/TestImageList.test (68782 of 69683)
******************** TEST 'lldb-shell :: Reproducer/Functionalities/TestImageList.test' FAILED ********************
Script:
--
: 'RUN: at line 6';   /tmp/_update_lc/r/bin/clang --target=specify-a-target-or-use-a-_host-substitution --target=x86_64-unknown-linux-gnu -pthread -fmodules-cache-path=/tmp/_update_lc/r/lldb-test-build.noindex/module-cache-clang/lldb-shell /home/dave/ro_s/lp/lldb/test/Shell/Reproducer/Functionalities/Inputs/stepping.c -g -o /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.out
: 'RUN: at line 8';   rm -rf /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt
: 'RUN: at line 10';   echo "CAPTURE" >> /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt
: 'RUN: at line 11';   /tmp/_update_lc/r/bin/lldb --no-lldbinit -S /tmp/_update_lc/r/tools/lldb/test/Shell/lit-lldb-init -x -b  --capture --capture-path /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.repro     -o 'run'     -o 'image list'     -o 'reproducer generate'     /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.out >> /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt 2>&1
: 'RUN: at line 17';   echo "REPLAY" >> /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt
: 'RUN: at line 18';   /tmp/_update_lc/r/bin/lldb --no-lldbinit -S /tmp/_update_lc/r/tools/lldb/test/Shell/lit-lldb-init -x -b --replay /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.repro >> /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt 2>&1
: 'RUN: at line 20';   cat /tmp/_update_lc/r/tools/lldb/test/Reproducer/Functionalities/Output/TestImageList.test.tmp.txt | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/lldb/test/Shell/Reproducer/Functionalities/TestImageList.test
--
Exit Code: 1

Command Output (stderr):
--
clang-12: warning: argument unused during compilation: '-fmodules-cache-path=/tmp/_update_lc/r/lldb-test-build.noindex/module-cache-clang/lldb-shell' [-Wunused-command-line-argument]

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
********************
Failed Tests (1):
  lldb-shell :: Reproducer/Functionalities/TestImageList.test


Testing Time: 125.54s
  Unsupported      : 10774
  Passed           : 58806
  Expectedly Failed:   102
  Failed           :     1
FAILED: CMakeFiles/check-all
Tue, Sep 1, 8:38 AM · Restricted Project, Restricted Project

Mon, Aug 31

JDevlieghere committed rG297f69afac58: [lldb] Add reproducer verifier (authored by JDevlieghere).
[lldb] Add reproducer verifier
Mon, Aug 31, 3:14 PM
JDevlieghere closed D86497: [lldb] Add reproducer verifier.
Mon, Aug 31, 3:14 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D86497: [lldb] Add reproducer verifier.
Mon, Aug 31, 1:50 PM · Restricted Project, Restricted Project

Fri, Aug 28

JDevlieghere committed rG2965e9bd5edb: [lldb] Hoist --framework argument out of LLDB_TEST_COMMON_ARGS (NFC) (authored by JDevlieghere).
[lldb] Hoist --framework argument out of LLDB_TEST_COMMON_ARGS (NFC)
Fri, Aug 28, 6:17 PM
JDevlieghere committed rG3f2fb0132f7b: [lldb] Make the lit configuration values optional for the API tests (authored by JDevlieghere).
[lldb] Make the lit configuration values optional for the API tests
Fri, Aug 28, 6:08 PM
JDevlieghere closed D86821: [lldb] Make the majority of the lit configuration values optional for the API tests.
Fri, Aug 28, 6:08 PM · Restricted Project
JDevlieghere committed rG141c8475b693: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest (authored by JDevlieghere).
[lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest
Fri, Aug 28, 3:46 PM
JDevlieghere committed rG55e7d91072e8: [lldb] Dervice dotest.py path from config.lldb_src_root (NFC) (authored by JDevlieghere).
[lldb] Dervice dotest.py path from config.lldb_src_root (NFC)
Fri, Aug 28, 3:46 PM
JDevlieghere closed D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest.
Fri, Aug 28, 3:46 PM · Restricted Project
JDevlieghere requested review of D86821: [lldb] Make the majority of the lit configuration values optional for the API tests.
Fri, Aug 28, 3:20 PM · Restricted Project
JDevlieghere updated the diff for D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest.
  • Fix LLDB.framework path
  • Don't try to guess the LLDB.framework location
Fri, Aug 28, 2:43 PM · Restricted Project
JDevlieghere requested review of D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest.
Fri, Aug 28, 2:20 PM · Restricted Project
JDevlieghere committed rGcdc18163cd14: [lldb] Fix typo in disassemble_options_line description (authored by JDevlieghere).
[lldb] Fix typo in disassemble_options_line description
Fri, Aug 28, 11:42 AM
JDevlieghere accepted D86752: [lldb/test] Use shorter test case names in TestStandardUnwind.
Fri, Aug 28, 11:14 AM · Restricted Project

Thu, Aug 27

JDevlieghere committed rG7f717b6d1f65: [lldb] Fix "no matching std::pair constructor" on Ubuntu 16.04 (NFC) (authored by JDevlieghere).
[lldb] Fix "no matching std::pair constructor" on Ubuntu 16.04 (NFC)
Thu, Aug 27, 5:24 PM
JDevlieghere committed rGa7e4a1773535: [lldb] Make lldb-argdumper a dependency of liblldb (authored by JDevlieghere).
[lldb] Make lldb-argdumper a dependency of liblldb
Thu, Aug 27, 9:32 AM
JDevlieghere committed rGb981924bdda7: [lldb] Move triple construction out of getArchCFlags in DarwinBuilder (NFC) (authored by JDevlieghere).
[lldb] Move triple construction out of getArchCFlags in DarwinBuilder (NFC)
Thu, Aug 27, 9:32 AM
JDevlieghere closed D86722: [lldb] Make lldb-argdumper a dependency of liblldb.
Thu, Aug 27, 9:31 AM · Restricted Project
JDevlieghere requested review of D86722: [lldb] Make lldb-argdumper a dependency of liblldb.
Thu, Aug 27, 8:49 AM · Restricted Project

Wed, Aug 26

JDevlieghere added inline comments to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Wed, Aug 26, 7:44 PM · Restricted Project
JDevlieghere added inline comments to D86670: [intel-pt] Add a basic implementation of the dump command.
Wed, Aug 26, 7:28 PM · Restricted Project
JDevlieghere added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

Given that this feature is intended to be used by non debugger developers, I want to stick to using JSON as a default input format, as it's more ubiquitous than YAML and I prefer to make this decision based on the user experience than on the technical solution.

Wed, Aug 26, 7:25 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

A large part of this patch is concerned with parsing which worries me from a maintenance perspective. Did you consider using Yaml I/O? While I'm not a particularly big fan of the format, the benefits of being able to (de)serialize any class by implementing the appropriate traits are quite significant. We already have traits implemented for a bunch of utility classes, such as ArchSpec and FileSpec which we could reuse for this. I know changing the format would be invasive, but I think it might be worth it in the long term.

So the nice thing about using StructuredData is it can be in any format: JSON, XML, Apple property list, YAML etc. It seems like the functions that were added to ArchSpec and FileSpec for the YAML I/O could be converted to use StructuredData and then any of the formats would work.

Wed, Aug 26, 12:51 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D86497: [lldb] Add reproducer verifier.
  • Address code review feedback
  • Run the verifier when replaying a reproducer
  • Add SBReplayOptions instead of adding another overload
  • Add --reproducer-skip-verify flag
Wed, Aug 26, 11:18 AM · Restricted Project, Restricted Project

Tue, Aug 25

JDevlieghere added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

A large part of this patch is concerned with parsing which worries me from a maintenance perspective. Did you consider using Yaml I/O? While I'm not a particularly big fan of the format, the benefits of being able to (de)serialize any class by implementing the appropriate traits are quite significant. We already have traits implemented for a bunch of utility classes, such as ArchSpec and FileSpec which we could reuse for this. I know changing the format would be invasive, but I think it might be worth it in the long term.

Tue, Aug 25, 3:41 PM · Restricted Project, Restricted Project
JDevlieghere committed rG521220690ab7: [lldb] Make Reproducer compatbile with SubsystemRAII (NFC) (authored by JDevlieghere).
[lldb] Make Reproducer compatbile with SubsystemRAII (NFC)
Tue, Aug 25, 1:00 PM
JDevlieghere updated the diff for D86497: [lldb] Add reproducer verifier.
  • Make CHECK-line more specific
Tue, Aug 25, 10:52 AM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D86497: [lldb] Add reproducer verifier.
  • Add tests
  • Extract common code from CommandObjectReproducerDump and CommandObjectReproducerVerify into GetLoaderFromPathOrCurrent
  • Address code review feedback
Tue, Aug 25, 10:49 AM · Restricted Project, Restricted Project
JDevlieghere accepted D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime.

Nice

Tue, Aug 25, 9:54 AM · Restricted Project

Mon, Aug 24

JDevlieghere added inline comments to D86497: [lldb] Add reproducer verifier.
Mon, Aug 24, 7:28 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D86497: [lldb] Add reproducer verifier.

This will require a test and maybe some code deduplication in CommandObjectReproducer but I already wanted to put the patch up in case I can't get to that today.

Mon, Aug 24, 5:12 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D86497: [lldb] Add reproducer verifier.
Mon, Aug 24, 5:11 PM · Restricted Project, Restricted Project
JDevlieghere committed rGa842950b62b6: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID (authored by JDevlieghere).
[lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID
Mon, Aug 24, 3:09 PM
JDevlieghere closed D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID.
Mon, Aug 24, 3:09 PM · Restricted Project
JDevlieghere added a comment to D86406: Speedup llvm-dwarfdump 3.9x.

If I understand the patch correctly, the speedup is gained by caching the mode instead of trying to recompute it every time we call colorsEnabled()? This seems like a huge speedup for such a small thing, maybe I'm missing something?

Mon, Aug 24, 12:03 PM · Restricted Project
JDevlieghere added a comment to D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX.

This looks good to me, but I wonder if doing this with a dedicated flag instead of an environment variable would be better. But I'll leave that to the others who have a better idea how the dotest flags should work.

Mon, Aug 24, 12:58 AM · Restricted Project

Sat, Aug 22

JDevlieghere accepted D86402: Avoid creating lldb-python-scripts target more than once.

Thanks!

Sat, Aug 22, 6:40 PM · Restricted Project
JDevlieghere added inline comments to rG02bf5632a94d: Fix swig scripts install target name.
Sat, Aug 22, 10:42 AM
JDevlieghere requested changes to D86402: Avoid creating lldb-python-scripts target more than once.

The target should be created for everyone calling the finish_swig_python function. Let's say (not so) hypothetically I want to create bindings for Python 2 and Python 3. I'll call finish_swig_python, twice, once for each Python version:

Sat, Aug 22, 10:38 AM · Restricted Project
JDevlieghere committed rGbb894b97821a: [lldb] Extract reproducer providers & co into their own header. (authored by JDevlieghere).
[lldb] Extract reproducer providers & co into their own header.
Sat, Aug 22, 10:04 AM

Aug 21 2020

JDevlieghere updated the diff for D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID.
  • Add test.
  • Implement dump method.
Aug 21 2020, 11:43 PM · Restricted Project
JDevlieghere added inline comments to D86388: Fix use-after-free in ThreadPlan, and add test..
Aug 21 2020, 11:11 PM · Restricted Project
JDevlieghere added inline comments to rG02bf5632a94d: Fix swig scripts install target name.
Aug 21 2020, 11:09 PM
JDevlieghere committed rG86fc1933099d: [lldb] Don't pass --rerun-all-issues on Windows. (authored by JDevlieghere).
[lldb] Don't pass --rerun-all-issues on Windows.
Aug 21 2020, 7:58 PM
JDevlieghere added a comment to D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID.

I wasn't sure how to test this but Jason told me I can set LLDB_APPLE_DSYMFORUUID_EXECUTABLE.

Aug 21 2020, 6:15 PM · Restricted Project
JDevlieghere requested review of D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID.
Aug 21 2020, 6:09 PM · Restricted Project
JDevlieghere accepted D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary.

LGTM

Aug 21 2020, 3:32 PM · Restricted Project
JDevlieghere committed rGd3a49b03a57b: [lldb] Remove --rerun-all-issues as its functionality no longer exists (authored by JDevlieghere).
[lldb] Remove --rerun-all-issues as its functionality no longer exists
Aug 21 2020, 2:28 PM
JDevlieghere committed rG52e758f352e6: [lldb] Fix build error in TestSimulatorPlatform.py (authored by JDevlieghere).
[lldb] Fix build error in TestSimulatorPlatform.py
Aug 21 2020, 1:35 PM
JDevlieghere committed rG57e0ef131b62: [lldb] Make it a fatal error when %lldb cannot be substituted (authored by JDevlieghere).
[lldb] Make it a fatal error when %lldb cannot be substituted
Aug 21 2020, 11:18 AM
JDevlieghere committed rG08249d7f72ff: [lldb] Fix TestAPILog.py for reproducer replay (authored by JDevlieghere).
[lldb] Fix TestAPILog.py for reproducer replay
Aug 21 2020, 10:35 AM