Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (304 w, 3 d)

Recent Activity

Yesterday

JDevlieghere committed rG92a8dc0735cf: [lldb] Temporarily skip TestTsanBasic on Darwin (authored by JDevlieghere).
[lldb] Temporarily skip TestTsanBasic on Darwin
Tue, Nov 30, 8:11 PM
JDevlieghere added a comment to D112603: tsan: new runtime (v3).

This breaks TestTsanBasic.py: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38898/testReport/lldb-api/functionalities_tsan_basic/TestTsanBasic_py/

I suspect the new runtime will require lldb/source/Plugins/InstrumentationRuntime/TSan to be updated.

Hi Jonas,

I think the issue is not in the test, but in the tsan runtime.

Somehow the test is in __abort function but the debugger is getting EXC_BAD_INSTRUCTION rather than the expected SIGABRT:

runCmd: continue
output: Process 71919 resuming
Process 71919 stopped
* thread #3, stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x00007fff7370c8c0 libsystem_c.dylib`__abort + 169
libsystem_c.dylib`:
->  0x7fff7370c8c0 <+169>: ud2    

libsystem_c.dylib`abort_report_np:
    0x7fff7370c8c2 <+0>:   pushq  %rbp
    0x7fff7370c8c3 <+1>:   movq   %rsp, %rbp
    0x7fff7370c8c6 <+4>:   pushq  %r14


runCmd: thread list
output: Process 71919 stopped
  thread #1: tid = 0x3a3ceb, 0x00007fff7378055e libsystem_kernel.dylib`__ulock_wait + 10, queue = 'com.apple.main-thread'
  thread #2: tid = 0x3a3d7d, 0x00007fff73781756 libsystem_kernel.dylib`__semwait_signal + 10
* thread #3: tid = 0x3a3d7f, 0x00007fff7370c8c0 libsystem_c.dylib`__abort + 169, stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)

Ran command:
"thread list"

Got output:
Process 71919 stopped
  thread #1: tid = 0x3a3ceb, 0x00007fff7378055e libsystem_kernel.dylib`__ulock_wait + 10, queue = 'com.apple.main-thread'
  thread #2: tid = 0x3a3d7d, 0x00007fff73781756 libsystem_kernel.dylib`__semwait_signal + 10
* thread #3: tid = 0x3a3d7f, 0x00007fff7370c8c0 libsystem_c.dylib`__abort + 169, stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)

Expecting sub string: "stopped" (was found)
Expecting sub string: "stop reason = signal SIGABRT" (was not found)
We should be stopped due a SIGABRT
Tue, Nov 30, 8:09 PM · Restricted Project
JDevlieghere added inline comments to D114819: [lldb] Split TestCxxChar8_t.
Tue, Nov 30, 1:19 PM
JDevlieghere requested review of D114819: [lldb] Split TestCxxChar8_t.
Tue, Nov 30, 1:18 PM
JDevlieghere committed rGd1326a3b1005: [lldb] Fix broken skipUnlessUndefinedBehaviorSanitizer decorator (authored by JDevlieghere).
[lldb] Fix broken skipUnlessUndefinedBehaviorSanitizer decorator
Tue, Nov 30, 1:04 PM
JDevlieghere committed rGc47135949779: [lldb] Fix TypeError: argument of type 'NoneType' is not iterable (authored by JDevlieghere).
[lldb] Fix TypeError: argument of type 'NoneType' is not iterable
Tue, Nov 30, 12:43 PM
JDevlieghere committed rG5f2e8f579697: [lldb] Mark TestTsanBasic and TestUbsanBasic as "no debug info" tests (authored by JDevlieghere).
[lldb] Mark TestTsanBasic and TestUbsanBasic as "no debug info" tests
Tue, Nov 30, 12:42 PM
JDevlieghere committed rG4fa9e435209e: [lldb] Fix indentation in builders/darwin.py (authored by JDevlieghere).
[lldb] Fix indentation in builders/darwin.py
Tue, Nov 30, 11:29 AM
JDevlieghere committed rG0a302f666737: [lldb] Search PrivateFrameworks when using an internal SDK (authored by JDevlieghere).
[lldb] Search PrivateFrameworks when using an internal SDK
Tue, Nov 30, 11:29 AM
JDevlieghere closed D114742: [lldb] Search PrivateFrameworks when using an internal SDK.
Tue, Nov 30, 11:29 AM · Restricted Project
JDevlieghere added inline comments to D114742: [lldb] Search PrivateFrameworks when using an internal SDK.
Tue, Nov 30, 11:25 AM · Restricted Project

Mon, Nov 29

JDevlieghere added a comment to D112603: tsan: new runtime (v3).

This breaks TestTsanBasic.py: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38898/testReport/lldb-api/functionalities_tsan_basic/TestTsanBasic_py/

Mon, Nov 29, 4:44 PM · Restricted Project
JDevlieghere requested review of D114742: [lldb] Search PrivateFrameworks when using an internal SDK.
Mon, Nov 29, 2:44 PM · Restricted Project
JDevlieghere accepted D114327: [CMake] Installable find modules for terminfo and libffi.

I'm assuming the logic to find the actual packages is the same (I didn't check in detail). Splitting this into separate Find-modules is definitely the way to go and that part of this patch LGTM.

Mon, Nov 29, 9:28 AM · Restricted Project
JDevlieghere accepted D114369: [lldb] Remove 'extern "C"' from the lldb-swig-python interface.

Makes sense. LGTM.

Mon, Nov 29, 9:20 AM · Restricted Project
JDevlieghere added a reviewer for D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code: bulbazord.
Mon, Nov 29, 9:18 AM · Restricted Project
JDevlieghere accepted D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation.

LGTM

Mon, Nov 29, 8:59 AM · Restricted Project
JDevlieghere added a comment to D77287: Windows: support `DoLoadImage`.

I can't speak to the correctness of the Windows parts, but all the utility function stuff looks sane to me. LGTM if Pavel has no outstanding objections.

Mon, Nov 29, 8:58 AM · Restricted Project

Fri, Nov 19

JDevlieghere accepted D114259: [lldb] Fix [some] leaks in python bindings.

Nice cleanup. LGTM.

Fri, Nov 19, 10:35 AM · Restricted Project

Thu, Nov 18

JDevlieghere accepted D114150: [lldb] Deobfuscate python-swigsafecast.swig.

Ship it

Thu, Nov 18, 8:31 AM · Restricted Project

Wed, Nov 17

JDevlieghere accepted D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb.
Wed, Nov 17, 7:24 PM · Restricted Project
JDevlieghere added a comment to D114111: Remove a useless temporary of a base class type..

@labath Do you know what the status is of removing RenderScript altogether?

Wed, Nov 17, 11:38 AM · Restricted Project
JDevlieghere added a reviewer for D114111: Remove a useless temporary of a base class type.: labath.
Wed, Nov 17, 11:38 AM · Restricted Project
JDevlieghere accepted D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

LGTM modulo the inline comment.

Wed, Nov 17, 10:22 AM · Restricted Project

Tue, Nov 16

JDevlieghere abandoned D110893: [lldb] Refactor statistics (NFC).
Tue, Nov 16, 1:17 PM
JDevlieghere abandoned D110895: [lldb] Move ownership of analytics out of Target.
Tue, Nov 16, 1:17 PM
JDevlieghere added inline comments to D113608: [lldb] Simplify specifying of platform supported architectures.
Tue, Nov 16, 1:16 PM · Restricted Project
JDevlieghere accepted D113650: [lldb] fix -print-script-interpreter-info on windows.

LGTM if the Windows bot is happy :-)

Tue, Nov 16, 1:14 PM · Restricted Project
JDevlieghere accepted D112972: [lldb] use EXT_SUFFIX for python extension.

LGTM

Tue, Nov 16, 1:13 PM · Restricted Project
JDevlieghere accepted D113965: [NFC] Refactor symbol table parsing..

LGTM

Tue, Nov 16, 1:09 PM · Restricted Project

Thu, Nov 11

JDevlieghere accepted D113608: [lldb] Simplify specifying of platform supported architectures.

LGTM

Thu, Nov 11, 9:31 PM · Restricted Project

Wed, Nov 10

JDevlieghere added inline comments to D113608: [lldb] Simplify specifying of platform supported architectures.
Wed, Nov 10, 1:21 PM · Restricted Project
JDevlieghere accepted D112167: [lldb/Plugins] Refactor ScriptedThread register context creation.

LGTM

Wed, Nov 10, 12:05 PM · Restricted Project
JDevlieghere committed rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used. (authored by JDevlieghere).
[debugserver] Remove varaible `ldb_set` which is set but not used.
Wed, Nov 10, 11:57 AM
JDevlieghere closed D113598: [debugserver] Remove unused variable.
Wed, Nov 10, 11:57 AM · Restricted Project
JDevlieghere requested review of D113598: [debugserver] Remove unused variable.
Wed, Nov 10, 11:26 AM · Restricted Project
JDevlieghere added a comment to D111409: proposed support for Java interface to Scripting Bridge.

Hi David, this looks really comprehensive. As far as the code is concerned, it has all the parts that we'd want to support another scripting language in LLDB. That leaves us with the last remaining questions:

Wed, Nov 10, 10:57 AM
JDevlieghere accepted D112973: [lldb] make it easier to find LLDB's python.

LGTM

Wed, Nov 10, 9:26 AM · Restricted Project
JDevlieghere added a comment to D112973: [lldb] make it easier to find LLDB's python.

A few small nits but I'm very happy with the approach. Thanks Larry!

Wed, Nov 10, 8:47 AM · Restricted Project
JDevlieghere accepted D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles.
Wed, Nov 10, 8:35 AM · Restricted Project
JDevlieghere added a comment to D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles.

Some of the formatting in the Python tests seems a little off (can you run it through something like yapf?). Other than that this LGTM with the inline comments addressed.

Wed, Nov 10, 8:35 AM · Restricted Project

Tue, Nov 9

JDevlieghere accepted D112107: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref.

Thanks. This LGTM!

Tue, Nov 9, 10:13 PM · Restricted Project
JDevlieghere added inline comments to D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles.
Tue, Nov 9, 10:05 PM · Restricted Project
JDevlieghere added a comment to D112973: [lldb] make it easier to find LLDB's python.

Rather than percolating up a JSON string, we should use StructuredData (and SBStructuredData at the SB API layer) and only convert it to JSON at the very last moment.

Tue, Nov 9, 3:32 PM · Restricted Project
JDevlieghere abandoned D109101: [lldb] Add an option to specify a VFS overlay.

Looks like there's an easier way to test this, so no need to add another SB API.

Tue, Nov 9, 9:01 AM

Mon, Nov 8

JDevlieghere committed rG0f2a7f2955cc: [debugserver] Put building for arm64e behind a CMake flag (authored by JDevlieghere).
[debugserver] Put building for arm64e behind a CMake flag
Mon, Nov 8, 9:02 PM
JDevlieghere accepted D113445: Support looking up absolute symbols.

LGTM

Mon, Nov 8, 8:50 PM · Restricted Project

Sun, Nov 7

JDevlieghere committed rGd09a21a0b378: [lldb] Remove failures case from TestTaggedPointerCmd (authored by JDevlieghere).
[lldb] Remove failures case from TestTaggedPointerCmd
Sun, Nov 7, 10:41 AM

Fri, Nov 5

JDevlieghere committed rG1ab9a2906e19: [lldb] Fix C2360: initialization of 'identifier' is skipped by 'case' label (authored by JDevlieghere).
[lldb] Fix C2360: initialization of 'identifier' is skipped by 'case' label
Fri, Nov 5, 11:09 PM
JDevlieghere committed rGcd7a2bf94b69: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex (authored by JDevlieghere).
[lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex
Fri, Nov 5, 10:52 PM
JDevlieghere closed D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex.
Fri, Nov 5, 10:52 PM · Restricted Project
JDevlieghere committed rG05fbe758906e: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC) (authored by JDevlieghere).
[lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)
Fri, Nov 5, 9:12 PM
JDevlieghere committed rGef2efd2553e0: [lldb] Remove 'result' variable which is set but not used (NFC) (authored by JDevlieghere).
[lldb] Remove 'result' variable which is set but not used (NFC)
Fri, Nov 5, 9:12 PM
JDevlieghere closed D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC).
Fri, Nov 5, 9:12 PM · Restricted Project
JDevlieghere added inline comments to D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC).
Fri, Nov 5, 8:20 PM · Restricted Project
JDevlieghere committed rG6d48e2505c7a: [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient (authored by JDevlieghere).
[lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient
Fri, Nov 5, 1:19 PM
JDevlieghere committed rG10eb32f45d40: [lldb] Improve 'lang objc tagged-pointer info' command (authored by JDevlieghere).
[lldb] Improve 'lang objc tagged-pointer info' command
Fri, Nov 5, 1:19 PM
JDevlieghere closed D113314: [lldb] Use std::string instead of llvm::Twine.
Fri, Nov 5, 1:19 PM · Restricted Project
JDevlieghere updated subscribers of D113314: [lldb] Use std::string instead of llvm::Twine.

@david: Yes, I considered it, but I think this is slightly more readable.

Fri, Nov 5, 1:17 PM · Restricted Project
JDevlieghere requested review of D113314: [lldb] Use std::string instead of llvm::Twine.
Fri, Nov 5, 12:54 PM · Restricted Project

Thu, Nov 4

JDevlieghere committed rG3120cadac782: [debugserver] Fix typo in DNBArchImplARM64 (authored by JDevlieghere).
[debugserver] Fix typo in DNBArchImplARM64
Thu, Nov 4, 9:44 AM
JDevlieghere accepted D113184: [lldb] Fix cross-platform kills.

LGTM

Thu, Nov 4, 8:50 AM · Restricted Project

Wed, Nov 3

JDevlieghere requested review of D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex.
Wed, Nov 3, 5:47 PM · Restricted Project
JDevlieghere added inline comments to D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC).
Wed, Nov 3, 5:36 PM · Restricted Project
JDevlieghere requested review of D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC).
Wed, Nov 3, 5:33 PM · Restricted Project
JDevlieghere committed rGf9e6be5cc1a2: [lldb] Update tagged pointer command output and test. (authored by JDevlieghere).
[lldb] Update tagged pointer command output and test.
Wed, Nov 3, 3:04 PM
JDevlieghere committed rZORGfc5df48cf854: [jenkins] Add a --runtimes flag to monorepo_build.py (authored by JDevlieghere).
[jenkins] Add a --runtimes flag to monorepo_build.py
Wed, Nov 3, 12:21 PM

Tue, Nov 2

JDevlieghere added a comment to D112973: [lldb] make it easier to find LLDB's python.

I was talking to Jim about this offline and one potential solution would be to have a flag that asks the current script interpreter for some of this relevant information. What that means would be different for every language, so the output would have to be able to define its own keys and values. (JSON could be a good candidate for this?) For Python, this would include the python path and the prefix, while for lua this might be something totally different. Both could include a version.

Tue, Nov 2, 6:19 PM · Restricted Project
JDevlieghere committed rG50b40b051890: [lldb] Improve error reporting in `lang objc tagged-pointer info` (authored by JDevlieghere).
[lldb] Improve error reporting in `lang objc tagged-pointer info`
Tue, Nov 2, 2:26 PM
JDevlieghere closed D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.
Tue, Nov 2, 2:25 PM · Restricted Project
JDevlieghere accepted D113047: [lldb] update TestEchoCommands.

LGTM

Tue, Nov 2, 2:20 PM · Restricted Project
JDevlieghere updated the diff for D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.

Address code review feedback

Tue, Nov 2, 12:54 PM · Restricted Project
JDevlieghere added inline comments to D112988: [lldb] fix --source-quietly.
Tue, Nov 2, 11:36 AM · Restricted Project
JDevlieghere added a comment to D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.

Thanks!

Tue, Nov 2, 9:05 AM · Restricted Project

Mon, Nov 1

JDevlieghere added a comment to D112973: [lldb] make it easier to find LLDB's python.

I feel like this puts too much Python specific logic in the driver compared to the convenience it brings. Even though we already leak python details (like --python-path), LLDB has always been designed to support several scripting languages. I'm not convinced this use case is compelling enough to make the situation worse.

Mon, Nov 1, 5:21 PM · Restricted Project
JDevlieghere updated the diff for D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.

Add test

Mon, Nov 1, 11:56 AM · Restricted Project
JDevlieghere requested review of D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.
Mon, Nov 1, 11:56 AM · Restricted Project
JDevlieghere committed rG64cc073abd59: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message. (authored by JDevlieghere).
[lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.
Mon, Nov 1, 9:40 AM
JDevlieghere closed D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message..
Mon, Nov 1, 9:40 AM · Restricted Project

Oct 29 2021

JDevlieghere committed rG80405df30749: [llvm] Include LLVM_ENABLE_RUNTIMES in the cross compilation invocation (authored by JDevlieghere).
[llvm] Include LLVM_ENABLE_RUNTIMES in the cross compilation invocation
Oct 29 2021, 4:33 PM
JDevlieghere closed D112855: [llvm] Include LLVM_ENABLE_RUNTIMES in the cross compilation invocation.
Oct 29 2021, 4:33 PM · Restricted Project
JDevlieghere requested review of D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message..
Oct 29 2021, 4:28 PM · Restricted Project
JDevlieghere added a comment to D112855: [llvm] Include LLVM_ENABLE_RUNTIMES in the cross compilation invocation.

Without this change, you get something like:

Oct 29 2021, 4:24 PM · Restricted Project
JDevlieghere requested review of D112855: [llvm] Include LLVM_ENABLE_RUNTIMES in the cross compilation invocation.
Oct 29 2021, 4:23 PM · Restricted Project
JDevlieghere committed rGd321548c3ce9: [llvm] Disable xar on macOS 12.0 and later (authored by JDevlieghere).
[llvm] Disable xar on macOS 12.0 and later
Oct 29 2021, 3:31 PM
JDevlieghere closed D112849: [llvm] Disable xar on macOS 12.0 and later .
Oct 29 2021, 3:31 PM · Restricted Project
JDevlieghere added inline comments to D112849: [llvm] Disable xar on macOS 12.0 and later .
Oct 29 2021, 3:11 PM · Restricted Project
JDevlieghere updated the diff for D112849: [llvm] Disable xar on macOS 12.0 and later .

Print a status message about the deprecation of the xar file format and corresponding cmake variable.

Oct 29 2021, 3:11 PM · Restricted Project
JDevlieghere requested review of D112849: [llvm] Disable xar on macOS 12.0 and later .
Oct 29 2021, 2:55 PM · Restricted Project
JDevlieghere requested changes to D112825: [lldb] Add MemoryTagMap class.
Oct 29 2021, 11:03 AM · Restricted Project

Oct 28 2021

JDevlieghere accepted D112212: [lldb/test] Print build commands in trace mode.

Thanks everyone. LGTM!

Oct 28 2021, 7:12 PM · Restricted Project
JDevlieghere accepted D112767: [clang][driver] Fix multiarch output name with -Wl arg.

LGTM

Oct 28 2021, 7:11 PM · Restricted Project
JDevlieghere committed rG2aa3b5633942: [lldb] Fix TestMacCatalyst.py (authored by JDevlieghere).
[lldb] Fix TestMacCatalyst.py
Oct 28 2021, 5:58 PM
JDevlieghere accepted D111742: Add LLVM_EXTERNALIZE_DEBUGINFO_FLATTEN, which can do flat dSYM.

Alright, sounds reasonable. LGTM.

Oct 28 2021, 4:31 PM · Restricted Project
JDevlieghere added a comment to D112691: Include target settings in "statistics dump" output..

I understand the need for something like this to make some of the statistics more meaningful, but this is stretching the notion of statistics. Conceptually, this is approaching something like a dump of the debugger for issue/performance analysis. I think that idea is really exciting, and from that perspective there's a lot more useful information we could add to it. Long term, I can see this output be something that we ask users to include in every bug report.

Oct 28 2021, 9:03 AM · Restricted Project

Oct 27 2021

JDevlieghere committed rG2c350730ca8b: [lldb] The os and version are not separate components in the triple (authored by JDevlieghere).
[lldb] The os and version are not separate components in the triple
Oct 27 2021, 4:40 PM
JDevlieghere closed D112676: [lldb] The os and version are not separate components in the triple.
Oct 27 2021, 4:40 PM · Restricted Project
JDevlieghere added inline comments to D112676: [lldb] The os and version are not separate components in the triple.
Oct 27 2021, 4:39 PM · Restricted Project
JDevlieghere updated the diff for D112676: [lldb] The os and version are not separate components in the triple.

Skip the environment if it's empty and avoid a TypeError when concatenating 'NoneType' and 'str'.

Oct 27 2021, 4:36 PM · Restricted Project
JDevlieghere requested review of D112676: [lldb] The os and version are not separate components in the triple.
Oct 27 2021, 4:17 PM · Restricted Project